From: Denis Efremov <efremov@linux.com> To: Julia Lawall <julia.lawall@inria.fr> Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coccinelle: misc: add swap script Date: Thu, 18 Feb 2021 09:13:34 +0300 [thread overview] Message-ID: <c2b60288-3e46-14e3-9be2-3f75366a4b47@linux.com> (raw) In-Reply-To: <alpine.DEB.2.22.394.2102172224570.3081@hadrien> On 2/18/21 12:31 AM, Julia Lawall wrote: >> +@depends on patch@ >> +identifier tmp; >> +expression a, b; >> +type T; >> +@@ >> + >> +( >> +- T tmp; >> +| >> +- T tmp = 0; >> +| >> +- T *tmp = NULL; >> +) >> +... when != tmp >> +- tmp = a; >> +- a = b; >> +- b = tmp; >> ++ swap(a, b); >> +... when != tmp > > In this rule and the next one, if you remove the final ; from the b = tmp > line and from the swap line, and put it into context code afterwards, them > the generated code looks better on cases like fs/xfs/xfs_inode.c in the > function xfs_lock_two_inodes where two successive swap calls are > generated. > > There are also some cases such as drivers/net/wireless/ath/ath5k/phy.c in > the function ath5k_hw_get_median_noise_floor where the swap code makes up > a whole if branch. > In this cases it would be good to remove the {}. How this can be handled? If I use this pattern: @depends on patch@ identifier tmp; expression a, b; @@ ( if (...) - { - tmp = a; - a = b; - b = tmp + swap(a, b) ; - } | - tmp = a; - a = b; - b = tmp + swap(a, b) ; ) The tool fails with error: EXN: Failure("rule starting on line 58: already tagged token:\nC code context\nFile \"drivers/net/wireless/ath/ath5k/phy.c\", line 1574, column 4, charpos = 41650\n around = 'sort',\n whole content = \t\t\t\tsort[j - 1] = tmp;") in drivers/net/wireless/ath/ath5k/phy.c Thanks, Denis
WARNING: multiple messages have this Message-ID (diff)
From: Denis Efremov <efremov@linux.com> To: Julia Lawall <julia.lawall@inria.fr> Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH] coccinelle: misc: add swap script Date: Thu, 18 Feb 2021 09:13:34 +0300 [thread overview] Message-ID: <c2b60288-3e46-14e3-9be2-3f75366a4b47@linux.com> (raw) In-Reply-To: <alpine.DEB.2.22.394.2102172224570.3081@hadrien> On 2/18/21 12:31 AM, Julia Lawall wrote: >> +@depends on patch@ >> +identifier tmp; >> +expression a, b; >> +type T; >> +@@ >> + >> +( >> +- T tmp; >> +| >> +- T tmp = 0; >> +| >> +- T *tmp = NULL; >> +) >> +... when != tmp >> +- tmp = a; >> +- a = b; >> +- b = tmp; >> ++ swap(a, b); >> +... when != tmp > > In this rule and the next one, if you remove the final ; from the b = tmp > line and from the swap line, and put it into context code afterwards, them > the generated code looks better on cases like fs/xfs/xfs_inode.c in the > function xfs_lock_two_inodes where two successive swap calls are > generated. > > There are also some cases such as drivers/net/wireless/ath/ath5k/phy.c in > the function ath5k_hw_get_median_noise_floor where the swap code makes up > a whole if branch. > In this cases it would be good to remove the {}. How this can be handled? If I use this pattern: @depends on patch@ identifier tmp; expression a, b; @@ ( if (...) - { - tmp = a; - a = b; - b = tmp + swap(a, b) ; - } | - tmp = a; - a = b; - b = tmp + swap(a, b) ; ) The tool fails with error: EXN: Failure("rule starting on line 58: already tagged token:\nC code context\nFile \"drivers/net/wireless/ath/ath5k/phy.c\", line 1574, column 4, charpos = 41650\n around = 'sort',\n whole content = \t\t\t\tsort[j - 1] = tmp;") in drivers/net/wireless/ath/ath5k/phy.c Thanks, Denis _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2021-02-18 6:35 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-16 8:01 [PATCH] coccinelle: misc: add swap script Denis Efremov 2021-02-16 8:01 ` [Cocci] " Denis Efremov 2021-02-16 18:05 ` Markus Elfring 2021-02-17 21:31 ` Julia Lawall 2021-02-17 21:31 ` [Cocci] " Julia Lawall 2021-02-18 6:13 ` Denis Efremov [this message] 2021-02-18 6:13 ` Denis Efremov 2021-02-18 10:17 ` Julia Lawall 2021-02-18 10:17 ` [Cocci] " Julia Lawall 2021-02-18 11:03 ` Denis Efremov 2021-02-18 11:03 ` [Cocci] " Denis Efremov 2021-02-18 11:29 ` Julia Lawall 2021-02-18 11:29 ` [Cocci] " Julia Lawall 2021-02-18 11:34 ` Denis Efremov 2021-02-18 11:34 ` [Cocci] " Denis Efremov [not found] ` <50eb8319-a552-c749-6143-7e24a8778a04@web.de> 2021-02-18 20:03 ` Julia Lawall 2021-02-18 20:03 ` [Cocci] " Julia Lawall 2021-02-19 9:05 ` [PATCH v2] coccinelle: misc: add minmax script Denis Efremov 2021-02-19 9:05 ` [Cocci] " Denis Efremov 2021-02-19 9:07 ` Denis Efremov 2021-02-19 9:07 ` [Cocci] " Denis Efremov 2021-02-19 9:24 ` [PATCH v2] coccinelle: misc: add swap script Denis Efremov 2021-02-19 9:24 ` [Cocci] " Denis Efremov 2021-03-03 16:37 ` Julia Lawall 2021-03-03 16:37 ` [Cocci] " Julia Lawall 2021-03-05 10:09 ` [PATCH v3] " Denis Efremov 2021-03-05 10:09 ` [Cocci] " Denis Efremov 2021-03-28 9:19 ` Denis Efremov 2021-04-04 12:33 ` Julia Lawall 2021-04-04 12:33 ` [Cocci] " Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c2b60288-3e46-14e3-9be2-3f75366a4b47@linux.com \ --to=efremov@linux.com \ --cc=cocci@systeme.lip6.fr \ --cc=julia.lawall@inria.fr \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.