All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc
@ 2018-09-29 12:00 Hari Kumar Vemula
  2018-09-29 12:00 ` [PATCH 1/4] driver/crypto: enable meson support for the aesni gcm Hari Kumar Vemula
                   ` (9 more replies)
  0 siblings, 10 replies; 15+ messages in thread
From: Hari Kumar Vemula @ 2018-09-29 12:00 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch, Hari Kumar Vemula

1/4: enablement of aesni_gcm pmd in meson
2/4: enablement of aesni_mb pmd in meson
3/4: enablement of kasumi pmd enable in meson
4/4: enablement of zuc pmd enable in meson

Hari Kumar Vemula (4):
  driver/crypto: enable meson support for the aesni gcm
  drivers/crypto: enable meson support for the aesni mb
  drivers/crypto: enable meson support for the kasumi
  drivers/crypto: enable meson support for the zuc

 drivers/crypto/aesni_gcm/meson.build | 17 +++++++++++++++++
 drivers/crypto/aesni_mb/meson.build  | 16 ++++++++++++++++
 drivers/crypto/kasumi/meson.build    | 18 ++++++++++++++++++
 drivers/crypto/meson.build           |  4 ++--
 drivers/crypto/zuc/meson.build       | 18 ++++++++++++++++++
 meson_options.txt                    |  6 ++++++
 6 files changed, 77 insertions(+), 2 deletions(-)
 create mode 100644 drivers/crypto/aesni_gcm/meson.build
 create mode 100644 drivers/crypto/aesni_mb/meson.build
 create mode 100644 drivers/crypto/kasumi/meson.build
 create mode 100644 drivers/crypto/zuc/meson.build

-- 
2.13.6

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 1/4] driver/crypto: enable meson support for the aesni gcm
  2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
@ 2018-09-29 12:00 ` Hari Kumar Vemula
  2018-10-01  9:31   ` Bruce Richardson
  2018-09-29 12:00 ` [PATCH 2/4] drivers/crypto: enable meson support for the aesni mb Hari Kumar Vemula
                   ` (8 subsequent siblings)
  9 siblings, 1 reply; 15+ messages in thread
From: Hari Kumar Vemula @ 2018-09-29 12:00 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch, Hari Kumar Vemula

Added new meson.build files for aesni_gcm
Exported dependency library path through meson_options.txt file

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
---
 drivers/crypto/aesni_gcm/meson.build | 17 +++++++++++++++++
 drivers/crypto/meson.build           |  2 +-
 meson_options.txt                    |  2 ++
 3 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/aesni_gcm/meson.build

diff --git a/drivers/crypto/aesni_gcm/meson.build b/drivers/crypto/aesni_gcm/meson.build
new file mode 100644
index 000000000..a84c792c5
--- /dev/null
+++ b/drivers/crypto/aesni_gcm/meson.build
@@ -0,0 +1,17 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+path = get_option('lib_IPSec_MB')
+lib_dir = path + '/lib'
+
+lib = cc.find_library('IPSec_MB', required: false)
+if not lib.found()
+	build = false
+else
+	ext_deps += lib
+endif
+
+sources = files('aesni_gcm_pmd.c', 'aesni_gcm_pmd_ops.c')
+
+deps += ['bus_vdev']
+
diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index 6ed853b7a..7e14cbba0 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-drivers = ['ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
+drivers = ['aesni_gcm', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
 	'null', 'openssl', 'qat', 'scheduler', 'virtio']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
diff --git a/meson_options.txt b/meson_options.txt
index d38ba56e2..8c75826c1 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -24,3 +24,5 @@ option('use_hpet', type: 'boolean', value: false,
 	description: 'use HPET timer in EAL')
 option('tests', type: 'boolean', value: true,
 	description: 'build unit tests')
+option('lib_IPSec_MB', type: 'string', value: '',
+	description: 'path to the IPSec_MB library installation directory')
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 2/4] drivers/crypto: enable meson support for the aesni mb
  2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
  2018-09-29 12:00 ` [PATCH 1/4] driver/crypto: enable meson support for the aesni gcm Hari Kumar Vemula
@ 2018-09-29 12:00 ` Hari Kumar Vemula
  2018-09-29 12:01 ` [PATCH 3/4] drivers/crypto: enable meson support for the kasumi Hari Kumar Vemula
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Hari Kumar Vemula @ 2018-09-29 12:00 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch, Hari Kumar Vemula

Added new meson.build file for aesni_mb
Exported dependency library path through meson_options.txt file

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
---
 drivers/crypto/aesni_mb/meson.build | 16 ++++++++++++++++
 drivers/crypto/meson.build          |  2 +-
 2 files changed, 17 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/aesni_mb/meson.build

diff --git a/drivers/crypto/aesni_mb/meson.build b/drivers/crypto/aesni_mb/meson.build
new file mode 100644
index 000000000..000c7adb4
--- /dev/null
+++ b/drivers/crypto/aesni_mb/meson.build
@@ -0,0 +1,16 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+path = get_option('lib_IPSec_MB')
+lib_dir = path + '/lib'
+
+lib = cc.find_library('IPSec_MB', required: false)
+if not lib.found()
+	build = false
+else
+	ext_deps += lib
+endif
+
+sources = files('rte_aesni_mb_pmd.c', 'rte_aesni_mb_pmd_ops.c')
+
+deps += ['bus_vdev']
diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index 7e14cbba0..ab68c2751 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-drivers = ['aesni_gcm', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
+drivers = ['aesni_gcm',  'aesni_mb', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
 	'null', 'openssl', 'qat', 'scheduler', 'virtio']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 3/4] drivers/crypto: enable meson support for the kasumi
  2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
  2018-09-29 12:00 ` [PATCH 1/4] driver/crypto: enable meson support for the aesni gcm Hari Kumar Vemula
  2018-09-29 12:00 ` [PATCH 2/4] drivers/crypto: enable meson support for the aesni mb Hari Kumar Vemula
@ 2018-09-29 12:01 ` Hari Kumar Vemula
  2018-09-29 12:01 ` [PATCH 4/4] drivers/crypto: enable meson support for the zuc Hari Kumar Vemula
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Hari Kumar Vemula @ 2018-09-29 12:01 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch, Hari Kumar Vemula

Added new meson.build file for KASUMI
Exported dependency library path through meson_options.txt file

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
---
 drivers/crypto/kasumi/meson.build | 18 ++++++++++++++++++
 drivers/crypto/meson.build        |  2 +-
 meson_options.txt                 |  2 ++
 3 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/kasumi/meson.build

diff --git a/drivers/crypto/kasumi/meson.build b/drivers/crypto/kasumi/meson.build
new file mode 100644
index 000000000..b65de65cc
--- /dev/null
+++ b/drivers/crypto/kasumi/meson.build
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+path = get_option('libsso_kasumi_dir')
+lib_dir = path + '/build'
+inc_dir = path + '/include'
+
+lib = cc.find_library('libsso_kasumi', dirs: lib_dir, required: false)
+if not lib.found()
+	build = false
+else
+	ext_deps += lib
+	includes += include_directories(inc_dir)
+endif
+
+sources = files('rte_kasumi_pmd.c', 'rte_kasumi_pmd_ops.c')
+
+deps += ['bus_vdev']
diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index ab68c2751..4ed87c367 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-drivers = ['aesni_gcm',  'aesni_mb', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
+drivers = ['aesni_gcm',  'aesni_mb', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'kasumi', 'mvsam',
 	'null', 'openssl', 'qat', 'scheduler', 'virtio']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
diff --git a/meson_options.txt b/meson_options.txt
index 8c75826c1..782213477 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -26,3 +26,5 @@ option('tests', type: 'boolean', value: true,
 	description: 'build unit tests')
 option('lib_IPSec_MB', type: 'string', value: '',
 	description: 'path to the IPSec_MB library installation directory')
+option('libsso_kasumi_dir', type: 'string', value: '',
+	description: 'path to the KASUMI library installation directory')
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 4/4] drivers/crypto: enable meson support for the zuc
  2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
                   ` (2 preceding siblings ...)
  2018-09-29 12:01 ` [PATCH 3/4] drivers/crypto: enable meson support for the kasumi Hari Kumar Vemula
@ 2018-09-29 12:01 ` Hari Kumar Vemula
  2018-09-30 10:01 ` [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Luca Boccassi
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Hari Kumar Vemula @ 2018-09-29 12:01 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch, Hari Kumar Vemula

Added new meson.build file for ZUC
Exported dependency library path through meson_options.txt file

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
---
 drivers/crypto/meson.build     |  2 +-
 drivers/crypto/zuc/meson.build | 18 ++++++++++++++++++
 meson_options.txt              |  2 ++
 3 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/zuc/meson.build

diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index 4ed87c367..b45049ce3 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -2,7 +2,7 @@
 # Copyright(c) 2017 Intel Corporation
 
 drivers = ['aesni_gcm',  'aesni_mb', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'kasumi', 'mvsam',
-	'null', 'openssl', 'qat', 'scheduler', 'virtio']
+	'null', 'openssl', 'qat', 'scheduler', 'virtio', 'zuc']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
 config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
diff --git a/drivers/crypto/zuc/meson.build b/drivers/crypto/zuc/meson.build
new file mode 100644
index 000000000..4fa5d9b8c
--- /dev/null
+++ b/drivers/crypto/zuc/meson.build
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+path = get_option('libsso_zuc_dir')
+lib_dir = path + '/build'
+inc_dir = path + '/include'
+
+lib = cc.find_library('libsso_zuc', dirs: lib_dir, required: false)
+if not lib.found()
+	build = false
+else
+	ext_deps += lib
+	includes += include_directories(inc_dir)
+endif
+
+sources = files('rte_zuc_pmd.c', 'rte_zuc_pmd_ops.c')
+
+deps += ['bus_vdev']
diff --git a/meson_options.txt b/meson_options.txt
index 782213477..842b6c6de 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -28,3 +28,5 @@ option('lib_IPSec_MB', type: 'string', value: '',
 	description: 'path to the IPSec_MB library installation directory')
 option('libsso_kasumi_dir', type: 'string', value: '',
 	description: 'path to the KASUMI library installation directory')
+option('libsso_zuc_dir', type: 'string', value: '',
+	description: 'path to the ZUC library installation directory')
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc
  2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
                   ` (3 preceding siblings ...)
  2018-09-29 12:01 ` [PATCH 4/4] drivers/crypto: enable meson support for the zuc Hari Kumar Vemula
@ 2018-09-30 10:01 ` Luca Boccassi
  2018-10-01  9:36   ` Bruce Richardson
  2018-10-05 10:59 ` [PATCH v2 " Hari Kumar Vemula
                   ` (4 subsequent siblings)
  9 siblings, 1 reply; 15+ messages in thread
From: Luca Boccassi @ 2018-09-30 10:01 UTC (permalink / raw)
  To: Hari Kumar Vemula, dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty, pablo.de.lara.guarch

On Sat, 2018-09-29 at 13:00 +0100, Hari Kumar Vemula wrote:
> 1/4: enablement of aesni_gcm pmd in meson
> 2/4: enablement of aesni_mb pmd in meson
> 3/4: enablement of kasumi pmd enable in meson
> 4/4: enablement of zuc pmd enable in meson
> 
> Hari Kumar Vemula (4):
>   driver/crypto: enable meson support for the aesni gcm
>   drivers/crypto: enable meson support for the aesni mb
>   drivers/crypto: enable meson support for the kasumi
>   drivers/crypto: enable meson support for the zuc
> 
>  drivers/crypto/aesni_gcm/meson.build | 17 +++++++++++++++++
>  drivers/crypto/aesni_mb/meson.build  | 16 ++++++++++++++++
>  drivers/crypto/kasumi/meson.build    | 18 ++++++++++++++++++
>  drivers/crypto/meson.build           |  4 ++--
>  drivers/crypto/zuc/meson.build       | 18 ++++++++++++++++++
>  meson_options.txt                    |  6 ++++++
>  6 files changed, 77 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/crypto/aesni_gcm/meson.build
>  create mode 100644 drivers/crypto/aesni_mb/meson.build
>  create mode 100644 drivers/crypto/kasumi/meson.build
>  create mode 100644 drivers/crypto/zuc/meson.build

Hi,

With Meson we want to reduce the large number of build-time options.
For dependencies, I don't think it's necessary to have a separate
option to pass the library path.

The preferred option would be for the dependency to have a pkg-config
file which sets the necessary flags. If that's not installed in the
standard path, the PKG_CONFIG_PATH environment variable can be set to
add custom paths.

If a dependency does not have a pkg-config file (if you control it
would be a good time to add it :-) ), then you can set the path to the
shared object with something like: LD_FLAGS=-L/path/to/lib/ and Meson
will use that automatically (and CFLAGS=-I/path/to/headers/ if
necessary as well).

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/4] driver/crypto: enable meson support for the aesni gcm
  2018-09-29 12:00 ` [PATCH 1/4] driver/crypto: enable meson support for the aesni gcm Hari Kumar Vemula
@ 2018-10-01  9:31   ` Bruce Richardson
  0 siblings, 0 replies; 15+ messages in thread
From: Bruce Richardson @ 2018-10-01  9:31 UTC (permalink / raw)
  To: Hari Kumar Vemula
  Cc: dev, reshma.pattan, declan.doherty, pablo.de.lara.guarch

On Sat, Sep 29, 2018 at 01:00:58PM +0100, Hari Kumar Vemula wrote:
> Added new meson.build files for aesni_gcm
> Exported dependency library path through meson_options.txt file
> 
> Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
> ---
>  drivers/crypto/aesni_gcm/meson.build | 17 +++++++++++++++++
>  drivers/crypto/meson.build           |  2 +-
>  meson_options.txt                    |  2 ++
>  3 files changed, 20 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/crypto/aesni_gcm/meson.build
> 
> diff --git a/drivers/crypto/aesni_gcm/meson.build b/drivers/crypto/aesni_gcm/meson.build
> new file mode 100644
> index 000000000..a84c792c5
> --- /dev/null
> +++ b/drivers/crypto/aesni_gcm/meson.build
> @@ -0,0 +1,17 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Intel Corporation
> +
> +path = get_option('lib_IPSec_MB')
> +lib_dir = path + '/lib'
> +

lib_dir doesn't seem to be used after being assigned, whcih means that
having the build option is unnecessary.

> +lib = cc.find_library('IPSec_MB', required: false)
> +if not lib.found()
> +	build = false
> +else
> +	ext_deps += lib
> +endif
> +
> +sources = files('aesni_gcm_pmd.c', 'aesni_gcm_pmd_ops.c')
> +
> +deps += ['bus_vdev']
> +

You don't seem to require any header file paths from the IPSec_MD library,
so even if you need the path for the lib, you can used LD_LIBRARY_PATH
environment variable to point to it rather than needing a build-time
option. I'd like to avoid adding unnecessary options, if possible.

> diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
> index 6ed853b7a..7e14cbba0 100644
> --- a/drivers/crypto/meson.build
> +++ b/drivers/crypto/meson.build
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017 Intel Corporation
>  
> -drivers = ['ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
> +drivers = ['aesni_gcm', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
>  	'null', 'openssl', 'qat', 'scheduler', 'virtio']
>  
>  std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
> diff --git a/meson_options.txt b/meson_options.txt
> index d38ba56e2..8c75826c1 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -24,3 +24,5 @@ option('use_hpet', type: 'boolean', value: false,
>  	description: 'use HPET timer in EAL')
>  option('tests', type: 'boolean', value: true,
>  	description: 'build unit tests')
> +option('lib_IPSec_MB', type: 'string', value: '',
> +	description: 'path to the IPSec_MB library installation directory')
> -- 
> 2.13.6
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc
  2018-09-30 10:01 ` [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Luca Boccassi
@ 2018-10-01  9:36   ` Bruce Richardson
  0 siblings, 0 replies; 15+ messages in thread
From: Bruce Richardson @ 2018-10-01  9:36 UTC (permalink / raw)
  To: Luca Boccassi
  Cc: Hari Kumar Vemula, dev, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch

On Sun, Sep 30, 2018 at 11:01:38AM +0100, Luca Boccassi wrote:
> On Sat, 2018-09-29 at 13:00 +0100, Hari Kumar Vemula wrote:
> > 1/4: enablement of aesni_gcm pmd in meson 2/4: enablement of aesni_mb
> > pmd in meson 3/4: enablement of kasumi pmd enable in meson 4/4:
> > enablement of zuc pmd enable in meson
> > 
> > Hari Kumar Vemula (4):   driver/crypto: enable meson support for the
> > aesni gcm   drivers/crypto: enable meson support for the aesni mb  
> > drivers/crypto: enable meson support for the kasumi   drivers/crypto:
> > enable meson support for the zuc
> > 
> >  drivers/crypto/aesni_gcm/meson.build | 17 +++++++++++++++++
> >  drivers/crypto/aesni_mb/meson.build  | 16 ++++++++++++++++
> >  drivers/crypto/kasumi/meson.build    | 18 ++++++++++++++++++
> >  drivers/crypto/meson.build           |  4 ++--
> >  drivers/crypto/zuc/meson.build       | 18 ++++++++++++++++++
> >  meson_options.txt                    |  6 ++++++  6 files changed, 77
> > insertions(+), 2 deletions(-)  create mode 100644
> > drivers/crypto/aesni_gcm/meson.build  create mode 100644
> > drivers/crypto/aesni_mb/meson.build  create mode 100644
> > drivers/crypto/kasumi/meson.build  create mode 100644
> > drivers/crypto/zuc/meson.build
> 
> Hi,
> 
> With Meson we want to reduce the large number of build-time options.  For
> dependencies, I don't think it's necessary to have a separate option to
> pass the library path.
> 
> The preferred option would be for the dependency to have a pkg-config
> file which sets the necessary flags. If that's not installed in the
> standard path, the PKG_CONFIG_PATH environment variable can be set to add
> custom paths.
> 
> If a dependency does not have a pkg-config file (if you control it would
> be a good time to add it :-) ), then you can set the path to the shared
> object with something like: LD_FLAGS=-L/path/to/lib/ and Meson will use
> that automatically (and CFLAGS=-I/path/to/headers/ if necessary as well).
> 
For completeness: third option is to have the libraries on which you depend
install themselves in /usr/local as normal for additional software, which
means that they should still be found in most cases without either
pkg-config files or extra LD/CFLAGS.

/Bruce

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc
  2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
                   ` (4 preceding siblings ...)
  2018-09-30 10:01 ` [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Luca Boccassi
@ 2018-10-05 10:59 ` Hari Kumar Vemula
  2018-10-05 11:13   ` Luca Boccassi
  2018-10-05 10:59 ` [PATCH v2 1/4] drivers/crypto: enable meson support for the aesni gcm Hari Kumar Vemula
                   ` (3 subsequent siblings)
  9 siblings, 1 reply; 15+ messages in thread
From: Hari Kumar Vemula @ 2018-10-05 10:59 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch, Hari Kumar Vemula

1/4: enablement of aesni_gcm pmd in meson
2/4: enablement of aesni_mb pmd in meson
3/4: enablement of kasumi pmd enable in meson
4/4: enablement of zuc pmd enable in meson

--
v2: Removed lib dependancy options from  meson_option.txt file
--


Hari Kumar Vemula (4):
  drivers/crypto: enable meson support for the aesni gcm
  drivers/crypto: enable meson support for the aesni mb
  drivers/crypto: enable meson support for the kasumi
  drivers/crypto: enable meson support for the zuc

 drivers/crypto/aesni_gcm/meson.build | 13 +++++++++++++
 drivers/crypto/aesni_mb/meson.build  | 12 ++++++++++++
 drivers/crypto/kasumi/meson.build    | 12 ++++++++++++
 drivers/crypto/meson.build           |  4 ++--
 drivers/crypto/zuc/meson.build       | 12 ++++++++++++
 5 files changed, 51 insertions(+), 2 deletions(-)
 create mode 100644 drivers/crypto/aesni_gcm/meson.build
 create mode 100644 drivers/crypto/aesni_mb/meson.build
 create mode 100644 drivers/crypto/kasumi/meson.build
 create mode 100644 drivers/crypto/zuc/meson.build

-- 
2.13.6

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 1/4] drivers/crypto: enable meson support for the aesni gcm
  2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
                   ` (5 preceding siblings ...)
  2018-10-05 10:59 ` [PATCH v2 " Hari Kumar Vemula
@ 2018-10-05 10:59 ` Hari Kumar Vemula
  2018-10-05 10:59 ` [PATCH v2 2/4] drivers/crypto: enable meson support for the aesni mb Hari Kumar Vemula
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Hari Kumar Vemula @ 2018-10-05 10:59 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch, Hari Kumar Vemula

Added new meson.build files for aesni_gcm

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
---
 drivers/crypto/aesni_gcm/meson.build | 13 +++++++++++++
 drivers/crypto/meson.build           |  2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/aesni_gcm/meson.build

diff --git a/drivers/crypto/aesni_gcm/meson.build b/drivers/crypto/aesni_gcm/meson.build
new file mode 100644
index 000000000..e64f8ce71
--- /dev/null
+++ b/drivers/crypto/aesni_gcm/meson.build
@@ -0,0 +1,13 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+lib = cc.find_library('IPSec_MB', required: false)
+if not lib.found()
+	build = false
+else
+	ext_deps += lib
+endif
+
+sources = files('aesni_gcm_pmd.c', 'aesni_gcm_pmd_ops.c')
+deps += ['bus_vdev']
+
diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index 6ed853b7a..7e14cbba0 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-drivers = ['ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
+drivers = ['aesni_gcm', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
 	'null', 'openssl', 'qat', 'scheduler', 'virtio']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH v2 2/4] drivers/crypto: enable meson support for the aesni mb
  2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
                   ` (6 preceding siblings ...)
  2018-10-05 10:59 ` [PATCH v2 1/4] drivers/crypto: enable meson support for the aesni gcm Hari Kumar Vemula
@ 2018-10-05 10:59 ` Hari Kumar Vemula
  2018-10-05 10:59 ` [PATCH v2 3/4] drivers/crypto: enable meson support for the kasumi Hari Kumar Vemula
  2018-10-05 10:59 ` [PATCH v2 4/4] drivers/crypto: enable meson support for the zuc Hari Kumar Vemula
  9 siblings, 0 replies; 15+ messages in thread
From: Hari Kumar Vemula @ 2018-10-05 10:59 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch, Hari Kumar Vemula

 Added new meson.build file for aesni_mb

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
---
 drivers/crypto/aesni_mb/meson.build | 12 ++++++++++++
 drivers/crypto/meson.build          |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/aesni_mb/meson.build

diff --git a/drivers/crypto/aesni_mb/meson.build b/drivers/crypto/aesni_mb/meson.build
new file mode 100644
index 000000000..aae0995e5
--- /dev/null
+++ b/drivers/crypto/aesni_mb/meson.build
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+lib = cc.find_library('IPSec_MB', required: false)
+if not lib.found()
+	build = false
+else
+	ext_deps += lib
+endif
+
+sources = files('rte_aesni_mb_pmd.c', 'rte_aesni_mb_pmd_ops.c')
+deps += ['bus_vdev']
diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index 7e14cbba0..1de5cfa35 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-drivers = ['aesni_gcm', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
+drivers = ['aesni_gcm', 'aesni_mb', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
 	'null', 'openssl', 'qat', 'scheduler', 'virtio']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH v2 3/4] drivers/crypto: enable meson support for the kasumi
  2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
                   ` (7 preceding siblings ...)
  2018-10-05 10:59 ` [PATCH v2 2/4] drivers/crypto: enable meson support for the aesni mb Hari Kumar Vemula
@ 2018-10-05 10:59 ` Hari Kumar Vemula
  2018-10-05 10:59 ` [PATCH v2 4/4] drivers/crypto: enable meson support for the zuc Hari Kumar Vemula
  9 siblings, 0 replies; 15+ messages in thread
From: Hari Kumar Vemula @ 2018-10-05 10:59 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch, Hari Kumar Vemula

Added new meson.build file for KASUMI

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
---
 drivers/crypto/kasumi/meson.build | 12 ++++++++++++
 drivers/crypto/meson.build        |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/kasumi/meson.build

diff --git a/drivers/crypto/kasumi/meson.build b/drivers/crypto/kasumi/meson.build
new file mode 100644
index 000000000..a09b0e251
--- /dev/null
+++ b/drivers/crypto/kasumi/meson.build
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+lib = cc.find_library('libsso_kasumi', required: false)
+if not lib.found()
+	build = false
+else
+	ext_deps += lib
+endif
+
+sources = files('rte_kasumi_pmd.c', 'rte_kasumi_pmd_ops.c')
+deps += ['bus_vdev']
diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index 1de5cfa35..228729da1 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-drivers = ['aesni_gcm', 'aesni_mb', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
+drivers = ['aesni_gcm', 'aesni_mb', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'kasumi', 'mvsam',
 	'null', 'openssl', 'qat', 'scheduler', 'virtio']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH v2 4/4] drivers/crypto: enable meson support for the zuc
  2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
                   ` (8 preceding siblings ...)
  2018-10-05 10:59 ` [PATCH v2 3/4] drivers/crypto: enable meson support for the kasumi Hari Kumar Vemula
@ 2018-10-05 10:59 ` Hari Kumar Vemula
  9 siblings, 0 replies; 15+ messages in thread
From: Hari Kumar Vemula @ 2018-10-05 10:59 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty,
	pablo.de.lara.guarch, Hari Kumar Vemula

Added new meson.build file for ZUC

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
---
 drivers/crypto/meson.build     |  2 +-
 drivers/crypto/zuc/meson.build | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/zuc/meson.build

diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index 228729da1..85ab80557 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -2,7 +2,7 @@
 # Copyright(c) 2017 Intel Corporation
 
 drivers = ['aesni_gcm', 'aesni_mb', 'ccp', 'dpaa_sec', 'dpaa2_sec', 'kasumi', 'mvsam',
-	'null', 'openssl', 'qat', 'scheduler', 'virtio']
+	'null', 'openssl', 'qat', 'scheduler', 'virtio', 'zuc']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
 config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
diff --git a/drivers/crypto/zuc/meson.build b/drivers/crypto/zuc/meson.build
new file mode 100644
index 000000000..b8ca7107e
--- /dev/null
+++ b/drivers/crypto/zuc/meson.build
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+lib = cc.find_library('libsso_zuc', required: false)
+if not lib.found()
+	build = false
+else
+	ext_deps += lib
+endif
+
+sources = files('rte_zuc_pmd.c', 'rte_zuc_pmd_ops.c')
+deps += ['bus_vdev']
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc
  2018-10-05 10:59 ` [PATCH v2 " Hari Kumar Vemula
@ 2018-10-05 11:13   ` Luca Boccassi
  2018-10-09 12:41     ` Akhil Goyal
  0 siblings, 1 reply; 15+ messages in thread
From: Luca Boccassi @ 2018-10-05 11:13 UTC (permalink / raw)
  To: Hari Kumar Vemula, dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty, pablo.de.lara.guarch

On Fri, 2018-10-05 at 11:59 +0100, Hari Kumar Vemula wrote:
> 1/4: enablement of aesni_gcm pmd in meson
> 2/4: enablement of aesni_mb pmd in meson
> 3/4: enablement of kasumi pmd enable in meson
> 4/4: enablement of zuc pmd enable in meson
> 
> --
> v2: Removed lib dependancy options from  meson_option.txt file
> --
> 
> 
> Hari Kumar Vemula (4):
>   drivers/crypto: enable meson support for the aesni gcm
>   drivers/crypto: enable meson support for the aesni mb
>   drivers/crypto: enable meson support for the kasumi
>   drivers/crypto: enable meson support for the zuc
> 
>  drivers/crypto/aesni_gcm/meson.build | 13 +++++++++++++
>  drivers/crypto/aesni_mb/meson.build  | 12 ++++++++++++
>  drivers/crypto/kasumi/meson.build    | 12 ++++++++++++
>  drivers/crypto/meson.build           |  4 ++--
>  drivers/crypto/zuc/meson.build       | 12 ++++++++++++
>  5 files changed, 51 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/crypto/aesni_gcm/meson.build
>  create mode 100644 drivers/crypto/aesni_mb/meson.build
>  create mode 100644 drivers/crypto/kasumi/meson.build
>  create mode 100644 drivers/crypto/zuc/meson.build

Series-acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc
  2018-10-05 11:13   ` Luca Boccassi
@ 2018-10-09 12:41     ` Akhil Goyal
  0 siblings, 0 replies; 15+ messages in thread
From: Akhil Goyal @ 2018-10-09 12:41 UTC (permalink / raw)
  To: Luca Boccassi, Hari Kumar Vemula, dev
  Cc: bruce.richardson, reshma.pattan, declan.doherty, pablo.de.lara.guarch



On 10/5/2018 4:43 PM, Luca Boccassi wrote:
> On Fri, 2018-10-05 at 11:59 +0100, Hari Kumar Vemula wrote:
>> 1/4: enablement of aesni_gcm pmd in meson
>> 2/4: enablement of aesni_mb pmd in meson
>> 3/4: enablement of kasumi pmd enable in meson
>> 4/4: enablement of zuc pmd enable in meson
>>
>> --
>> v2: Removed lib dependancy options from  meson_option.txt file
>> --
>>
>>
>> Hari Kumar Vemula (4):
>>    drivers/crypto: enable meson support for the aesni gcm
>>    drivers/crypto: enable meson support for the aesni mb
>>    drivers/crypto: enable meson support for the kasumi
>>    drivers/crypto: enable meson support for the zuc
>>
>>   drivers/crypto/aesni_gcm/meson.build | 13 +++++++++++++
>>   drivers/crypto/aesni_mb/meson.build  | 12 ++++++++++++
>>   drivers/crypto/kasumi/meson.build    | 12 ++++++++++++
>>   drivers/crypto/meson.build           |  4 ++--
>>   drivers/crypto/zuc/meson.build       | 12 ++++++++++++
>>   5 files changed, 51 insertions(+), 2 deletions(-)
>>   create mode 100644 drivers/crypto/aesni_gcm/meson.build
>>   create mode 100644 drivers/crypto/aesni_mb/meson.build
>>   create mode 100644 drivers/crypto/kasumi/meson.build
>>   create mode 100644 drivers/crypto/zuc/meson.build
> Series-acked-by: Luca Boccassi <bluca@debian.org>
>
rebased and applied to dpdk-next-crypto

modified the title of the patches as

crypto/zuc: enable meson build
crypto/kasumi: enable meson build
crypto/aesni_mb: enable meson build
crypto/aesni_gcm: enable meson build

Thanks

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2018-10-09 12:41 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-29 12:00 [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Hari Kumar Vemula
2018-09-29 12:00 ` [PATCH 1/4] driver/crypto: enable meson support for the aesni gcm Hari Kumar Vemula
2018-10-01  9:31   ` Bruce Richardson
2018-09-29 12:00 ` [PATCH 2/4] drivers/crypto: enable meson support for the aesni mb Hari Kumar Vemula
2018-09-29 12:01 ` [PATCH 3/4] drivers/crypto: enable meson support for the kasumi Hari Kumar Vemula
2018-09-29 12:01 ` [PATCH 4/4] drivers/crypto: enable meson support for the zuc Hari Kumar Vemula
2018-09-30 10:01 ` [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc Luca Boccassi
2018-10-01  9:36   ` Bruce Richardson
2018-10-05 10:59 ` [PATCH v2 " Hari Kumar Vemula
2018-10-05 11:13   ` Luca Boccassi
2018-10-09 12:41     ` Akhil Goyal
2018-10-05 10:59 ` [PATCH v2 1/4] drivers/crypto: enable meson support for the aesni gcm Hari Kumar Vemula
2018-10-05 10:59 ` [PATCH v2 2/4] drivers/crypto: enable meson support for the aesni mb Hari Kumar Vemula
2018-10-05 10:59 ` [PATCH v2 3/4] drivers/crypto: enable meson support for the kasumi Hari Kumar Vemula
2018-10-05 10:59 ` [PATCH v2 4/4] drivers/crypto: enable meson support for the zuc Hari Kumar Vemula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.