Re: [PATCH v1] i2c: img-scb: remove duplicate dev_err()

Re: [PATCH v1] i2c: img-scb: remove duplicate dev_err()

[Markus Elfring]

> it will print an error message by itself when platform_get_irq()
> goes wrong. so don't need dev_err() in here again.

I suggest to improve the change description.
Can you get any further inspiration by previous patches from
other contributors according to the presented transformation pattern?

Would you like to adjust any more source files in the mentioned
software area?

Regards,
Markus

Re: [PATCH v1] i2c: img-scb: remove duplicate dev_err()

[Dejin Zheng]

On Tue, Apr 14, 2020 at 05:48:41PM +0200, Markus Elfring wrote:
> > it will print an error message by itself when platform_get_irq()
> > goes wrong. so don't need dev_err() in here again.
> 
> I suggest to improve the change description.
> Can you get any further inspiration by previous patches from
> other contributors according to the presented transformation pattern?
> 
> Would you like to adjust any more source files in the mentioned
> software area?
>
Hi Markus:

Thanks for your comments, and maybe we can use coccinelle tools for
more source files do this change in the mentioned software area.

BR,
Dejin
> Regards,
> Markus

Re: i2c: img-scb: remove duplicate dev_err()

[Markus Elfring]

> Thanks for your comments, and maybe we can use coccinelle tools for
> more source files do this change in the mentioned software area.

I found 19 source files (for example in the directory “drivers/i2c”
of the software “Linux next-20200408”) which seem to contain similar
update candidates according to a known transformation pattern.
Would you like to take another look at corresponding change possibilities?

Regards,
Markus

Re: i2c: img-scb: remove duplicate dev_err()

[Dejin Zheng]

On Wed, Apr 15, 2020 at 07:47:41AM +0200, Markus Elfring wrote:
> > Thanks for your comments, and maybe we can use coccinelle tools for
> > more source files do this change in the mentioned software area.
> 
> I found 19 source files (for example in the directory “drivers/i2c”
> of the software “Linux next-20200408”) which seem to contain similar
> update candidates according to a known transformation pattern.
> Would you like to take another look at corresponding change possibilities?
>
yes, I want to do it and thanks for your info.

BR,
Dejin

> Regards,
> Markus

Re: i2c: img-scb: remove duplicate dev_err()

[Markus Elfring]

>> Would you like to take another look at corresponding change possibilities?
>>
> yes, I want to do it and thanks for your info.

This positive feedback can lead to corresponding software development opportunities.
Which directions would you like try out next?

Regards,
Markus

Re: i2c: img-scb: remove duplicate dev_err()

[Markus Elfring]

>>> Would you like to take another look at corresponding change possibilities?
>>>
>> yes, I want to do it and thanks for your info.

How do you think about to improve the clarification around potentially
“odd fixes” (because of collateral evolution)?


I noticed your update suggestion “i2c: busses: convert to devm_platform_ioremap_resource”.
https://lore.kernel.org/linux-i2c/20200409135224.7426-1-zhengdejin5@gmail.com/
https://lore.kernel.org/patchwork/patch/1222122/
https://lkml.org/lkml/2020/4/9/431

It seems that you got encouraged to contribute changes according to another
transformation approach by a single patch for a directory hierarchy.
How likely is it that such adjustments touch source code places
where related error messages would be found for further software
development considerations?
Would you like to wait until the integration of this update succeeded?

Will it be interesting in the meantime to become more familiar with
applications around scripts for the semantic patch language?
Can the Coccinelle software make the discussed transformations more convenient
also for your needs?

Regards,
Markus

Re: i2c: img-scb: remove duplicate dev_err()

[Markus Elfring]

>>> Would you like to take another look at corresponding change possibilities?
>>>
>> yes, I want to do it and thanks for your info.

How do you think about to improve the clarification around potentially
“odd fixes” (because of collateral evolution)?


I noticed your update suggestion “i2c: busses: convert to devm_platform_ioremap_resource”.
https://lore.kernel.org/linux-i2c/20200409135224.7426-1-zhengdejin5@gmail.com/
https://lore.kernel.org/patchwork/patch/1222122/
https://lkml.org/lkml/2020/4/9/431

It seems that you got encouraged to contribute changes according to another
transformation approach by a single patch for a directory hierarchy.
How likely is it that such adjustments touch source code places
where related error messages would be found for further software
development considerations?
Would you like to wait until the integration of this update succeeded?

Will it be interesting in the meantime to become more familiar with
applications around scripts for the semantic patch language?
Can the Coccinelle software make the discussed transformations more convenient
also for your needs?

Regards,
Markus

Re: i2c: img-scb: remove duplicate dev_err()

[Dejin Zheng]

On Wed, Apr 15, 2020 at 06:24:09PM +0200, Markus Elfring wrote:
> >> Would you like to take another look at corresponding change possibilities?
> >>
> > yes, I want to do it and thanks for your info.
> 
> This positive feedback can lead to corresponding software development opportunities.
> Which directions would you like try out next?
>
May be related to usb, ethernet and pcie. My current job is related to
these. Thanks!

BR,
Dejin

> Regards,
> Markus