From: Lu Baolu <baolu.lu@linux.intel.com> To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>, iommu@lists.linux-foundation.org Cc: baolu.lu@linux.intel.com, joro@8bytes.org, linux-pci@vger.kernel.org, jcrouse@codeaurora.org, alex.williamson@redhat.com, Jonathan.Cameron@huawei.com, jacob.jun.pan@linux.intel.com, christian.koenig@amd.com, eric.auger@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, andrew.murray@arm.com, will.deacon@arm.com, robin.murphy@arm.com, ashok.raj@intel.com, xuzaibo@huawei.com, liguozhu@hisilicon.com, okaya@codeaurora.org, bharatku@xilinx.com, ilias.apalodimas@linaro.org, shunyong.yang@hxt-semitech.com Subject: Re: [PATCH v3 06/10] iommu/sva: Search mm by PASID Date: Tue, 25 Sep 2018 12:59:33 +0800 [thread overview] Message-ID: <bb2e42bb-175a-3368-4a53-8872e63e8d3e@linux.intel.com> (raw) In-Reply-To: <20180920170046.20154-7-jean-philippe.brucker@arm.com> Hi, On 09/21/2018 01:00 AM, Jean-Philippe Brucker wrote: > The fault handler will need to find an mm given its PASID. This is the > reason we have an IDR for storing address spaces, so hook it up. > > Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com> > --- > drivers/iommu/iommu-sva.c | 26 ++++++++++++++++++++++++++ > include/linux/iommu.h | 7 +++++++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c > index 5ff8967cb213..ee86f00ee1b9 100644 > --- a/drivers/iommu/iommu-sva.c > +++ b/drivers/iommu/iommu-sva.c > @@ -636,6 +636,32 @@ void iommu_sva_unbind_device_all(struct device *dev) > } > EXPORT_SYMBOL_GPL(iommu_sva_unbind_device_all); > > +/** > + * iommu_sva_find() - Find mm associated to the given PASID > + * @pasid: Process Address Space ID assigned to the mm > + * > + * Returns the mm corresponding to this PASID, or NULL if not found. A reference > + * to the mm is taken, and must be released with mmput(). > + */ > +struct mm_struct *iommu_sva_find(int pasid) > +{ > + struct io_mm *io_mm; > + struct mm_struct *mm = NULL; > + > + spin_lock(&iommu_sva_lock); > + io_mm = idr_find(&iommu_pasid_idr, pasid); The same thing here. We can't guarantee that a pointer of mm_struct type is associated with a pasid value when pasid is also used for other purposes. If hardware reports a bad pasid, this function might run into problem. Best regards, Lu Baolu > + if (io_mm && io_mm_get_locked(io_mm)) { > + if (mmget_not_zero(io_mm->mm)) > + mm = io_mm->mm; > + > + io_mm_put_locked(io_mm); > + } > + spin_unlock(&iommu_sva_lock); > + > + return mm; > +} > +EXPORT_SYMBOL_GPL(iommu_sva_find); > + > /** > * iommu_sva_init_device() - Initialize Shared Virtual Addressing for a device > * @dev: the device > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 429f3dc37a35..a457650b80de 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -987,6 +987,8 @@ extern int __iommu_sva_bind_device(struct device *dev, struct mm_struct *mm, > void *drvdata); > extern int __iommu_sva_unbind_device(struct device *dev, int pasid); > extern void iommu_sva_unbind_device_all(struct device *dev); > +extern struct mm_struct *iommu_sva_find(int pasid); > + > #else /* CONFIG_IOMMU_SVA */ > static inline int iommu_sva_init_device(struct device *dev, > unsigned long features, > @@ -1016,6 +1018,11 @@ static inline int __iommu_sva_unbind_device(struct device *dev, int pasid) > static inline void iommu_sva_unbind_device_all(struct device *dev) > { > } > + > +static inline struct mm_struct *iommu_sva_find(int pasid) > +{ > + return NULL; > +} > #endif /* CONFIG_IOMMU_SVA */ > > #endif /* __LINUX_IOMMU_H */ >
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> To: Jean-Philippe Brucker <jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Cc: kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ilias.apalodimas-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, liguozhu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, robin.murphy-5wv7dgnIgG8@public.gmane.org, christian.koenig-5C7GfCeVMHo@public.gmane.org Subject: Re: [PATCH v3 06/10] iommu/sva: Search mm by PASID Date: Tue, 25 Sep 2018 12:59:33 +0800 [thread overview] Message-ID: <bb2e42bb-175a-3368-4a53-8872e63e8d3e@linux.intel.com> (raw) In-Reply-To: <20180920170046.20154-7-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> Hi, On 09/21/2018 01:00 AM, Jean-Philippe Brucker wrote: > The fault handler will need to find an mm given its PASID. This is the > reason we have an IDR for storing address spaces, so hook it up. > > Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> > --- > drivers/iommu/iommu-sva.c | 26 ++++++++++++++++++++++++++ > include/linux/iommu.h | 7 +++++++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c > index 5ff8967cb213..ee86f00ee1b9 100644 > --- a/drivers/iommu/iommu-sva.c > +++ b/drivers/iommu/iommu-sva.c > @@ -636,6 +636,32 @@ void iommu_sva_unbind_device_all(struct device *dev) > } > EXPORT_SYMBOL_GPL(iommu_sva_unbind_device_all); > > +/** > + * iommu_sva_find() - Find mm associated to the given PASID > + * @pasid: Process Address Space ID assigned to the mm > + * > + * Returns the mm corresponding to this PASID, or NULL if not found. A reference > + * to the mm is taken, and must be released with mmput(). > + */ > +struct mm_struct *iommu_sva_find(int pasid) > +{ > + struct io_mm *io_mm; > + struct mm_struct *mm = NULL; > + > + spin_lock(&iommu_sva_lock); > + io_mm = idr_find(&iommu_pasid_idr, pasid); The same thing here. We can't guarantee that a pointer of mm_struct type is associated with a pasid value when pasid is also used for other purposes. If hardware reports a bad pasid, this function might run into problem. Best regards, Lu Baolu > + if (io_mm && io_mm_get_locked(io_mm)) { > + if (mmget_not_zero(io_mm->mm)) > + mm = io_mm->mm; > + > + io_mm_put_locked(io_mm); > + } > + spin_unlock(&iommu_sva_lock); > + > + return mm; > +} > +EXPORT_SYMBOL_GPL(iommu_sva_find); > + > /** > * iommu_sva_init_device() - Initialize Shared Virtual Addressing for a device > * @dev: the device > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 429f3dc37a35..a457650b80de 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -987,6 +987,8 @@ extern int __iommu_sva_bind_device(struct device *dev, struct mm_struct *mm, > void *drvdata); > extern int __iommu_sva_unbind_device(struct device *dev, int pasid); > extern void iommu_sva_unbind_device_all(struct device *dev); > +extern struct mm_struct *iommu_sva_find(int pasid); > + > #else /* CONFIG_IOMMU_SVA */ > static inline int iommu_sva_init_device(struct device *dev, > unsigned long features, > @@ -1016,6 +1018,11 @@ static inline int __iommu_sva_unbind_device(struct device *dev, int pasid) > static inline void iommu_sva_unbind_device_all(struct device *dev) > { > } > + > +static inline struct mm_struct *iommu_sva_find(int pasid) > +{ > + return NULL; > +} > #endif /* CONFIG_IOMMU_SVA */ > > #endif /* __LINUX_IOMMU_H */ >
next prev parent reply other threads:[~2018-09-25 5:01 UTC|newest] Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-20 17:00 [PATCH v3 00/10] Shared Virtual Addressing for the IOMMU Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker 2018-09-20 17:00 ` [PATCH v3 01/10] iommu: Introduce Shared Virtual Addressing API Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker [not found] ` <20180920170046.20154-2-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> 2018-09-23 2:39 ` Lu Baolu 2018-09-24 12:07 ` Jean-Philippe Brucker 2018-09-24 12:07 ` Jean-Philippe Brucker 2018-09-25 13:16 ` Joerg Roedel 2018-09-25 13:16 ` Joerg Roedel 2018-09-25 22:46 ` Jacob Pan 2018-09-25 22:46 ` Jacob Pan 2018-09-26 10:14 ` Jean-Philippe Brucker 2018-09-26 10:14 ` Jean-Philippe Brucker 2018-09-26 12:48 ` Joerg Roedel 2018-09-26 12:48 ` Joerg Roedel 2018-09-20 17:00 ` [PATCH v3 02/10] iommu/sva: Bind process address spaces to devices Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker 2018-09-23 3:05 ` Lu Baolu 2018-09-23 3:05 ` Lu Baolu 2018-09-24 12:07 ` Jean-Philippe Brucker 2018-09-24 12:07 ` Jean-Philippe Brucker 2018-09-26 18:01 ` Jacob Pan 2018-09-26 18:01 ` Jacob Pan 2018-09-27 15:06 ` Jean-Philippe Brucker 2018-09-27 15:06 ` Jean-Philippe Brucker 2018-09-28 1:14 ` Tian, Kevin 2018-09-28 1:14 ` Tian, Kevin 2018-09-20 17:00 ` [PATCH v3 03/10] iommu/sva: Manage process address spaces Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker 2018-09-25 3:15 ` Lu Baolu 2018-09-25 3:15 ` Lu Baolu 2018-09-25 10:32 ` Jean-Philippe Brucker 2018-09-25 10:32 ` Jean-Philippe Brucker 2018-09-26 3:12 ` Lu Baolu 2018-09-26 3:12 ` Lu Baolu 2018-09-25 13:26 ` Joerg Roedel 2018-09-25 13:26 ` Joerg Roedel 2018-09-25 23:33 ` Lu Baolu 2018-09-25 23:33 ` Lu Baolu 2018-09-26 10:20 ` Jean-Philippe Brucker 2018-09-26 10:20 ` Jean-Philippe Brucker 2018-09-26 12:45 ` Joerg Roedel 2018-09-26 12:45 ` Joerg Roedel 2018-09-26 13:50 ` Jean-Philippe Brucker 2018-09-26 13:50 ` Jean-Philippe Brucker 2018-09-27 3:22 ` Liu, Yi L 2018-09-27 3:22 ` Liu, Yi L 2018-09-27 13:37 ` Jean-Philippe Brucker 2018-09-27 13:37 ` Jean-Philippe Brucker 2018-10-08 8:29 ` Liu, Yi L 2018-10-08 8:29 ` Liu, Yi L 2018-09-26 22:58 ` Jacob Pan 2018-09-26 22:58 ` Jacob Pan 2018-09-26 22:35 ` Jacob Pan 2018-09-26 22:35 ` Jacob Pan 2018-10-03 17:52 ` Jean-Philippe Brucker 2018-10-03 17:52 ` Jean-Philippe Brucker 2018-10-15 20:53 ` Jacob Pan 2018-10-15 20:53 ` Jacob Pan 2018-09-20 17:00 ` [PATCH v3 04/10] iommu/sva: Add a mm_exit callback for device drivers Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker 2018-09-20 17:00 ` [PATCH v3 05/10] iommu/sva: Track mm changes with an MMU notifier Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker 2018-09-20 17:00 ` [PATCH v3 06/10] iommu/sva: Search mm by PASID Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker 2018-09-25 4:59 ` Lu Baolu [this message] 2018-09-25 4:59 ` Lu Baolu 2018-09-20 17:00 ` [PATCH v3 07/10] iommu: Add a page fault handler Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker 2018-09-27 20:37 ` Jacob Pan 2018-09-27 20:37 ` Jacob Pan 2018-10-03 17:46 ` Jean-Philippe Brucker 2018-10-03 17:46 ` Jean-Philippe Brucker 2018-09-20 17:00 ` [PATCH v3 08/10] iommu/iopf: Handle mm faults Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker 2018-09-20 17:00 ` [PATCH v3 09/10] iommu/sva: Register page fault handler Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker 2018-09-20 17:00 ` [RFC PATCH v3 10/10] iommu/sva: Add support for private PASIDs Jean-Philippe Brucker 2018-09-20 17:00 ` Jean-Philippe Brucker 2018-10-12 14:32 ` Jordan Crouse 2018-10-12 14:32 ` Jordan Crouse 2018-10-17 14:21 ` Jean-Philippe Brucker 2018-10-17 14:21 ` Jean-Philippe Brucker 2018-10-17 14:24 ` Jean-Philippe Brucker 2018-10-17 14:24 ` Jean-Philippe Brucker 2018-10-17 15:07 ` Jordan Crouse 2018-10-17 15:07 ` Jordan Crouse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bb2e42bb-175a-3368-4a53-8872e63e8d3e@linux.intel.com \ --to=baolu.lu@linux.intel.com \ --cc=Jonathan.Cameron@huawei.com \ --cc=alex.williamson@redhat.com \ --cc=andrew.murray@arm.com \ --cc=ashok.raj@intel.com \ --cc=bharatku@xilinx.com \ --cc=christian.koenig@amd.com \ --cc=eric.auger@redhat.com \ --cc=ilias.apalodimas@linaro.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jcrouse@codeaurora.org \ --cc=jean-philippe.brucker@arm.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=liguozhu@hisilicon.com \ --cc=linux-pci@vger.kernel.org \ --cc=okaya@codeaurora.org \ --cc=robin.murphy@arm.com \ --cc=shunyong.yang@hxt-semitech.com \ --cc=will.deacon@arm.com \ --cc=xuzaibo@huawei.com \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.