From: LIU Zhiwei <zhiwei_liu@c-sky.com> To: Richard Henderson <richard.henderson@linaro.org>, peter.maydell@linaro.org Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, wxy194768@alibaba-inc.com, wenmeng_zhang@c-sky.com, palmer@dabbelt.com, alistair23@gmail.com, alex.bennee@linaro.org Subject: Re: [RFC PATCH 8/8] riscv: Add RV64F instructions description Date: Tue, 19 May 2020 20:27:33 +0800 [thread overview] Message-ID: <c093ec93-d16b-1ca3-39d6-9c21bd4fa623@c-sky.com> (raw) In-Reply-To: <99fa418c-9a2e-d806-b164-3a08fecd74e8@linaro.org> On 2020/5/12 2:11, Richard Henderson wrote: > On 4/30/20 12:21 AM, LIU Zhiwei wrote: >> +FCVT_L_S RISCV 1100000 00010 rs1:5 rm:3 rd:5 1010011 \ >> +!constraints { $rd != 2 && $rd != 3 && $rd != 4 && $rm != 6 && $rm != 5 } >> + >> +FCVT_LU_S RISCV 1100000 00011 rs1:5 rm:3 rd:5 1010011 \ >> +!constraints { $rd != 2 && $rd != 3 && $rd != 4 && $rm != 6 && $rm != 5 } >> + >> +FCVT_S_L RISCV 1101000 00010 rs1:5 rm:3 rd:5 1010011 \ >> +!constraints { $rs1 != 2 && $rm != 6 && $rm != 5 } >> + >> +FCVT_S_LU RISCV 1101000 00011 rs1:5 rm:3 rd:5 1010011 \ >> +!constraints { $rs1 != 2 && $rm != 6 && $rm != 5 } > Interesting question here: Do we really want to avoid the reserved rounding > modes, or do we want to verify that we raise an invalid operand exception? I think we should always generate legal instructions except explicitly illegal instructions with proper risu ops code. Zhiwei > I guess I'm fine with it either way. > > > r~
WARNING: multiple messages have this Message-ID (diff)
From: LIU Zhiwei <zhiwei_liu@c-sky.com> To: Richard Henderson <richard.henderson@linaro.org>, peter.maydell@linaro.org Cc: alistair23@gmail.com, palmer@dabbelt.com, wenmeng_zhang@c-sky.com, wxy194768@alibaba-inc.com, qemu-devel@nongnu.org, alex.bennee@linaro.org, qemu-riscv@nongnu.org Subject: Re: [RFC PATCH 8/8] riscv: Add RV64F instructions description Date: Tue, 19 May 2020 20:27:33 +0800 [thread overview] Message-ID: <c093ec93-d16b-1ca3-39d6-9c21bd4fa623@c-sky.com> (raw) In-Reply-To: <99fa418c-9a2e-d806-b164-3a08fecd74e8@linaro.org> On 2020/5/12 2:11, Richard Henderson wrote: > On 4/30/20 12:21 AM, LIU Zhiwei wrote: >> +FCVT_L_S RISCV 1100000 00010 rs1:5 rm:3 rd:5 1010011 \ >> +!constraints { $rd != 2 && $rd != 3 && $rd != 4 && $rm != 6 && $rm != 5 } >> + >> +FCVT_LU_S RISCV 1100000 00011 rs1:5 rm:3 rd:5 1010011 \ >> +!constraints { $rd != 2 && $rd != 3 && $rd != 4 && $rm != 6 && $rm != 5 } >> + >> +FCVT_S_L RISCV 1101000 00010 rs1:5 rm:3 rd:5 1010011 \ >> +!constraints { $rs1 != 2 && $rm != 6 && $rm != 5 } >> + >> +FCVT_S_LU RISCV 1101000 00011 rs1:5 rm:3 rd:5 1010011 \ >> +!constraints { $rs1 != 2 && $rm != 6 && $rm != 5 } > Interesting question here: Do we really want to avoid the reserved rounding > modes, or do we want to verify that we raise an invalid operand exception? I think we should always generate legal instructions except explicitly illegal instructions with proper risu ops code. Zhiwei > I guess I'm fine with it either way. > > > r~
next prev parent reply other threads:[~2020-05-19 12:29 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-30 7:21 [RFC PATCH 0/8] RISCV risu porting LIU Zhiwei 2020-04-30 7:21 ` LIU Zhiwei 2020-04-30 7:21 ` [RFC PATCH 1/8] riscv: Add RV64I instructions description LIU Zhiwei 2020-04-30 7:21 ` LIU Zhiwei 2020-05-11 16:39 ` Richard Henderson 2020-05-11 16:39 ` Richard Henderson 2020-05-20 2:41 ` LIU Zhiwei 2020-05-20 2:41 ` LIU Zhiwei 2020-05-20 5:39 ` Richard Henderson 2020-05-20 5:39 ` Richard Henderson 2020-04-30 7:21 ` [RFC PATCH 2/8] riscv: Generate payload scripts LIU Zhiwei 2020-04-30 7:21 ` LIU Zhiwei 2020-05-11 17:40 ` Richard Henderson 2020-05-11 17:40 ` Richard Henderson 2020-05-20 2:37 ` LIU Zhiwei 2020-05-20 2:37 ` LIU Zhiwei 2020-05-20 5:41 ` Richard Henderson 2020-05-20 5:41 ` Richard Henderson 2020-05-20 9:06 ` LIU Zhiwei 2020-05-20 9:06 ` LIU Zhiwei 2020-04-30 7:21 ` [RFC PATCH 3/8] riscv: Define riscv struct reginfo LIU Zhiwei 2020-04-30 7:21 ` LIU Zhiwei 2020-05-11 17:42 ` Richard Henderson 2020-05-11 17:42 ` Richard Henderson 2020-04-30 7:21 ` [RFC PATCH 4/8] riscv: Implement payload load interfaces LIU Zhiwei 2020-04-30 7:21 ` LIU Zhiwei 2020-05-11 18:03 ` Richard Henderson 2020-05-11 18:03 ` Richard Henderson 2020-05-11 18:07 ` Richard Henderson 2020-05-11 18:07 ` Richard Henderson 2020-04-30 7:21 ` [RFC PATCH 5/8] riscv: Add standard test case LIU Zhiwei 2020-04-30 7:21 ` LIU Zhiwei 2020-05-11 18:04 ` Richard Henderson 2020-05-11 18:04 ` Richard Henderson 2020-04-30 7:21 ` [RFC PATCH 6/8] riscv: Add configure script LIU Zhiwei 2020-04-30 7:21 ` LIU Zhiwei 2020-05-11 18:06 ` Richard Henderson 2020-05-11 18:06 ` Richard Henderson 2020-05-20 1:45 ` LIU Zhiwei 2020-05-20 1:45 ` LIU Zhiwei 2020-05-20 2:28 ` LIU Zhiwei 2020-05-20 2:28 ` LIU Zhiwei 2020-04-30 7:21 ` [RFC PATCH 7/8] riscv: Add RV64M instructions description LIU Zhiwei 2020-04-30 7:21 ` LIU Zhiwei 2020-05-11 18:12 ` Richard Henderson 2020-05-11 18:12 ` Richard Henderson 2020-04-30 7:21 ` [RFC PATCH 8/8] riscv: Add RV64F " LIU Zhiwei 2020-04-30 7:21 ` LIU Zhiwei 2020-05-11 18:11 ` Richard Henderson 2020-05-11 18:11 ` Richard Henderson 2020-05-19 12:27 ` LIU Zhiwei [this message] 2020-05-19 12:27 ` LIU Zhiwei 2020-05-11 16:30 ` [RFC PATCH 0/8] RISCV risu porting Richard Henderson 2020-05-11 16:30 ` Richard Henderson 2020-05-19 9:44 ` LIU Zhiwei 2020-05-19 9:44 ` LIU Zhiwei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c093ec93-d16b-1ca3-39d6-9c21bd4fa623@c-sky.com \ --to=zhiwei_liu@c-sky.com \ --cc=alex.bennee@linaro.org \ --cc=alistair23@gmail.com \ --cc=palmer@dabbelt.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=wenmeng_zhang@c-sky.com \ --cc=wxy194768@alibaba-inc.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.