From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> To: Robin Murphy <robin.murphy@arm.com> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Mike Leach <mike.leach@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, Stephen Boyd <swboyd@chromium.org> Subject: Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF Date: Wed, 03 Jun 2020 19:21:04 +0530 [thread overview] Message-ID: <c3b17c472783faa6f153bccc157ad8c4@codeaurora.org> (raw) In-Reply-To: <68444180-3ebe-8988-493a-fdd1dff994b6@arm.com> Hi Robin, On 2020-06-03 19:10, Robin Murphy wrote: > On 2020-06-03 13:26, Sai Prakash Ranjan wrote: >> Hi Robin, >> >> On 2020-06-03 17:51, Robin Murphy wrote: >>> On 2020-06-03 13:00, Sai Prakash Ranjan wrote: >>>> Hi Robin, Mathieu >>>> >>>> On 2020-06-03 17:07, Robin Murphy wrote: >>>>> On 2020-06-01 22:28, Mathieu Poirier wrote: >>>>>> That being said I'm sure that dependencies on an IOMMU isn't a >>>>>> problem confined >>>>>> to coresight. I am adding Robin Murphy, who added this commit [1], >>>>>> to the thread >>>>>> in the hope that he can provide guidance on the right way to do >>>>>> this. >>>>> >>>>> Right, it's not specific to CoreSight, and it's not even specific >>>>> to >>>>> IOMMUs really. In short, blame kexec ;) >>>>> >>>> >>>> Yes it is not specific to coresight, we are targeting this for all >>>> consumers/clients of SMMU(atleast on SC7180 SoC). We have display >>>> throwing >>>> NoC/interconnect errors[1] during reboot after SMMU is disabled. >>>> This is also not specific to kexec either as you explained here [2] >>>> about >>>> a case with display which is exacly what is happening in our system >>>> [1]. >>> >>> Sure, but those instances are begging the question of why the SMMU is >>> disabled at reboot in the first place ;) >>> >> >> That is what happens in SMMU shutdown callback right? It is the >> reboot/shutdown flow. > > Yes, that's where it happens, but my point is *why* it happens at all. > > hint: `git log --grep=shutdown drivers/iommu/` > Ah my change :) > If we could assume the system is always about to be powered off or > reset, we wouldn't need to do anything to the SMMU either ;) > Are you hinting at removing SMMU shutdown callback altogether ;) Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> To: Robin Murphy <robin.murphy@arm.com> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>, linux-arm-kernel@lists.infradead.org, Mike Leach <mike.leach@linaro.org> Subject: Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF Date: Wed, 03 Jun 2020 19:21:04 +0530 [thread overview] Message-ID: <c3b17c472783faa6f153bccc157ad8c4@codeaurora.org> (raw) In-Reply-To: <68444180-3ebe-8988-493a-fdd1dff994b6@arm.com> Hi Robin, On 2020-06-03 19:10, Robin Murphy wrote: > On 2020-06-03 13:26, Sai Prakash Ranjan wrote: >> Hi Robin, >> >> On 2020-06-03 17:51, Robin Murphy wrote: >>> On 2020-06-03 13:00, Sai Prakash Ranjan wrote: >>>> Hi Robin, Mathieu >>>> >>>> On 2020-06-03 17:07, Robin Murphy wrote: >>>>> On 2020-06-01 22:28, Mathieu Poirier wrote: >>>>>> That being said I'm sure that dependencies on an IOMMU isn't a >>>>>> problem confined >>>>>> to coresight. I am adding Robin Murphy, who added this commit [1], >>>>>> to the thread >>>>>> in the hope that he can provide guidance on the right way to do >>>>>> this. >>>>> >>>>> Right, it's not specific to CoreSight, and it's not even specific >>>>> to >>>>> IOMMUs really. In short, blame kexec ;) >>>>> >>>> >>>> Yes it is not specific to coresight, we are targeting this for all >>>> consumers/clients of SMMU(atleast on SC7180 SoC). We have display >>>> throwing >>>> NoC/interconnect errors[1] during reboot after SMMU is disabled. >>>> This is also not specific to kexec either as you explained here [2] >>>> about >>>> a case with display which is exacly what is happening in our system >>>> [1]. >>> >>> Sure, but those instances are begging the question of why the SMMU is >>> disabled at reboot in the first place ;) >>> >> >> That is what happens in SMMU shutdown callback right? It is the >> reboot/shutdown flow. > > Yes, that's where it happens, but my point is *why* it happens at all. > > hint: `git log --grep=shutdown drivers/iommu/` > Ah my change :) > If we could assume the system is always about to be powered off or > reset, we wouldn't need to do anything to the SMMU either ;) > Are you hinting at removing SMMU shutdown callback altogether ;) Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-03 13:51 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-01 8:02 [PATCH 0/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF Sai Prakash Ranjan 2020-06-01 8:02 ` Sai Prakash Ranjan 2020-06-01 8:02 ` [PATCH 1/2] coresight: tmc: Add enable flag to indicate the status of ETR/ETF Sai Prakash Ranjan 2020-06-01 8:02 ` Sai Prakash Ranjan 2020-06-01 13:27 ` Mike Leach 2020-06-01 13:27 ` Mike Leach 2020-06-01 17:13 ` Sai Prakash Ranjan 2020-06-01 17:13 ` Sai Prakash Ranjan 2020-06-01 8:02 ` [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF Sai Prakash Ranjan 2020-06-01 8:02 ` Sai Prakash Ranjan 2020-06-01 13:35 ` Mike Leach 2020-06-01 13:35 ` Mike Leach 2020-06-01 17:15 ` Sai Prakash Ranjan 2020-06-01 17:15 ` Sai Prakash Ranjan 2020-06-01 21:28 ` Mathieu Poirier 2020-06-01 21:28 ` Mathieu Poirier 2020-06-02 7:30 ` Sai Prakash Ranjan 2020-06-02 7:30 ` Sai Prakash Ranjan 2020-06-02 22:12 ` Mike Leach 2020-06-02 22:12 ` Mike Leach 2020-06-03 10:24 ` Sai Prakash Ranjan 2020-06-03 10:24 ` Sai Prakash Ranjan 2020-06-03 11:27 ` Mike Leach 2020-06-03 11:27 ` Mike Leach 2020-06-03 12:14 ` Sai Prakash Ranjan 2020-06-03 12:14 ` Sai Prakash Ranjan 2020-06-03 13:22 ` Mike Leach 2020-06-03 13:22 ` Mike Leach 2020-06-03 13:34 ` Robin Murphy 2020-06-03 13:34 ` Robin Murphy 2020-06-03 13:43 ` Sai Prakash Ranjan 2020-06-03 13:43 ` Sai Prakash Ranjan 2020-06-03 13:51 ` Mike Leach 2020-06-03 13:51 ` Mike Leach 2020-06-03 14:02 ` Sai Prakash Ranjan 2020-06-03 14:02 ` Sai Prakash Ranjan 2020-06-03 17:44 ` Mathieu Poirier 2020-06-03 17:44 ` Mathieu Poirier 2020-06-04 7:27 ` Sai Prakash Ranjan 2020-06-04 7:27 ` Sai Prakash Ranjan 2020-06-08 14:07 ` Sai Prakash Ranjan 2020-06-08 14:07 ` Sai Prakash Ranjan 2020-06-09 15:27 ` Mathieu Poirier 2020-06-09 15:27 ` Mathieu Poirier 2020-06-09 15:37 ` Sai Prakash Ranjan 2020-06-09 15:37 ` Sai Prakash Ranjan 2020-06-03 11:37 ` Robin Murphy 2020-06-03 11:37 ` Robin Murphy 2020-06-03 12:00 ` Sai Prakash Ranjan 2020-06-03 12:00 ` Sai Prakash Ranjan 2020-06-03 12:21 ` Robin Murphy 2020-06-03 12:21 ` Robin Murphy 2020-06-03 12:26 ` Sai Prakash Ranjan 2020-06-03 12:26 ` Sai Prakash Ranjan 2020-06-03 13:40 ` Robin Murphy 2020-06-03 13:40 ` Robin Murphy 2020-06-03 13:51 ` Sai Prakash Ranjan [this message] 2020-06-03 13:51 ` Sai Prakash Ranjan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c3b17c472783faa6f153bccc157ad8c4@codeaurora.org \ --to=saiprakash.ranjan@codeaurora.org \ --cc=coresight@lists.linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=robin.murphy@arm.com \ --cc=suzuki.poulose@arm.com \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.