All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	coresight@lists.linaro.org, Stephen Boyd <swboyd@chromium.org>,
	Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Subject: [PATCH 0/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF
Date: Mon,  1 Jun 2020 13:32:24 +0530	[thread overview]
Message-ID: <cover.1590947174.git.saiprakash.ranjan@codeaurora.org> (raw)

This series adds a shutdown callback to TMC ETR/ETF to ensure that
it is properly shutdown in reboot/shutdown path. This is required
for ETR/ETF which has SMMU address translation enabled like on SC7180
SoC and few others. If the hardware is still accessing memory after
SMMU translation is disabled as part of SMMU shutdown callback in
system reboot or shutdown path, then IOVAs(I/O virtual address)
which it was using will go on the bus as the physical addresses which
might result in unknown crashes (NoC/interconnect errors). So we make
sure from this shutdown callback that the ETR/ETF is shutdown before
SMMU translation is disabled and device_link in SMMU driver will take
care of ordering of shutdown callbacks such that SMMU shutdown callback
is not called before any of its consumer shutdown callbacks.

Sai Prakash Ranjan (2):
  coresight: tmc: Add enable flag to indicate the status of ETR/ETF
  coresight: tmc: Add shutdown callback for TMC ETR/ETF

 .../hwtracing/coresight/coresight-tmc-etf.c   |  4 +--
 .../hwtracing/coresight/coresight-tmc-etr.c   |  2 +-
 drivers/hwtracing/coresight/coresight-tmc.c   | 31 +++++++++++++++++++
 drivers/hwtracing/coresight/coresight-tmc.h   |  5 +++
 4 files changed, 39 insertions(+), 3 deletions(-)


base-commit: 059e38815950dbec65beafe03757bce9436e89a4
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


WARNING: multiple messages have this Message-ID (diff)
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>
Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org,
	linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF
Date: Mon,  1 Jun 2020 13:32:24 +0530	[thread overview]
Message-ID: <cover.1590947174.git.saiprakash.ranjan@codeaurora.org> (raw)

This series adds a shutdown callback to TMC ETR/ETF to ensure that
it is properly shutdown in reboot/shutdown path. This is required
for ETR/ETF which has SMMU address translation enabled like on SC7180
SoC and few others. If the hardware is still accessing memory after
SMMU translation is disabled as part of SMMU shutdown callback in
system reboot or shutdown path, then IOVAs(I/O virtual address)
which it was using will go on the bus as the physical addresses which
might result in unknown crashes (NoC/interconnect errors). So we make
sure from this shutdown callback that the ETR/ETF is shutdown before
SMMU translation is disabled and device_link in SMMU driver will take
care of ordering of shutdown callbacks such that SMMU shutdown callback
is not called before any of its consumer shutdown callbacks.

Sai Prakash Ranjan (2):
  coresight: tmc: Add enable flag to indicate the status of ETR/ETF
  coresight: tmc: Add shutdown callback for TMC ETR/ETF

 .../hwtracing/coresight/coresight-tmc-etf.c   |  4 +--
 .../hwtracing/coresight/coresight-tmc-etr.c   |  2 +-
 drivers/hwtracing/coresight/coresight-tmc.c   | 31 +++++++++++++++++++
 drivers/hwtracing/coresight/coresight-tmc.h   |  5 +++
 4 files changed, 39 insertions(+), 3 deletions(-)


base-commit: 059e38815950dbec65beafe03757bce9436e89a4
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2020-06-01  8:02 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01  8:02 Sai Prakash Ranjan [this message]
2020-06-01  8:02 ` [PATCH 0/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF Sai Prakash Ranjan
2020-06-01  8:02 ` [PATCH 1/2] coresight: tmc: Add enable flag to indicate the status of ETR/ETF Sai Prakash Ranjan
2020-06-01  8:02   ` Sai Prakash Ranjan
2020-06-01 13:27   ` Mike Leach
2020-06-01 13:27     ` Mike Leach
2020-06-01 17:13     ` Sai Prakash Ranjan
2020-06-01 17:13       ` Sai Prakash Ranjan
2020-06-01  8:02 ` [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF Sai Prakash Ranjan
2020-06-01  8:02   ` Sai Prakash Ranjan
2020-06-01 13:35   ` Mike Leach
2020-06-01 13:35     ` Mike Leach
2020-06-01 17:15     ` Sai Prakash Ranjan
2020-06-01 17:15       ` Sai Prakash Ranjan
2020-06-01 21:28   ` Mathieu Poirier
2020-06-01 21:28     ` Mathieu Poirier
2020-06-02  7:30     ` Sai Prakash Ranjan
2020-06-02  7:30       ` Sai Prakash Ranjan
2020-06-02 22:12       ` Mike Leach
2020-06-02 22:12         ` Mike Leach
2020-06-03 10:24         ` Sai Prakash Ranjan
2020-06-03 10:24           ` Sai Prakash Ranjan
2020-06-03 11:27           ` Mike Leach
2020-06-03 11:27             ` Mike Leach
2020-06-03 12:14             ` Sai Prakash Ranjan
2020-06-03 12:14               ` Sai Prakash Ranjan
2020-06-03 13:22               ` Mike Leach
2020-06-03 13:22                 ` Mike Leach
2020-06-03 13:34                 ` Robin Murphy
2020-06-03 13:34                   ` Robin Murphy
2020-06-03 13:43                   ` Sai Prakash Ranjan
2020-06-03 13:43                     ` Sai Prakash Ranjan
2020-06-03 13:51                   ` Mike Leach
2020-06-03 13:51                     ` Mike Leach
2020-06-03 14:02                     ` Sai Prakash Ranjan
2020-06-03 14:02                       ` Sai Prakash Ranjan
2020-06-03 17:44                   ` Mathieu Poirier
2020-06-03 17:44                     ` Mathieu Poirier
2020-06-04  7:27                     ` Sai Prakash Ranjan
2020-06-04  7:27                       ` Sai Prakash Ranjan
2020-06-08 14:07                       ` Sai Prakash Ranjan
2020-06-08 14:07                         ` Sai Prakash Ranjan
2020-06-09 15:27                         ` Mathieu Poirier
2020-06-09 15:27                           ` Mathieu Poirier
2020-06-09 15:37                           ` Sai Prakash Ranjan
2020-06-09 15:37                             ` Sai Prakash Ranjan
2020-06-03 11:37     ` Robin Murphy
2020-06-03 11:37       ` Robin Murphy
2020-06-03 12:00       ` Sai Prakash Ranjan
2020-06-03 12:00         ` Sai Prakash Ranjan
2020-06-03 12:21         ` Robin Murphy
2020-06-03 12:21           ` Robin Murphy
2020-06-03 12:26           ` Sai Prakash Ranjan
2020-06-03 12:26             ` Sai Prakash Ranjan
2020-06-03 13:40             ` Robin Murphy
2020-06-03 13:40               ` Robin Murphy
2020-06-03 13:51               ` Sai Prakash Ranjan
2020-06-03 13:51                 ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1590947174.git.saiprakash.ranjan@codeaurora.org \
    --to=saiprakash.ranjan@codeaurora.org \
    --cc=coresight@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.