From: Igor Stoppa <igor.stoppa@huawei.com>
To: <jglisse@redhat.com>, <keescook@chromium.org>,
<mhocko@kernel.org>, <labbott@redhat.com>, <hch@infradead.org>,
<willy@infradead.org>
Cc: <cl@linux.com>, <linux-security-module@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<kernel-hardening@lists.openwall.com>
Subject: [kernel-hardening] Re: [PATCH 4/6] Protectable Memory
Date: Fri, 26 Jan 2018 21:41:35 +0200 [thread overview]
Message-ID: <c5ae2b4f-4a60-1526-0512-51f1c9a5e4a8@huawei.com> (raw)
In-Reply-To: <20180124175631.22925-5-igor.stoppa@huawei.com>
On 24/01/18 19:56, Igor Stoppa wrote:
[...]
> +bool pmalloc_prealloc(struct gen_pool *pool, size_t size)
> +{
[...]
> +abort:
> + vfree(chunk);
this should be vfree_atomic()
[...]
> +void *pmalloc(struct gen_pool *pool, size_t size, gfp_t gfp)
> +{
[...]
> +free:
> + vfree(chunk);
and this one too
I will fix them in the next iteration.
I am waiting to see if any more comments arrive.
Otherwise, I'll send it out probably next Tuesday.
--
igor
WARNING: multiple messages have this Message-ID (diff)
From: igor.stoppa@huawei.com (Igor Stoppa)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 4/6] Protectable Memory
Date: Fri, 26 Jan 2018 21:41:35 +0200 [thread overview]
Message-ID: <c5ae2b4f-4a60-1526-0512-51f1c9a5e4a8@huawei.com> (raw)
In-Reply-To: <20180124175631.22925-5-igor.stoppa@huawei.com>
On 24/01/18 19:56, Igor Stoppa wrote:
[...]
> +bool pmalloc_prealloc(struct gen_pool *pool, size_t size)
> +{
[...]
> +abort:
> + vfree(chunk);
this should be vfree_atomic()
[...]
> +void *pmalloc(struct gen_pool *pool, size_t size, gfp_t gfp)
> +{
[...]
> +free:
> + vfree(chunk);
and this one too
I will fix them in the next iteration.
I am waiting to see if any more comments arrive.
Otherwise, I'll send it out probably next Tuesday.
--
igor
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Igor Stoppa <igor.stoppa@huawei.com>
To: jglisse@redhat.com, keescook@chromium.org, mhocko@kernel.org,
labbott@redhat.com, hch@infradead.org, willy@infradead.org
Cc: cl@linux.com, linux-security-module@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH 4/6] Protectable Memory
Date: Fri, 26 Jan 2018 21:41:35 +0200 [thread overview]
Message-ID: <c5ae2b4f-4a60-1526-0512-51f1c9a5e4a8@huawei.com> (raw)
In-Reply-To: <20180124175631.22925-5-igor.stoppa@huawei.com>
On 24/01/18 19:56, Igor Stoppa wrote:
[...]
> +bool pmalloc_prealloc(struct gen_pool *pool, size_t size)
> +{
[...]
> +abort:
> + vfree(chunk);
this should be vfree_atomic()
[...]
> +void *pmalloc(struct gen_pool *pool, size_t size, gfp_t gfp)
> +{
[...]
> +free:
> + vfree(chunk);
and this one too
I will fix them in the next iteration.
I am waiting to see if any more comments arrive.
Otherwise, I'll send it out probably next Tuesday.
--
igor
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Igor Stoppa <igor.stoppa@huawei.com>
To: jglisse@redhat.com, keescook@chromium.org, mhocko@kernel.org,
labbott@redhat.com, hch@infradead.org, willy@infradead.org
Cc: cl@linux.com, linux-security-module@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH 4/6] Protectable Memory
Date: Fri, 26 Jan 2018 21:41:35 +0200 [thread overview]
Message-ID: <c5ae2b4f-4a60-1526-0512-51f1c9a5e4a8@huawei.com> (raw)
In-Reply-To: <20180124175631.22925-5-igor.stoppa@huawei.com>
On 24/01/18 19:56, Igor Stoppa wrote:
[...]
> +bool pmalloc_prealloc(struct gen_pool *pool, size_t size)
> +{
[...]
> +abort:
> + vfree(chunk);
this should be vfree_atomic()
[...]
> +void *pmalloc(struct gen_pool *pool, size_t size, gfp_t gfp)
> +{
[...]
> +free:
> + vfree(chunk);
and this one too
I will fix them in the next iteration.
I am waiting to see if any more comments arrive.
Otherwise, I'll send it out probably next Tuesday.
--
igor
next prev parent reply other threads:[~2018-01-26 19:41 UTC|newest]
Thread overview: 171+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 17:56 [kernel-hardening] [RFC PATCH v11 0/6] mm: security: ro protection for dynamic data Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` [kernel-hardening] [PATCH 1/6] genalloc: track beginning of allocations Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` [kernel-hardening] [PATCH 2/6] genalloc: selftest Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` [kernel-hardening] [PATCH 3/6] struct page: add field for vm_struct Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` [kernel-hardening] [PATCH 4/6] Protectable Memory Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 19:10 ` [kernel-hardening] " Jann Horn
2018-01-24 19:10 ` Jann Horn
2018-01-24 19:10 ` Jann Horn
2018-01-25 11:59 ` Igor Stoppa
2018-01-25 11:59 ` Igor Stoppa
2018-01-25 11:59 ` Igor Stoppa
2018-01-25 11:59 ` Igor Stoppa
2018-01-25 15:14 ` Boris Lukashev
2018-01-25 15:14 ` Boris Lukashev
2018-01-25 15:14 ` Boris Lukashev
2018-01-25 15:38 ` Jerome Glisse
2018-01-25 15:38 ` Jerome Glisse
2018-01-25 15:38 ` Jerome Glisse
2018-01-26 12:28 ` Igor Stoppa
2018-01-26 12:28 ` Igor Stoppa
2018-01-26 12:28 ` Igor Stoppa
2018-01-26 16:36 ` Boris Lukashev
2018-01-26 16:36 ` Boris Lukashev
2018-01-26 16:36 ` Boris Lukashev
2018-01-30 13:46 ` Igor Stoppa
2018-01-30 13:46 ` Igor Stoppa
2018-01-30 13:46 ` Igor Stoppa
2018-01-26 5:35 ` Matthew Wilcox
2018-01-26 5:35 ` Matthew Wilcox
2018-01-26 5:35 ` Matthew Wilcox
2018-01-26 11:46 ` Igor Stoppa
2018-01-26 11:46 ` Igor Stoppa
2018-01-26 11:46 ` Igor Stoppa
2018-01-26 11:46 ` Igor Stoppa
2018-02-02 18:39 ` Christopher Lameter
2018-02-02 18:39 ` Christopher Lameter
2018-02-02 18:39 ` Christopher Lameter
2018-02-03 15:38 ` Igor Stoppa
2018-02-03 15:38 ` Igor Stoppa
2018-02-03 15:38 ` Igor Stoppa
2018-02-03 15:38 ` Igor Stoppa
2018-02-03 19:57 ` Igor Stoppa
2018-02-03 19:57 ` Igor Stoppa
2018-02-03 19:57 ` Igor Stoppa
2018-02-03 19:57 ` Igor Stoppa
2018-02-03 20:12 ` Boris Lukashev
2018-02-03 20:12 ` Boris Lukashev
2018-02-03 20:12 ` Boris Lukashev
2018-02-03 20:32 ` Igor Stoppa
2018-02-03 20:32 ` Igor Stoppa
2018-02-03 20:32 ` Igor Stoppa
2018-02-03 22:29 ` Boris Lukashev
2018-02-03 22:29 ` Boris Lukashev
2018-02-03 22:29 ` Boris Lukashev
2018-02-04 15:05 ` Igor Stoppa
2018-02-04 15:05 ` Igor Stoppa
2018-02-04 15:05 ` Igor Stoppa
2018-02-12 23:27 ` Kees Cook
2018-02-12 23:27 ` Kees Cook
2018-02-12 23:27 ` Kees Cook
2018-02-13 0:40 ` Laura Abbott
2018-02-13 0:40 ` Laura Abbott
2018-02-13 0:40 ` Laura Abbott
2018-02-13 1:25 ` Kees Cook
2018-02-13 1:25 ` Kees Cook
2018-02-13 1:25 ` Kees Cook
2018-02-13 3:39 ` Jann Horn
2018-02-13 3:39 ` Jann Horn
2018-02-13 3:39 ` Jann Horn
2018-02-13 16:09 ` Laura Abbott
2018-02-13 16:09 ` Laura Abbott
2018-02-13 16:09 ` Laura Abbott
2018-02-13 21:43 ` Kees Cook
2018-02-13 21:43 ` Kees Cook
2018-02-13 21:43 ` Kees Cook
2018-02-14 19:06 ` arm64 physmap (was Re: [kernel-hardening] [PATCH 4/6] Protectable Memory) Laura Abbott
2018-02-14 19:06 ` Laura Abbott
2018-02-14 19:06 ` Laura Abbott
2018-02-14 19:06 ` Laura Abbott
2018-02-14 19:28 ` Ard Biesheuvel
2018-02-14 19:28 ` Ard Biesheuvel
2018-02-14 19:28 ` Ard Biesheuvel
2018-02-14 19:28 ` Ard Biesheuvel
2018-02-14 20:13 ` Laura Abbott
2018-02-14 20:13 ` Laura Abbott
2018-02-14 20:13 ` Laura Abbott
2018-02-14 20:13 ` Laura Abbott
2018-02-14 19:29 ` Kees Cook
2018-02-14 19:29 ` Kees Cook
2018-02-14 19:29 ` Kees Cook
2018-02-14 19:29 ` Kees Cook
2018-02-14 19:35 ` Kees Cook
2018-02-14 19:35 ` Kees Cook
2018-02-14 19:35 ` Kees Cook
2018-02-14 19:35 ` Kees Cook
2018-02-20 16:28 ` Igor Stoppa
2018-02-20 16:28 ` Igor Stoppa
2018-02-20 16:28 ` Igor Stoppa
2018-02-20 16:28 ` Igor Stoppa
2018-02-21 22:22 ` Kees Cook
2018-02-21 22:22 ` Kees Cook
2018-02-21 22:22 ` Kees Cook
2018-02-21 22:22 ` Kees Cook
2018-02-14 19:48 ` Kees Cook
2018-02-14 19:48 ` Kees Cook
2018-02-14 19:48 ` Kees Cook
2018-02-14 19:48 ` Kees Cook
2018-02-14 22:13 ` Tycho Andersen
2018-02-14 22:13 ` Tycho Andersen
2018-02-14 22:13 ` Tycho Andersen
2018-02-14 22:13 ` Tycho Andersen
2018-02-14 22:27 ` Kees Cook
2018-02-14 22:27 ` Kees Cook
2018-02-14 22:27 ` Kees Cook
2018-02-14 22:27 ` Kees Cook
2018-02-13 15:20 ` [kernel-hardening] [PATCH 4/6] Protectable Memory Igor Stoppa
2018-02-13 15:20 ` Igor Stoppa
2018-02-13 15:20 ` Igor Stoppa
2018-02-13 15:20 ` Igor Stoppa
2018-02-13 15:20 ` [kernel-hardening] " Igor Stoppa
[not found] ` <5a83024c.64369d0a.a1e94.cdd6SMTPIN_ADDED_BROKEN@mx.google.com>
2018-02-13 18:10 ` Laura Abbott
2018-02-13 18:10 ` Laura Abbott
2018-02-13 18:10 ` Laura Abbott
2018-02-20 17:16 ` Igor Stoppa
2018-02-20 17:16 ` Igor Stoppa
2018-02-20 17:16 ` Igor Stoppa
2018-02-21 22:37 ` Kees Cook
2018-02-21 22:37 ` Kees Cook
2018-02-21 22:37 ` Kees Cook
2018-02-05 15:40 ` Christopher Lameter
2018-02-05 15:40 ` Christopher Lameter
2018-02-05 15:40 ` Christopher Lameter
2018-02-09 11:17 ` Igor Stoppa
2018-02-09 11:17 ` Igor Stoppa
2018-02-09 11:17 ` Igor Stoppa
2018-02-09 11:17 ` Igor Stoppa
2018-01-26 19:41 ` Igor Stoppa [this message]
2018-01-26 19:41 ` [kernel-hardening] " Igor Stoppa
2018-01-26 19:41 ` Igor Stoppa
2018-01-26 19:41 ` Igor Stoppa
2018-01-24 17:56 ` [kernel-hardening] [PATCH 5/6] Documentation for Pmalloc Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 19:14 ` [kernel-hardening] " Ralph Campbell
2018-01-24 19:14 ` Ralph Campbell
2018-01-24 19:14 ` Ralph Campbell
2018-01-24 19:14 ` Ralph Campbell
2018-01-25 7:53 ` [kernel-hardening] " Igor Stoppa
2018-01-25 7:53 ` Igor Stoppa
2018-01-25 7:53 ` Igor Stoppa
2018-01-25 7:53 ` Igor Stoppa
2018-01-24 17:56 ` [kernel-hardening] [PATCH 6/6] Pmalloc: self-test Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
2018-01-24 17:56 ` Igor Stoppa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5ae2b4f-4a60-1526-0512-51f1c9a5e4a8@huawei.com \
--to=igor.stoppa@huawei.com \
--cc=cl@linux.com \
--cc=hch@infradead.org \
--cc=jglisse@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.