Re: [PATCH v3 5/7] PCI: brcmstb: add MSI capability

From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	mbrugger@suse.com, maz@kernel.org, phil@raspberrypi.org,
	linux-kernel@vger.kernel.org, jeremy.linton@arm.com,
	Eric Anholt <eric@anholt.net>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Stefan Wahren <wahrenst@gmx.net>,
	james.quinlan@broadcom.com, linux-pci@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/7] PCI: brcmstb: add MSI capability
Date: Mon, 02 Dec 2019 13:22:09 +0100	[thread overview]
Message-ID: <c63647bb1b13cc05c9cecdd7f25e497ab9416e4f.camel@suse.de> (raw)
In-Reply-To: <20191202122050.GA18399@e119886-lin.cambridge.arm.com>

[-- Attachment #1: Type: text/plain, Size: 1943 bytes --]

On Mon, 2019-12-02 at 12:20 +0000, Andrew Murray wrote:
> On Mon, Dec 02, 2019 at 10:59:36AM +0100, Nicolas Saenz Julienne wrote:
> > Hi Andrew,
> > 
> > On Fri, 2019-11-29 at 15:46 +0000, Andrew Murray wrote:
> > > On Tue, Nov 26, 2019 at 10:19:43AM +0100, Nicolas Saenz Julienne wrote:
> > > > From: Jim Quinlan <james.quinlan@broadcom.com>
> > > > 
> > > > This adds MSI support to the Broadcom STB PCIe host controller. The MSI
> > > > controller is physically located within the PCIe block, however, there
> > > > is no reason why the MSI controller could not be moved elsewhere in the
> > > > future. MSIX is not supported by the HW.
> > > > 
> > > > Since the internal Brcmstb MSI controller is intertwined with the PCIe
> > > > controller, it is not its own platform device but rather part of the
> > > > PCIe platform device.
> > > > 
> > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > > Co-developed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > > > Reviewed-by: Marc Zyngier <maz@kernel.org>
> > > > 
> > > > ---
> > > > 
> > > > Changes since v2 (kept Marc's Reviewed-by as changes didn't affect irq
> > > > subsystem stuff or seem petty enough):
> > > >   - Use standard APIs on register operations
> > > >   - Get rid of revision code
> > > 
> > > Do any RPI4's have a HW revision of less than 33?
> > 
> > No, IIRC it's actually revision 34. I had left that bit of code in,
> > following
> > the same train of thought as with the of_data on the device-tree part of the
> > driver: "It's harmless and should make accomodating other devices easier."
> > It
> > turned out not to be such a great approach. Lesson's learned. So I decided
> > to
> > remove it.
> 
> OK you can add my:
> 
> Reviewed-by: Andrew Murray <andrew.murray@arm.com>
> 
> Thanks,
> 
> Andrew Murray

Thanks!

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]