All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	"Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xfs: remove a stray tab in xfs_remount_rw()
Date: Fri, 08 Nov 2019 14:29:56 +0800	[thread overview]
Message-ID: <c87e0acc9f6cbf36a2860d7bebc28df6b1dcfc97.camel@themaw.net> (raw)
In-Reply-To: <20191108051121.GA26279@mwanda>

On Fri, 2019-11-08 at 08:11 +0300, Dan Carpenter wrote:
> The extra tab makes the code slightly confusing.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  fs/xfs/xfs_super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index b3188ea49413..ede6fac47c56 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1599,7 +1599,7 @@ xfs_remount_rw(
>  	if (error) {
>  		xfs_err(mp,
>  			"Error %d recovering leftover CoW allocations.", error);
> -			xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> +		xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
>  		return error;
>  	}
>  	xfs_start_block_reaping(mp);

Indeed, my bad.
Reviewed-by: Ian Kent <raven@themaw.net>


WARNING: multiple messages have this Message-ID (diff)
From: Ian Kent <raven@themaw.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	"Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xfs: remove a stray tab in xfs_remount_rw()
Date: Fri, 08 Nov 2019 06:29:56 +0000	[thread overview]
Message-ID: <c87e0acc9f6cbf36a2860d7bebc28df6b1dcfc97.camel@themaw.net> (raw)
In-Reply-To: <20191108051121.GA26279@mwanda>

On Fri, 2019-11-08 at 08:11 +0300, Dan Carpenter wrote:
> The extra tab makes the code slightly confusing.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  fs/xfs/xfs_super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index b3188ea49413..ede6fac47c56 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1599,7 +1599,7 @@ xfs_remount_rw(
>  	if (error) {
>  		xfs_err(mp,
>  			"Error %d recovering leftover CoW allocations.", error);
> -			xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> +		xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
>  		return error;
>  	}
>  	xfs_start_block_reaping(mp);

Indeed, my bad.
Reviewed-by: Ian Kent <raven@themaw.net>

  parent reply	other threads:[~2019-11-08  6:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08  5:11 [PATCH] xfs: remove a stray tab in xfs_remount_rw() Dan Carpenter
2019-11-08  5:11 ` Dan Carpenter
2019-11-08  5:49 ` Christoph Hellwig
2019-11-08  5:49   ` Christoph Hellwig
2019-11-08  6:29 ` Ian Kent [this message]
2019-11-08  6:29   ` Ian Kent
2019-11-08 16:06 ` Darrick J. Wong
2019-11-08 16:06   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c87e0acc9f6cbf36a2860d7bebc28df6b1dcfc97.camel@themaw.net \
    --to=raven@themaw.net \
    --cc=dan.carpenter@oracle.com \
    --cc=darrick.wong@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.