* [PATCH] xfs: remove a stray tab in xfs_remount_rw()
@ 2019-11-08 5:11 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2019-11-08 5:11 UTC (permalink / raw)
To: Darrick J. Wong, Ian Kent; +Cc: linux-xfs, kernel-janitors
The extra tab makes the code slightly confusing.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
fs/xfs/xfs_super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index b3188ea49413..ede6fac47c56 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1599,7 +1599,7 @@ xfs_remount_rw(
if (error) {
xfs_err(mp,
"Error %d recovering leftover CoW allocations.", error);
- xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
+ xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
return error;
}
xfs_start_block_reaping(mp);
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] xfs: remove a stray tab in xfs_remount_rw()
2019-11-08 5:11 ` Dan Carpenter
@ 2019-11-08 5:49 ` Christoph Hellwig
-1 siblings, 0 replies; 8+ messages in thread
From: Christoph Hellwig @ 2019-11-08 5:49 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Darrick J. Wong, Ian Kent, linux-xfs, kernel-janitors
On Fri, Nov 08, 2019 at 08:11:22AM +0300, Dan Carpenter wrote:
> The extra tab makes the code slightly confusing.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xfs: remove a stray tab in xfs_remount_rw()
@ 2019-11-08 5:49 ` Christoph Hellwig
0 siblings, 0 replies; 8+ messages in thread
From: Christoph Hellwig @ 2019-11-08 5:49 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Darrick J. Wong, Ian Kent, linux-xfs, kernel-janitors
On Fri, Nov 08, 2019 at 08:11:22AM +0300, Dan Carpenter wrote:
> The extra tab makes the code slightly confusing.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xfs: remove a stray tab in xfs_remount_rw()
2019-11-08 5:11 ` Dan Carpenter
@ 2019-11-08 6:29 ` Ian Kent
-1 siblings, 0 replies; 8+ messages in thread
From: Ian Kent @ 2019-11-08 6:29 UTC (permalink / raw)
To: Dan Carpenter, Darrick J. Wong; +Cc: linux-xfs, kernel-janitors
On Fri, 2019-11-08 at 08:11 +0300, Dan Carpenter wrote:
> The extra tab makes the code slightly confusing.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index b3188ea49413..ede6fac47c56 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1599,7 +1599,7 @@ xfs_remount_rw(
> if (error) {
> xfs_err(mp,
> "Error %d recovering leftover CoW allocations.", error);
> - xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> + xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> return error;
> }
> xfs_start_block_reaping(mp);
Indeed, my bad.
Reviewed-by: Ian Kent <raven@themaw.net>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xfs: remove a stray tab in xfs_remount_rw()
@ 2019-11-08 6:29 ` Ian Kent
0 siblings, 0 replies; 8+ messages in thread
From: Ian Kent @ 2019-11-08 6:29 UTC (permalink / raw)
To: Dan Carpenter, Darrick J. Wong; +Cc: linux-xfs, kernel-janitors
On Fri, 2019-11-08 at 08:11 +0300, Dan Carpenter wrote:
> The extra tab makes the code slightly confusing.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index b3188ea49413..ede6fac47c56 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1599,7 +1599,7 @@ xfs_remount_rw(
> if (error) {
> xfs_err(mp,
> "Error %d recovering leftover CoW allocations.", error);
> - xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> + xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> return error;
> }
> xfs_start_block_reaping(mp);
Indeed, my bad.
Reviewed-by: Ian Kent <raven@themaw.net>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xfs: remove a stray tab in xfs_remount_rw()
2019-11-08 5:11 ` Dan Carpenter
@ 2019-11-08 16:06 ` Darrick J. Wong
-1 siblings, 0 replies; 8+ messages in thread
From: Darrick J. Wong @ 2019-11-08 16:06 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Ian Kent, linux-xfs, kernel-janitors
On Fri, Nov 08, 2019 at 08:11:22AM +0300, Dan Carpenter wrote:
> The extra tab makes the code slightly confusing.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index b3188ea49413..ede6fac47c56 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1599,7 +1599,7 @@ xfs_remount_rw(
> if (error) {
> xfs_err(mp,
> "Error %d recovering leftover CoW allocations.", error);
> - xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> + xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> return error;
> }
> xfs_start_block_reaping(mp);
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xfs: remove a stray tab in xfs_remount_rw()
@ 2019-11-08 16:06 ` Darrick J. Wong
0 siblings, 0 replies; 8+ messages in thread
From: Darrick J. Wong @ 2019-11-08 16:06 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Ian Kent, linux-xfs, kernel-janitors
On Fri, Nov 08, 2019 at 08:11:22AM +0300, Dan Carpenter wrote:
> The extra tab makes the code slightly confusing.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index b3188ea49413..ede6fac47c56 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1599,7 +1599,7 @@ xfs_remount_rw(
> if (error) {
> xfs_err(mp,
> "Error %d recovering leftover CoW allocations.", error);
> - xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> + xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> return error;
> }
> xfs_start_block_reaping(mp);
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread