From: Helge Deller <deller@gmx.de> To: Daniel Vetter <daniel@ffwll.ch> Cc: linux-fbdev@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Javier Martinez Canillas <javierm@redhat.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Thomas Zimmermann <tzimmermann@suse.de> Subject: Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer Date: Mon, 17 Jan 2022 18:19:17 +0100 [thread overview] Message-ID: <cbe8641e-9358-2ea6-235f-bd837171eaf0@gmx.de> (raw) In-Reply-To: <CAKMK7uECQU2ALkLHuFfPCjDcH456R6yJ4N_yKbHJ6PiFZ6fiow@mail.gmail.com> On 1/17/22 17:38, Daniel Vetter wrote: > On Mon, Jan 17, 2022 at 5:22 PM Helge Deller <deller@gmx.de> wrote: >> >> On 1/17/22 16:58, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 17.01.22 um 16:42 schrieb Helge Deller: >>>> [...] >>>>>> c) reintroduce the state where fbcon is fast on fbdev. This is important for non-DRM machines, >>>>>> either when run on native hardware or in an emulator. >>>>>> d) not break DRM development >>>>>> >>>>>> Especially regarding c) I complained in [1] and got no feedback. I really would like to >>>>>> understand where the actual problems were and what's necessary to fix them. >>>>>> >>>>>> Helge >>>>>> >>>>>> [1] https://lore.kernel.org/r/feea8303-2b83-fc36-972c-4fc8ad723bde@gmx.de >>> >>> Seems like few people read linux-fbdev these days. >>> I suggest to partly revert the patch to the point were performance >>> gets better again. >> Yes, *please*! >> That would solve my biggest concern. >> >> As far as I can see that's only 2 commits to be reverted: >> b3ec8cdf457e - "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)" >> 39aead8373b3 - "fbcon: Disable accelerated scrolling"for-next-next >> >> I think both were not related to any 0-day bug reports (but again, I might be wrong). > > syzbot, not 0day, and there's like a sea of them unfortunately. > There's all kinds of funny races going on when resizing consoles (due The patches above are not about resizing consoles. Even if a resize should happen in between, it's better to introduce some kind of big lock instead of completely disable acceleration for est. 58 other graphic card drivers and slow them down that much that it renders them to become unusable. > to bad locking design) which then blow up, especially in less tested > code. For the sw rendering we've merged a bunch of patches, but you > pretty much have to assume that it's all fairly broken code until it's > rewritten and fully covered with tests. Shadowfb + memcpy is probably > much faster for restoring scrolling performance than anything else > really. That's maybe true for fast new machines with fast PCI busses. But have you measured that on other/older hardware too? There is a good reason why 2D acceleration was introduced. Helge
WARNING: multiple messages have this Message-ID (diff)
From: Helge Deller <deller@gmx.de> To: Daniel Vetter <daniel@ffwll.ch> Cc: Thomas Zimmermann <tzimmermann@suse.de>, Linus Torvalds <torvalds@linux-foundation.org>, "airlied@gmail.com" <airlied@gmail.com>, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas <javierm@redhat.com>, Geert Uytterhoeven <geert@linux-m68k.org> Subject: Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer Date: Mon, 17 Jan 2022 18:19:17 +0100 [thread overview] Message-ID: <cbe8641e-9358-2ea6-235f-bd837171eaf0@gmx.de> (raw) In-Reply-To: <CAKMK7uECQU2ALkLHuFfPCjDcH456R6yJ4N_yKbHJ6PiFZ6fiow@mail.gmail.com> On 1/17/22 17:38, Daniel Vetter wrote: > On Mon, Jan 17, 2022 at 5:22 PM Helge Deller <deller@gmx.de> wrote: >> >> On 1/17/22 16:58, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 17.01.22 um 16:42 schrieb Helge Deller: >>>> [...] >>>>>> c) reintroduce the state where fbcon is fast on fbdev. This is important for non-DRM machines, >>>>>> either when run on native hardware or in an emulator. >>>>>> d) not break DRM development >>>>>> >>>>>> Especially regarding c) I complained in [1] and got no feedback. I really would like to >>>>>> understand where the actual problems were and what's necessary to fix them. >>>>>> >>>>>> Helge >>>>>> >>>>>> [1] https://lore.kernel.org/r/feea8303-2b83-fc36-972c-4fc8ad723bde@gmx.de >>> >>> Seems like few people read linux-fbdev these days. >>> I suggest to partly revert the patch to the point were performance >>> gets better again. >> Yes, *please*! >> That would solve my biggest concern. >> >> As far as I can see that's only 2 commits to be reverted: >> b3ec8cdf457e - "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)" >> 39aead8373b3 - "fbcon: Disable accelerated scrolling"for-next-next >> >> I think both were not related to any 0-day bug reports (but again, I might be wrong). > > syzbot, not 0day, and there's like a sea of them unfortunately. > There's all kinds of funny races going on when resizing consoles (due The patches above are not about resizing consoles. Even if a resize should happen in between, it's better to introduce some kind of big lock instead of completely disable acceleration for est. 58 other graphic card drivers and slow them down that much that it renders them to become unusable. > to bad locking design) which then blow up, especially in less tested > code. For the sw rendering we've merged a bunch of patches, but you > pretty much have to assume that it's all fairly broken code until it's > rewritten and fully covered with tests. Shadowfb + memcpy is probably > much faster for restoring scrolling performance than anything else > really. That's maybe true for fast new machines with fast PCI busses. But have you measured that on other/older hardware too? There is a good reason why 2D acceleration was introduced. Helge
next prev parent reply other threads:[~2022-01-17 17:20 UTC|newest] Thread overview: 149+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-14 18:11 [PATCH] MAINTAINERS: Add Helge as fbdev maintainer Helge Deller 2022-01-14 18:31 ` Geert Uytterhoeven 2022-01-14 18:31 ` Geert Uytterhoeven 2022-01-17 9:48 ` Daniel Vetter 2022-01-17 9:48 ` Daniel Vetter 2022-01-17 10:02 ` Daniel Vetter 2022-01-17 10:02 ` Daniel Vetter 2022-01-17 10:19 ` Javier Martinez Canillas 2022-01-17 10:19 ` Javier Martinez Canillas 2022-01-17 10:49 ` Jani Nikula 2022-01-17 10:57 ` Helge Deller 2022-01-17 12:15 ` Helge Deller 2022-01-17 12:15 ` Helge Deller 2022-01-17 12:57 ` Gerd Hoffmann 2022-01-17 12:57 ` Gerd Hoffmann 2022-01-17 13:29 ` Geert Uytterhoeven 2022-01-17 13:29 ` Geert Uytterhoeven 2022-01-17 13:51 ` Thomas Zimmermann 2022-01-17 13:51 ` Thomas Zimmermann 2022-01-17 14:10 ` Geert Uytterhoeven 2022-01-17 14:10 ` Geert Uytterhoeven 2022-01-17 14:47 ` Helge Deller 2022-01-17 14:47 ` Helge Deller 2022-01-17 15:03 ` Daniel Vetter 2022-01-17 15:03 ` Daniel Vetter 2022-01-17 20:17 ` Helge Deller 2022-01-17 20:17 ` Helge Deller 2022-01-18 6:29 ` Gerd Hoffmann 2022-01-18 6:29 ` Gerd Hoffmann 2022-01-18 8:10 ` Geert Uytterhoeven 2022-01-18 8:10 ` Geert Uytterhoeven 2022-01-18 11:44 ` Daniel Vetter 2022-01-18 11:44 ` Daniel Vetter 2022-01-18 14:23 ` Thomas Zimmermann 2022-01-18 14:23 ` Thomas Zimmermann 2022-01-18 14:39 ` Simon Ser 2022-01-18 14:39 ` Simon Ser 2022-01-20 12:50 ` Gerd Hoffmann 2022-01-20 12:50 ` Gerd Hoffmann 2022-01-21 8:55 ` Daniel Vetter 2022-01-21 8:55 ` Daniel Vetter 2022-01-24 18:38 ` Geert Uytterhoeven 2022-01-24 18:38 ` Geert Uytterhoeven 2022-01-24 18:50 ` Daniel Vetter 2022-01-24 18:50 ` Daniel Vetter 2022-01-24 19:05 ` Thomas Zimmermann 2022-01-24 19:05 ` Thomas Zimmermann 2022-01-18 8:20 ` Helge Deller 2022-01-18 8:20 ` Helge Deller 2022-01-18 9:16 ` Gerd Hoffmann 2022-01-18 9:16 ` Gerd Hoffmann 2022-01-18 10:13 ` Helge Deller 2022-01-18 10:13 ` Helge Deller 2022-01-18 10:44 ` Helge Deller 2022-01-18 10:44 ` Helge Deller 2022-01-18 12:48 ` Gerd Hoffmann 2022-01-18 12:48 ` Gerd Hoffmann 2022-01-17 15:05 ` Thomas Zimmermann 2022-01-17 15:05 ` Thomas Zimmermann 2022-01-17 16:05 ` Helge Deller 2022-01-17 16:05 ` Helge Deller 2022-01-17 14:53 ` Thomas Zimmermann 2022-01-17 14:53 ` Thomas Zimmermann 2022-01-18 6:11 ` Gerd Hoffmann 2022-01-18 6:11 ` Gerd Hoffmann 2022-01-18 8:09 ` Helge Deller 2022-01-18 8:09 ` Helge Deller 2022-01-17 15:00 ` Daniel Vetter 2022-01-17 15:00 ` Daniel Vetter 2022-01-17 15:42 ` Helge Deller 2022-01-17 15:42 ` Helge Deller 2022-01-17 15:56 ` Daniel Vetter 2022-01-17 15:56 ` Daniel Vetter 2022-01-17 15:58 ` Thomas Zimmermann 2022-01-17 15:58 ` Thomas Zimmermann 2022-01-17 16:21 ` Helge Deller 2022-01-17 16:21 ` Helge Deller 2022-01-17 16:38 ` Daniel Vetter 2022-01-17 16:38 ` Daniel Vetter 2022-01-17 17:19 ` Helge Deller [this message] 2022-01-17 17:19 ` Helge Deller 2022-01-17 19:45 ` Helge Deller 2022-01-17 19:45 ` Helge Deller 2022-01-17 21:55 ` Ilia Mirkin 2022-01-17 21:55 ` Ilia Mirkin 2022-01-18 11:14 ` Daniel Vetter 2022-01-18 11:14 ` Daniel Vetter 2022-01-18 14:14 ` Thomas Zimmermann 2022-01-18 14:14 ` Thomas Zimmermann 2022-01-17 21:40 ` Jani Nikula 2022-01-17 21:40 ` Jani Nikula 2022-01-17 21:44 ` Helge Deller 2022-01-17 21:44 ` Helge Deller 2022-01-18 8:38 ` Jani Nikula 2022-01-18 8:38 ` Jani Nikula 2022-01-18 8:41 ` Geert Uytterhoeven 2022-01-18 8:41 ` Geert Uytterhoeven 2022-01-18 11:41 ` Daniel Vetter 2022-01-18 11:41 ` Daniel Vetter 2022-01-18 12:11 ` Simon Ser 2022-01-18 12:11 ` Simon Ser 2022-01-18 8:54 ` Helge Deller 2022-01-18 8:54 ` Helge Deller 2022-01-18 9:33 ` Javier Martinez Canillas 2022-01-18 9:33 ` Javier Martinez Canillas 2022-01-18 9:45 ` Geert Uytterhoeven 2022-01-18 9:45 ` Geert Uytterhoeven 2022-01-18 11:18 ` Daniel Vetter 2022-01-18 11:18 ` Daniel Vetter 2022-01-18 11:42 ` Helge Deller 2022-01-18 11:42 ` Helge Deller 2022-01-18 8:41 ` Helge Deller 2022-01-18 8:41 ` Helge Deller 2022-01-18 9:12 ` Helge Deller 2022-01-18 9:12 ` Helge Deller 2022-01-17 11:16 ` Thomas Zimmermann 2022-01-17 11:33 ` Helge Deller 2022-01-17 12:13 ` Thomas Zimmermann 2022-01-17 18:47 ` Sven Schnelle 2022-01-18 8:33 ` Pekka Paalanen 2022-01-18 8:33 ` Pekka Paalanen 2022-01-18 9:53 ` Gerd Hoffmann 2022-01-18 9:53 ` Gerd Hoffmann 2022-01-18 11:22 ` Daniel Vetter 2022-01-18 11:22 ` Daniel Vetter 2022-01-18 12:07 ` Gerd Hoffmann 2022-01-18 12:07 ` Gerd Hoffmann 2022-01-19 8:39 ` Pekka Paalanen 2022-01-19 8:39 ` Pekka Paalanen 2022-01-20 9:06 ` Geert Uytterhoeven 2022-01-20 9:06 ` Geert Uytterhoeven 2022-01-20 11:32 ` Daniel Vetter 2022-01-20 11:32 ` Daniel Vetter 2022-01-20 12:13 ` Geert Uytterhoeven 2022-01-20 12:13 ` Geert Uytterhoeven 2022-01-20 12:33 ` Daniel Vetter 2022-01-20 12:33 ` Daniel Vetter 2022-01-20 12:46 ` Geert Uytterhoeven 2022-01-20 12:46 ` Geert Uytterhoeven 2022-01-24 18:50 ` Geert Uytterhoeven 2022-01-24 18:50 ` Geert Uytterhoeven 2022-01-24 19:37 ` Daniel Vetter 2022-01-24 19:37 ` Daniel Vetter 2022-01-20 11:51 ` Gerd Hoffmann 2022-01-20 11:51 ` Gerd Hoffmann 2022-01-18 8:58 ` Michel Dänzer 2022-01-18 10:05 ` Sven Schnelle 2022-01-18 10:05 ` Sven Schnelle 2022-01-18 14:06 ` Thomas Zimmermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cbe8641e-9358-2ea6-235f-bd837171eaf0@gmx.de \ --to=deller@gmx.de \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=javierm@redhat.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=torvalds@linux-foundation.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.