From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Andrew Lunn <andrew@lunn.ch>, Vignesh Raghavendra <vigneshr@ti.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Jiri Pirko <jiri@nvidia.com>,
<netdev@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support
Date: Thu, 3 Dec 2020 18:22:05 +0200 [thread overview]
Message-ID: <d4ab92c8-8b70-ce26-e47f-d5172c8fd4e7@ti.com> (raw)
In-Reply-To: <20201203141838.GE2333853@lunn.ch>
On 03/12/2020 16:18, Andrew Lunn wrote:
>> We don't want to enable HW based switch support unless explicitly
>> asked by user.
>
> This is the key point. Why? Does individual ports when passed through
> the switch not work properly? Does it add extra latency/jitter?
When switch mode is enabled the forwarding is enabled by default and can't be completely
disabled, while in multi port mode every port and switch tables (ALE) configured so no packet
leaking between ports is happen.
The multi port is the requirement for us to have as default mode no mater to what upper interface
ports are attached to LAG, LRE (HSR/PRP) or bridge.
Switching between modes required significant Port and ALE reconfiguration there for
technical decision made and implemented to use parameter for mode change (by using devlink).
It also allows to keep user interface similar to what was implements for previous generation
of TI CPSW (am3/4/5).
--
Best regards,
grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Andrew Lunn <andrew@lunn.ch>, Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-doc@vger.kernel.org, netdev@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, Jiri Pirko <jiri@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support
Date: Thu, 3 Dec 2020 18:22:05 +0200 [thread overview]
Message-ID: <d4ab92c8-8b70-ce26-e47f-d5172c8fd4e7@ti.com> (raw)
In-Reply-To: <20201203141838.GE2333853@lunn.ch>
On 03/12/2020 16:18, Andrew Lunn wrote:
>> We don't want to enable HW based switch support unless explicitly
>> asked by user.
>
> This is the key point. Why? Does individual ports when passed through
> the switch not work properly? Does it add extra latency/jitter?
When switch mode is enabled the forwarding is enabled by default and can't be completely
disabled, while in multi port mode every port and switch tables (ALE) configured so no packet
leaking between ports is happen.
The multi port is the requirement for us to have as default mode no mater to what upper interface
ports are attached to LAG, LRE (HSR/PRP) or bridge.
Switching between modes required significant Port and ALE reconfiguration there for
technical decision made and implemented to use parameter for mode change (by using devlink).
It also allows to keep user interface similar to what was implements for previous generation
of TI CPSW (am3/4/5).
--
Best regards,
grygorii
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-03 16:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 8:20 [PATCH 0/4] net: ti: am65-cpsw-nuss: Add switchdev driver Vignesh Raghavendra
2020-11-30 8:20 ` Vignesh Raghavendra
2020-11-30 8:20 ` [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support Vignesh Raghavendra
2020-11-30 8:20 ` Vignesh Raghavendra
2020-11-30 15:50 ` Andrew Lunn
2020-11-30 15:50 ` Andrew Lunn
2020-12-03 8:40 ` Vignesh Raghavendra
2020-12-03 8:40 ` Vignesh Raghavendra
2020-12-03 14:18 ` Andrew Lunn
2020-12-03 14:18 ` Andrew Lunn
2020-12-03 16:22 ` Grygorii Strashko [this message]
2020-12-03 16:22 ` Grygorii Strashko
2020-11-30 8:20 ` [PATCH 2/4] net: ti: am65-cpsw-nuss: Add netdevice notifiers Vignesh Raghavendra
2020-11-30 8:20 ` Vignesh Raghavendra
2020-11-30 8:20 ` [PATCH 3/4] net: ti: am65-cpsw-nuss: Add switchdev support Vignesh Raghavendra
2020-11-30 8:20 ` Vignesh Raghavendra
2020-11-30 17:20 ` Andrew Lunn
2020-11-30 17:20 ` Andrew Lunn
2020-12-03 13:49 ` Vignesh Raghavendra
2020-12-03 13:49 ` Vignesh Raghavendra
2020-11-30 8:20 ` [PATCH 4/4] docs: networking: ti: Add driver doc for AM65 NUSS switch driver Vignesh Raghavendra
2020-11-30 8:20 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4ab92c8-8b70-ce26-e47f-d5172c8fd4e7@ti.com \
--to=grygorii.strashko@ti.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.