* Re: [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum
@ 2020-02-07 15:37 linmiaohe
0 siblings, 0 replies; 4+ messages in thread
From: linmiaohe @ 2020-02-07 15:37 UTC (permalink / raw)
To: Eric Auger
Cc: thuth, drjones, wei.huang2, krish.sadhukhan, eric.auger.pro,
linux-kernel, kvm, pbonzini, vkuznets
Eric Auger <eric.auger@redhat.com> writes:
>x86_register enum is not used. Its presence incites us to enumerate GPRs in the same order in other looming structs. So let's remove it.
>
>Signed-off-by: Eric Auger <eric.auger@redhat.com>
>Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Make sense for me. Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum
2020-02-07 14:27 ` [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum Eric Auger
2020-02-07 15:07 ` Vitaly Kuznetsov
@ 2020-02-08 1:07 ` Krish Sadhukhan
1 sibling, 0 replies; 4+ messages in thread
From: Krish Sadhukhan @ 2020-02-08 1:07 UTC (permalink / raw)
To: Eric Auger, eric.auger.pro, linux-kernel, kvm, pbonzini, vkuznets
Cc: thuth, drjones, wei.huang2
On 2/7/20 6:27 AM, Eric Auger wrote:
> x86_register enum is not used. Its presence incites us
> to enumerate GPRs in the same order in other looming
> structs. So let's remove it.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> .../selftests/kvm/include/x86_64/processor.h | 20 -------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h
> index 6f7fffaea2e8..e48dac5c29e8 100644
> --- a/tools/testing/selftests/kvm/include/x86_64/processor.h
> +++ b/tools/testing/selftests/kvm/include/x86_64/processor.h
> @@ -36,26 +36,6 @@
> #define X86_CR4_SMAP (1ul << 21)
> #define X86_CR4_PKE (1ul << 22)
>
> -/* The enum values match the intruction encoding of each register */
> -enum x86_register {
> - RAX = 0,
> - RCX,
> - RDX,
> - RBX,
> - RSP,
> - RBP,
> - RSI,
> - RDI,
> - R8,
> - R9,
> - R10,
> - R11,
> - R12,
> - R13,
> - R14,
> - R15,
> -};
> -
> struct desc64 {
> uint16_t limit0;
> uint16_t base0;
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum
2020-02-07 14:27 ` [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum Eric Auger
@ 2020-02-07 15:07 ` Vitaly Kuznetsov
2020-02-08 1:07 ` Krish Sadhukhan
1 sibling, 0 replies; 4+ messages in thread
From: Vitaly Kuznetsov @ 2020-02-07 15:07 UTC (permalink / raw)
To: Eric Auger
Cc: thuth, drjones, wei.huang2, krish.sadhukhan, eric.auger.pro,
eric.auger, linux-kernel, kvm, pbonzini
Eric Auger <eric.auger@redhat.com> writes:
> x86_register enum is not used. Its presence incites us
> to enumerate GPRs in the same order in other looming
> structs. So let's remove it.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> .../selftests/kvm/include/x86_64/processor.h | 20 -------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h
> index 6f7fffaea2e8..e48dac5c29e8 100644
> --- a/tools/testing/selftests/kvm/include/x86_64/processor.h
> +++ b/tools/testing/selftests/kvm/include/x86_64/processor.h
> @@ -36,26 +36,6 @@
> #define X86_CR4_SMAP (1ul << 21)
> #define X86_CR4_PKE (1ul << 22)
>
> -/* The enum values match the intruction encoding of each register */
> -enum x86_register {
> - RAX = 0,
> - RCX,
> - RDX,
> - RBX,
> - RSP,
> - RBP,
> - RSI,
> - RDI,
> - R8,
> - R9,
> - R10,
> - R11,
> - R12,
> - R13,
> - R14,
> - R15,
> -};
> -
> struct desc64 {
> uint16_t limit0;
> uint16_t base0;
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum
2020-02-07 14:27 [PATCH v5 0/4] selftests: KVM: AMD Nested SVM test infrastructure Eric Auger
@ 2020-02-07 14:27 ` Eric Auger
2020-02-07 15:07 ` Vitaly Kuznetsov
2020-02-08 1:07 ` Krish Sadhukhan
0 siblings, 2 replies; 4+ messages in thread
From: Eric Auger @ 2020-02-07 14:27 UTC (permalink / raw)
To: eric.auger.pro, eric.auger, linux-kernel, kvm, pbonzini, vkuznets
Cc: thuth, drjones, wei.huang2, krish.sadhukhan
x86_register enum is not used. Its presence incites us
to enumerate GPRs in the same order in other looming
structs. So let's remove it.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
.../selftests/kvm/include/x86_64/processor.h | 20 -------------------
1 file changed, 20 deletions(-)
diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h
index 6f7fffaea2e8..e48dac5c29e8 100644
--- a/tools/testing/selftests/kvm/include/x86_64/processor.h
+++ b/tools/testing/selftests/kvm/include/x86_64/processor.h
@@ -36,26 +36,6 @@
#define X86_CR4_SMAP (1ul << 21)
#define X86_CR4_PKE (1ul << 22)
-/* The enum values match the intruction encoding of each register */
-enum x86_register {
- RAX = 0,
- RCX,
- RDX,
- RBX,
- RSP,
- RBP,
- RSI,
- RDI,
- R8,
- R9,
- R10,
- R11,
- R12,
- R13,
- R14,
- R15,
-};
-
struct desc64 {
uint16_t limit0;
uint16_t base0;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-08 1:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07 15:37 [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum linmiaohe
-- strict thread matches above, loose matches on Subject: below --
2020-02-07 14:27 [PATCH v5 0/4] selftests: KVM: AMD Nested SVM test infrastructure Eric Auger
2020-02-07 14:27 ` [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum Eric Auger
2020-02-07 15:07 ` Vitaly Kuznetsov
2020-02-08 1:07 ` Krish Sadhukhan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.