* [PATCH] drm/amdgpu: no need fbcon under sriov
@ 2019-06-04 13:43 Yintian Tao
[not found] ` <1559655785-30379-1-git-send-email-yttao-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Yintian Tao @ 2019-06-04 13:43 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Yintian Tao
Under Sriov, there is no need of the support for fbcon.
Signed-off-by: Yintian Tao <yttao@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 1f38d6f..28d095b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev)
{
struct drm_device *dev = pci_get_drvdata(pdev);
- DRM_ERROR("Device removal is currently not supported outside of fbcon\n");
+ if (!amdgpu_sriov_vf(adev))
+ DRM_ERROR("Device removal is currently not supported outside of fbcon\n");
drm_dev_unplug(dev);
drm_dev_put(dev);
pci_disable_device(pdev);
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1559655785-30379-1-git-send-email-yttao-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: no need fbcon under sriov [not found] ` <1559655785-30379-1-git-send-email-yttao-5C7GfCeVMHo@public.gmane.org> @ 2019-06-04 13:57 ` Christian König [not found] ` <1686be7b-ca1c-e43c-3906-e6131e8d25e1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Christian König @ 2019-06-04 13:57 UTC (permalink / raw) To: Yintian Tao, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Am 04.06.19 um 15:43 schrieb Yintian Tao: > Under Sriov, there is no need of the support for fbcon. NAK, that error message is not related to fbcon but means that PCIe device removal is not supported. Christian. > > Signed-off-by: Yintian Tao <yttao@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index 1f38d6f..28d095b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev) > { > struct drm_device *dev = pci_get_drvdata(pdev); > > - DRM_ERROR("Device removal is currently not supported outside of fbcon\n"); > + if (!amdgpu_sriov_vf(adev)) > + DRM_ERROR("Device removal is currently not supported outside of fbcon\n"); > drm_dev_unplug(dev); > drm_dev_put(dev); > pci_disable_device(pdev); _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1686be7b-ca1c-e43c-3906-e6131e8d25e1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* 答复: [PATCH] drm/amdgpu: no need fbcon under sriov [not found] ` <1686be7b-ca1c-e43c-3906-e6131e8d25e1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2019-06-04 15:16 ` Tao, Yintian [not found] ` <MN2PR12MB3039F0DD22910F40A6674546E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Tao, Yintian @ 2019-06-04 15:16 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Koenig, Christian [-- Attachment #1.1: Type: text/plain, Size: 1550 bytes --] Hi Christian But when amdgpu driver is unloading, it will call this function. And driver unloading is an legal case under SR-IOV. Do you mean PCIe device removal indicates the unplug the real device? Best Regards Yitnian Tao ________________________________ 发件人: Christian K?nig <ckoenig.leichtzumerken@gmail.com> 发送时间: 2019年6月4日 21:57:37 收件人: Tao, Yintian; amd-gfx@lists.freedesktop.org 主题: Re: [PATCH] drm/amdgpu: no need fbcon under sriov Am 04.06.19 um 15:43 schrieb Yintian Tao: > Under Sriov, there is no need of the support for fbcon. NAK, that error message is not related to fbcon but means that PCIe device removal is not supported. Christian. > > Signed-off-by: Yintian Tao <yttao@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index 1f38d6f..28d095b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev) > { > struct drm_device *dev = pci_get_drvdata(pdev); > > - DRM_ERROR("Device removal is currently not supported outside of fbcon\n"); > + if (!amdgpu_sriov_vf(adev)) > + DRM_ERROR("Device removal is currently not supported outside of fbcon\n"); > drm_dev_unplug(dev); > drm_dev_put(dev); > pci_disable_device(pdev); [-- Attachment #1.2: Type: text/html, Size: 3309 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <MN2PR12MB3039F0DD22910F40A6674546E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov [not found] ` <MN2PR12MB3039F0DD22910F40A6674546E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2019-06-04 15:22 ` Koenig, Christian [not found] ` <a0c24c05-6bca-ee5c-75bf-672f27abdb33-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Koenig, Christian @ 2019-06-04 15:22 UTC (permalink / raw) To: Tao, Yintian, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 1835 bytes --] Am 04.06.19 um 17:16 schrieb Tao, Yintian: Hi Christian But when amdgpu driver is unloading, it will call this function. And driver unloading is an legal case under SR-IOV. Do you mean PCIe device removal indicates the unplug the real device? Yes, exactly and that is not supported. Sounds like the error message is then on the wrong place. Christian. Best Regards Yitnian Tao ________________________________ 发件人: Christian König <ckoenig.leichtzumerken@gmail.com><mailto:ckoenig.leichtzumerken@gmail.com> 发送时间: 2019年6月4日 21:57:37 收件人: Tao, Yintian; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> 主题: Re: [PATCH] drm/amdgpu: no need fbcon under sriov Am 04.06.19 um 15:43 schrieb Yintian Tao: > Under Sriov, there is no need of the support for fbcon. NAK, that error message is not related to fbcon but means that PCIe device removal is not supported. Christian. > > Signed-off-by: Yintian Tao <yttao@amd.com><mailto:yttao@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index 1f38d6f..28d095b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev) > { > struct drm_device *dev = pci_get_drvdata(pdev); > > - DRM_ERROR("Device removal is currently not supported outside of fbcon\n"); > + if (!amdgpu_sriov_vf(adev)) > + DRM_ERROR("Device removal is currently not supported outside of fbcon\n"); > drm_dev_unplug(dev); > drm_dev_put(dev); > pci_disable_device(pdev); [-- Attachment #1.2: Type: text/html, Size: 4132 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <a0c24c05-6bca-ee5c-75bf-672f27abdb33-5C7GfCeVMHo@public.gmane.org>]
* 答复: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov [not found] ` <a0c24c05-6bca-ee5c-75bf-672f27abdb33-5C7GfCeVMHo@public.gmane.org> @ 2019-06-04 15:29 ` Tao, Yintian [not found] ` <MN2PR12MB3039F3AF3CA365AA420DBC79E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Tao, Yintian @ 2019-06-04 15:29 UTC (permalink / raw) To: Koenig, Christian, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 2195 bytes --] Yes, you are right the error message is at wrong place. May I just remove this message? Best Regards Yintian Tao ________________________________ 发件人: Koenig, Christian 发送时间: 2019年6月4日 23:22:00 收件人: Tao, Yintian; amd-gfx@lists.freedesktop.org 主题: Re: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov Am 04.06.19 um 17:16 schrieb Tao, Yintian: Hi Christian But when amdgpu driver is unloading, it will call this function. And driver unloading is an legal case under SR-IOV. Do you mean PCIe device removal indicates the unplug the real device? Yes, exactly and that is not supported. Sounds like the error message is then on the wrong place. Christian. Best Regards Yitnian Tao ________________________________ 发件人: Christian König <ckoenig.leichtzumerken@gmail.com><mailto:ckoenig.leichtzumerken@gmail.com> 发送时间: 2019年6月4日 21:57:37 收件人: Tao, Yintian; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> 主题: Re: [PATCH] drm/amdgpu: no need fbcon under sriov Am 04.06.19 um 15:43 schrieb Yintian Tao: > Under Sriov, there is no need of the support for fbcon. NAK, that error message is not related to fbcon but means that PCIe device removal is not supported. Christian. > > Signed-off-by: Yintian Tao <yttao@amd.com><mailto:yttao@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index 1f38d6f..28d095b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev) > { > struct drm_device *dev = pci_get_drvdata(pdev); > > - DRM_ERROR("Device removal is currently not supported outside of fbcon\n"); > + if (!amdgpu_sriov_vf(adev)) > + DRM_ERROR("Device removal is currently not supported outside of fbcon\n"); > drm_dev_unplug(dev); > drm_dev_put(dev); > pci_disable_device(pdev); [-- Attachment #1.2: Type: text/html, Size: 5130 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <MN2PR12MB3039F3AF3CA365AA420DBC79E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: 答复: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov [not found] ` <MN2PR12MB3039F3AF3CA365AA420DBC79E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2019-06-05 18:23 ` Koenig, Christian 0 siblings, 0 replies; 6+ messages in thread From: Koenig, Christian @ 2019-06-05 18:23 UTC (permalink / raw) To: Tao, Yintian, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 2436 bytes --] Am 04.06.19 um 17:29 schrieb Tao, Yintian: Yes, you are right the error message is at wrong place. May I just remove this message? Fine with me, but you might want to double check who added the message and why. Something like "git blame ...." should do the trick. Christian. Best Regards Yintian Tao ________________________________ 发件人: Koenig, Christian 发送时间: 2019年6月4日 23:22:00 收件人: Tao, Yintian; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> 主题: Re: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov Am 04.06.19 um 17:16 schrieb Tao, Yintian: Hi Christian But when amdgpu driver is unloading, it will call this function. And driver unloading is an legal case under SR-IOV. Do you mean PCIe device removal indicates the unplug the real device? Yes, exactly and that is not supported. Sounds like the error message is then on the wrong place. Christian. Best Regards Yitnian Tao ________________________________ 发件人: Christian König <ckoenig.leichtzumerken@gmail.com><mailto:ckoenig.leichtzumerken@gmail.com> 发送时间: 2019年6月4日 21:57:37 收件人: Tao, Yintian; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> 主题: Re: [PATCH] drm/amdgpu: no need fbcon under sriov Am 04.06.19 um 15:43 schrieb Yintian Tao: > Under Sriov, there is no need of the support for fbcon. NAK, that error message is not related to fbcon but means that PCIe device removal is not supported. Christian. > > Signed-off-by: Yintian Tao <yttao@amd.com><mailto:yttao@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index 1f38d6f..28d095b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev) > { > struct drm_device *dev = pci_get_drvdata(pdev); > > - DRM_ERROR("Device removal is currently not supported outside of fbcon\n"); > + if (!amdgpu_sriov_vf(adev)) > + DRM_ERROR("Device removal is currently not supported outside of fbcon\n"); > drm_dev_unplug(dev); > drm_dev_put(dev); > pci_disable_device(pdev); [-- Attachment #1.2: Type: text/html, Size: 6011 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-05 18:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 13:43 [PATCH] drm/amdgpu: no need fbcon under sriov Yintian Tao
[not found] ` <1559655785-30379-1-git-send-email-yttao-5C7GfCeVMHo@public.gmane.org>
2019-06-04 13:57 ` Christian König
[not found] ` <1686be7b-ca1c-e43c-3906-e6131e8d25e1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-04 15:16 ` 答复: " Tao, Yintian
[not found] ` <MN2PR12MB3039F0DD22910F40A6674546E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-06-04 15:22 ` Koenig, Christian
[not found] ` <a0c24c05-6bca-ee5c-75bf-672f27abdb33-5C7GfCeVMHo@public.gmane.org>
2019-06-04 15:29 ` 答复: " Tao, Yintian
[not found] ` <MN2PR12MB3039F3AF3CA365AA420DBC79E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-06-05 18:23 ` Koenig, Christian
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.