From: Jon Hunter <jonathanh@nvidia.com> To: Laxman Dewangan <ldewangan@nvidia.com>, thierry.reding@gmail.com, robh+dt@kernel.org Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 4/4] pwm: tegra: Add support to configure pin state in suspends/resume Date: Thu, 6 Apr 2017 16:17:34 +0100 [thread overview] Message-ID: <e6eef15a-45e4-002b-dd45-38c268070241@nvidia.com> (raw) In-Reply-To: <1491488461-24621-5-git-send-email-ldewangan@nvidia.com> On 06/04/17 15:21, Laxman Dewangan wrote: > In some of NVIDIA Tegra's platform, PWM controller is used to > control the PWM controlled regulators. PWM signal is connected to > the VID pin of the regulator where duty cycle of PWM signal decide > the voltage level of the regulator output. > > The tristate (high impedance of PWM pin form Tegra) also define > one of the state of PWM regulator which needs to be configure in > suspend state of system. > > Add support to configure the pin state via pinctrl frameworks in > suspend and active state of the system. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > --- > Changes from v1: > - Use standard pinctrl names for sleep and active state. > - Use API pinctrl_pm_select_*() > > drivers/pwm/pwm-tegra.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c > index e9c4de5..af1bd4f 100644 > --- a/drivers/pwm/pwm-tegra.c > +++ b/drivers/pwm/pwm-tegra.c > @@ -29,6 +29,7 @@ > #include <linux/of_device.h> > #include <linux/pwm.h> > #include <linux/platform_device.h> > +#include <linux/pinctrl/consumer.h> > #include <linux/slab.h> > #include <linux/reset.h> > > @@ -256,6 +257,22 @@ static int tegra_pwm_remove(struct platform_device *pdev) > return pwmchip_remove(&pc->chip); > } > > +#ifdef CONFIG_PM_SLEEP > +static int tegra_pwm_suspend(struct device *dev) > +{ > + pinctrl_pm_select_sleep_state(dev); Why not return the error code here? > + > + return 0; > +} > + > +static int tegra_pwm_resume(struct device *dev) > +{ > + pinctrl_pm_select_default_state(dev); And here. By the way, do you plan to include patches to populate the bindings for the pwm devices? Cheers Jon -- nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jonathanh@nvidia.com> To: Laxman Dewangan <ldewangan@nvidia.com>, <thierry.reding@gmail.com>, <robh+dt@kernel.org> Cc: <mark.rutland@arm.com>, <linux-pwm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH V4 4/4] pwm: tegra: Add support to configure pin state in suspends/resume Date: Thu, 6 Apr 2017 16:17:34 +0100 [thread overview] Message-ID: <e6eef15a-45e4-002b-dd45-38c268070241@nvidia.com> (raw) In-Reply-To: <1491488461-24621-5-git-send-email-ldewangan@nvidia.com> On 06/04/17 15:21, Laxman Dewangan wrote: > In some of NVIDIA Tegra's platform, PWM controller is used to > control the PWM controlled regulators. PWM signal is connected to > the VID pin of the regulator where duty cycle of PWM signal decide > the voltage level of the regulator output. > > The tristate (high impedance of PWM pin form Tegra) also define > one of the state of PWM regulator which needs to be configure in > suspend state of system. > > Add support to configure the pin state via pinctrl frameworks in > suspend and active state of the system. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > --- > Changes from v1: > - Use standard pinctrl names for sleep and active state. > - Use API pinctrl_pm_select_*() > > drivers/pwm/pwm-tegra.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c > index e9c4de5..af1bd4f 100644 > --- a/drivers/pwm/pwm-tegra.c > +++ b/drivers/pwm/pwm-tegra.c > @@ -29,6 +29,7 @@ > #include <linux/of_device.h> > #include <linux/pwm.h> > #include <linux/platform_device.h> > +#include <linux/pinctrl/consumer.h> > #include <linux/slab.h> > #include <linux/reset.h> > > @@ -256,6 +257,22 @@ static int tegra_pwm_remove(struct platform_device *pdev) > return pwmchip_remove(&pc->chip); > } > > +#ifdef CONFIG_PM_SLEEP > +static int tegra_pwm_suspend(struct device *dev) > +{ > + pinctrl_pm_select_sleep_state(dev); Why not return the error code here? > + > + return 0; > +} > + > +static int tegra_pwm_resume(struct device *dev) > +{ > + pinctrl_pm_select_default_state(dev); And here. By the way, do you plan to include patches to populate the bindings for the pwm devices? Cheers Jon -- nvpublic
next prev parent reply other threads:[~2017-04-06 15:17 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-06 14:20 [PATCH V2 0/4] pwm: tegra: Pin configuration in suspend/resume and cleanups Laxman Dewangan 2017-04-06 14:20 ` Laxman Dewangan 2017-04-06 14:20 ` [PATCH V2 2/4] pwm: tegra: Increase precision in pwm rate calculation Laxman Dewangan 2017-04-06 14:20 ` Laxman Dewangan [not found] ` <1491488461-24621-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2017-04-06 16:24 ` Thierry Reding 2017-04-06 16:24 ` Thierry Reding 2017-04-06 17:03 ` Laxman Dewangan 2017-04-06 16:28 ` Thierry Reding 2017-04-06 16:28 ` Thierry Reding [not found] ` <1491488461-24621-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2017-04-06 14:20 ` [PATCH V2 1/4] pwm: tegra: Use DIV_ROUND_CLOSEST_ULL() instead of local implementation Laxman Dewangan 2017-04-06 14:20 ` Laxman Dewangan 2017-04-06 16:28 ` Thierry Reding 2017-04-06 14:21 ` [PATCH V3 3/4] pwm: tegra: Add DT binding details to configure pin in suspends/resume Laxman Dewangan 2017-04-06 14:21 ` Laxman Dewangan 2017-04-06 15:26 ` Jon Hunter 2017-04-06 15:26 ` Jon Hunter [not found] ` <f43c83a9-8ae0-73b0-d41d-97d3bc6c253e-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2017-04-06 16:48 ` Laxman Dewangan 2017-04-06 16:48 ` Laxman Dewangan [not found] ` <58E67152.1080400-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2017-04-07 7:49 ` Jon Hunter 2017-04-07 7:49 ` Jon Hunter 2017-04-06 14:21 ` [PATCH V4 4/4] pwm: tegra: Add support to configure pin state " Laxman Dewangan 2017-04-06 14:21 ` Laxman Dewangan 2017-04-06 15:17 ` Jon Hunter [this message] 2017-04-06 15:17 ` Jon Hunter 2017-04-06 16:40 ` Laxman Dewangan 2017-04-06 16:40 ` Laxman Dewangan [not found] ` <58E66F8F.1030802-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2017-04-07 7:51 ` Jon Hunter 2017-04-07 7:51 ` Jon Hunter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e6eef15a-45e4-002b-dd45-38c268070241@nvidia.com \ --to=jonathanh@nvidia.com \ --cc=devicetree@vger.kernel.org \ --cc=ldewangan@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.