From: Anshuman Khandual <khandual@linux.vnet.ibm.com> To: Michal Hocko <mhocko@kernel.org>, Anshuman Khandual <khandual@linux.vnet.ibm.com> Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, sfr@canb.auug.org.au, broonie@kernel.org Subject: Re: mmotm 2018-01-04-16-19 uploaded Date: Sun, 7 Jan 2018 12:19:32 +0530 [thread overview] Message-ID: <e81dce2b-5d47-b7d3-efbf-27bc171ba4ab@linux.vnet.ibm.com> (raw) In-Reply-To: <20180105084631.GG2801@dhcp22.suse.cz> On 01/05/2018 02:16 PM, Michal Hocko wrote: > On Fri 05-01-18 12:13:17, Anshuman Khandual wrote: >> On 01/05/2018 05:50 AM, akpm@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2018-01-04-16-19 has been uploaded to [...] >>> >>> This tree is partially included in linux-next. To see which patches are >>> included in linux-next, consult the `series' file. Only the patches >>> within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in >>> linux-next. >>> >>> A git tree which contains the memory management portion of this tree is >>> maintained at git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git >> Seems like this latest snapshot mmotm-2018-01-04-16-19 has not been >> updated in this git tree. I could not fetch not it shows up in the >> http link below. >> >> https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git > I will update the tree today (WIP). This is not a fully automated > process and Andrew pushed his tree during my night ;) So be patient > please. My tree is non-rebasing which means I cannot just throw the old > tree away and regenerate it from scratch. > >> The last one mmotm-2017-12-22-17-55 seems to have some regression on >> powerpc with respect to ELF loading of binaries (see below). Seems to >> be related to recent MAP_FIXED_SAFE (or MAP_FIXED_NOREPLACE as seen >> now in the code). IIUC (have not been following the series last month) >> MAP_FIXED_NOREPLACE will fail an allocation request if the hint address >> cannot be reserve instead of changing existing mappings. > Correct > >> Is it possible >> that ELF loading needs to be fixed at a higher level to deal with these >> new possible mmap() failures because of MAP_FIXED_NOREPLACE ? > Could you give us more information about the failure please. Debugging > patch from http://lkml.kernel.org/r/20171218091302.GL16951@dhcp22.suse.cz > should help to see what is the clashing VMA. Seems like its re-requesting the same mapping again. [ 23.423642] 9148 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 23.423706] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon [ 23.426089] 9151 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 23.426232] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon [ 23.429048] 9154 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 23.429196] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon [ 23.482766] 9164 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 23.482904] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon [ 23.485849] 9167 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 23.485945] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon [ 76.041836] 9262 (hostname): Uhuuh, elf segment at 0000000010020000 requested but the memory is mapped already [ 76.041965] requested [10020000, 10030000] mapped [10020000, 10030000] 100073 anon [ 76.207197] 9285 (pkg-config): Uhuuh, elf segment at 0000000010020000 requested but the memory is mapped already [ 76.207326] requested [10020000, 10030000] mapped [10020000, 10030000] 100073 anon [ 76.371073] 9299 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 76.371165] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon I have fixed/changed the debug patch a bit diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index d8c5657..a43eccaa 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -372,11 +372,35 @@ static unsigned long elf_map(struct file *filep, unsigned long addr, } else map_addr = vm_mmap(filep, addr, size, prot, type, off); - if ((type & MAP_FIXED_NOREPLACE) && BAD_ADDR(map_addr)) + if ((type & MAP_FIXED_NOREPLACE) && BAD_ADDR(map_addr)) { + struct vm_area_struct *vma; + unsigned long end; + + if (total_size) + end = addr + total_size; + else + end = addr + size; + pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n", task_pid_nr(current), current->comm, (void *)addr); + vma = find_vma(current->mm, addr); + if (vma && vma->vm_start <= addr) { + pr_info("requested [%lx, %lx] mapped [%lx, %lx] %lx ", addr, end, + vma->vm_start, vma->vm_end, vma->vm_flags); + if (!vma->vm_file) { + pr_cont("anon\n"); + } else { + char path[512]; + char *p = file_path(vma->vm_file, path, sizeof(path)); + if (IS_ERR(p)) + p = "?"; + pr_cont("\"%s\"\n", kbasename(p)); + } + dump_stack(); + } + } return(map_addr); }
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <khandual@linux.vnet.ibm.com> To: Michal Hocko <mhocko@kernel.org>, Anshuman Khandual <khandual@linux.vnet.ibm.com> Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, sfr@canb.auug.org.au, broonie@kernel.org Subject: Re: mmotm 2018-01-04-16-19 uploaded Date: Sun, 7 Jan 2018 12:19:32 +0530 [thread overview] Message-ID: <e81dce2b-5d47-b7d3-efbf-27bc171ba4ab@linux.vnet.ibm.com> (raw) In-Reply-To: <20180105084631.GG2801@dhcp22.suse.cz> On 01/05/2018 02:16 PM, Michal Hocko wrote: > On Fri 05-01-18 12:13:17, Anshuman Khandual wrote: >> On 01/05/2018 05:50 AM, akpm@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2018-01-04-16-19 has been uploaded to [...] >>> >>> This tree is partially included in linux-next. To see which patches are >>> included in linux-next, consult the `series' file. Only the patches >>> within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in >>> linux-next. >>> >>> A git tree which contains the memory management portion of this tree is >>> maintained at git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git >> Seems like this latest snapshot mmotm-2018-01-04-16-19 has not been >> updated in this git tree. I could not fetch not it shows up in the >> http link below. >> >> https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git > I will update the tree today (WIP). This is not a fully automated > process and Andrew pushed his tree during my night ;) So be patient > please. My tree is non-rebasing which means I cannot just throw the old > tree away and regenerate it from scratch. > >> The last one mmotm-2017-12-22-17-55 seems to have some regression on >> powerpc with respect to ELF loading of binaries (see below). Seems to >> be related to recent MAP_FIXED_SAFE (or MAP_FIXED_NOREPLACE as seen >> now in the code). IIUC (have not been following the series last month) >> MAP_FIXED_NOREPLACE will fail an allocation request if the hint address >> cannot be reserve instead of changing existing mappings. > Correct > >> Is it possible >> that ELF loading needs to be fixed at a higher level to deal with these >> new possible mmap() failures because of MAP_FIXED_NOREPLACE ? > Could you give us more information about the failure please. Debugging > patch from http://lkml.kernel.org/r/20171218091302.GL16951@dhcp22.suse.cz > should help to see what is the clashing VMA. Seems like its re-requesting the same mapping again. [ 23.423642] 9148 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 23.423706] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon [ 23.426089] 9151 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 23.426232] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon [ 23.429048] 9154 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 23.429196] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon [ 23.482766] 9164 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 23.482904] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon [ 23.485849] 9167 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 23.485945] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon [ 76.041836] 9262 (hostname): Uhuuh, elf segment at 0000000010020000 requested but the memory is mapped already [ 76.041965] requested [10020000, 10030000] mapped [10020000, 10030000] 100073 anon [ 76.207197] 9285 (pkg-config): Uhuuh, elf segment at 0000000010020000 requested but the memory is mapped already [ 76.207326] requested [10020000, 10030000] mapped [10020000, 10030000] 100073 anon [ 76.371073] 9299 (sed): Uhuuh, elf segment at 0000000010030000 requested but the memory is mapped already [ 76.371165] requested [10030000, 10040000] mapped [10030000, 10040000] 100073 anon I have fixed/changed the debug patch a bit diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index d8c5657..a43eccaa 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -372,11 +372,35 @@ static unsigned long elf_map(struct file *filep, unsigned long addr, } else map_addr = vm_mmap(filep, addr, size, prot, type, off); - if ((type & MAP_FIXED_NOREPLACE) && BAD_ADDR(map_addr)) + if ((type & MAP_FIXED_NOREPLACE) && BAD_ADDR(map_addr)) { + struct vm_area_struct *vma; + unsigned long end; + + if (total_size) + end = addr + total_size; + else + end = addr + size; + pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n", task_pid_nr(current), current->comm, (void *)addr); + vma = find_vma(current->mm, addr); + if (vma && vma->vm_start <= addr) { + pr_info("requested [%lx, %lx] mapped [%lx, %lx] %lx ", addr, end, + vma->vm_start, vma->vm_end, vma->vm_flags); + if (!vma->vm_file) { + pr_cont("anon\n"); + } else { + char path[512]; + char *p = file_path(vma->vm_file, path, sizeof(path)); + if (IS_ERR(p)) + p = "?"; + pr_cont("\"%s\"\n", kbasename(p)); + } + dump_stack(); + } + } return(map_addr); } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-07 6:49 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-05 0:20 mmotm 2018-01-04-16-19 uploaded akpm 2018-01-05 0:20 ` akpm 2018-01-05 6:43 ` Anshuman Khandual 2018-01-05 6:43 ` Anshuman Khandual 2018-01-05 8:46 ` Michal Hocko 2018-01-05 8:46 ` Michal Hocko 2018-01-07 6:49 ` Anshuman Khandual [this message] 2018-01-07 6:49 ` Anshuman Khandual 2018-01-07 9:02 ` ppc elf_map breakage with MAP_FIXED_NOREPLACE (was: Re: mmotm 2018-01-04-16-19 uploaded) Michal Hocko 2018-01-07 9:02 ` Michal Hocko 2018-01-07 11:26 ` Michael Ellerman 2018-01-07 11:26 ` Michael Ellerman 2018-01-08 3:02 ` ppc elf_map breakage with MAP_FIXED_NOREPLACE Anshuman Khandual 2018-01-08 3:02 ` Anshuman Khandual 2018-01-08 22:12 ` Michael Ellerman 2018-01-08 22:12 ` Michael Ellerman 2018-01-08 22:12 ` Michael Ellerman 2018-01-09 11:48 ` Anshuman Khandual 2018-01-09 11:48 ` Anshuman Khandual 2018-01-09 16:13 ` Michal Hocko 2018-01-09 16:13 ` Michal Hocko 2018-01-11 10:08 ` Anshuman Khandual 2018-01-11 10:08 ` Anshuman Khandual 2018-01-17 8:07 ` Michal Hocko 2018-01-17 8:07 ` Michal Hocko 2018-01-23 11:25 ` Anshuman Khandual 2018-01-23 11:25 ` Anshuman Khandual 2018-01-23 12:45 ` Michal Hocko 2018-01-23 12:45 ` Michal Hocko 2018-01-23 15:58 ` Anshuman Khandual 2018-01-23 15:58 ` Anshuman Khandual 2018-01-23 16:06 ` Michal Hocko 2018-01-23 16:06 ` Michal Hocko 2018-01-24 5:09 ` Anshuman Khandual 2018-01-24 5:09 ` Anshuman Khandual 2018-01-24 9:05 ` Michal Hocko 2018-01-24 9:05 ` Michal Hocko 2018-01-26 12:34 ` Anshuman Khandual 2018-01-26 12:34 ` Anshuman Khandual 2018-01-26 14:04 ` Michal Hocko 2018-01-26 14:04 ` Michal Hocko 2018-01-29 2:47 ` Anshuman Khandual 2018-01-29 2:47 ` Anshuman Khandual 2018-01-29 5:32 ` Anshuman Khandual 2018-01-29 5:32 ` Anshuman Khandual 2018-01-29 13:22 ` Michal Hocko 2018-01-29 13:22 ` Michal Hocko 2018-01-30 3:35 ` Michael Ellerman 2018-01-30 3:35 ` Michael Ellerman 2018-01-30 9:42 ` Michal Hocko 2018-01-30 9:42 ` Michal Hocko 2018-01-31 5:05 ` Anshuman Khandual 2018-01-31 5:05 ` Anshuman Khandual 2018-01-31 13:19 ` Michal Hocko 2018-01-31 13:19 ` Michal Hocko 2018-02-01 3:13 ` Anshuman Khandual 2018-02-01 3:13 ` Anshuman Khandual 2018-02-01 13:10 ` Michal Hocko 2018-02-01 13:10 ` Michal Hocko 2018-02-01 13:40 ` Michal Hocko 2018-02-01 13:40 ` Michal Hocko 2018-02-01 20:55 ` Kees Cook 2018-02-01 20:55 ` Kees Cook 2018-02-13 10:04 ` [RFC PATCH] elf: enforce MAP_FIXED on overlaying elf segments (was: Re: ppc elf_map breakage with MAP_FIXED_NOREPLACE) Michal Hocko 2018-02-13 10:04 ` Michal Hocko 2018-02-13 10:04 ` Michal Hocko 2018-02-14 16:30 ` Khalid Aziz 2018-02-14 16:30 ` Khalid Aziz 2018-02-01 13:48 ` ppc elf_map breakage with MAP_FIXED_NOREPLACE Michal Hocko 2018-02-01 13:48 ` Michal Hocko 2018-02-01 21:06 ` Kees Cook 2018-02-01 21:06 ` Kees Cook 2018-02-12 14:48 ` Michal Hocko 2018-02-12 14:48 ` Michal Hocko 2018-02-13 1:02 ` Anshuman Khandual 2018-02-13 1:02 ` Anshuman Khandual 2018-02-13 6:49 ` Anshuman Khandual 2018-02-13 6:49 ` Anshuman Khandual 2018-02-13 10:00 ` Michal Hocko 2018-02-13 10:00 ` Michal Hocko 2018-01-05 12:14 ` mmotm 2018-01-04-16-19 uploaded Michal Hocko 2018-01-05 12:14 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e81dce2b-5d47-b7d3-efbf-27bc171ba4ab@linux.vnet.ibm.com \ --to=khandual@linux.vnet.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=broonie@kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-next@vger.kernel.org \ --cc=mhocko@kernel.org \ --cc=mm-commits@vger.kernel.org \ --cc=sfr@canb.auug.org.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.