All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: <dillon.minfei@gmail.com>, <robh+dt@kernel.org>,
	<a.fatoum@pengutronix.de>, <mcoquelin.stm32@gmail.com>,
	<alexandre.torgue@st.com>, <devicetree@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux@armlinux.org.uk>,
	<vladimir.murzin@arm.com>, <afzal.mohd.ma@gmail.com>
Subject: Re: [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support
Date: Mon, 29 Mar 2021 10:00:11 +0200	[thread overview]
Message-ID: <eb2437ef-ecd2-e258-b77b-2fe9f70205f2@foss.st.com> (raw)
In-Reply-To: <1615530274-31422-9-git-send-email-dillon.minfei@gmail.com>

Hi Dillon

On 3/12/21 7:24 AM, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
> 
> This patch adds STM32H750 pinctrl and GPIO support
> since stm32h750 has the same pin alternate functions
> with stm32h743, so just reuse the stm32h743's pinctrl
> driver
> 
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
> ---
> v2:
> - add compatible string st,stm32h750-pinctrl to pinctl-stm32h743.c as they
>    have same pin alternate functions
> - add STM32H750 to Kconfig description
> 
>   drivers/pinctrl/stm32/Kconfig             | 2 +-
>   drivers/pinctrl/stm32/pinctrl-stm32h743.c | 3 +++
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig
> index f36f29113370..fb1ffc94c57f 100644
> --- a/drivers/pinctrl/stm32/Kconfig
> +++ b/drivers/pinctrl/stm32/Kconfig
> @@ -35,7 +35,7 @@ config PINCTRL_STM32F769
>   	select PINCTRL_STM32
>   
>   config PINCTRL_STM32H743
> -	bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743
> +	bool "STMicroelectronics STM32H743/STM32H750 pin control" if COMPILE_TEST && !MACH_STM32H743
>   	depends on OF && HAS_IOMEM
>   	default MACH_STM32H743
>   	select PINCTRL_STM32
> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32h743.c b/drivers/pinctrl/stm32/pinctrl-stm32h743.c
> index ffe7b5271506..700206c7bc11 100644
> --- a/drivers/pinctrl/stm32/pinctrl-stm32h743.c
> +++ b/drivers/pinctrl/stm32/pinctrl-stm32h743.c
> @@ -1966,6 +1966,9 @@ static const struct of_device_id stm32h743_pctrl_match[] = {
>   		.compatible = "st,stm32h743-pinctrl",
>   		.data = &stm32h743_match_data,
>   	},
> +	{	.compatible = "st,stm32h750-pinctrl",
> +		.data = &stm32h743_match_data,
> +	},

If you use exactly the same driver (i.e. same ball out and AF mux) then 
you don't have to create a new compatible for that. Just use the same 
than h743.(so you don't have to factorize DT files).

Regards
Alex

>   	{ }
>   };
>   
> 

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: <dillon.minfei@gmail.com>, <robh+dt@kernel.org>,
	<a.fatoum@pengutronix.de>, <mcoquelin.stm32@gmail.com>,
	<alexandre.torgue@st.com>, <devicetree@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux@armlinux.org.uk>,
	<vladimir.murzin@arm.com>, <afzal.mohd.ma@gmail.com>
Subject: Re: [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support
Date: Mon, 29 Mar 2021 10:00:11 +0200	[thread overview]
Message-ID: <eb2437ef-ecd2-e258-b77b-2fe9f70205f2@foss.st.com> (raw)
In-Reply-To: <1615530274-31422-9-git-send-email-dillon.minfei@gmail.com>

Hi Dillon

On 3/12/21 7:24 AM, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
> 
> This patch adds STM32H750 pinctrl and GPIO support
> since stm32h750 has the same pin alternate functions
> with stm32h743, so just reuse the stm32h743's pinctrl
> driver
> 
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
> ---
> v2:
> - add compatible string st,stm32h750-pinctrl to pinctl-stm32h743.c as they
>    have same pin alternate functions
> - add STM32H750 to Kconfig description
> 
>   drivers/pinctrl/stm32/Kconfig             | 2 +-
>   drivers/pinctrl/stm32/pinctrl-stm32h743.c | 3 +++
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig
> index f36f29113370..fb1ffc94c57f 100644
> --- a/drivers/pinctrl/stm32/Kconfig
> +++ b/drivers/pinctrl/stm32/Kconfig
> @@ -35,7 +35,7 @@ config PINCTRL_STM32F769
>   	select PINCTRL_STM32
>   
>   config PINCTRL_STM32H743
> -	bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743
> +	bool "STMicroelectronics STM32H743/STM32H750 pin control" if COMPILE_TEST && !MACH_STM32H743
>   	depends on OF && HAS_IOMEM
>   	default MACH_STM32H743
>   	select PINCTRL_STM32
> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32h743.c b/drivers/pinctrl/stm32/pinctrl-stm32h743.c
> index ffe7b5271506..700206c7bc11 100644
> --- a/drivers/pinctrl/stm32/pinctrl-stm32h743.c
> +++ b/drivers/pinctrl/stm32/pinctrl-stm32h743.c
> @@ -1966,6 +1966,9 @@ static const struct of_device_id stm32h743_pctrl_match[] = {
>   		.compatible = "st,stm32h743-pinctrl",
>   		.data = &stm32h743_match_data,
>   	},
> +	{	.compatible = "st,stm32h750-pinctrl",
> +		.data = &stm32h743_match_data,
> +	},

If you use exactly the same driver (i.e. same ball out and AF mux) then 
you don't have to create a new compatible for that. Just use the same 
than h743.(so you don't have to factorize DT files).

Regards
Alex

>   	{ }
>   };
>   
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-29  8:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  6:24 [PATCH v2 0/8] ARM: STM32: add art-pi(stm32h750xbh6) board support dillon.minfei
2021-03-12  6:24 ` dillon.minfei
2021-03-12  6:24 ` [PATCH v2 1/8] Documentation: arm: stm32: Add stm32h750 value line doc dillon.minfei
2021-03-12  6:24   ` dillon.minfei
2021-03-12  6:24 ` [PATCH v2 2/8] dt-bindings: arm: stm32: Add compatible strings for ART-PI board dillon.minfei
2021-03-12  6:24   ` dillon.minfei
2021-03-12  6:24 ` [PATCH v2 3/8] dt-bindings: pinctrl: stm32: Add stm32h750 pinctrl dillon.minfei
2021-03-12  6:24   ` dillon.minfei
2021-03-12  6:24 ` [PATCH v2 4/8] ARM: dts: stm32: introduce stm32h7-pinctrl.dtsi to support stm32h750 dillon.minfei
2021-03-12  6:24   ` dillon.minfei
2021-03-15  0:25   ` kernel test robot
2021-03-15  0:25     ` kernel test robot
2021-03-15  0:25     ` kernel test robot
2021-03-12  6:24 ` [PATCH v2 5/8] ARM: dts: stm32: add stm32h750-pinctrl.dtsi dillon.minfei
2021-03-12  6:24   ` dillon.minfei
2021-03-12  6:24 ` [PATCH v2 6/8] ARM: dts: stm32: add support for art-pi board based on stm32h750xbh6 dillon.minfei
2021-03-12  6:24   ` dillon.minfei
2021-03-15  0:25   ` kernel test robot
2021-03-15  0:25     ` kernel test robot
2021-03-15  0:25     ` kernel test robot
2021-03-12  6:24 ` [PATCH v2 7/8] ARM: stm32: Add a new SOC - STM32H750 dillon.minfei
2021-03-12  6:24   ` dillon.minfei
2021-03-12  6:24 ` [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support dillon.minfei
2021-03-12  6:24   ` dillon.minfei
2021-03-29  8:00   ` Alexandre TORGUE [this message]
2021-03-29  8:00     ` Alexandre TORGUE
2021-03-29  8:07     ` dillon min
2021-03-29  8:07       ` dillon min
2021-03-29 10:13       ` Alexandre TORGUE
2021-03-29 10:13         ` Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb2437ef-ecd2-e258-b77b-2fe9f70205f2@foss.st.com \
    --to=alexandre.torgue@foss.st.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=afzal.mohd.ma@gmail.com \
    --cc=alexandre.torgue@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dillon.minfei@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux@armlinux.org.uk \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=vladimir.murzin@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.