All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Andrey Konovalov <andreyknvl@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Alexander Potapenko <glider@google.com>,
	Marco Elver <elver@google.com>, Will Deacon <will.deacon@arm.com>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Peter Collingbourne <pcc@google.com>,
	Evgenii Stepanov <eugenis@google.com>,
	Branislav Rankov <Branislav.Rankov@arm.com>,
	Kevin Brodsky <kevin.brodsky@arm.com>,
	kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/12] arm64: kasan: simplify and inline MTE functions
Date: Thu, 4 Feb 2021 12:39:08 +0000	[thread overview]
Message-ID: <f87043c9-6126-c87b-a5c6-b48f28556b92@arm.com> (raw)
In-Reply-To: <20210201144407.dd603ec4edcd589643654057@linux-foundation.org>

Hi Andrew,

On 2/1/21 10:44 PM, Andrew Morton wrote:
> On Mon,  1 Feb 2021 20:43:34 +0100 Andrey Konovalov <andreyknvl@google.com> wrote:
> 
>> This change provides a simpler implementation of mte_get_mem_tag(),
>> mte_get_random_tag(), and mte_set_mem_tag_range().
>>
>> Simplifications include removing system_supports_mte() checks as these
>> functions are onlye called from KASAN runtime that had already checked
>> system_supports_mte(). Besides that, size and address alignment checks
>> are removed from mte_set_mem_tag_range(), as KASAN now does those.
>>
>> This change also moves these functions into the asm/mte-kasan.h header
>> and implements mte_set_mem_tag_range() via inline assembly to avoid
>> unnecessary functions calls.
>>
>> Co-developed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> 
> Co-developed-by requires a Signed-off-by: as well.  Vincenzo, please
> send us one?
> 
> 

I added my Signed-off-by to the patch.

-- 
Regards,
Vincenzo

WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Andrey Konovalov <andreyknvl@google.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Marco Elver <elver@google.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Kevin Brodsky <kevin.brodsky@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Branislav Rankov <Branislav.Rankov@arm.com>,
	kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Alexander Potapenko <glider@google.com>,
	Evgenii Stepanov <eugenis@google.com>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Peter Collingbourne <pcc@google.com>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH 10/12] arm64: kasan: simplify and inline MTE functions
Date: Thu, 4 Feb 2021 12:39:08 +0000	[thread overview]
Message-ID: <f87043c9-6126-c87b-a5c6-b48f28556b92@arm.com> (raw)
In-Reply-To: <20210201144407.dd603ec4edcd589643654057@linux-foundation.org>

Hi Andrew,

On 2/1/21 10:44 PM, Andrew Morton wrote:
> On Mon,  1 Feb 2021 20:43:34 +0100 Andrey Konovalov <andreyknvl@google.com> wrote:
> 
>> This change provides a simpler implementation of mte_get_mem_tag(),
>> mte_get_random_tag(), and mte_set_mem_tag_range().
>>
>> Simplifications include removing system_supports_mte() checks as these
>> functions are onlye called from KASAN runtime that had already checked
>> system_supports_mte(). Besides that, size and address alignment checks
>> are removed from mte_set_mem_tag_range(), as KASAN now does those.
>>
>> This change also moves these functions into the asm/mte-kasan.h header
>> and implements mte_set_mem_tag_range() via inline assembly to avoid
>> unnecessary functions calls.
>>
>> Co-developed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> 
> Co-developed-by requires a Signed-off-by: as well.  Vincenzo, please
> send us one?
> 
> 

I added my Signed-off-by to the patch.

-- 
Regards,
Vincenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-04 12:36 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 19:43 [PATCH 00/12] kasan: optimizations and fixes for HW_TAGS Andrey Konovalov
2021-02-01 19:43 ` Andrey Konovalov
2021-02-01 19:43 ` Andrey Konovalov
2021-02-01 19:43 ` [PATCH 01/12] kasan, mm: don't save alloc stacks twice Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-02 16:06   ` Marco Elver
2021-02-02 16:06     ` Marco Elver
2021-02-02 18:01     ` Andrey Konovalov
2021-02-02 18:01       ` Andrey Konovalov
2021-02-02 18:01       ` Andrey Konovalov
2021-02-02 18:40       ` Marco Elver
2021-02-02 18:40         ` Marco Elver
2021-02-02 18:40         ` Marco Elver
2021-02-01 19:43 ` [PATCH 02/12] kasan, mm: optimize kmalloc poisoning Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-02 16:25   ` Marco Elver
2021-02-02 16:25     ` Marco Elver
2021-02-02 17:15     ` Andrey Konovalov
2021-02-02 17:15       ` Andrey Konovalov
2021-02-02 17:15       ` Andrey Konovalov
2021-02-02 17:39       ` Marco Elver
2021-02-02 17:39         ` Marco Elver
2021-02-02 17:39         ` Marco Elver
2021-02-01 19:43 ` [PATCH 03/12] kasan: optimize large " Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-02 16:57   ` Marco Elver
2021-02-02 16:57     ` Marco Elver
2021-02-01 19:43 ` [PATCH 04/12] kasan: clean up setting free info in kasan_slab_free Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-02 17:03   ` Marco Elver
2021-02-02 17:03     ` Marco Elver
2021-02-01 19:43 ` [PATCH 05/12] kasan: unify large kfree checks Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-03 12:13   ` Marco Elver
2021-02-03 12:13     ` Marco Elver
2021-02-01 19:43 ` [PATCH 06/12] kasan: rework krealloc tests Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-03 14:48   ` Marco Elver
2021-02-03 14:48     ` Marco Elver
2021-02-01 19:43 ` [PATCH 07/12] kasan, mm: remove krealloc side-effect Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-03 15:10   ` Marco Elver
2021-02-03 15:10     ` Marco Elver
2021-02-01 19:43 ` [PATCH 08/12] kasan, mm: optimize krealloc poisoning Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-03 14:34   ` Marco Elver
2021-02-03 14:34     ` Marco Elver
2021-02-01 19:43 ` [PATCH 09/12] kasan: ensure poisoning size alignment Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-03 15:31   ` Marco Elver
2021-02-03 15:31     ` Marco Elver
2021-02-01 19:43 ` [PATCH 10/12] arm64: kasan: simplify and inline MTE functions Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 22:44   ` Andrew Morton
2021-02-01 22:44     ` Andrew Morton
2021-02-04 12:39     ` Vincenzo Frascino [this message]
2021-02-04 12:39       ` Vincenzo Frascino
2021-02-02 15:42   ` Catalin Marinas
2021-02-02 15:42     ` Catalin Marinas
2021-02-02 18:04     ` Andrey Konovalov
2021-02-02 18:04       ` Andrey Konovalov
2021-02-02 18:04       ` Andrey Konovalov
2021-02-04 12:37   ` Vincenzo Frascino
2021-02-04 12:37     ` Vincenzo Frascino
2021-02-01 19:43 ` [PATCH 11/12] kasan: always inline HW_TAGS helper functions Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-03 15:51   ` Marco Elver
2021-02-03 15:51     ` Marco Elver
2021-02-01 19:43 ` [PATCH 12/12] arm64: kasan: export MTE symbols for KASAN tests Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-01 19:43   ` Andrey Konovalov
2021-02-02 10:46   ` Will Deacon
2021-02-02 10:46     ` Will Deacon
2021-02-02 13:42     ` Andrey Konovalov
2021-02-02 13:42       ` Andrey Konovalov
2021-02-02 13:42       ` Andrey Konovalov
2021-02-02 15:43   ` Catalin Marinas
2021-02-02 15:43     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f87043c9-6126-c87b-a5c6-b48f28556b92@arm.com \
    --to=vincenzo.frascino@arm.com \
    --cc=Branislav.Rankov@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=catalin.marinas@arm.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=eugenis@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=kevin.brodsky@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pcc@google.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.