* [Qemu-devel] [PATCH] hw: input: set category of the i8042 device
@ 2019-01-25 15:14 kumar sourav
2019-01-25 15:24 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: kumar sourav @ 2019-01-25 15:14 UTC (permalink / raw)
To: qemu-trivial; +Cc: mst, pbonzini, qemu-devel, thuth
Sets the category of i8042 device as DEVICE_CATEGORY_INPUT
Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
---
hw/input/pckbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
index 3e66713b47..72e7d5f6cc 100644
--- a/hw/input/pckbd.c
+++ b/hw/input/pckbd.c
@@ -574,6 +574,7 @@ static void i8042_class_initfn(ObjectClass *klass, void *data)
dc->realize = i8042_realizefn;
dc->vmsd = &vmstate_kbd_isa;
+ set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
}
static const TypeInfo i8042_info = {
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] hw: input: set category of the i8042 device
2019-01-25 15:14 [Qemu-devel] [PATCH] hw: input: set category of the i8042 device kumar sourav
@ 2019-01-25 15:24 ` Thomas Huth
2019-01-25 16:44 ` Philippe Mathieu-Daudé
2019-01-25 19:46 ` Michael S. Tsirkin
2019-01-30 9:19 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 1 reply; 8+ messages in thread
From: Thomas Huth @ 2019-01-25 15:24 UTC (permalink / raw)
To: kumar sourav, qemu-trivial; +Cc: pbonzini, qemu-devel, mst
On 2019-01-25 16:14, kumar sourav wrote:
> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> ---
> hw/input/pckbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
> index 3e66713b47..72e7d5f6cc 100644
> --- a/hw/input/pckbd.c
> +++ b/hw/input/pckbd.c
> @@ -574,6 +574,7 @@ static void i8042_class_initfn(ObjectClass *klass, void *data)
>
> dc->realize = i8042_realizefn;
> dc->vmsd = &vmstate_kbd_isa;
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo i8042_info = {
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] hw: input: set category of the i8042 device
2019-01-25 15:24 ` Thomas Huth
@ 2019-01-25 16:44 ` Philippe Mathieu-Daudé
2019-01-25 18:00 ` ksourav
2019-01-28 8:14 ` Thomas Huth
0 siblings, 2 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-25 16:44 UTC (permalink / raw)
To: Thomas Huth, kumar sourav, qemu-trivial; +Cc: pbonzini, qemu-devel, mst
On 1/25/19 4:24 PM, Thomas Huth wrote:
> On 2019-01-25 16:14, kumar sourav wrote:
>> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT
>> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>>
>> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
>> ---
>> hw/input/pckbd.c | 1 +
It seems we have other potential cases:
$ git grep -L 'set_bit(DEVICE_CATEGORY_INPUT' hw/input/*c
hw/input/adb.c
hw/input/hid.c
hw/input/lm832x.c
hw/input/milkymist-softusb.c
hw/input/pckbd.c
hw/input/pl050.c
hw/input/ps2.c
hw/input/pxa2xx_keypad.c
hw/input/stellaris_input.c
hw/input/tsc2005.c
hw/input/tsc210x.c
hw/input/virtio-input-hid.c
hw/input/virtio-input-host.c
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
>> index 3e66713b47..72e7d5f6cc 100644
>> --- a/hw/input/pckbd.c
>> +++ b/hw/input/pckbd.c
>> @@ -574,6 +574,7 @@ static void i8042_class_initfn(ObjectClass *klass, void *data)
>>
>> dc->realize = i8042_realizefn;
>> dc->vmsd = &vmstate_kbd_isa;
>> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>> }
>>
>> static const TypeInfo i8042_info = {
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] hw: input: set category of the i8042 device
2019-01-25 16:44 ` Philippe Mathieu-Daudé
@ 2019-01-25 18:00 ` ksourav
2019-01-25 19:47 ` Michael S. Tsirkin
2019-01-28 8:14 ` Thomas Huth
1 sibling, 1 reply; 8+ messages in thread
From: ksourav @ 2019-01-25 18:00 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Thomas Huth, qemu-trivial, pbonzini, QEMU Developers, mst
On Fri, Jan 25, 2019 at 10:14 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> On 1/25/19 4:24 PM, Thomas Huth wrote:
> > On 2019-01-25 16:14, kumar sourav wrote:
> >> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT
> >> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
> >>
> >> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> >> ---
> >> hw/input/pckbd.c | 1 +
>
> It seems we have other potential cases:
>
> $ git grep -L 'set_bit(DEVICE_CATEGORY_INPUT' hw/input/*c
> hw/input/adb.c
> hw/input/hid.c
> hw/input/lm832x.c
> hw/input/milkymist-softusb.c
> hw/input/pckbd.c
> hw/input/pl050.c
> hw/input/ps2.c
> hw/input/pxa2xx_keypad.c
> hw/input/stellaris_input.c
> hw/input/tsc2005.c
> hw/input/tsc210x.c
> hw/input/virtio-input-hid.c
> hw/input/virtio-input-host.c
>
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
> >> index 3e66713b47..72e7d5f6cc 100644
> >> --- a/hw/input/pckbd.c
> >> +++ b/hw/input/pckbd.c
> >> @@ -574,6 +574,7 @@ static void i8042_class_initfn(ObjectClass *klass, void *data)
> >>
> >> dc->realize = i8042_realizefn;
> >> dc->vmsd = &vmstate_kbd_isa;
> >> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> >> }
> >>
> >> static const TypeInfo i8042_info = {
> >>
> >
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
Ok I will add device categories for these devices too. Should I send
the changes in one patch for all these devices/files ?
Or should I send it separately - one patch per device/file ?
Thanks & Regards
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] hw: input: set category of the i8042 device
2019-01-25 18:00 ` ksourav
@ 2019-01-25 19:47 ` Michael S. Tsirkin
0 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2019-01-25 19:47 UTC (permalink / raw)
To: ksourav
Cc: Philippe Mathieu-Daudé,
Thomas Huth, qemu-trivial, pbonzini, QEMU Developers
On Fri, Jan 25, 2019 at 11:30:10PM +0530, ksourav wrote:
> On Fri, Jan 25, 2019 at 10:14 PM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
> >
> > On 1/25/19 4:24 PM, Thomas Huth wrote:
> > > On 2019-01-25 16:14, kumar sourav wrote:
> > >> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT
> > >> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
> > >>
> > >> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> > >> ---
> > >> hw/input/pckbd.c | 1 +
> >
> > It seems we have other potential cases:
> >
> > $ git grep -L 'set_bit(DEVICE_CATEGORY_INPUT' hw/input/*c
> > hw/input/adb.c
> > hw/input/hid.c
> > hw/input/lm832x.c
> > hw/input/milkymist-softusb.c
> > hw/input/pckbd.c
> > hw/input/pl050.c
> > hw/input/ps2.c
> > hw/input/pxa2xx_keypad.c
> > hw/input/stellaris_input.c
> > hw/input/tsc2005.c
> > hw/input/tsc210x.c
> > hw/input/virtio-input-hid.c
> > hw/input/virtio-input-host.c
> >
> > >> 1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
> > >> index 3e66713b47..72e7d5f6cc 100644
> > >> --- a/hw/input/pckbd.c
> > >> +++ b/hw/input/pckbd.c
> > >> @@ -574,6 +574,7 @@ static void i8042_class_initfn(ObjectClass *klass, void *data)
> > >>
> > >> dc->realize = i8042_realizefn;
> > >> dc->vmsd = &vmstate_kbd_isa;
> > >> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> > >> }
> > >>
> > >> static const TypeInfo i8042_info = {
> > >>
> > >
> > > Reviewed-by: Thomas Huth <thuth@redhat.com>
> >
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> >
> Ok I will add device categories for these devices too. Should I send
> the changes in one patch for all these devices/files ?
> Or should I send it separately - one patch per device/file ?
>
> Thanks & Regards
Either is fine. One patch will be merged faster :)
--
MST
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] hw: input: set category of the i8042 device
2019-01-25 16:44 ` Philippe Mathieu-Daudé
2019-01-25 18:00 ` ksourav
@ 2019-01-28 8:14 ` Thomas Huth
1 sibling, 0 replies; 8+ messages in thread
From: Thomas Huth @ 2019-01-28 8:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, kumar sourav, qemu-trivial
Cc: pbonzini, qemu-devel, mst
On 2019-01-25 17:44, Philippe Mathieu-Daudé wrote:
> On 1/25/19 4:24 PM, Thomas Huth wrote:
>> On 2019-01-25 16:14, kumar sourav wrote:
>>> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT
>>> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>>>
>>> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
>>> ---
>>> hw/input/pckbd.c | 1 +
>
> It seems we have other potential cases:
>
> $ git grep -L 'set_bit(DEVICE_CATEGORY_INPUT' hw/input/*c
> hw/input/adb.c
> hw/input/hid.c
> hw/input/lm832x.c
> hw/input/milkymist-softusb.c
> hw/input/pckbd.c
> hw/input/pl050.c
> hw/input/ps2.c
> hw/input/pxa2xx_keypad.c
> hw/input/stellaris_input.c
> hw/input/tsc2005.c
> hw/input/tsc210x.c
> hw/input/virtio-input-hid.c
> hw/input/virtio-input-host.c
Note that some of these are not even "qomified" yet (e.g. tsc2005),
others are not creatable by the user (pl050) as far as I can see, so it
does not make much sense to set a category for these devices yet.
Thomas
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] hw: input: set category of the i8042 device
2019-01-25 15:14 [Qemu-devel] [PATCH] hw: input: set category of the i8042 device kumar sourav
2019-01-25 15:24 ` Thomas Huth
@ 2019-01-25 19:46 ` Michael S. Tsirkin
2019-01-30 9:19 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2019-01-25 19:46 UTC (permalink / raw)
To: kumar sourav; +Cc: qemu-trivial, pbonzini, qemu-devel, thuth
On Fri, Jan 25, 2019 at 08:44:40PM +0530, kumar sourav wrote:
> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
who's merging this? Paolo?
> ---
> hw/input/pckbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
> index 3e66713b47..72e7d5f6cc 100644
> --- a/hw/input/pckbd.c
> +++ b/hw/input/pckbd.c
> @@ -574,6 +574,7 @@ static void i8042_class_initfn(ObjectClass *klass, void *data)
>
> dc->realize = i8042_realizefn;
> dc->vmsd = &vmstate_kbd_isa;
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo i8042_info = {
> --
> 2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: input: set category of the i8042 device
2019-01-25 15:14 [Qemu-devel] [PATCH] hw: input: set category of the i8042 device kumar sourav
2019-01-25 15:24 ` Thomas Huth
2019-01-25 19:46 ` Michael S. Tsirkin
@ 2019-01-30 9:19 ` Laurent Vivier
2 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2019-01-30 9:19 UTC (permalink / raw)
To: kumar sourav, qemu-trivial; +Cc: pbonzini, thuth, qemu-devel, mst
On 25/01/2019 16:14, kumar sourav wrote:
> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> ---
> hw/input/pckbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
> index 3e66713b47..72e7d5f6cc 100644
> --- a/hw/input/pckbd.c
> +++ b/hw/input/pckbd.c
> @@ -574,6 +574,7 @@ static void i8042_class_initfn(ObjectClass *klass, void *data)
>
> dc->realize = i8042_realizefn;
> dc->vmsd = &vmstate_kbd_isa;
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo i8042_info = {
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-01-30 9:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 15:14 [Qemu-devel] [PATCH] hw: input: set category of the i8042 device kumar sourav
2019-01-25 15:24 ` Thomas Huth
2019-01-25 16:44 ` Philippe Mathieu-Daudé
2019-01-25 18:00 ` ksourav
2019-01-25 19:47 ` Michael S. Tsirkin
2019-01-28 8:14 ` Thomas Huth
2019-01-25 19:46 ` Michael S. Tsirkin
2019-01-30 9:19 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.