* `all_video.mod` missing loading `grub.cfg` generated by grub-pc in GRUB payload (coreboot)
@ 2017-04-15 10:25 Paul Menzel
2017-04-15 11:22 ` Andrei Borzenkov
0 siblings, 1 reply; 14+ messages in thread
From: Paul Menzel @ 2017-04-15 10:25 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]
Dear GRUB folks,
When using GRUB as a coreboot payload, that means passing `--with-
platform=coreboot` to configure, and configuring it to load the GRUB
configuration file from disk, `/boot/grub/grub.cfg` in Debian 8.7
(Jessie/stable) and 9 (Stretch/testing), generated by GRUB shipped by
the GNU/Linux distribution, I get a warning about the missing module
`all_video.mod`, and the enter key has to be pressed to continue
booting.
The function `load_video` in `/boot/grub/grub.cfg` is causing this.
```
function load_video {
if [ x$feature_all_video_module = xy ]; then
insmod all_video
else
insmod efi_gop
insmod efi_uga
insmod ieee1275_fb
insmod vbe
insmod vga
insmod video_bochs
insmod video_cirrus
fi
}
```
This get added by `update-grub` from `/etc/grub.d/00_header`.
```
cat <<EOF
function load_video {
EOF
if [ -n "${GRUB_VIDEO_BACKEND}" ]; then
cat <<EOF
insmod ${GRUB_VIDEO_BACKEND}
EOF
else
# If all_video.mod isn't available load all modules available
# with versions prior to introduction of all_video.mod
cat <<EOF
if [ x\$feature_all_video_module = xy ]; then
insmod all_video
else
insmod efi_gop
insmod efi_uga
insmod ieee1275_fb
insmod vbe
insmod vga
insmod video_bochs
insmod video_cirrus
fi
EOF
fi
```
Do you know of a way to make that compatible with grub-pc and GRUB
payload? That’s useful, as the hard disk can be connected to a system
running coreboot with SeaBIOS or GRUB as a payload, or a proprietary
vendor firmware.
Kind regards,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: `all_video.mod` missing loading `grub.cfg` generated by grub-pc in GRUB payload (coreboot)
2017-04-15 10:25 `all_video.mod` missing loading `grub.cfg` generated by grub-pc in GRUB payload (coreboot) Paul Menzel
@ 2017-04-15 11:22 ` Andrei Borzenkov
2017-04-16 19:31 ` Paul Menzel
0 siblings, 1 reply; 14+ messages in thread
From: Andrei Borzenkov @ 2017-04-15 11:22 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1.1: Type: text/plain, Size: 649 bytes --]
15.04.2017 13:25, Paul Menzel пишет:
> Dear GRUB folks,
>
>
> When using GRUB as a coreboot payload, that means passing `--with-
> platform=coreboot` to configure, and configuring it to load the GRUB
> configuration file from disk, `/boot/grub/grub.cfg` in Debian 8.7
> (Jessie/stable) and 9 (Stretch/testing), generated by GRUB shipped by
> the GNU/Linux distribution, I get a warning about the missing module
> `all_video.mod`, and the enter key has to be pressed to continue
> booting.
>
...
>
> Do you know of a way to make that compatible with grub-pc and GRUB
> payload?
Include all_video in coreboot payload?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: `all_video.mod` missing loading `grub.cfg` generated by grub-pc in GRUB payload (coreboot)
2017-04-15 11:22 ` Andrei Borzenkov
@ 2017-04-16 19:31 ` Paul Menzel
2017-04-16 21:45 ` [PATCH] Makefile.am: Add `all_video` to `default_payload.elf` Paul Menzel
0 siblings, 1 reply; 14+ messages in thread
From: Paul Menzel @ 2017-04-16 19:31 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
Dear Andrei,
Am Samstag, den 15.04.2017, 14:22 +0300 schrieb Andrei Borzenkov:
> 15.04.2017 13:25, Paul Menzel пишет:
> > When using GRUB as a coreboot payload, that means passing `--with-
> > platform=coreboot` to configure, and configuring it to load the GRUB
> > configuration file from disk, `/boot/grub/grub.cfg` in Debian 8.7
> > (Jessie/stable) and 9 (Stretch/testing), generated by GRUB shipped by
> > the GNU/Linux distribution, I get a warning about the missing module
> > `all_video.mod`, and the enter key has to be pressed to continue
> > booting.
>
> ...
>
> > Do you know of a way to make that compatible with grub-pc and GRUB
> > payload?
>
> Include all_video in coreboot payload?
Thank you. That indeed works. I thought, it wouldn’t be available for
that platform, and it is. I’ll send a patch to add it by default.
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] Makefile.am: Add `all_video` to `default_payload.elf`
2017-04-16 19:31 ` Paul Menzel
@ 2017-04-16 21:45 ` Paul Menzel
2018-03-21 8:28 ` [PATCH v2] " Paul Menzel
0 siblings, 1 reply; 14+ messages in thread
From: Paul Menzel @ 2017-04-16 21:45 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 1966 bytes --]
Date: Sun, 16 Apr 2017 21:02:58 +0200
The module `all_video` is used in `util/grub.d/00_header.in`, and
included for grub-pc by default.
To make it easier to load such a GRUB configuration from disk for a GRUB
coreboot payload, add this module also to `default_payload.elf` by
default. That avoids aa missing module error by GRUB, forcing the user
to hit enter during the start process.
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 7795baeb6..80a787e57 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -424,7 +424,7 @@ bootcheck: $(BOOTCHECKS)
if COND_i386_coreboot
default_payload.elf: grub-mkstandalone grub-mkimage FORCE
test -f $@ && rm $@ || true
- pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
+ pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu all_video $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
endif
endif
--
2.11.0
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2] Makefile.am: Add `all_video` to `default_payload.elf`
2017-04-16 21:45 ` [PATCH] Makefile.am: Add `all_video` to `default_payload.elf` Paul Menzel
@ 2018-03-21 8:28 ` Paul Menzel
2018-04-23 19:45 ` Paul Menzel
0 siblings, 1 reply; 14+ messages in thread
From: Paul Menzel @ 2018-03-21 8:28 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 2209 bytes --]
From a199bc1f64e33aa942b23fe6d16670cc6002bb6c Mon Sep 17 00:00:00 2001
From: Paul Menzel <paulepanter@users.sourceforge.net>
Date: Sun, 16 Apr 2017 21:02:58 +0200
Subject: [PATCH] Makefile.am: Add `all_video` to default_payload.elf
The module `all_video` is used in `util/grub.d/00_header.in`, and
included for grub-pc by default.
To make it easier to load such a GRUB configuration from disk with a GRUB
coreboot payload, add this module also to `default_payload.elf` by
default. That avoids a missing module error by GRUB, forcing the user to
hit enter during the start process.
---
v2: Resend and fix typo in commit message.
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 7795baeb6..80a787e57 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -424,7 +424,7 @@ bootcheck: $(BOOTCHECKS)
if COND_i386_coreboot
default_payload.elf: grub-mkstandalone grub-mkimage FORCE
test -f $@ && rm $@ || true
- pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
+ pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu all_video $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
endif
endif
--
2.16.2
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2] Makefile.am: Add `all_video` to `default_payload.elf`
2018-03-21 8:28 ` [PATCH v2] " Paul Menzel
@ 2018-04-23 19:45 ` Paul Menzel
2018-04-24 10:20 ` Daniel Kiper
0 siblings, 1 reply; 14+ messages in thread
From: Paul Menzel @ 2018-04-23 19:45 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 2416 bytes --]
Dear GRUB folks,
Am Mittwoch, den 21.03.2018, 09:28 +0100 schrieb Paul Menzel:
> From a199bc1f64e33aa942b23fe6d16670cc6002bb6c Mon Sep 17 00:00:00 2001
> From: Paul Menzel <paulepanter@users.sourceforge.net>
> Date: Sun, 16 Apr 2017 21:02:58 +0200
> Subject: [PATCH] Makefile.am: Add `all_video` to default_payload.elf
>
> The module `all_video` is used in `util/grub.d/00_header.in`, and
> included for grub-pc by default.
>
> To make it easier to load such a GRUB configuration from disk with a GRUB
> coreboot payload, add this module also to `default_payload.elf` by
> default. That avoids a missing module error by GRUB, forcing the user to
> hit enter during the start process.
> ---
> v2: Resend and fix typo in commit message.
>
> Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 7795baeb6..80a787e57 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -424,7 +424,7 @@ bootcheck: $(BOOTCHECKS)
> if COND_i386_coreboot
> default_payload.elf: grub-mkstandalone grub-mkimage FORCE
> test -f $@ && rm $@ || true
> - pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
> + pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu all_video $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
> endif
>
> endif
Can you please commit this to the master branch?
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] Makefile.am: Add `all_video` to `default_payload.elf`
2018-04-23 19:45 ` Paul Menzel
@ 2018-04-24 10:20 ` Daniel Kiper
2018-08-09 6:20 ` [PATCH v3] " Paul Menzel
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Kiper @ 2018-04-24 10:20 UTC (permalink / raw)
To: paulepanter; +Cc: grub-devel, dkiper
On Mon, Apr 23, 2018 at 09:45:02PM +0200, Paul Menzel wrote:
> Dear GRUB folks,
>
>
> Am Mittwoch, den 21.03.2018, 09:28 +0100 schrieb Paul Menzel:
> > From a199bc1f64e33aa942b23fe6d16670cc6002bb6c Mon Sep 17 00:00:00 2001
> > From: Paul Menzel <paulepanter@users.sourceforge.net>
> > Date: Sun, 16 Apr 2017 21:02:58 +0200
> > Subject: [PATCH] Makefile.am: Add `all_video` to default_payload.elf
> >
> > The module `all_video` is used in `util/grub.d/00_header.in`, and
> > included for grub-pc by default.
> >
> > To make it easier to load such a GRUB configuration from disk with a GRUB
> > coreboot payload, add this module also to `default_payload.elf` by
> > default. That avoids a missing module error by GRUB, forcing the user to
> > hit enter during the start process.
> > ---
> > v2: Resend and fix typo in commit message.
> >
> > Makefile.am | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index 7795baeb6..80a787e57 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -424,7 +424,7 @@ bootcheck: $(BOOTCHECKS)
> > if COND_i386_coreboot
> > default_payload.elf: grub-mkstandalone grub-mkimage FORCE
> > test -f $@ && rm $@ || true
> > - pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
> > + pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu all_video $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
> > endif
> >
> > endif
>
> Can you please commit this to the master branch?
LGTM. Could you rebase and repost it?
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`
2018-04-24 10:20 ` Daniel Kiper
@ 2018-08-09 6:20 ` Paul Menzel
2018-09-06 12:58 ` Daniel Kiper
0 siblings, 1 reply; 14+ messages in thread
From: Paul Menzel @ 2018-08-09 6:20 UTC (permalink / raw)
To: grub-devel; +Cc: Daniel Kiper
[-- Attachment #1: Type: text/plain, Size: 2052 bytes --]
Date: Sun, 16 Apr 2017 21:02:58 +0200
The module `all_video` is used in `util/grub.d/00_header.in`, and
included for grub-pc by default.
To make it easier to load such a GRUB configuration from disk with a
GRUB built as a coreboot payload, add this module also to
`default_payload.elf` by default. That avoids a missing module error by
GRUB, forcing the user to hit enter during the start process.
error: file `/boot/grub/i386-coreboot/all_video.mod' not found.
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 7795baeb6..80a787e57 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -424,7 +424,7 @@ bootcheck: $(BOOTCHECKS)
if COND_i386_coreboot
default_payload.elf: grub-mkstandalone grub-mkimage FORCE
test -f $@ && rm $@ || true
- pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
+ pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu all_video $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
endif
endif
--
2.18.0
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`
2018-08-09 6:20 ` [PATCH v3] " Paul Menzel
@ 2018-09-06 12:58 ` Daniel Kiper
2018-09-06 13:07 ` Vladimir 'phcoder' Serbinenko
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Kiper @ 2018-09-06 12:58 UTC (permalink / raw)
To: Paul Menzel; +Cc: grub-devel, Daniel Kiper
On Thu, Aug 09, 2018 at 08:20:07AM +0200, Paul Menzel wrote:
> Date: Sun, 16 Apr 2017 21:02:58 +0200
>
> The module `all_video` is used in `util/grub.d/00_header.in`, and
> included for grub-pc by default.
>
> To make it easier to load such a GRUB configuration from disk with a
> GRUB built as a coreboot payload, add this module also to
> `default_payload.elf` by default. That avoids a missing module error by
> GRUB, forcing the user to hit enter during the start process.
>
> error: file `/boot/grub/i386-coreboot/all_video.mod' not found.
>
Lack of of SOB... :-((( Otherwise LGTM. If I get your SOB in a reply
to this email or something like that then I will get this patch...
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`
2018-09-06 12:58 ` Daniel Kiper
@ 2018-09-06 13:07 ` Vladimir 'phcoder' Serbinenko
2018-09-06 13:21 ` Daniel Kiper
0 siblings, 1 reply; 14+ messages in thread
From: Vladimir 'phcoder' Serbinenko @ 2018-09-06 13:07 UTC (permalink / raw)
To: The development of GNU GRUB; +Cc: Daniel Kiper, Paul Menzel
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
Unfortunately this pulls in some problematic graphics drivers that
shouldn't be in default payload
On Thu, 6 Sep 2018, 14:59 Daniel Kiper, <dkiper@net-space.pl> wrote:
> On Thu, Aug 09, 2018 at 08:20:07AM +0200, Paul Menzel wrote:
> > Date: Sun, 16 Apr 2017 21:02:58 +0200
> >
> > The module `all_video` is used in `util/grub.d/00_header.in`, and
> > included for grub-pc by default.
> >
> > To make it easier to load such a GRUB configuration from disk with a
> > GRUB built as a coreboot payload, add this module also to
> > `default_payload.elf` by default. That avoids a missing module error by
> > GRUB, forcing the user to hit enter during the start process.
> >
> > error: file `/boot/grub/i386-coreboot/all_video.mod' not found.
> >
>
> Lack of of SOB... :-((( Otherwise LGTM. If I get your SOB in a reply
> to this email or something like that then I will get this patch...
>
> Daniel
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: Type: text/html, Size: 1614 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`
2018-09-06 13:07 ` Vladimir 'phcoder' Serbinenko
@ 2018-09-06 13:21 ` Daniel Kiper
2018-09-19 16:12 ` Daniel Kiper
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Kiper @ 2018-09-06 13:21 UTC (permalink / raw)
To: Vladimir 'phcoder' Serbinenko
Cc: The development of GNU GRUB, Paul Menzel, Daniel Kiper
On Thu, Sep 06, 2018 at 03:07:57PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Unfortunately this pulls in some problematic graphics drivers that
> shouldn't be in default payload
Which ones?
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`
2018-09-06 13:21 ` Daniel Kiper
@ 2018-09-19 16:12 ` Daniel Kiper
2018-09-27 16:52 ` Daniel Kiper
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Kiper @ 2018-09-19 16:12 UTC (permalink / raw)
To: phcoder; +Cc: dkiper, The development of GNU GRUB, Paul Menzel
On Thu, Sep 06, 2018 at 03:21:24PM +0200, Daniel Kiper wrote:
> On Thu, Sep 06, 2018 at 03:07:57PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> > Unfortunately this pulls in some problematic graphics drivers that
> > shouldn't be in default payload
>
> Which ones?
I have vbe, vga, video_bochs and video_cirrus for i386-pc and
efi_gop, efi_uga, video_bochs and video_cirrus for x86_64-efi.
I do not see anything scary. Do you?
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`
2018-09-19 16:12 ` Daniel Kiper
@ 2018-09-27 16:52 ` Daniel Kiper
2018-10-01 9:00 ` Paul Menzel
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Kiper @ 2018-09-27 16:52 UTC (permalink / raw)
To: The development of GNU GRUB; +Cc: phcoder, Paul Menzel, dkiper
On Wed, Sep 19, 2018 at 06:12:18PM +0200, Daniel Kiper wrote:
> On Thu, Sep 06, 2018 at 03:21:24PM +0200, Daniel Kiper wrote:
> > On Thu, Sep 06, 2018 at 03:07:57PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> > > Unfortunately this pulls in some problematic graphics drivers that
> > > shouldn't be in default payload
> >
> > Which ones?
>
> I have vbe, vga, video_bochs and video_cirrus for i386-pc and
> efi_gop, efi_uga, video_bochs and video_cirrus for x86_64-efi.
> I do not see anything scary. Do you?
If I get SOB for the patch, Paul?, and there are no objections in a week
or so I will apply it. In the worst case we can revert it.
Daniel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`
2018-09-27 16:52 ` Daniel Kiper
@ 2018-10-01 9:00 ` Paul Menzel
0 siblings, 0 replies; 14+ messages in thread
From: Paul Menzel @ 2018-10-01 9:00 UTC (permalink / raw)
To: Daniel Kiper; +Cc: grub-devel, Vladimir 'phcoder' Serbinenko
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
Dear Daniel,
On 09/27/18 18:52, Daniel Kiper wrote:
> On Wed, Sep 19, 2018 at 06:12:18PM +0200, Daniel Kiper wrote:
>> On Thu, Sep 06, 2018 at 03:21:24PM +0200, Daniel Kiper wrote:
>>> On Thu, Sep 06, 2018 at 03:07:57PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>>>> Unfortunately this pulls in some problematic graphics drivers that
>>>> shouldn't be in default payload
>>>
>>> Which ones?
>>
>> I have vbe, vga, video_bochs and video_cirrus for i386-pc and
>> efi_gop, efi_uga, video_bochs and video_cirrus for x86_64-efi.
>> I do not see anything scary. Do you?
It looks like there are no video modes displayed when using GRUB
as a coreboot payload.
> If I get SOB for the patch, Paul?, and there are no objections in a week
> or so I will apply it. In the worst case we can revert it.
I’ll try to reproduce my issue with QEMU, and post the
instructions here.
Kind regards,
Paul
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-10-01 9:01 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-15 10:25 `all_video.mod` missing loading `grub.cfg` generated by grub-pc in GRUB payload (coreboot) Paul Menzel
2017-04-15 11:22 ` Andrei Borzenkov
2017-04-16 19:31 ` Paul Menzel
2017-04-16 21:45 ` [PATCH] Makefile.am: Add `all_video` to `default_payload.elf` Paul Menzel
2018-03-21 8:28 ` [PATCH v2] " Paul Menzel
2018-04-23 19:45 ` Paul Menzel
2018-04-24 10:20 ` Daniel Kiper
2018-08-09 6:20 ` [PATCH v3] " Paul Menzel
2018-09-06 12:58 ` Daniel Kiper
2018-09-06 13:07 ` Vladimir 'phcoder' Serbinenko
2018-09-06 13:21 ` Daniel Kiper
2018-09-19 16:12 ` Daniel Kiper
2018-09-27 16:52 ` Daniel Kiper
2018-10-01 9:00 ` Paul Menzel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.