From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
lee.jones@linaro.org, linux-omap@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [RFC PATCH v2 2/9] dt-bindings: ti-lmu: Remove LM3697
Date: Wed, 3 Oct 2018 07:24:23 -0500 [thread overview]
Message-ID: <fef2c612-ac35-126e-669e-335fb3075f64@ti.com> (raw)
In-Reply-To: <20181002072827.GA19677@amd>
Hello
On 10/02/2018 02:28 AM, Pavel Machek wrote:
> On Fri 2018-09-28 13:29:47, Dan Murphy wrote:
>> Remove support for the LM3697 LED device
>> from the ti-lmu. The LM3697 will be supported
>> via a stand alone LED driver.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>
> NAK, for reasons I explained before. Please add it to the patch so
> that it does not get applied by mistake. Ouch and AFAICT Rob was not
> happy with this either.
>
> Yes, you are creating new drivers, ok; but that does _not_ mean you
> should create new binding.
I am copying my comment here on the review of this original binding for
records
I found the review or at least the reference for the ti-lmu.txt binding.
https://lore.kernel.org/patchwork/patch/764180/
Does not appear that the binding was sent to the device tree mail list.
(Maybe that email list did not exist in Feb 2017).
Especially with the amount of change that is being submitted in the
newer patchsets.
<new content>
Having found this submission and no comments on the review I would think
we need to take an exception on these bindings.
Dan
> Pavel
>
--
------------------
Dan Murphy
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: <robh+dt@kernel.org>, <jacek.anaszewski@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lee.jones@linaro.org>, <linux-omap@vger.kernel.org>,
<linux-leds@vger.kernel.org>
Subject: Re: [RFC PATCH v2 2/9] dt-bindings: ti-lmu: Remove LM3697
Date: Wed, 3 Oct 2018 07:24:23 -0500 [thread overview]
Message-ID: <fef2c612-ac35-126e-669e-335fb3075f64@ti.com> (raw)
In-Reply-To: <20181002072827.GA19677@amd>
Hello
On 10/02/2018 02:28 AM, Pavel Machek wrote:
> On Fri 2018-09-28 13:29:47, Dan Murphy wrote:
>> Remove support for the LM3697 LED device
>> from the ti-lmu. The LM3697 will be supported
>> via a stand alone LED driver.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>
> NAK, for reasons I explained before. Please add it to the patch so
> that it does not get applied by mistake. Ouch and AFAICT Rob was not
> happy with this either.
>
> Yes, you are creating new drivers, ok; but that does _not_ mean you
> should create new binding.
I am copying my comment here on the review of this original binding for
records
I found the review or at least the reference for the ti-lmu.txt binding.
https://lore.kernel.org/patchwork/patch/764180/
Does not appear that the binding was sent to the device tree mail list.
(Maybe that email list did not exist in Feb 2017).
Especially with the amount of change that is being submitted in the
newer patchsets.
<new content>
Having found this submission and no comments on the review I would think
we need to take an exception on these bindings.
Dan
> Pavel
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2018-10-03 12:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 18:29 [RFC PATCH v2 0/9] TI LMU and Dedicated Drivers Dan Murphy
2018-09-28 18:29 ` Dan Murphy
2018-09-28 18:29 ` [RFC PATCH v2 1/9] leds: add TI LMU backlight driver Dan Murphy
2018-09-28 18:29 ` Dan Murphy
2018-10-02 7:56 ` Pavel Machek
2018-10-02 12:32 ` Dan Murphy
2018-10-02 12:32 ` Dan Murphy
2018-10-02 18:52 ` Jacek Anaszewski
2018-10-02 22:07 ` Pavel Machek
2018-10-03 12:00 ` Dan Murphy
2018-10-03 12:00 ` Dan Murphy
2018-10-03 12:10 ` Dan Murphy
2018-10-03 12:10 ` Dan Murphy
2018-09-28 18:29 ` [RFC PATCH v2 2/9] dt-bindings: ti-lmu: Remove LM3697 Dan Murphy
2018-09-28 18:29 ` Dan Murphy
2018-10-02 7:28 ` Pavel Machek
2018-10-03 12:24 ` Dan Murphy [this message]
2018-10-03 12:24 ` Dan Murphy
2018-10-03 13:01 ` Pavel Machek
2018-10-03 20:46 ` Jacek Anaszewski
2018-10-03 20:46 ` Jacek Anaszewski
2018-10-04 13:26 ` Dan Murphy
2018-10-04 13:26 ` Dan Murphy
2018-09-28 18:29 ` [RFC PATCH v2 3/9] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2018-09-28 18:29 ` Dan Murphy
2018-09-28 18:29 ` [RFC PATCH v2 4/9] dt-bindings: leds: Add bindings for lm3697 driver Dan Murphy
2018-09-28 18:29 ` Dan Murphy
2018-09-28 18:29 ` [RFC PATCH v2 5/9] leds: lm3697: Introduce the " Dan Murphy
2018-09-28 18:29 ` Dan Murphy
2018-09-28 18:29 ` [RFC PATCH v2 6/9] dt-bindings: leds: Add support for the LM3633 Dan Murphy
2018-09-28 18:29 ` Dan Murphy
2018-09-28 18:29 ` [RFC PATCH v2 7/9] leds: lm3633: Introduce the lm3633 driver Dan Murphy
2018-09-28 18:29 ` Dan Murphy
2018-09-28 18:29 ` [RFC PATCH v2 8/9] dt-bindings: leds: Add the LM3632 LED dt binding Dan Murphy
2018-09-28 18:29 ` Dan Murphy
2018-09-28 18:29 ` [RFC PATCH v2 9/9] leds: lm3632: Introduce the TI LM3632 driver Dan Murphy
2018-09-28 18:29 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fef2c612-ac35-126e-669e-335fb3075f64@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.