[PATCH v2] linux-omap_2.6.39: remove patch that prevented board from resuming from suspend.

[PATCH v2] linux-omap_2.6.39: remove patch that prevented board from resuming from suspend.

[Tasslehoff Kjappfot]

From: Tasslehoff Kjappfot tasskjapp@gmail.com>

Running on a board similar to Beagleboard C3 (but without NAND) I could not resume from suspend with the patch.
The console output when suspending was as expected, but neither console input nor a timer would wake the board.
Without the patch, everything works as it should.

Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>
---
 recipes/linux/linux-omap_2.6.39.bb |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/recipes/linux/linux-omap_2.6.39.bb b/recipes/linux/linux-omap_2.6.39.bb
index 8370e58..3880aa1 100644
--- a/recipes/linux/linux-omap_2.6.39.bb
+++ b/recipes/linux/linux-omap_2.6.39.bb
@@ -27,7 +27,6 @@ SRC_URI_append = " \
            file://sakoman/0010-Revert-omap2_mcspi-Flush-posted-writes.patch \
            file://sakoman/0011-Revert-omap_hsmmc-improve-interrupt-synchronisation.patch \
            file://sakoman/0012-Don-t-turn-SDIO-cards-off-to-save-power.-Doing-so-wi.patch \
-           file://sakoman/0013-Enable-the-use-of-SDIO-card-interrupts.patch \
            file://sakoman/0014-soc-codecs-Enable-audio-capture-by-default-for-twl40.patch \
            file://sakoman/0015-soc-codecs-twl4030-Turn-on-mic-bias-by-default.patch \
            file://sakoman/0016-RTC-add-support-for-backup-battery-recharge.patch \
-- 
1.7.4.4

Re: [PATCH v2] linux-omap_2.6.39: remove patch that prevented board from resuming from suspend.

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2341 bytes --]

Dear Tasslehoff,


Am Mittwoch, den 31.08.2011, 19:41 +0200 schrieb Tasslehoff Kjappfot:
> From: Tasslehoff Kjappfot tasskjapp@gmail.com>
> 
> Running on a board similar to Beagleboard C3 (but without NAND) I could not resume from suspend with the patch.
> The console output when suspending was as expected, but neither console input nor a timer would wake the board.
> Without the patch, everything works as it should.
> 
> Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>

Tasslehoff thank you for sending this iteration (no full stop at the end
of the summary please next time) and thank you Koen for pushing this
[1].

> ---

Next time, please add below the »---« what you changed in v2 or other
iterations.

>  recipes/linux/linux-omap_2.6.39.bb |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/linux/linux-omap_2.6.39.bb b/recipes/linux/linux-omap_2.6.39.bb
> index 8370e58..3880aa1 100644
> --- a/recipes/linux/linux-omap_2.6.39.bb
> +++ b/recipes/linux/linux-omap_2.6.39.bb
> @@ -27,7 +27,6 @@ SRC_URI_append = " \
>             file://sakoman/0010-Revert-omap2_mcspi-Flush-posted-writes.patch \
>             file://sakoman/0011-Revert-omap_hsmmc-improve-interrupt-synchronisation.patch \
>             file://sakoman/0012-Don-t-turn-SDIO-cards-off-to-save-power.-Doing-so-wi.patch \
> -           file://sakoman/0013-Enable-the-use-of-SDIO-card-interrupts.patch \
>             file://sakoman/0014-soc-codecs-Enable-audio-capture-by-default-for-twl40.patch \
>             file://sakoman/0015-soc-codecs-twl4030-Turn-on-mic-bias-by-default.patch \
>             file://sakoman/0016-RTC-add-support-for-backup-battery-recharge.patch \

Koen, do you know why that patch breaks resume? I guess when applying
those you had tested suspend and resume and it worked for you. Maybe we
should contact the patch author [2]?

Additionally should the patch file be removed from the tree too as no
other recipe is using it?


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=8deb9697d85388af845e1dda193d9149f55b07f5
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/linux/linux-omap-2.6.39/sakoman/0013-Enable-the-use-of-SDIO-card-interrupts.patch?id=8deb9697d85388af845e1dda193d9149f55b07f5

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] linux-omap_2.6.39: remove patch that prevented board from resuming from suspend.

[Paul Eggleton]

On Thursday 01 September 2011 09:48:52 Paul Menzel wrote:
> (no full stop at the end of the summary please next time)

I know you're trying to ensure quality Paul, but this is pedantry to the nth 
degree. Really, we only need to ensure that patches are technically correct 
and adequately described in the commit message.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH v2] linux-omap_2.6.39: remove patch that prevented board from resuming from suspend.

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

Am Donnerstag, den 01.09.2011, 10:02 +0100 schrieb Paul Eggleton:
> On Thursday 01 September 2011 09:48:52 Paul Menzel wrote:
> > (no full stop at the end of the summary please next time)
> 
> I know you're trying to ensure quality Paul, but this is pedantry to the nth 
> degree. Really, we only need to ensure that patches are technically correct 
> and adequately described in the commit message.

1. That is why I wrote »next time«.
2. And if I understand the last item in the Commit Patch Message
Guidelines [1] correctly

	- Avoid punctuation in the short log.

it is actually considered an error.


Thanks,

Paul


[1] http://openembedded.org/index.php/Commit_Patch_Message_Guidelineshttp://openembedded.org/index.php/Commit_Patch_Message_Guidelines

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] linux-omap_2.6.39: remove patch that prevented board from resuming from suspend.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 01-09-11 10:48, Paul Menzel schreef:
> Dear Tasslehoff,
> 
> 
> Am Mittwoch, den 31.08.2011, 19:41 +0200 schrieb Tasslehoff Kjappfot:
>> From: Tasslehoff Kjappfot tasskjapp@gmail.com>
>> 
>> Running on a board similar to Beagleboard C3 (but without NAND) I could
>> not resume from suspend with the patch. The console output when
>> suspending was as expected, but neither console input nor a timer would
>> wake the board. Without the patch, everything works as it should.
>> 
>> Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>
> 
> Tasslehoff thank you for sending this iteration (no full stop at the end 
> of the summary please next time) and thank you Koen for pushing this 
> [1].
> 
>> ---
> 
> Next time, please add below the »---« what you changed in v2 or other 
> iterations.
> 
>> recipes/linux/linux-omap_2.6.39.bb |    1 - 1 files changed, 0
>> insertions(+), 1 deletions(-)
>> 
>> diff --git a/recipes/linux/linux-omap_2.6.39.bb
>> b/recipes/linux/linux-omap_2.6.39.bb index 8370e58..3880aa1 100644 ---
>> a/recipes/linux/linux-omap_2.6.39.bb +++
>> b/recipes/linux/linux-omap_2.6.39.bb @@ -27,7 +27,6 @@ SRC_URI_append =
>> " \ file://sakoman/0010-Revert-omap2_mcspi-Flush-posted-writes.patch \ 
>> file://sakoman/0011-Revert-omap_hsmmc-improve-interrupt-synchronisation.patch
>> \ 
>> file://sakoman/0012-Don-t-turn-SDIO-cards-off-to-save-power.-Doing-so-wi.patch
>> \ -
>> file://sakoman/0013-Enable-the-use-of-SDIO-card-interrupts.patch \ 
>> file://sakoman/0014-soc-codecs-Enable-audio-capture-by-default-for-twl40.patch
>> \ 
>> file://sakoman/0015-soc-codecs-twl4030-Turn-on-mic-bias-by-default.patch
>> \ file://sakoman/0016-RTC-add-support-for-backup-battery-recharge.patch
>> \
> 
> Koen, do you know why that patch breaks resume? I guess when applying 
> those you had tested suspend and resume and it worked for you. Maybe we 
> should contact the patch author [2]?

I stopped testing suspend/resume when dynamic ticks become good enough to
use, which was a few years ago :)

On a more serious note, s/r had never worked on omap3 when using usb
devices, only recently it started working (.37-ish) on mainline kernels with
the right defconfig. So I was suprised that Tasslehoff reported it to work
at all!

But for omap2+: take a serious look at dyntick and cpuidle, it isn't hard to
make it idle to suspend like powerlevels without actually suspending.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOX1BxMkyGM64RGpERAuf0AKCwDXiPOkUSXLqwZfF+/SAhbOH8PgCfbIXl
1fpTUc9QpGodmuHGd7VsYW8=
=LgCa
-----END PGP SIGNATURE-----