Re: [Xen-devel] Re: [PATCH RFC] x86/acpi: don't ignore I/O APICs just because there's no local APIC

From: ebiederm@xmission.com (Eric W. Biederman)
To: "Nakajima\, Jun" <jun.nakajima@intel.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	Xen-devel <xen-devel@lists.xensource.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Keir Fraser <keir.fraser@eu.citrix.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>, Len Brown <lenb@kernel.org>
Subject: Re: [Xen-devel] Re: [PATCH RFC] x86/acpi: don't ignore I/O APICs just because there's no local APIC
Date: Sat, 20 Jun 2009 01:18:07 -0700	[thread overview]
Message-ID: <m163erpbcw.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <0B53E02A2965CE4F9ADB38B34501A3A188656507@orsmsx505.amr.corp.intel.com> (Jun Nakajima's message of "Fri\, 19 Jun 2009 16\:44\:24 -0700")

"Nakajima, Jun" <jun.nakajima@intel.com> writes:

> Jeremy Fitzhardinge wrote on Fri, 19 Jun 2009 at 12:58:14:
>
>>> 
>>> Which if dom0 is to be redundant/restartable seems to make the
>>> argument for AML living in Xen.
>>> 
>>> Xen has everything except the AML interpreter.
>>> 
>> 
>> I assume that putting AML into Xen has been considered, but I don't
>> anything about those deliberations.  Keir? Jun?
>> 
>
> Yes, it was one of the options years ago. We did not do that because Linux and Solaris (as dom0) already had the AML interpreter and it's overkill and redundant to have such a large component in the Xen hypervisor. Since the hypervisor does most of the power management (i.e. P, C, S-state, etc.) getting the info from dom0 today, we might want to reconsider the option. 

In my brief investigation it looks as if Xen having the AML
interpreter would considerably simplify the complexity of the
dom0 interface.

What I am certain of is that the current Xen dom0 irq interface exposes
implementation details (aka the vector number) that if continued will prevent
Xen from scaling to machines with large amounts of I/O.  As YH has recently
demonstrated.

That interface needs to be fixed.

I think the path to fixing it and getting linux kernel support is.
- Merge pass through device support for domU.
- Move all of the irq setup from dom0 into Xen, making dom0 interrupt
  handling exactly the same as domU.
- Move all of ACPI handling into Xen, in support of irq handling
  and power management.  Things Xen already claims are interesting
  problems.

At that point I don't know what is left but in the area that I am
knowledge, irq handling, will be complete.  The incestuousness of
the interface is removed and Xen and the linux kernel can keep those
same interfaces for the foreseeable future.

In summary.  

In support of the Xen grand vision of all domains being equal.  I
don't think linux should ever merge dom0 support.  I think domU
support should be expanded, and the dom0 requirements simplified
until there are no differences left.

Eric