gitweb: please show tags file history browsing

gitweb: please show tags file history browsing

[Tjernlund]

I would really like to see where the tags are when browsing
file or directory history in gitweb. Would that be possible?

 Jocke

Re: gitweb: please show tags file history browsing

[Jakub Narebski]

"Tjernlund" <tjernlund@tjernlund.se> writes:

> I would really like to see where the tags are when browsing
> file or directory history in gitweb. Would that be possible?

Hmmm... that is second such request...

While it probably be possible to show tags in 'history' view, it would
be not easy.  The problem is that 'history' view shows only commits
that touch specified file or directory, and tagged commits usually do
not touch those files (at least if one is using "bump version number"
commits to tag them).

So you would have: 
1. Design where to show those tags - they would be between shown
   commits.
2. Create code which shows some/all tags that are between commits in
   the presence of nonlinear history, without affecting performance
   too badly.

-- 
Jakub Narebski
Poland
ShadeHawk on #git

RE: gitweb: please show tags file history browsing

[Tjernlund]

> -----Original Message-----
> From: Jakub Narebski [mailto:jnareb@gmail.com]
> 
> "Tjernlund" <tjernlund@tjernlund.se> writes:
> 
> > I would really like to see where the tags are when browsing
> > file or directory history in gitweb. Would that be possible?
> 
> Hmmm... that is second such request...

:)

> 
> While it probably be possible to show tags in 'history' view, it would
> be not easy.  The problem is that 'history' view shows only commits
> that touch specified file or directory, and tagged commits usually do
> not touch those files (at least if one is using "bump version number"
> commits to tag them).
> 
> So you would have:
> 1. Design where to show those tags - they would be between shown
>    commits.
> 2. Create code which shows some/all tags that are between commits in
>    the presence of nonlinear history, without affecting performance
>    too badly.

Ah, that is too bad because I think it would really useful.
Image browsing a drivers history in the linux kernel. Then it would be
really nice to see what changes/bug fixes went into what release.

 Jocke

Re: gitweb: please show tags file history browsing

[Jakub Narebski]

On Sun, 12 Sep 2010, Tjernlund wrote:
> > -----Original Message-----
> > From: Jakub Narebski [mailto:jnareb@gmail.com]
> > 
> > "Tjernlund" <tjernlund@tjernlund.se> writes:
> > 
> > > I would really like to see where the tags are when browsing
> > > file or directory history in gitweb. Would that be possible?

> > While it probably be possible to show tags in 'history' view, it would
> > be not easy.  The problem is that 'history' view shows only commits
> > that touch specified file or directory, and tagged commits usually do
> > not touch those files (at least if one is using "bump version number"
> > commits to tag them).
> > 
> > So you would have:
> > 1. Design where to show those tags - they would be between shown
> >    commits.
> > 2. Create code which shows some/all tags that are between commits in
> >    the presence of nonlinear history, without affecting performance
> >    too badly.
> 
> Ah, that is too bad because I think it would really useful.
> Image browsing a drivers history in the linux kernel. Then it would be
> really nice to see what changes/bug fixes went into what release.

First, you can help with the first issue even if you can't help with
the coding itself.

Second, with single 'git name-rev --tags --stdin' or with '--decorate'
or '%d' in format we could (I think) either display at least some tags,
or name-rev decorations, i.e. something like:

  (v1.7.3-rc0~38) gitweb: Don't die_error in git_tag after already printing headers
  (v1.7.3-rc0~44) Merge branch 'maint'
  (v1.7.2.3~15) Typos in code comments, an error message, documentation
  (v1.7.3-rc0~85) Merge branch 'jn/maint-gitweb-dynconf'
  (v1.7.3-rc0~92) Merge branch 'maint'
  (v1.7.2.2~12) gitweb: clarify search results page when no matching commit found
  [...]

If we want to display all tags we would have IIUC extend git-log to
generate such information.

-- 
Jakub Narebski
Poland

RE: gitweb: please show tags file history browsing

[Tjernlund]

Jocke

> -----Original Message-----
> From: Jakub Narebski [mailto:jnareb@gmail.com]
> On Sun, 12 Sep 2010, Tjernlund wrote:
> > > -----Original Message-----
> > > From: Jakub Narebski [mailto:jnareb@gmail.com]
> > >
> > > "Tjernlund" <tjernlund@tjernlund.se> writes:
> > >
> > > > I would really like to see where the tags are when browsing
> > > > file or directory history in gitweb. Would that be possible?
> 
> > > While it probably be possible to show tags in 'history' view, it would
> > > be not easy.  The problem is that 'history' view shows only commits
> > > that touch specified file or directory, and tagged commits usually do
> > > not touch those files (at least if one is using "bump version number"
> > > commits to tag them).
> > >
> > > So you would have:
> > > 1. Design where to show those tags - they would be between shown
> > >    commits.
> > > 2. Create code which shows some/all tags that are between commits in
> > >    the presence of nonlinear history, without affecting performance
> > >    too badly.
> >
> > Ah, that is too bad because I think it would really useful.
> > Image browsing a drivers history in the linux kernel. Then it would be
> > really nice to see what changes/bug fixes went into what release.
> 
> First, you can help with the first issue even if you can't help with
> the coding itself.

I like the gitk way of showing tags, won't that work in gitweb too?

> 
> Second, with single 'git name-rev --tags --stdin' or with '--decorate'
> or '%d' in format we could (I think) either display at least some tags,
> or name-rev decorations, i.e. something like:
> 
>   (v1.7.3-rc0~38) gitweb: Don't die_error in git_tag after already printing headers
>   (v1.7.3-rc0~44) Merge branch 'maint'
>   (v1.7.2.3~15) Typos in code comments, an error message, documentation
>   (v1.7.3-rc0~85) Merge branch 'jn/maint-gitweb-dynconf'
>   (v1.7.3-rc0~92) Merge branch 'maint'
>   (v1.7.2.2~12) gitweb: clarify search results page when no matching commit found
>   [...]
> 
> If we want to display all tags we would have IIUC extend git-log to
> generate such information.

if displaying tags is a too expensive operation one could have a knob
in gitweb to get at the tags.

Re: gitweb: please show tags file history browsing

[Jakub Narebski]

On Sun, 12 Sep 2010, Tjernlund wrote:
>> -----Original Message-----
>> From: Jakub Narebski [mailto:jnareb@gmail.com]
>> On Sun, 12 Sep 2010, Tjernlund wrote:
>>>> -----Original Message-----
>>>> From: Jakub Narebski [mailto:jnareb@gmail.com]
>>>>
>>>> "Tjernlund" <tjernlund@tjernlund.se> writes:
>>>>
>>>>> I would really like to see where the tags are when browsing
>>>>> file or directory history in gitweb. Would that be possible?
>> 
>>>> While it probably be possible to show tags in 'history' view, it would
>>>> be not easy.  The problem is that 'history' view shows only commits
>>>> that touch specified file or directory, and tagged commits usually do
>>>> not touch those files (at least if one is using "bump version number"
>>>> commits to tag them).
>>>>
>>>> So you would have:
>>>> 1. Design where to show those tags - they would be between shown
>>>>    commits.
>>>> 2. Create code which shows some/all tags that are between commits in
>>>>    the presence of nonlinear history, without affecting performance
>>>>    too badly.
>>>
>>> Ah, that is too bad because I think it would really useful.
>>> Image browsing a drivers history in the linux kernel. Then it would be
>>> really nice to see what changes/bug fixes went into what release.
>> 
>> First, you can help with the first issue even if you can't help with
>> the coding itself.
> 
> I like the gitk way of showing tags, won't that work in gitweb too?

Err... "gitk" shows tags, but so does 'shortlog' and 'log' view in
gitweb.  The 'history' view in gitweb doesn't show intermediate tags,
but neither does "gitk -- <path>".

>> Second, with single 'git name-rev --tags --stdin' or with '--decorate'
>> or '%d' in format we could (I think) either display at least some tags,
>> or name-rev decorations, i.e. something like:
>> 
>>   (v1.7.3-rc0~38) gitweb: Don't die_error in git_tag after already printing headers
>>   (v1.7.3-rc0~44) Merge branch 'maint'
>>   (v1.7.2.3~15) Typos in code comments, an error message, documentation
>>   (v1.7.3-rc0~85) Merge branch 'jn/maint-gitweb-dynconf'
>>   (v1.7.3-rc0~92) Merge branch 'maint'
>>   (v1.7.2.2~12) gitweb: clarify search results page when no matching commit found
>>   [...]
>> 
>> If we want to display all tags we would have IIUC extend git-log to
>> generate such information.
> 
> if displaying tags is a too expensive operation one could have a knob
> in gitweb to get at the tags.

Good thinking.  We have such knobs, so called 'features', for 'pickaxe'
and for 'grep' searches (both which can be expensive).

-- 
Jakub Narebski
Poland

RE: gitweb: please show tags file history browsing

[Tjernlund]

> -----Original Message-----
> On Sun, 12 Sep 2010, Tjernlund wrote:
> >> -----Original Message-----
> >> From: Jakub Narebski [mailto:jnareb@gmail.com]
> >> On Sun, 12 Sep 2010, Tjernlund wrote:
> >>>> -----Original Message-----
> >>>> From: Jakub Narebski [mailto:jnareb@gmail.com]
> >>>>
> >>>> "Tjernlund" <tjernlund@tjernlund.se> writes:
> >>>>
> >>>>> I would really like to see where the tags are when browsing
> >>>>> file or directory history in gitweb. Would that be possible?
> >>
> >>>> While it probably be possible to show tags in 'history' view, it would
> >>>> be not easy.  The problem is that 'history' view shows only commits
> >>>> that touch specified file or directory, and tagged commits usually do
> >>>> not touch those files (at least if one is using "bump version number"
> >>>> commits to tag them).
> >>>>
> >>>> So you would have:
> >>>> 1. Design where to show those tags - they would be between shown
> >>>>    commits.
> >>>> 2. Create code which shows some/all tags that are between commits in
> >>>>    the presence of nonlinear history, without affecting performance
> >>>>    too badly.
> >>>
> >>> Ah, that is too bad because I think it would really useful.
> >>> Image browsing a drivers history in the linux kernel. Then it would be
> >>> really nice to see what changes/bug fixes went into what release.
> >>
> >> First, you can help with the first issue even if you can't help with
> >> the coding itself.
> >
> > I like the gitk way of showing tags, won't that work in gitweb too?
> 
> Err... "gitk" shows tags, but so does 'shortlog' and 'log' view in
> gitweb.  The 'history' view in gitweb doesn't show intermediate tags,
> but neither does "gitk -- <path>".

I know, I just meant the yellow note with tag name in it, how tags
are displayed. When they are display is another matter :)

Re: gitweb: please show tags file history browsing

[Jakub Narebski]

Tjernlund wrote:
>> On Sun, 12 Sep 2010, Tjernlund wrote:
>>>> From: Jakub Narebski [mailto:jnareb@gmail.com]
>>>> On Sun, 12 Sep 2010, Tjernlund wrote:
>>>>>> From: Jakub Narebski [mailto:jnareb@gmail.com]

>>>>>> While it probably be possible to show tags in 'history' view, it would
>>>>>> be not easy.  The problem is that 'history' view shows only commits
>>>>>> that touch specified file or directory, and tagged commits usually do
>>>>>> not touch those files (at least if one is using "bump version number"
>>>>>> commits to tag them).
>>>>>>
>>>>>> So you would have:
>>>>>> 1. Design where to show those tags - they would be between shown
>>>>>>    commits.
>>>>>> 2. Create code which shows some/all tags that are between commits in
>>>>>>    the presence of nonlinear history, without affecting performance
>>>>>>    too badly.
>>>>>
>>>>> Ah, that is too bad because I think it would really useful.
>>>>> Image browsing a drivers history in the linux kernel. Then it would be
>>>>> really nice to see what changes/bug fixes went into what release.
>>>>
>>>> First, you can help with the first issue even if you can't help with
>>>> the coding itself.
>>>
>>> I like the gitk way of showing tags, won't that work in gitweb too?
>> 
>> Err... "gitk" shows tags, but so does 'shortlog' and 'log' view in
>> gitweb.  The 'history' view in gitweb doesn't show intermediate tags,
>> but neither does "gitk -- <path>".
> 
> I know, I just meant the yellow note with tag name in it, how tags
> are displayed. When they are display is another matter :)

When those yellow notes with tag name are displayed beside commit
subject it means that this commit is referenced by given tag (i.e.
<this tag>^{commit} = <this commit>).

We have to distinguish situation where tag is between commits, and
tag points to commit.

-- 
Jakub Narebski
Poland

RE: gitweb: please show tags file history browsing

[Tjernlund]

> -----Original Message-----
> From: Jakub Narebski [mailto:jnareb@gmail.com]
> Tjernlund wrote:
> >> On Sun, 12 Sep 2010, Tjernlund wrote:
> >>>> From: Jakub Narebski [mailto:jnareb@gmail.com]
> >>>> On Sun, 12 Sep 2010, Tjernlund wrote:
> >>>>>> From: Jakub Narebski [mailto:jnareb@gmail.com]
> 
> >>>>>> While it probably be possible to show tags in 'history' view, it would
> >>>>>> be not easy.  The problem is that 'history' view shows only commits
> >>>>>> that touch specified file or directory, and tagged commits usually do
> >>>>>> not touch those files (at least if one is using "bump version number"
> >>>>>> commits to tag them).
> >>>>>>
> >>>>>> So you would have:
> >>>>>> 1. Design where to show those tags - they would be between shown
> >>>>>>    commits.
> >>>>>> 2. Create code which shows some/all tags that are between commits in
> >>>>>>    the presence of nonlinear history, without affecting performance
> >>>>>>    too badly.
> >>>>>
> >>>>> Ah, that is too bad because I think it would really useful.
> >>>>> Image browsing a drivers history in the linux kernel. Then it would be
> >>>>> really nice to see what changes/bug fixes went into what release.
> >>>>
> >>>> First, you can help with the first issue even if you can't help with
> >>>> the coding itself.
> >>>
> >>> I like the gitk way of showing tags, won't that work in gitweb too?
> >>
> >> Err... "gitk" shows tags, but so does 'shortlog' and 'log' view in
> >> gitweb.  The 'history' view in gitweb doesn't show intermediate tags,
> >> but neither does "gitk -- <path>".
> >
> > I know, I just meant the yellow note with tag name in it, how tags
> > are displayed. When they are display is another matter :)
> 
> When those yellow notes with tag name are displayed beside commit
> subject it means that this commit is referenced by given tag (i.e.
> <this tag>^{commit} = <this commit>).
> 
> We have to distinguish situation where tag is between commits, and
> tag points to commit.

Why? I just want to know if a commit is included or not in the tag.
When a tag is formally between commits, just display the
tag with the commit line below.

 Jocke