All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Josh Boyer <jwboyer@redhat.com>
Cc: alsa-devel@alsa-project.org, Gabriel Somlo <somlo@cmu.edu>,
	linux-kernel@vger.kernel.org, kernel-team@fedoraproject.org
Subject: Re: [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5,1 machines
Date: Thu, 12 Apr 2012 20:05:05 +0200	[thread overview]
Message-ID: <s5hpqbcrfla.wl%tiwai@suse.de> (raw)
In-Reply-To: <20120412175536.GB25425@zod.bos.redhat.com>

At Thu, 12 Apr 2012 13:55:36 -0400,
Josh Boyer wrote:
> 
> A user reported that setting model=imac24 used to allow sound to work on their
> Mac Pro 5,1 machine.  Commit 5671087ffa "Move ALC885 macpro and imac24 models
> to auto-parser" removed this model option.  All Mac machines are now explicitly
> handled with a quirk and the auto-parser.  This adds a quirk for the device
> found on the Mac Pro 5,1 machines.
> 
> This (partially) fixes https://bugzilla.redhat.com/show_bug.cgi?id=808559
> 
> Reported-by: Gabriel Somlo <somlo@cmu.edu>
> Signed-off-by: Josh Boyer <jwboyer@redhat.com>

Applied now (with sorting in the id number order).
Thanks.


Takashi


> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 9917e55..1e0eea8 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5371,6 +5371,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x106b, 0x00a1, "Macbook", ALC889_FIXUP_MBP_VREF),
>  	SND_PCI_QUIRK(0x106b, 0x00a4, "MacbookPro 4,1", ALC889_FIXUP_MBP_VREF),
>  	SND_PCI_QUIRK(0x106b, 0x0c00, "Mac Pro", ALC885_FIXUP_MACPRO_GPIO),
> +	SND_PCI_QUIRK(0x106b, 0x4200,  "Mac Pro 5,1", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x1000, "iMac 24", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x2800, "AppleTV", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC889_FIXUP_MBP_VREF),
> -- 
> 1.7.7.6
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Josh Boyer <jwboyer@redhat.com>
Cc: kernel-team@fedoraproject.org, alsa-devel@alsa-project.org,
	Gabriel Somlo <somlo@cmu.edu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5, 1 machines
Date: Thu, 12 Apr 2012 20:05:05 +0200	[thread overview]
Message-ID: <s5hpqbcrfla.wl%tiwai@suse.de> (raw)
In-Reply-To: <20120412175536.GB25425@zod.bos.redhat.com>

At Thu, 12 Apr 2012 13:55:36 -0400,
Josh Boyer wrote:
> 
> A user reported that setting model=imac24 used to allow sound to work on their
> Mac Pro 5,1 machine.  Commit 5671087ffa "Move ALC885 macpro and imac24 models
> to auto-parser" removed this model option.  All Mac machines are now explicitly
> handled with a quirk and the auto-parser.  This adds a quirk for the device
> found on the Mac Pro 5,1 machines.
> 
> This (partially) fixes https://bugzilla.redhat.com/show_bug.cgi?id=808559
> 
> Reported-by: Gabriel Somlo <somlo@cmu.edu>
> Signed-off-by: Josh Boyer <jwboyer@redhat.com>

Applied now (with sorting in the id number order).
Thanks.


Takashi


> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 9917e55..1e0eea8 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5371,6 +5371,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x106b, 0x00a1, "Macbook", ALC889_FIXUP_MBP_VREF),
>  	SND_PCI_QUIRK(0x106b, 0x00a4, "MacbookPro 4,1", ALC889_FIXUP_MBP_VREF),
>  	SND_PCI_QUIRK(0x106b, 0x0c00, "Mac Pro", ALC885_FIXUP_MACPRO_GPIO),
> +	SND_PCI_QUIRK(0x106b, 0x4200,  "Mac Pro 5,1", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x1000, "iMac 24", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x2800, "AppleTV", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC889_FIXUP_MBP_VREF),
> -- 
> 1.7.7.6
> 

  reply	other threads:[~2012-04-12 18:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12 17:55 [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5,1 machines Josh Boyer
2012-04-12 18:05 ` Takashi Iwai [this message]
2012-04-12 18:05   ` [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5, 1 machines Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpqbcrfla.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jwboyer@redhat.com \
    --cc=kernel-team@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=somlo@cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.