From: Takashi Iwai <tiwai@suse.de> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Cc: alsa-devel@alsa-project.org, arnd@arndb.de, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, vinod.koul@intel.com, broonie@kernel.org, andriy.shevchenko@linux.intel.com, torvalds@linux-foundation.org Subject: Re: [alsa-devel] [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig Date: Tue, 21 Nov 2017 18:07:27 +0100 [thread overview] Message-ID: <s5hzi7ftvao.wl-tiwai@suse.de> (raw) In-Reply-To: <20171118000202.22302-2-pierre-louis.bossart@linux.intel.com> On Sat, 18 Nov 2017 01:01:56 +0100, Pierre-Louis Bossart wrote: > > Follow network example suggested by Linus, move Intel definitions > in if/endif block and clarify which options distro configurations > should enable - everything except legacy Baytrail stuff and > NOCODEC (test only) > > There should be no functionality change - except that sound capabilities > are restored when using older configs without any user selection. > > Fixes: f6a118a800e3 ("ASoC: Intel: clarify Kconfig dependencies") > Reported-by: Linus Torvalds <torvalds@linux-foundation.org> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> A few another things I noticed while looking at the end result: > config SND_SOC_INTEL_SKYLAKE > tristate "Intel ASoC SST driver for SKL/BXT/KBL/GLK/CNL" > - depends on SND_SOC_INTEL_SST_TOPLEVEL && PCI && ACPI > + depends on PCI && ACPI > select SND_HDA_EXT_CORE > select SND_HDA_DSP_LOADER > select SND_SOC_TOPOLOGY > select SND_SOC_INTEL_SST > + select SND_SOC_INTEL_COMMON > + > +endif ## SND_SOC_INTEL_SST_TOPLEVEL This endif should cover the whole including the source boards/Kconfig. In that way, deselecting SND_SOC_INTEL_SST_TOPLEVEL will skip the whole. As of this patch, you'll be still asked about the board config even if you say TOPLEVEL=n. > # ASoC codec drivers > source "sound/soc/intel/boards/Kconfig" > + > +# configs common to SST and SOF to compile sound/soc/intel/common > +# directory and use matching tables > + > +config SND_SOC_INTEL_COMMON > + tristate > + select SND_SOC_ACPI_INTEL_MATCH if ACPI > + > +config SND_SOC_ACPI_INTEL_MATCH > + tristate > + select SND_SOC_ACPI if ACPI ... so here should be placed the endif. > diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig > index 6f754708a48c..4ae44b0cea0a 100644 > --- a/sound/soc/intel/boards/Kconfig > +++ b/sound/soc/intel/boards/Kconfig > @@ -1,7 +1,14 @@ > -config SND_SOC_INTEL_MACH > - tristate "Intel Audio machine drivers" > - depends on SND_SOC_INTEL_SST_TOPLEVEL > - select SND_SOC_ACPI_INTEL_MATCH if ACPI > +config SND_SOC_INTEL_MACH > + bool "Intel ASoC machine drivers" > + default y > + help > + Intel ASoC Audio Machine Drivers. If you have a Intel machine that > + has audio controller with a DSP and I2S or DMIC port, then > + enable this option by saying Y > + > + Note that the answer to this question doesn't directly affect the > + kernel: saying N will just cause the configurator to skip all > + the questions about Intel SST machine drivers. Do we still need this filtering? Since we have a top-level filter, users who want to skip the Intel stuff can say N there already, and I can't imagine anyone who want only the SST core / platform drivers built without machine drivers explicitly. thanks, Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Cc: alsa-devel@alsa-project.org, arnd@arndb.de, vinod.koul@intel.com, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, broonie@kernel.org, andriy.shevchenko@linux.intel.com, torvalds@linux-foundation.org Subject: Re: [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig Date: Tue, 21 Nov 2017 18:07:27 +0100 [thread overview] Message-ID: <s5hzi7ftvao.wl-tiwai@suse.de> (raw) In-Reply-To: <20171118000202.22302-2-pierre-louis.bossart@linux.intel.com> On Sat, 18 Nov 2017 01:01:56 +0100, Pierre-Louis Bossart wrote: > > Follow network example suggested by Linus, move Intel definitions > in if/endif block and clarify which options distro configurations > should enable - everything except legacy Baytrail stuff and > NOCODEC (test only) > > There should be no functionality change - except that sound capabilities > are restored when using older configs without any user selection. > > Fixes: f6a118a800e3 ("ASoC: Intel: clarify Kconfig dependencies") > Reported-by: Linus Torvalds <torvalds@linux-foundation.org> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> A few another things I noticed while looking at the end result: > config SND_SOC_INTEL_SKYLAKE > tristate "Intel ASoC SST driver for SKL/BXT/KBL/GLK/CNL" > - depends on SND_SOC_INTEL_SST_TOPLEVEL && PCI && ACPI > + depends on PCI && ACPI > select SND_HDA_EXT_CORE > select SND_HDA_DSP_LOADER > select SND_SOC_TOPOLOGY > select SND_SOC_INTEL_SST > + select SND_SOC_INTEL_COMMON > + > +endif ## SND_SOC_INTEL_SST_TOPLEVEL This endif should cover the whole including the source boards/Kconfig. In that way, deselecting SND_SOC_INTEL_SST_TOPLEVEL will skip the whole. As of this patch, you'll be still asked about the board config even if you say TOPLEVEL=n. > # ASoC codec drivers > source "sound/soc/intel/boards/Kconfig" > + > +# configs common to SST and SOF to compile sound/soc/intel/common > +# directory and use matching tables > + > +config SND_SOC_INTEL_COMMON > + tristate > + select SND_SOC_ACPI_INTEL_MATCH if ACPI > + > +config SND_SOC_ACPI_INTEL_MATCH > + tristate > + select SND_SOC_ACPI if ACPI ... so here should be placed the endif. > diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig > index 6f754708a48c..4ae44b0cea0a 100644 > --- a/sound/soc/intel/boards/Kconfig > +++ b/sound/soc/intel/boards/Kconfig > @@ -1,7 +1,14 @@ > -config SND_SOC_INTEL_MACH > - tristate "Intel Audio machine drivers" > - depends on SND_SOC_INTEL_SST_TOPLEVEL > - select SND_SOC_ACPI_INTEL_MATCH if ACPI > +config SND_SOC_INTEL_MACH > + bool "Intel ASoC machine drivers" > + default y > + help > + Intel ASoC Audio Machine Drivers. If you have a Intel machine that > + has audio controller with a DSP and I2S or DMIC port, then > + enable this option by saying Y > + > + Note that the answer to this question doesn't directly affect the > + kernel: saying N will just cause the configurator to skip all > + the questions about Intel SST machine drivers. Do we still need this filtering? Since we have a top-level filter, users who want to skip the Intel stuff can say N there already, and I can't imagine anyone who want only the SST core / platform drivers built without machine drivers explicitly. thanks, Takashi
next prev parent reply other threads:[~2017-11-21 17:07 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-18 0:01 [RFC PATCH 0/7] Fix Intel audio Kconfig issues Pierre-Louis Bossart 2017-11-18 0:01 ` Pierre-Louis Bossart 2017-11-18 0:01 ` [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig Pierre-Louis Bossart 2017-11-18 16:49 ` Takashi Iwai 2017-11-18 16:49 ` Takashi Iwai 2017-11-20 16:18 ` [alsa-devel] " Pierre-Louis Bossart 2017-11-20 16:18 ` Pierre-Louis Bossart 2017-11-21 17:07 ` Takashi Iwai [this message] 2017-11-21 17:07 ` Takashi Iwai 2017-11-21 21:31 ` [alsa-devel] " Pierre-Louis Bossart 2017-11-18 0:01 ` [RFC PATCH 2/7] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies Pierre-Louis Bossart 2017-11-18 0:01 ` Pierre-Louis Bossart 2017-11-18 16:53 ` Andy Shevchenko 2017-11-18 16:53 ` Andy Shevchenko 2017-11-18 16:55 ` Shevchenko, Andriy 2017-11-18 16:55 ` Shevchenko, Andriy 2017-11-20 16:23 ` [alsa-devel] " Pierre-Louis Bossart 2017-11-20 16:58 ` Alan Cox 2017-11-20 16:58 ` Alan Cox 2017-11-21 12:05 ` [alsa-devel] " Andy Shevchenko 2017-11-20 15:23 ` Alan Cox 2017-11-18 0:01 ` [RFC PATCH 3/7] ASoC: Intel: document what Kconfig options do Pierre-Louis Bossart 2017-11-18 0:01 ` Pierre-Louis Bossart 2017-11-21 17:09 ` [alsa-devel] " Takashi Iwai 2017-11-21 17:09 ` Takashi Iwai 2017-11-21 21:32 ` [alsa-devel] " Pierre-Louis Bossart 2017-11-21 21:32 ` Pierre-Louis Bossart 2017-11-18 0:01 ` [RFC PATCH 4/7] ASoC: Intel: Fix nested/unnecessary Kconfig dependencies Pierre-Louis Bossart 2017-11-18 0:01 ` Pierre-Louis Bossart 2017-11-18 0:02 ` [RFC PATCH 5/7] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell Pierre-Louis Bossart 2018-01-08 16:22 ` Applied "ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell" to the asoc tree Mark Brown 2018-01-08 16:22 ` Mark Brown 2017-11-18 0:02 ` [RFC PATCH 6/7] ASoC: Intel: boards: align Kconfig configurations for HiFi2 Pierre-Louis Bossart 2017-11-18 0:02 ` Pierre-Louis Bossart 2017-11-18 17:08 ` Andy Shevchenko 2017-11-18 17:08 ` Andy Shevchenko 2017-11-20 16:27 ` [alsa-devel] " Pierre-Louis Bossart 2017-11-20 16:27 ` Pierre-Louis Bossart 2017-11-18 0:02 ` [RFC PATCH 7/7] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs Pierre-Louis Bossart 2017-11-18 0:02 ` Pierre-Louis Bossart 2017-11-18 17:14 ` Andy Shevchenko 2017-11-18 17:14 ` Andy Shevchenko 2017-11-18 0:09 ` [RFC PATCH 0/7] Fix Intel audio Kconfig issues Linus Torvalds 2017-11-18 0:09 ` Linus Torvalds 2017-11-18 9:25 ` Takashi Iwai 2017-11-18 9:25 ` Takashi Iwai 2017-11-20 13:28 ` Arnd Bergmann 2017-11-20 13:28 ` Arnd Bergmann 2017-11-21 17:10 ` Takashi Iwai 2017-11-21 21:36 ` [alsa-devel] " Pierre-Louis Bossart 2017-11-22 11:54 ` Mark Brown 2017-11-22 11:54 ` Mark Brown 2017-11-27 14:40 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=s5hzi7ftvao.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=liam.r.girdwood@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=torvalds@linux-foundation.org \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.