From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
torvalds@linux-foundation.org, vinod.koul@intel.com,
liam.r.girdwood@linux.intel.com,
andriy.shevchenko@linux.intel.com, arnd@arndb.de,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig
Date: Sat, 18 Nov 2017 17:49:38 +0100 [thread overview]
Message-ID: <s5hine78rbx.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171118000202.22302-2-pierre-louis.bossart@linux.intel.com>
On Sat, 18 Nov 2017 01:01:56 +0100,
Pierre-Louis Bossart wrote:
>
> +if SND_SOC_INTEL_BAYTRAIL
>
> config SND_SOC_INTEL_BYT_MAX98090_MACH
> tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
> + default n
default=n is superfluous, can be dropped.
> depends on X86_INTEL_LPSS && I2C
> - depends on SND_SST_IPC_ACPI = n
> - depends on SND_SOC_INTEL_BAYTRAIL
> select SND_SOC_MAX98090
So the dependency on ND_SST_IPC_ACPI=n is removed here too, and I
guess this will allow this machine driver built although it shouldn't
be?
thanks,
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, arnd@arndb.de, vinod.koul@intel.com,
linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com,
broonie@kernel.org, andriy.shevchenko@linux.intel.com,
torvalds@linux-foundation.org
Subject: Re: [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig
Date: Sat, 18 Nov 2017 17:49:38 +0100 [thread overview]
Message-ID: <s5hine78rbx.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171118000202.22302-2-pierre-louis.bossart@linux.intel.com>
On Sat, 18 Nov 2017 01:01:56 +0100,
Pierre-Louis Bossart wrote:
>
> +if SND_SOC_INTEL_BAYTRAIL
>
> config SND_SOC_INTEL_BYT_MAX98090_MACH
> tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
> + default n
default=n is superfluous, can be dropped.
> depends on X86_INTEL_LPSS && I2C
> - depends on SND_SST_IPC_ACPI = n
> - depends on SND_SOC_INTEL_BAYTRAIL
> select SND_SOC_MAX98090
So the dependency on ND_SST_IPC_ACPI=n is removed here too, and I
guess this will allow this machine driver built although it shouldn't
be?
thanks,
Takashi
next prev parent reply other threads:[~2017-11-18 16:49 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 0:01 [RFC PATCH 0/7] Fix Intel audio Kconfig issues Pierre-Louis Bossart
2017-11-18 0:01 ` Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig Pierre-Louis Bossart
2017-11-18 16:49 ` Takashi Iwai [this message]
2017-11-18 16:49 ` Takashi Iwai
2017-11-20 16:18 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-20 16:18 ` Pierre-Louis Bossart
2017-11-21 17:07 ` [alsa-devel] " Takashi Iwai
2017-11-21 17:07 ` Takashi Iwai
2017-11-21 21:31 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 2/7] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies Pierre-Louis Bossart
2017-11-18 0:01 ` Pierre-Louis Bossart
2017-11-18 16:53 ` Andy Shevchenko
2017-11-18 16:53 ` Andy Shevchenko
2017-11-18 16:55 ` Shevchenko, Andriy
2017-11-18 16:55 ` Shevchenko, Andriy
2017-11-20 16:23 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-20 16:58 ` Alan Cox
2017-11-20 16:58 ` Alan Cox
2017-11-21 12:05 ` [alsa-devel] " Andy Shevchenko
2017-11-20 15:23 ` Alan Cox
2017-11-18 0:01 ` [RFC PATCH 3/7] ASoC: Intel: document what Kconfig options do Pierre-Louis Bossart
2017-11-18 0:01 ` Pierre-Louis Bossart
2017-11-21 17:09 ` [alsa-devel] " Takashi Iwai
2017-11-21 17:09 ` Takashi Iwai
2017-11-21 21:32 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-21 21:32 ` Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 4/7] ASoC: Intel: Fix nested/unnecessary Kconfig dependencies Pierre-Louis Bossart
2017-11-18 0:01 ` Pierre-Louis Bossart
2017-11-18 0:02 ` [RFC PATCH 5/7] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell Pierre-Louis Bossart
2018-01-08 16:22 ` Applied "ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell" to the asoc tree Mark Brown
2018-01-08 16:22 ` Mark Brown
2017-11-18 0:02 ` [RFC PATCH 6/7] ASoC: Intel: boards: align Kconfig configurations for HiFi2 Pierre-Louis Bossart
2017-11-18 0:02 ` Pierre-Louis Bossart
2017-11-18 17:08 ` Andy Shevchenko
2017-11-18 17:08 ` Andy Shevchenko
2017-11-20 16:27 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-20 16:27 ` Pierre-Louis Bossart
2017-11-18 0:02 ` [RFC PATCH 7/7] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs Pierre-Louis Bossart
2017-11-18 0:02 ` Pierre-Louis Bossart
2017-11-18 17:14 ` Andy Shevchenko
2017-11-18 17:14 ` Andy Shevchenko
2017-11-18 0:09 ` [RFC PATCH 0/7] Fix Intel audio Kconfig issues Linus Torvalds
2017-11-18 0:09 ` Linus Torvalds
2017-11-18 9:25 ` Takashi Iwai
2017-11-18 9:25 ` Takashi Iwai
2017-11-20 13:28 ` Arnd Bergmann
2017-11-20 13:28 ` Arnd Bergmann
2017-11-21 17:10 ` Takashi Iwai
2017-11-21 21:36 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-22 11:54 ` Mark Brown
2017-11-22 11:54 ` Mark Brown
2017-11-27 14:40 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hine78rbx.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.