* [PATCH] aic7xxx: Fix queue depth handling
@ 2016-02-15 18:53 Alan
2016-02-15 19:01 ` James Bottomley
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alan @ 2016-02-15 18:53 UTC (permalink / raw)
To: hare, linux-scsi
We were setting the queue depth correctly, then setting it back to two. If
you hit this as a bisection point then please send me an email as it would
imply we've been hiding other bugs with this one.
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/scsi/aic7xxx/aic7xxx_osm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
index b846a46..fc6a831 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
@@ -1336,6 +1336,7 @@ ahc_platform_set_tags(struct ahc_softc *ahc, struct scsi_device *sdev,
case AHC_DEV_Q_TAGGED:
scsi_change_queue_depth(sdev,
dev->openings + dev->active);
+ break;
default:
/*
* We allow the OS to queue 2 untagged transactions to
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] aic7xxx: Fix queue depth handling
2016-02-15 18:53 [PATCH] aic7xxx: Fix queue depth handling Alan
@ 2016-02-15 19:01 ` James Bottomley
2016-02-16 6:51 ` Hannes Reinecke
2016-02-18 0:16 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: James Bottomley @ 2016-02-15 19:01 UTC (permalink / raw)
To: Alan, hare, linux-scsi
On Mon, 2016-02-15 at 18:53 +0000, Alan wrote:
> We were setting the queue depth correctly, then setting it back to
> two. If you hit this as a bisection point then please send me an
> email as it would imply we've been hiding other bugs with this one.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> drivers/scsi/aic7xxx/aic7xxx_osm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> index b846a46..fc6a831 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> @@ -1336,6 +1336,7 @@ ahc_platform_set_tags(struct ahc_softc *ahc,
> struct scsi_device *sdev,
> case AHC_DEV_Q_TAGGED:
> scsi_change_queue_depth(sdev,
> dev->openings + dev->active);
> + break;
> default:
>
Heh, that's a bit of an oopsie. I'll add a cc to stable to see what
happens with older kernels.
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] aic7xxx: Fix queue depth handling
2016-02-15 18:53 [PATCH] aic7xxx: Fix queue depth handling Alan
2016-02-15 19:01 ` James Bottomley
@ 2016-02-16 6:51 ` Hannes Reinecke
2016-02-18 0:16 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2016-02-16 6:51 UTC (permalink / raw)
To: Alan, linux-scsi
On 02/15/2016 07:53 PM, Alan wrote:
> We were setting the queue depth correctly, then setting it back to two. If
> you hit this as a bisection point then please send me an email as it would
> imply we've been hiding other bugs with this one.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> drivers/scsi/aic7xxx/aic7xxx_osm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> index b846a46..fc6a831 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> @@ -1336,6 +1336,7 @@ ahc_platform_set_tags(struct ahc_softc *ahc, struct scsi_device *sdev,
> case AHC_DEV_Q_TAGGED:
> scsi_change_queue_depth(sdev,
> dev->openings + dev->active);
> + break;
> default:
> /*
> * We allow the OS to queue 2 untagged transactions to
>
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.com +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] aic7xxx: Fix queue depth handling
2016-02-15 18:53 [PATCH] aic7xxx: Fix queue depth handling Alan
2016-02-15 19:01 ` James Bottomley
2016-02-16 6:51 ` Hannes Reinecke
@ 2016-02-18 0:16 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2016-02-18 0:16 UTC (permalink / raw)
To: Alan; +Cc: hare, linux-scsi
>>>>> "Alan" == Alan <gnomes@lxorguk.ukuu.org.uk> writes:
Alan> We were setting the queue depth correctly, then setting it back to
Alan> two. If you hit this as a bisection point then please send me an
Alan> email as it would imply we've been hiding other bugs with this
Alan> one.
Applied to 4.6/scsi-queue, CC:stable@.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-18 0:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-15 18:53 [PATCH] aic7xxx: Fix queue depth handling Alan
2016-02-15 19:01 ` James Bottomley
2016-02-16 6:51 ` Hannes Reinecke
2016-02-18 0:16 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.