AMD-GFX Archive on
 help / color / Atom feed
* drm/amdkfd: Change pasid's type to unsigned int
@ 2020-05-22 19:25 Fenghua Yu
  2020-05-22 19:40 ` Felix Kuehling
  0 siblings, 1 reply; 4+ messages in thread
From: Fenghua Yu @ 2020-05-22 19:25 UTC (permalink / raw)
  To: Yong Zhao, Felix Kuehling; +Cc: amd-gfx

Hi, Yong,

In commit: 6027b1bf6071fc61a5aa11b9922a2e0e91bff1ea
    drm/amdkfd: Use hex print format for pasid

pasid's type was change to "uint16_t" from "unsigned int" in
struct kfd_process.

But, pasid is a 20-bit value according to PCIe spec and other places
in amdkfd (plus other iommu code) define pasid as "unsigned int".
If defined as uint16_t, pasid will overflow if its value is bigger than 16-bit.

Did I miss anything? Should we change pasid's type back to "unsigned int"?

[a little background: pasid is defined as various types including "int",
"unsigned int", "u32" in iommu. I'm changing pasid's types to "unsigned int"
so that the types are consistent in iommu]


amd-gfx mailing list

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 19:25 drm/amdkfd: Change pasid's type to unsigned int Fenghua Yu
2020-05-22 19:40 ` Felix Kuehling
2020-05-22 21:21   ` Fenghua Yu
2020-05-23  3:14     ` Zhao, Yong

AMD-GFX Archive on

Archives are clonable:
	git clone --mirror amd-gfx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 amd-gfx amd-gfx/ \
	public-inbox-index amd-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone