From: claudiu beznea <claudiu.beznea@tuxon.dev> To: Varshini Rajendran <varshini.rajendran@microchip.com>, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, andre.przywara@arm.com, gregory.clement@bootlin.com, linus.walleij@linaro.org, baruch@tkos.co.il, mihai.sain@microchip.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 39/39] ARM: dts: at91: sam9x75_curiosity: add sam9x75 curiosity board Date: Sun, 3 Mar 2024 14:19:25 +0200 [thread overview] Message-ID: <b189dbc3-e875-45c9-b742-928a6a323d5c@tuxon.dev> (raw) In-Reply-To: <20240223173113.673595-1-varshini.rajendran@microchip.com> s/ARM: dts: at91/ARM: dts: microchip in title. On 23.02.2024 19:31, Varshini Rajendran wrote: > Add device tree file for sam9x75 curiosity board. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > Changes in v4: > - Removed full node paths > - Renamed Leds with color names > - Corrected regulator node names > - Added support for classd and i2s nodes and their corresponding > pinctrl nodes > - Dropped USB nodes owing to the discussion here > https://lore.kernel.org/linux-devicetree/CAL_JsqJ9PrX6fj-EbffeJce09MXs=B7t+KS_kOinxaRx38=WxA@mail.gmail.com/ > (Explained elaborately in the cover letter) > - Updated the linux,code property with the necessary value > --- > arch/arm/boot/dts/microchip/Makefile | 3 + > .../dts/microchip/at91-sam9x75_curiosity.dts | 309 ++++++++++++++++++ > 2 files changed, 312 insertions(+) > create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > > diff --git a/arch/arm/boot/dts/microchip/Makefile b/arch/arm/boot/dts/microchip/Makefile > index efde9546c8f4..5b3d518da319 100644 > --- a/arch/arm/boot/dts/microchip/Makefile > +++ b/arch/arm/boot/dts/microchip/Makefile > @@ -12,6 +12,7 @@ DTC_FLAGS_at91-sama5d3_eds := -@ > DTC_FLAGS_at91-sama5d3_xplained := -@ > DTC_FLAGS_at91-sama5d4_xplained := -@ > DTC_FLAGS_at91-sama7g5ek := -@ > +DTC_FLAGS_at91-sam9x75_curiosity := -@ Keep it alphanumerically sorted, thus after sam9x60 entry. > dtb-$(CONFIG_SOC_AT91RM9200) += \ > at91rm9200ek.dtb \ > mpa1600.dtb > @@ -59,6 +60,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \ > dtb-$(CONFIG_SOC_SAM9X60) += \ > at91-sam9x60_curiosity.dtb \ > at91-sam9x60ek.dtb > +dtb-$(CONFIG_SOC_SAM9X7) += \ > + at91-sam9x75_curiosity.dtb > dtb-$(CONFIG_SOC_SAM_V7) += \ > at91-kizbox2-2.dtb \ > at91-kizbox3-hs.dtb \ > diff --git a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > new file mode 100644 > index 000000000000..be37022d3d05 > --- /dev/null > +++ b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > @@ -0,0 +1,309 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * at91-sam9x75_curiosity.dts - Device Tree file for Microchip SAM9X75 Curiosity board > + * > + * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries > + * > + * Author: Varshini Rajendran <varshini.rajendran@microchip.com> > + */ > +/dts-v1/; > +#include "sam9x7.dtsi" > +#include <dt-bindings/input/input.h> > + > +/ { > + model = "Microchip SAM9X75 Curiosity"; > + compatible = "microchip,sam9x75-curiosity", "microchip,sam9x7", "atmel,at91sam9"; > + > + aliases { > + i2c0 = &i2c6; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_key_gpio_default>; > + > + button-user { > + label = "USER"; > + gpios = <&pioC 9 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_0>; > + wakeup-source; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_led_gpio_default>; > + > + led-red { > + label = "red"; > + gpios = <&pioC 19 GPIO_ACTIVE_HIGH>; > + }; > + > + led-green { > + label = "green"; > + gpios = <&pioC 21 GPIO_ACTIVE_HIGH>; > + }; > + > + led-blue { > + label = "blue"; > + gpios = <&pioC 20 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + memory@20000000 { > + device_type = "memory"; > + reg = <0x20000000 0x10000000>; > + }; > +}; > + > +&classd { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_classd>; > + atmel,pwm-type = "diff"; > + atmel,non-overlap-time = <10>; > + status = "okay"; > +}; > + > +&dbgu { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dbgu>; > + status = "okay"; > +}; > + > +&dma0 { > + status = "okay"; > +}; > + > +&flx6 { > + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>; > + status = "okay"; > +}; > + > +&i2c6 { I don't know if you got any review comments w/ regards to this in the previous email but having flexcoms and inner node grouped together is easier to follow (at least to me). e.g.: > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx6_default>; > + i2c-analog-filter; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <35>; > + status = "okay"; > + > + pmic@5b { > + compatible = "microchip,mcp16502"; > + reg = <0x5b>; > + > + regulators { > + vdd_3v3: VDD_IO { > + regulator-name = "VDD_IO"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3600000>; I can't find the schematics for this but these values here should reflect the voltage that the board support not the ones that the PMIC itself supports. Valid for all the other regulators. > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vddioddr: VDD_DDR { > + regulator-name = "VDD_DDR"; > + regulator-min-microvolt = <1283000>; > + regulator-max-microvolt = <1450000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + }; > + > + vddcore: VDD_CORE { > + regulator-name = "VDD_CORE"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1210000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vddcpu: VDD_OTHER { > + regulator-name = "VDD_OTHER"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3600000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-ramp-delay = <3125>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3700000>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + }; > + }; > + > + vldo2: LDO2 { > + regulator-name = "LDO2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3700000>; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + }; > + }; > + }; > + }; > +}; > + > +&i2s { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2s_default>; > + #sound-dai-cells = <0>; > + status = "disabled"; Any reason this is disabled? > +}; > + > +&main_xtal { > + clock-frequency = <24000000>; > +}; > + > +&pinctrl { > + This line could be removed. > + classd { > + pinctrl_classd: classd { > + atmel,pins = > + <AT91_PIOA 18 AT91_PERIPH_C AT91_PINCTRL_PULL_UP Try to be compliant with coding style from here (valid everywhere): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n167 > + AT91_PIOA 19 AT91_PERIPH_C AT91_PINCTRL_PULL_DOWN>; > + }; > + }; > + > + dbgu { > + pinctrl_dbgu: dbgu-0 { usually pinctrl label is something like the following in Microchip AT91 DTSes: pinctrl_<ip-name>_default and node name is <ip-name>-default. Please use the same rule everywhere. > + atmel,pins = <AT91_PIOA 26 AT91_PERIPH_A AT91_PINCTRL_PULL_UP > + AT91_PIOA 27 AT91_PERIPH_A AT91_PINCTRL_NONE>; > + }; > + }; > + > + flexcom { > + pinctrl_flx6_default: flx6-twi { > + atmel,pins = > + <AT91_PIOA 24 AT91_PERIPH_A AT91_PINCTRL_PULL_UP > + AT91_PIOA 25 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; > + }; > + }; > + > + gpio-keys { > + pinctrl_key_gpio_default: key-gpio-default { > + atmel,pins = <AT91_PIOC 9 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; > + }; > + }; > + > + i2s { > + pinctrl_i2s_default: i2s { > + atmel,pins = > + <AT91_PIOB 26 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SCK */ > + AT91_PIOB 15 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SWS */ > + AT91_PIOB 16 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SDIN */ > + AT91_PIOB 17 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SDOUT */ > + AT91_PIOB 25 AT91_PERIPH_D AT91_PINCTRL_NONE>; /* I2SMCK */ > + }; > + }; > + > + leds { > + pinctrl_led_gpio_default: led-gpio-default { > + atmel,pins = <AT91_PIOC 19 AT91_PERIPH_GPIO AT91_PINCTRL_NONE > + AT91_PIOC 21 AT91_PERIPH_GPIO AT91_PINCTRL_NONE > + AT91_PIOC 20 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; > + }; > + }; > + > + sdmmc0 { > + pinctrl_sdmmc0_default: sdmmc0 { > + atmel,pins = > + <AT91_PIOA 2 AT91_PERIPH_A (AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA2 CK periph A with pullup */ > + AT91_PIOA 1 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA1 CMD periph A with pullup */ > + AT91_PIOA 0 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA0 DAT0 periph A */ > + AT91_PIOA 3 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA3 DAT1 periph A with pullup */ > + AT91_PIOA 4 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA4 DAT2 periph A with pullup */ > + AT91_PIOA 5 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS)>; /* PA5 DAT3 periph A with pullup */ > + }; > + }; > + You can remove this line > +}; /* pinctrl */ > + > +&rtt { > + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > +}; > + > +&sdmmc0 { > + bus-width = <4>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sdmmc0_default>; > + cd-gpios = <&pioA 23 GPIO_ACTIVE_LOW>; > + disable-wp; > + status = "okay"; > +}; > + > +&slow_xtal { > + clock-frequency = <32768>; > +}; > + > +&power_management { > + debounce-delay-us = <976>; > + status = "okay"; > + > + input@0 { > + reg = <0>; > + }; > +}; > + > +&trng { > + status = "okay"; > +}; > + > +&watchdog { > + status = "okay"; > +};
WARNING: multiple messages have this Message-ID (diff)
From: claudiu beznea <claudiu.beznea@tuxon.dev> To: Varshini Rajendran <varshini.rajendran@microchip.com>, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, andre.przywara@arm.com, gregory.clement@bootlin.com, linus.walleij@linaro.org, baruch@tkos.co.il, mihai.sain@microchip.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 39/39] ARM: dts: at91: sam9x75_curiosity: add sam9x75 curiosity board Date: Sun, 3 Mar 2024 14:19:25 +0200 [thread overview] Message-ID: <b189dbc3-e875-45c9-b742-928a6a323d5c@tuxon.dev> (raw) In-Reply-To: <20240223173113.673595-1-varshini.rajendran@microchip.com> s/ARM: dts: at91/ARM: dts: microchip in title. On 23.02.2024 19:31, Varshini Rajendran wrote: > Add device tree file for sam9x75 curiosity board. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > Changes in v4: > - Removed full node paths > - Renamed Leds with color names > - Corrected regulator node names > - Added support for classd and i2s nodes and their corresponding > pinctrl nodes > - Dropped USB nodes owing to the discussion here > https://lore.kernel.org/linux-devicetree/CAL_JsqJ9PrX6fj-EbffeJce09MXs=B7t+KS_kOinxaRx38=WxA@mail.gmail.com/ > (Explained elaborately in the cover letter) > - Updated the linux,code property with the necessary value > --- > arch/arm/boot/dts/microchip/Makefile | 3 + > .../dts/microchip/at91-sam9x75_curiosity.dts | 309 ++++++++++++++++++ > 2 files changed, 312 insertions(+) > create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > > diff --git a/arch/arm/boot/dts/microchip/Makefile b/arch/arm/boot/dts/microchip/Makefile > index efde9546c8f4..5b3d518da319 100644 > --- a/arch/arm/boot/dts/microchip/Makefile > +++ b/arch/arm/boot/dts/microchip/Makefile > @@ -12,6 +12,7 @@ DTC_FLAGS_at91-sama5d3_eds := -@ > DTC_FLAGS_at91-sama5d3_xplained := -@ > DTC_FLAGS_at91-sama5d4_xplained := -@ > DTC_FLAGS_at91-sama7g5ek := -@ > +DTC_FLAGS_at91-sam9x75_curiosity := -@ Keep it alphanumerically sorted, thus after sam9x60 entry. > dtb-$(CONFIG_SOC_AT91RM9200) += \ > at91rm9200ek.dtb \ > mpa1600.dtb > @@ -59,6 +60,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \ > dtb-$(CONFIG_SOC_SAM9X60) += \ > at91-sam9x60_curiosity.dtb \ > at91-sam9x60ek.dtb > +dtb-$(CONFIG_SOC_SAM9X7) += \ > + at91-sam9x75_curiosity.dtb > dtb-$(CONFIG_SOC_SAM_V7) += \ > at91-kizbox2-2.dtb \ > at91-kizbox3-hs.dtb \ > diff --git a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > new file mode 100644 > index 000000000000..be37022d3d05 > --- /dev/null > +++ b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > @@ -0,0 +1,309 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * at91-sam9x75_curiosity.dts - Device Tree file for Microchip SAM9X75 Curiosity board > + * > + * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries > + * > + * Author: Varshini Rajendran <varshini.rajendran@microchip.com> > + */ > +/dts-v1/; > +#include "sam9x7.dtsi" > +#include <dt-bindings/input/input.h> > + > +/ { > + model = "Microchip SAM9X75 Curiosity"; > + compatible = "microchip,sam9x75-curiosity", "microchip,sam9x7", "atmel,at91sam9"; > + > + aliases { > + i2c0 = &i2c6; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_key_gpio_default>; > + > + button-user { > + label = "USER"; > + gpios = <&pioC 9 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_0>; > + wakeup-source; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_led_gpio_default>; > + > + led-red { > + label = "red"; > + gpios = <&pioC 19 GPIO_ACTIVE_HIGH>; > + }; > + > + led-green { > + label = "green"; > + gpios = <&pioC 21 GPIO_ACTIVE_HIGH>; > + }; > + > + led-blue { > + label = "blue"; > + gpios = <&pioC 20 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + memory@20000000 { > + device_type = "memory"; > + reg = <0x20000000 0x10000000>; > + }; > +}; > + > +&classd { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_classd>; > + atmel,pwm-type = "diff"; > + atmel,non-overlap-time = <10>; > + status = "okay"; > +}; > + > +&dbgu { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dbgu>; > + status = "okay"; > +}; > + > +&dma0 { > + status = "okay"; > +}; > + > +&flx6 { > + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>; > + status = "okay"; > +}; > + > +&i2c6 { I don't know if you got any review comments w/ regards to this in the previous email but having flexcoms and inner node grouped together is easier to follow (at least to me). e.g.: > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx6_default>; > + i2c-analog-filter; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <35>; > + status = "okay"; > + > + pmic@5b { > + compatible = "microchip,mcp16502"; > + reg = <0x5b>; > + > + regulators { > + vdd_3v3: VDD_IO { > + regulator-name = "VDD_IO"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3600000>; I can't find the schematics for this but these values here should reflect the voltage that the board support not the ones that the PMIC itself supports. Valid for all the other regulators. > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vddioddr: VDD_DDR { > + regulator-name = "VDD_DDR"; > + regulator-min-microvolt = <1283000>; > + regulator-max-microvolt = <1450000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + }; > + > + vddcore: VDD_CORE { > + regulator-name = "VDD_CORE"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1210000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vddcpu: VDD_OTHER { > + regulator-name = "VDD_OTHER"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3600000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-ramp-delay = <3125>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3700000>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + }; > + }; > + > + vldo2: LDO2 { > + regulator-name = "LDO2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3700000>; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + }; > + }; > + }; > + }; > +}; > + > +&i2s { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2s_default>; > + #sound-dai-cells = <0>; > + status = "disabled"; Any reason this is disabled? > +}; > + > +&main_xtal { > + clock-frequency = <24000000>; > +}; > + > +&pinctrl { > + This line could be removed. > + classd { > + pinctrl_classd: classd { > + atmel,pins = > + <AT91_PIOA 18 AT91_PERIPH_C AT91_PINCTRL_PULL_UP Try to be compliant with coding style from here (valid everywhere): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n167 > + AT91_PIOA 19 AT91_PERIPH_C AT91_PINCTRL_PULL_DOWN>; > + }; > + }; > + > + dbgu { > + pinctrl_dbgu: dbgu-0 { usually pinctrl label is something like the following in Microchip AT91 DTSes: pinctrl_<ip-name>_default and node name is <ip-name>-default. Please use the same rule everywhere. > + atmel,pins = <AT91_PIOA 26 AT91_PERIPH_A AT91_PINCTRL_PULL_UP > + AT91_PIOA 27 AT91_PERIPH_A AT91_PINCTRL_NONE>; > + }; > + }; > + > + flexcom { > + pinctrl_flx6_default: flx6-twi { > + atmel,pins = > + <AT91_PIOA 24 AT91_PERIPH_A AT91_PINCTRL_PULL_UP > + AT91_PIOA 25 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; > + }; > + }; > + > + gpio-keys { > + pinctrl_key_gpio_default: key-gpio-default { > + atmel,pins = <AT91_PIOC 9 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; > + }; > + }; > + > + i2s { > + pinctrl_i2s_default: i2s { > + atmel,pins = > + <AT91_PIOB 26 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SCK */ > + AT91_PIOB 15 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SWS */ > + AT91_PIOB 16 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SDIN */ > + AT91_PIOB 17 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SDOUT */ > + AT91_PIOB 25 AT91_PERIPH_D AT91_PINCTRL_NONE>; /* I2SMCK */ > + }; > + }; > + > + leds { > + pinctrl_led_gpio_default: led-gpio-default { > + atmel,pins = <AT91_PIOC 19 AT91_PERIPH_GPIO AT91_PINCTRL_NONE > + AT91_PIOC 21 AT91_PERIPH_GPIO AT91_PINCTRL_NONE > + AT91_PIOC 20 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; > + }; > + }; > + > + sdmmc0 { > + pinctrl_sdmmc0_default: sdmmc0 { > + atmel,pins = > + <AT91_PIOA 2 AT91_PERIPH_A (AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA2 CK periph A with pullup */ > + AT91_PIOA 1 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA1 CMD periph A with pullup */ > + AT91_PIOA 0 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA0 DAT0 periph A */ > + AT91_PIOA 3 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA3 DAT1 periph A with pullup */ > + AT91_PIOA 4 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA4 DAT2 periph A with pullup */ > + AT91_PIOA 5 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS)>; /* PA5 DAT3 periph A with pullup */ > + }; > + }; > + You can remove this line > +}; /* pinctrl */ > + > +&rtt { > + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > +}; > + > +&sdmmc0 { > + bus-width = <4>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sdmmc0_default>; > + cd-gpios = <&pioA 23 GPIO_ACTIVE_LOW>; > + disable-wp; > + status = "okay"; > +}; > + > +&slow_xtal { > + clock-frequency = <32768>; > +}; > + > +&power_management { > + debounce-delay-us = <976>; > + status = "okay"; > + > + input@0 { > + reg = <0>; > + }; > +}; > + > +&trng { > + status = "okay"; > +}; > + > +&watchdog { > + status = "okay"; > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-03 12:19 UTC|newest] Thread overview: 179+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-23 17:13 [PATCH v4 00/39] Add support for sam9x7 SoC family Varshini Rajendran 2024-02-23 17:13 ` Varshini Rajendran 2024-02-23 17:22 ` [PATCH v4 01/39] dt-bindings: net: cdns,macb: add sam9x7 ethernet interface Varshini Rajendran 2024-02-23 17:22 ` [PATCH v4 02/39] dt-bindings: atmel-sysreg: add sam9x7 Varshini Rajendran 2024-02-23 17:22 ` Varshini Rajendran 2024-02-23 17:23 ` [PATCH v4 03/39] dt-bindings: crypto: add sam9x7 in Atmel AES Varshini Rajendran 2024-02-23 17:23 ` Varshini Rajendran 2024-02-26 9:18 ` Tudor Ambarus 2024-02-26 9:18 ` Tudor Ambarus 2024-02-23 17:23 ` [PATCH v4 04/39] dt-bindings: crypto: add sam9x7 in Atmel SHA Varshini Rajendran 2024-02-23 17:23 ` Varshini Rajendran 2024-02-26 9:23 ` Tudor Ambarus 2024-02-26 9:23 ` Tudor Ambarus 2024-02-23 17:24 ` [PATCH v4 05/39] dt-bindings: crypto: add sam9x7 in Atmel TDES Varshini Rajendran 2024-02-23 17:24 ` Varshini Rajendran 2024-02-24 19:50 ` Conor Dooley 2024-02-24 19:50 ` Conor Dooley 2024-02-26 9:24 ` Tudor Ambarus 2024-02-26 9:24 ` Tudor Ambarus 2024-02-23 17:24 ` [PATCH v4 06/39] dt-bindings: i2c: at91: Add sam9x7 compatible string Varshini Rajendran 2024-02-23 17:24 ` Varshini Rajendran 2024-02-24 19:49 ` Conor Dooley 2024-02-24 19:49 ` Conor Dooley 2024-02-23 17:25 ` [PATCH v4 07/39] dt-bindings: atmel-ssc: add microchip,sam9x7-ssc Varshini Rajendran 2024-02-23 17:25 ` Varshini Rajendran 2024-02-23 17:25 ` [PATCH v4 08/39] dt-bindings: atmel-nand: add microchip,sam9x7-pmecc Varshini Rajendran 2024-02-23 17:25 ` Varshini Rajendran 2024-02-23 17:25 ` Varshini Rajendran 2024-02-24 19:50 ` Conor Dooley 2024-02-24 19:50 ` Conor Dooley 2024-02-24 19:50 ` Conor Dooley 2024-02-26 10:43 ` Miquel Raynal 2024-02-26 10:43 ` Miquel Raynal 2024-02-26 10:43 ` Miquel Raynal 2024-02-23 17:25 ` [PATCH v4 09/39] dt-bindings: pinctrl: at91: add sam9x7 Varshini Rajendran 2024-02-23 17:25 ` Varshini Rajendran 2024-02-29 13:41 ` Linus Walleij 2024-02-29 13:41 ` Linus Walleij 2024-02-23 17:25 ` [PATCH v4 10/39] dt-bindings: rng: atmel,at91-trng: add sam9x7 TRNG Varshini Rajendran 2024-02-23 17:25 ` Varshini Rajendran 2024-02-23 17:25 ` [PATCH v4 11/39] dt-bindings: rtt: at91rm9260: add sam9x7 compatible Varshini Rajendran 2024-02-23 17:25 ` Varshini Rajendran 2024-02-24 19:51 ` Conor Dooley 2024-02-24 19:51 ` Conor Dooley 2024-02-29 21:27 ` (subset) " Alexandre Belloni 2024-02-29 21:27 ` Alexandre Belloni 2024-02-23 17:25 ` [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7 Varshini Rajendran 2024-02-23 17:25 ` Varshini Rajendran 2024-02-24 20:02 ` Conor Dooley 2024-02-24 20:02 ` Conor Dooley 2024-02-28 7:03 ` Varshini.Rajendran 2024-02-28 7:03 ` Varshini.Rajendran 2024-02-28 11:49 ` Conor Dooley 2024-02-28 11:49 ` Conor Dooley 2024-02-29 8:55 ` Varshini.Rajendran 2024-02-29 8:55 ` Varshini.Rajendran 2024-02-29 18:26 ` Conor Dooley 2024-02-29 18:26 ` Conor Dooley 2024-02-23 17:26 ` [PATCH v4 13/39] ASoC: dt-bindings: atmel-classd: add sam9x7 compatible Varshini Rajendran 2024-02-23 17:26 ` Varshini Rajendran 2024-02-24 19:48 ` Conor Dooley 2024-02-24 19:48 ` Conor Dooley 2024-02-23 17:26 ` [PATCH v4 14/39] dt-bindings: pwm: at91: Add sam9x7 compatible strings list Varshini Rajendran 2024-02-23 17:26 ` Varshini Rajendran 2024-02-24 20:03 ` Conor Dooley 2024-02-24 20:03 ` Conor Dooley [not found] ` <igmm3npqcnjuhhncfd22pjhjuzbtsl25jfzbpcsyx5bu2xbbto@ynp7psnpldxr> 2024-03-18 8:55 ` Uwe Kleine-König 2024-03-18 8:55 ` Uwe Kleine-König 2024-02-23 17:26 ` [PATCH v4 15/39] dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt Varshini Rajendran 2024-02-23 17:26 ` Varshini Rajendran 2024-02-24 20:04 ` Conor Dooley 2024-02-24 20:04 ` Conor Dooley 2024-02-23 17:26 ` [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list Varshini Rajendran 2024-02-23 17:26 ` Varshini Rajendran 2024-02-26 9:09 ` Tudor Ambarus 2024-02-26 9:09 ` Tudor Ambarus 2024-02-28 9:28 ` Varshini.Rajendran 2024-02-28 9:28 ` Varshini.Rajendran 2024-02-28 9:38 ` Tudor Ambarus 2024-02-28 9:38 ` Tudor Ambarus 2024-02-23 17:26 ` [PATCH v4 17/39] ASoC: dt-bindings: microchip: add sam9x7 Varshini Rajendran 2024-02-23 17:27 ` [PATCH v4 18/39] ARM: at91: pm: add support for sam9x7 SoC family Varshini Rajendran 2024-02-23 17:27 ` Varshini Rajendran 2024-03-03 12:20 ` claudiu beznea 2024-03-03 12:20 ` claudiu beznea 2024-02-23 17:27 ` [PATCH v4 19/39] ARM: at91: pm: add sam9x7 SoC init config Varshini Rajendran 2024-02-23 17:27 ` Varshini Rajendran 2024-03-03 12:20 ` claudiu beznea 2024-03-03 12:20 ` claudiu beznea 2024-02-23 17:27 ` [PATCH v4 20/39] ARM: at91: add support in SoC driver for new sam9x7 Varshini Rajendran 2024-02-23 17:27 ` Varshini Rajendran 2024-02-26 17:01 ` Nicolas Ferre 2024-02-26 17:01 ` Nicolas Ferre 2024-03-03 12:21 ` claudiu beznea 2024-03-03 12:21 ` claudiu beznea 2024-02-23 17:27 ` [PATCH v4 21/39] dt-bindings: clk: at91: add sam9x7 Varshini Rajendran 2024-02-23 17:27 ` Varshini Rajendran 2024-02-24 20:05 ` Conor Dooley 2024-02-24 20:05 ` Conor Dooley 2024-03-11 5:32 ` claudiu beznea 2024-03-11 5:32 ` claudiu beznea 2024-02-23 17:27 ` [PATCH v4 22/39] dt-bindings: clk: at91: add sam9x7 clock controller Varshini Rajendran 2024-02-23 17:27 ` Varshini Rajendran 2024-02-24 20:06 ` Conor Dooley 2024-02-24 20:06 ` Conor Dooley 2024-03-11 5:33 ` claudiu beznea 2024-03-11 5:33 ` claudiu beznea 2024-02-23 17:27 ` [PATCH v4 23/39] clk: at91: clk-sam9x60-pll: re-factor to support individual core freq outputs Varshini Rajendran 2024-02-23 17:27 ` Varshini Rajendran 2024-02-23 17:27 ` [PATCH v4 24/39] clk: at91: sam9x7: add support for HW PLL freq dividers Varshini Rajendran 2024-02-23 17:27 ` Varshini Rajendran 2024-03-11 5:34 ` claudiu beznea 2024-03-11 5:34 ` claudiu beznea 2024-02-23 17:28 ` [PATCH v4 25/39] clk: at91: sama7g5: move mux table macros to header file Varshini Rajendran 2024-02-23 17:28 ` Varshini Rajendran 2024-02-23 17:28 ` [PATCH v4 26/39] dt-bindings: clock: at91: Allow PLLs to be exported and referenced in DT Varshini Rajendran 2024-02-23 17:28 ` Varshini Rajendran 2024-03-01 21:26 ` Rob Herring 2024-03-01 21:26 ` Rob Herring 2024-02-23 17:28 ` [PATCH v4 27/39] clk: at91: sam9x7: add sam9x7 pmc driver Varshini Rajendran 2024-02-23 17:28 ` Varshini Rajendran 2024-03-11 5:58 ` claudiu beznea 2024-03-11 5:58 ` claudiu beznea 2024-03-18 9:25 ` Varshini.Rajendran 2024-03-18 9:25 ` Varshini.Rajendran 2024-03-18 20:17 ` claudiu beznea 2024-03-18 20:17 ` claudiu beznea 2024-02-23 17:28 ` [PATCH v4 28/39] dt-bindings: irqchip/atmel-aic5: Add support for sam9x7 aic Varshini Rajendran 2024-02-23 17:28 ` Varshini Rajendran 2024-02-23 17:29 ` [PATCH v4 29/39] irqchip/atmel-aic5: Add support to get nirqs from DT for sam9x60 & sam9x7 Varshini Rajendran 2024-02-23 17:29 ` Varshini Rajendran 2024-03-03 12:21 ` claudiu beznea 2024-03-03 12:21 ` claudiu beznea 2024-03-08 8:50 ` Varshini.Rajendran 2024-03-08 8:50 ` Varshini.Rajendran 2024-03-08 10:15 ` Conor Dooley 2024-03-08 10:15 ` Conor Dooley 2024-03-09 13:13 ` claudiu beznea 2024-03-09 13:13 ` claudiu beznea 2024-02-23 17:29 ` [PATCH v4 30/39] power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7 Varshini Rajendran 2024-02-23 17:29 ` Varshini Rajendran 2024-03-03 12:22 ` claudiu beznea 2024-03-03 12:22 ` claudiu beznea 2024-02-23 17:29 ` [PATCH v4 31/39] power: reset: at91-reset: add reset support for sam9x7 SoC Varshini Rajendran 2024-02-23 17:30 ` [PATCH v4 32/39] power: reset: at91-reset: add sdhwc " Varshini Rajendran 2024-02-23 17:30 ` [PATCH v4 33/39] dt-bindings: reset: atmel,at91sam9260-reset: add sam9x7 Varshini Rajendran 2024-02-23 17:30 ` Varshini Rajendran 2024-02-23 17:30 ` [PATCH v4 34/39] dt-bindings: power: reset: atmel,sama5d2-shdwc: " Varshini Rajendran 2024-02-23 17:30 ` Varshini Rajendran 2024-02-23 17:30 ` [PATCH v4 35/39] ARM: at91: Kconfig: add config flag for SAM9X7 SoC Varshini Rajendran 2024-02-23 17:30 ` Varshini Rajendran 2024-03-03 12:22 ` claudiu beznea 2024-03-03 12:22 ` claudiu beznea 2024-02-23 17:30 ` [PATCH v4 36/39] ARM: configs: at91: enable config flags for sam9x7 SoC family Varshini Rajendran 2024-02-23 17:30 ` Varshini Rajendran 2024-02-23 17:30 ` [PATCH v4 37/39] ARM: dts: at91: sam9x7: add device tree for SoC Varshini Rajendran 2024-03-03 12:24 ` claudiu beznea 2024-03-04 16:33 ` Varshini.Rajendran 2024-03-06 8:38 ` claudiu beznea 2024-02-23 17:31 ` [PATCH v4 38/39] dt-bindings: arm: add sam9x75 curiosity board Varshini Rajendran 2024-02-23 17:31 ` Varshini Rajendran 2024-03-01 21:26 ` Rob Herring 2024-03-01 21:26 ` Rob Herring 2024-02-23 17:31 ` [PATCH v4 39/39] ARM: dts: at91: sam9x75_curiosity: " Varshini Rajendran 2024-02-23 17:31 ` Varshini Rajendran 2024-03-03 12:19 ` claudiu beznea [this message] 2024-03-03 12:19 ` claudiu beznea 2024-03-08 9:48 ` Varshini.Rajendran 2024-03-08 9:48 ` Varshini.Rajendran 2024-02-24 1:18 ` (subset) [PATCH v4 00/39] Add support for sam9x7 SoC family Mark Brown 2024-02-24 1:18 ` Mark Brown 2024-02-27 1:21 ` Andi Shyti 2024-02-27 1:21 ` Andi Shyti 2024-02-27 3:20 ` patchwork-bot+netdevbpf 2024-02-27 3:20 ` patchwork-bot+netdevbpf 2024-02-28 15:53 ` (subset) " Mark Brown 2024-02-28 15:53 ` Mark Brown 2024-03-01 10:51 ` Herbert Xu 2024-03-01 10:51 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b189dbc3-e875-45c9-b742-928a6a323d5c@tuxon.dev \ --to=claudiu.beznea@tuxon.dev \ --cc=alexandre.belloni@bootlin.com \ --cc=andre.przywara@arm.com \ --cc=baruch@tkos.co.il \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@bootlin.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mihai.sain@microchip.com \ --cc=nicolas.ferre@microchip.com \ --cc=robh+dt@kernel.org \ --cc=varshini.rajendran@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.