From: "Pablo Sebastián Greco" <pgreco@centosproject.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Add Bluetooth device node
Date: Thu, 18 Apr 2019 13:14:35 -0300 [thread overview]
Message-ID: <bc5d7e91-74c5-103a-db72-6cb1f3ef53b9@centosproject.org> (raw)
In-Reply-To: <20190418155613.shiv7geoqyzfy4kf@flea>
El 18/4/19 a las 12:56, Maxime Ripard escribió:
> On Thu, Apr 18, 2019 at 12:11:20PM -0300, Pablo Greco wrote:
>> Since the bananapi-m2-ultra and the bananapi-m2-berry have the same
>> WiFi/Bluetooth, add the required nodes to the bananapi-m2-berry.
>>
>> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
>> ---
>> arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 26 +++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
>> index 78f4a1a..3d0bb7e 100644
>> --- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
>> +++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
>> @@ -96,6 +96,8 @@
>> wifi_pwrseq: wifi_pwrseq {
>> compatible = "mmc-pwrseq-simple";
>> reset-gpios = <&pio 6 10 GPIO_ACTIVE_LOW>; /* PG10 WIFI_EN */
>> + clocks = <&ccu CLK_OUTA>;
>> + clock-names = "ext_clock";
>> };
>> };
>>
>> @@ -171,6 +173,11 @@
>> status = "okay";
>> };
>>
>> +&pio {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&clk_out_a_pin>;
>> +};
>> +
> I'm not sure you answered my question about why that is needed?
Because it is the same case as
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts?id=1e5f1db4ccd8348a21da55bff82f4263000879ef
I can repeat that info in this commit log
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
>
Pablo.
WARNING: multiple messages have this Message-ID (diff)
From: "Pablo Sebastián Greco" <pgreco@centosproject.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 5/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Add Bluetooth device node
Date: Thu, 18 Apr 2019 13:14:35 -0300 [thread overview]
Message-ID: <bc5d7e91-74c5-103a-db72-6cb1f3ef53b9@centosproject.org> (raw)
In-Reply-To: <20190418155613.shiv7geoqyzfy4kf@flea>
El 18/4/19 a las 12:56, Maxime Ripard escribió:
> On Thu, Apr 18, 2019 at 12:11:20PM -0300, Pablo Greco wrote:
>> Since the bananapi-m2-ultra and the bananapi-m2-berry have the same
>> WiFi/Bluetooth, add the required nodes to the bananapi-m2-berry.
>>
>> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
>> ---
>> arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 26 +++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
>> index 78f4a1a..3d0bb7e 100644
>> --- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
>> +++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
>> @@ -96,6 +96,8 @@
>> wifi_pwrseq: wifi_pwrseq {
>> compatible = "mmc-pwrseq-simple";
>> reset-gpios = <&pio 6 10 GPIO_ACTIVE_LOW>; /* PG10 WIFI_EN */
>> + clocks = <&ccu CLK_OUTA>;
>> + clock-names = "ext_clock";
>> };
>> };
>>
>> @@ -171,6 +173,11 @@
>> status = "okay";
>> };
>>
>> +&pio {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&clk_out_a_pin>;
>> +};
>> +
> I'm not sure you answered my question about why that is needed?
Because it is the same case as
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts?id=1e5f1db4ccd8348a21da55bff82f4263000879ef
I can repeat that info in this commit log
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
>
Pablo.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-18 16:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 15:11 [PATCH v4 0/7] ARM: dts: sun8i: v40 Rewrite BPi M2 Berry DTS based on BPi M2 Ultra Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:11 ` [PATCH v4 1/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:55 ` Maxime Ripard
2019-04-18 15:55 ` Maxime Ripard
2019-04-18 15:55 ` Maxime Ripard
2019-04-18 15:11 ` [PATCH v4 2/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Enable HDMI output Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:11 ` [PATCH v4 3/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Enable AHCI Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:11 ` [PATCH v4 4/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix WiFi regulator definitions Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:11 ` [PATCH v4 5/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Add Bluetooth device node Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:56 ` Maxime Ripard
2019-04-18 15:56 ` Maxime Ripard
2019-04-18 15:56 ` Maxime Ripard
2019-04-18 16:14 ` Pablo Sebastián Greco [this message]
2019-04-18 16:14 ` Pablo Sebastián Greco
2019-04-23 16:12 ` Maxime Ripard
2019-04-23 16:12 ` Maxime Ripard
2019-04-18 15:11 ` [PATCH v4 6/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Add GPIO pin-bank regulator supplies Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:11 ` Pablo Greco
2019-04-18 15:54 ` Maxime Ripard
2019-04-18 15:54 ` Maxime Ripard
2019-04-18 15:54 ` Maxime Ripard
2019-04-18 15:11 ` [PATCH v4 7/7] ARM: dts: sun8i: r40: bananapi-m2-ultra: " Pablo Greco
2019-04-18 15:11 ` Pablo Greco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc5d7e91-74c5-103a-db72-6cb1f3ef53b9@centosproject.org \
--to=pgreco@centosproject.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.