From: Vlastimil Babka <vbabka@suse.cz>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: cocci@inria.fr
Subject: Re: [cocci] Need some help with spatch
Date: Fri, 5 Nov 2021 22:32:05 +0100 [thread overview]
Message-ID: <790dd83b-9b89-c4db-6b2a-6ffd0dd27aac@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2111052230480.3000@hadrien>
On 11/5/21 22:31, Julia Lawall wrote:
>> 3) eliminated whitespace including newlines
>>
>> This is stylistic but will require some postprocessing fixups if not solved.
>> There seem to be several cases like this where whitespace including newlines
>> is eliminated between two lines that are patched by the spatch:
>>
>> - struct page *page;
>> -
>> - page = container_of(h, struct page, rcu_head);
>> + struct slab *slab;slab = container_of(h, struct page, rcu_head);
>
> Which semantic patch causes this problem?
That's also 184d9494c1a4 slub.cocci
next prev parent reply other threads:[~2021-11-05 21:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 16:12 [cocci] Need some help with spatch Vlastimil Babka
2021-11-05 16:20 ` Luis Chamberlain
2021-11-06 6:44 ` Julia Lawall
2021-11-07 23:08 ` Vlastimil Babka
2021-11-08 14:35 ` Vlastimil Babka
2021-11-08 14:45 ` Julia Lawall
2021-11-08 16:53 ` Vlastimil Babka
2021-11-08 17:01 ` Julia Lawall
2021-11-05 20:56 ` Julia Lawall
2021-11-05 21:13 ` Julia Lawall
2021-11-05 21:24 ` Vlastimil Babka
2021-11-05 21:27 ` Julia Lawall
2021-11-05 21:31 ` Julia Lawall
2021-11-05 21:32 ` Vlastimil Babka [this message]
2021-11-05 21:43 ` Julia Lawall
2021-11-05 21:59 ` Julia Lawall
2021-11-06 15:36 ` [cocci] mm/slab: mass conversion of struct page to struct slab by spatch Markus Elfring
2021-11-07 12:10 ` [cocci] mm/slab: prepare for struct patch conversion " Markus Elfring
2021-11-07 12:22 ` Julia Lawall
2021-11-07 12:50 ` [cocci] mm/slab: prepare for struct page " Markus Elfring
2021-11-07 13:18 ` Julia Lawall
2021-11-07 13:40 ` Markus Elfring
2021-11-07 17:50 ` Vlastimil Babka
2021-11-07 18:09 ` Julia Lawall
2021-11-08 17:35 ` Markus Elfring
2021-11-08 17:40 ` Julia Lawall
2021-11-08 23:35 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=790dd83b-9b89-c4db-6b2a-6ffd0dd27aac@suse.cz \
--to=vbabka@suse.cz \
--cc=cocci@inria.fr \
--cc=julia.lawall@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).