From: Markus Elfring <Markus.Elfring@web.de>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: cocci@inria.fr
Subject: Re: [cocci] mm/slab: prepare for struct patch conversion by spatch
Date: Sun, 7 Nov 2021 13:10:13 +0100 [thread overview]
Message-ID: <a02a8c42-011d-0f9c-6a2f-7d45a3f216a5@web.de> (raw)
In-Reply-To: <17a7a40f-b736-e0ea-02ae-1b03ef4483bf@suse.cz>
> Because a lot of the changes there are mechanistic, I thought it would be a
> good idea to perform them via coccinelle semantic patch. But it's my first
> attempt at large real usage of spatch, and it probably shows.
I guess that your clarification request will trigger further collateral evolution.
Thus I suggest to reconsider also another commit message from your software
development branch accordingly.
https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/commit/?h=slab-struct_slab-v1r8&id=8a685ebb3b2a10c1d781d5b3e6ad0315ce9323d6
“This patch splits several declarations of multiple variables, or declarations
that include initial assignments, to separate lines, due to my inability to
make a coccinelle semantic patch match on those declarations.”
* How do you think about to specify desirable change preparations by the means of
the semantic patch language?
* Will any guidance help to find nicer solutions?
Regards,
Markus
next prev parent reply other threads:[~2021-11-07 12:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 16:12 [cocci] Need some help with spatch Vlastimil Babka
2021-11-05 16:20 ` Luis Chamberlain
2021-11-06 6:44 ` Julia Lawall
2021-11-07 23:08 ` Vlastimil Babka
2021-11-08 14:35 ` Vlastimil Babka
2021-11-08 14:45 ` Julia Lawall
2021-11-08 16:53 ` Vlastimil Babka
2021-11-08 17:01 ` Julia Lawall
2021-11-05 20:56 ` Julia Lawall
2021-11-05 21:13 ` Julia Lawall
2021-11-05 21:24 ` Vlastimil Babka
2021-11-05 21:27 ` Julia Lawall
2021-11-05 21:31 ` Julia Lawall
2021-11-05 21:32 ` Vlastimil Babka
2021-11-05 21:43 ` Julia Lawall
2021-11-05 21:59 ` Julia Lawall
2021-11-06 15:36 ` [cocci] mm/slab: mass conversion of struct page to struct slab by spatch Markus Elfring
2021-11-07 12:10 ` Markus Elfring [this message]
2021-11-07 12:22 ` [cocci] mm/slab: prepare for struct patch conversion " Julia Lawall
2021-11-07 12:50 ` [cocci] mm/slab: prepare for struct page " Markus Elfring
2021-11-07 13:18 ` Julia Lawall
2021-11-07 13:40 ` Markus Elfring
2021-11-07 17:50 ` Vlastimil Babka
2021-11-07 18:09 ` Julia Lawall
2021-11-08 17:35 ` Markus Elfring
2021-11-08 17:40 ` Julia Lawall
2021-11-08 23:35 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a02a8c42-011d-0f9c-6a2f-7d45a3f216a5@web.de \
--to=markus.elfring@web.de \
--cc=cocci@inria.fr \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).