Re: [cocci] Need some help with spatch

[Julia Lawall <julia.lawall@inria.fr>]

> for example the cocci patch is supposed to change all "page" to "slab", but
> some lines are patched like this:
>
> -       __free_slab(page->slab_cache, page);
> +       __free_slab(page->slab_cache, slab);

In the original definition of rcu_free_slab, the second argument has the
form page_slab(page).  This triggers the first disjunct of:

(
- page_slab(page)
+ slab
|
- compound_order(page)
+ slab_order(slab)
|
- PageSlab(page)
+ PageSlab(slab_page(slab))
|
- page_address(page)
+ slab_address(slab)
|
- page_size(page)
+ slab_size(slab)
|
- page_to_nid(page)
+ slab_nid(slab)
|
- page->pages
+ slab->slabs
|
- page
+ slab
)


Once a disjuntc has been chosen for a particular statement, then the
remaining ones are not taken into account.  So -page + slab is not taken
into account.

I wonder if you could just have one rule to change all occurences of page
to slab, and then have individual rules to change eg page_address(slab) to
slab_address(slab).  Then all the cases should be taken into account.

julia