Re: [cocci] mm/slab: mass conversion of struct page to struct slab by spatch

[Markus Elfring <Markus.Elfring@web.de>]

> Thanks in advance for any hints!

I have also taken another look at the proposed SmPL script file.
https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/diff/slab.cocci?h=slab-struct_slab-v1r8&id=ccd7da3f3888df4acd82448f861445d4593a9fcb

I have noticed then a few opportunities for a bit of fine-tuning
for the presented code according to the semantic patch language.


@convert_callers@
@@
(
(
-account_slab_page
+account_slab
|
-unaccount_slab_page
+unaccount_slab
)
  (
- page
+ slab
  , ...)
|
(
-PageSlabPfmemalloc
+slab_test_pfmemalloc
|
-ClearPageSlabPfmemalloc
+slab_clear_pfmemalloc
)
  (
- page
+ slab
  )
)

@convert_list_entry@
identifier fn =~ "^list_\w*entry(?:_or_null)?";
@@
-page
+slab
       = fn(...,
-          struct page
+          struct slab
            , ...)

@convert_param_struct_page_ptr@
identifier fn;
expression E;
@@
  fn(...,
-   struct page *page
+   struct slab *slab
     , ...)
  {
  <...
(
-page_node
+slab_node
|
-page_slab(page)
+slab
|
(
-page_address
+slab_address
|
-page_size
+slab_size
|
-page_to_nid
+slab_nid
)
  (
- page
+ slab
  )
|
-virt_to_head_page
+virt_to_slab
  (E)
|
-page
+slab
)
  ...>
  }

@convert_param_page_node@
identifier fn;
expression E;
@@
  fn(...,
     int
-       page_node
+       slab_node
     , ...)
  {
  <...
-page_node
+slab_node
  ...>
  }

@remove_slab_page_wrappers@
expression E;
@@
  index_to_obj(...,
-             slab_page(
                         E
-                      )
+             , ...)

@rename_called_function_parameter@
@@
  TODO(...,
-     page
+     slab
       , ...)

@convert_return_struct_page@
identifier fn =~ "^(?:cache_grow_begin|get_(?:valid_)?first_slab)";
expression E;
@@
  static
-struct page *
+struct slab *
  fn(...)
  {
  <...
-slab_page(
            E
-         )
  ...>
  }

@convert_local_struct_page@
identifier fn !~ "^kmem_(?:get|free)pages", tmp;
expression E;
@@
  fn(...)
  {
  <...
(
-struct page *page
+struct slab *slab
  ;
|
-struct page *
+struct slab *
  tmp;
|
-page_slab(page)
+slab
|
  kasan_poison_slab(
-                  page
+                  slab_page(slab)
                   )
|
(
-page_address
+slab_address
|
-page_size
+slab_size
|
-page_to_nid
+slab_nid
)
  (
- page
+ slab
  )
|
-page->pages
+slab->slabs
|
-page = virt_to_head_page
+slab = virt_to_slab
  (E)
|
-page
+slab
)
  ...>
  }


Regards,
Markus