Coccinelle archive on lore.kernel.org
 help / color / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] const in parameter lists
Date: Thu, 12 Sep 2019 16:49:32 +0200 (CEST)
Message-ID: <alpine.DEB.2.21.1909121648550.2876@hadrien> (raw)
In-Reply-To: <9ba987e2-c6a2-cf6a-5a94-8bf841a6e195@web.de>



On Thu, 12 Sep 2019, Markus Elfring wrote:

> > drbd_submit_peer_request(...
> > -    , const unsigned op, const unsigned op_flags
> > +    , const unsigned rw
> >  ,...)
> > {
> > ...
> > }
>
> How do you think about the following SmPL change specification?
>
>  drbd_submit_peer_request(...,
> -                         const unsigned op,
>                           const unsigned
> -                                        op_flags
> +                                        rw
>                           , ...)
>  {
>  ...
>  }

It would really be helpful if you would actually test things before
proposing them.  This produces the same parse error as the other options.

julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 11:13 Christoph Böhmwalder
2019-09-12 11:31 ` Julia Lawall
2019-09-12 12:34   ` Christoph Böhmwalder
2019-09-12 12:50     ` Julia Lawall
2019-09-12 14:33     ` Markus Elfring
2019-09-12 14:49       ` Julia Lawall [this message]
2019-09-12 14:56         ` Markus Elfring
2019-09-14 20:00     ` Julia Lawall
2019-09-15 11:38       ` Markus Elfring

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1909121648550.2876@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr cocci@archiver.kernel.org
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox