From: Matthias Brugger <matthias.bgg@gmail.com> To: Zhi Mao <zhi.mao@mediatek.com>, john@phrozen.org, Thierry Reding <thierry.reding@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-pwm@vger.kernel.org Cc: srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, yingjoe.chen@mediatek.com, yt.shen@mediatek.com, sean.wang@mediatek.com, zhenbao.liu@mediatek.com Subject: Re: [PATCH v3 2/6] pwm: mediatek: fix pwm source clock selection Date: Wed, 5 Jul 2017 13:09:44 +0200 [thread overview] Message-ID: <d009712e-f0a2-2dc7-2f64-ad8cfa21f98d@gmail.com> (raw) In-Reply-To: <1498802721-32455-3-git-send-email-zhi.mao@mediatek.com> On 06/30/2017 08:05 AM, Zhi Mao wrote: > In original code, the pwm output frequency is not correct > when set bit<3>=1 to PWMCON register. > > Signed-off-by: Zhi Mao <zhi.mao@mediatek.com> > --- > drivers/pwm/pwm-mediatek.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c > index 5c11bc7..d08b5b3 100644 > --- a/drivers/pwm/pwm-mediatek.c > +++ b/drivers/pwm/pwm-mediatek.c > @@ -91,7 +91,7 @@ static int mtk_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, > if (clkdiv > 7) > return -EINVAL; > > - mtk_pwm_writel(pc, pwm->hwpwm, PWMCON, BIT(15) | BIT(3) | clkdiv); > + mtk_pwm_writel(pc, pwm->hwpwm, PWMCON, BIT(15) | clkdiv); Just for clarification, BIT(15) enables old PWM mode, which ignores CLKSEL (BIT(3)). Therefore setting BIT(3) does not have any effect and can be discarded. Am I correct? I took mt7623n datasheet for reference. Regards, Matthias > mtk_pwm_writel(pc, pwm->hwpwm, PWMDWIDTH, period_ns / resolution); > mtk_pwm_writel(pc, pwm->hwpwm, PWMTHRES, duty_ns / resolution); > >
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/6] pwm: mediatek: fix pwm source clock selection Date: Wed, 5 Jul 2017 13:09:44 +0200 [thread overview] Message-ID: <d009712e-f0a2-2dc7-2f64-ad8cfa21f98d@gmail.com> (raw) In-Reply-To: <1498802721-32455-3-git-send-email-zhi.mao@mediatek.com> On 06/30/2017 08:05 AM, Zhi Mao wrote: > In original code, the pwm output frequency is not correct > when set bit<3>=1 to PWMCON register. > > Signed-off-by: Zhi Mao <zhi.mao@mediatek.com> > --- > drivers/pwm/pwm-mediatek.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c > index 5c11bc7..d08b5b3 100644 > --- a/drivers/pwm/pwm-mediatek.c > +++ b/drivers/pwm/pwm-mediatek.c > @@ -91,7 +91,7 @@ static int mtk_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, > if (clkdiv > 7) > return -EINVAL; > > - mtk_pwm_writel(pc, pwm->hwpwm, PWMCON, BIT(15) | BIT(3) | clkdiv); > + mtk_pwm_writel(pc, pwm->hwpwm, PWMCON, BIT(15) | clkdiv); Just for clarification, BIT(15) enables old PWM mode, which ignores CLKSEL (BIT(3)). Therefore setting BIT(3) does not have any effect and can be discarded. Am I correct? I took mt7623n datasheet for reference. Regards, Matthias > mtk_pwm_writel(pc, pwm->hwpwm, PWMDWIDTH, period_ns / resolution); > mtk_pwm_writel(pc, pwm->hwpwm, PWMTHRES, duty_ns / resolution); > >
next prev parent reply other threads:[~2017-07-05 11:09 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-30 6:05 [PATCH v3 0/6] mediatek: pwm driver add MT2712/MT7622 support Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-06-30 6:05 ` [PATCH v3 1/6] pwm: kconfig: modify mediatek information Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-08-21 7:31 ` Thierry Reding 2017-08-21 7:31 ` Thierry Reding 2017-06-30 6:05 ` [PATCH v3 2/6] pwm: mediatek: fix pwm source clock selection Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-07-05 11:09 ` Matthias Brugger [this message] 2017-07-05 11:09 ` Matthias Brugger 2017-07-06 6:16 ` Zhi Mao 2017-07-06 6:16 ` Zhi Mao 2017-07-06 6:16 ` Zhi Mao 2017-07-06 6:43 ` Zhi Mao 2017-07-06 6:43 ` Zhi Mao 2017-07-06 6:43 ` Zhi Mao 2017-07-18 16:34 ` Matthias Brugger 2017-07-18 16:34 ` Matthias Brugger 2017-08-21 7:35 ` Thierry Reding 2017-08-21 7:35 ` Thierry Reding 2017-08-21 7:35 ` Thierry Reding 2017-06-30 6:05 ` [PATCH v3 3/6] pwm: mediatek: fix clock control issue Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-08-21 7:47 ` Thierry Reding 2017-08-21 7:47 ` Thierry Reding 2017-08-21 7:47 ` Thierry Reding 2017-06-30 6:05 ` [PATCH v3 4/6] pwm: bindings: add MT2712/MT7622 information Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-08-21 7:51 ` Thierry Reding 2017-08-21 7:51 ` Thierry Reding 2017-06-30 6:05 ` [PATCH v3 5/6] pwm: mediatek: add PWM_CLK_DIV_MAX Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-08-21 7:58 ` Thierry Reding 2017-08-21 7:58 ` Thierry Reding 2017-06-30 6:05 ` [PATCH v3 6/6] pwm: mediatek: add MT2712/MT7622 support Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-06-30 6:05 ` Zhi Mao 2017-08-21 8:05 ` Thierry Reding 2017-08-21 8:05 ` Thierry Reding 2017-08-21 9:05 ` Zhi Mao 2017-08-21 9:05 ` Zhi Mao 2017-08-21 9:05 ` Zhi Mao 2017-07-17 3:16 ` [PATCH v3 0/6] mediatek: pwm driver " Zhi Mao 2017-07-17 3:16 ` Zhi Mao 2017-07-17 3:16 ` Zhi Mao 2017-08-02 7:19 ` Zhi Mao 2017-08-02 7:19 ` Zhi Mao 2017-08-02 7:19 ` Zhi Mao 2017-08-02 8:42 ` John Crispin 2017-08-02 8:42 ` John Crispin 2017-08-02 8:42 ` John Crispin 2017-08-03 9:41 ` Zhi Mao 2017-08-03 9:41 ` Zhi Mao 2017-08-03 9:41 ` Zhi Mao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d009712e-f0a2-2dc7-2f64-ad8cfa21f98d@gmail.com \ --to=matthias.bgg@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=john@phrozen.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pwm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sean.wang@mediatek.com \ --cc=srv_heupstream@mediatek.com \ --cc=thierry.reding@gmail.com \ --cc=yingjoe.chen@mediatek.com \ --cc=yt.shen@mediatek.com \ --cc=zhenbao.liu@mediatek.com \ --cc=zhi.mao@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.