From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org Subject: Re: [igt-dev] [PATCH i-g-t 13/24] i915/gem_ctx_param: Test set/get (copy) VM Date: Tue, 26 Mar 2019 10:22:18 +0000 [thread overview] Message-ID: <d0f0ef4f-716f-ad65-3cc4-269e26cc1291@linux.intel.com> (raw) In-Reply-To: <20190322092155.1656-13-chris@chris-wilson.co.uk> On 22/03/2019 09:21, Chris Wilson wrote: > Exercise reusing the GTT of one ctx in another. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > tests/i915/gem_ctx_param.c | 83 ++++++++++++++++++++++++++++++++------ > 1 file changed, 71 insertions(+), 12 deletions(-) > > diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c > index b3f8637df..54ade8b4b 100644 > --- a/tests/i915/gem_ctx_param.c > +++ b/tests/i915/gem_ctx_param.c > @@ -36,17 +36,6 @@ IGT_TEST_DESCRIPTION("Basic test for context set/get param input validation."); > #define NEW_CTX BIT(0) > #define USER BIT(1) > > -static int reopen_driver(int fd) > -{ > - char path[256]; > - > - snprintf(path, sizeof(path), "/proc/self/fd/%d", fd); > - fd = open(path, O_RDWR); > - igt_assert_lte(0, fd); > - > - return fd; > -} > - > static void set_priority(int i915) > { > static const int64_t test_values[] = { > @@ -91,7 +80,7 @@ static void set_priority(int i915) > igt_permute_array(values, size, igt_exchange_int64); > > igt_fork(flags, NEW_CTX | USER) { > - int fd = reopen_driver(i915); > + int fd = gem_reopen_driver(i915); > struct drm_i915_gem_context_param arg = { > .param = I915_CONTEXT_PARAM_PRIORITY, > .ctx_id = flags & NEW_CTX ? gem_context_create(fd) : 0, > @@ -143,6 +132,73 @@ static void set_priority(int i915) > free(values); > } > > +static uint32_t __batch_create(int i915, uint32_t offset) > +{ > + const uint32_t bbe = MI_BATCH_BUFFER_END; > + uint32_t handle; > + > + handle = gem_create(i915, ALIGN(offset + 4, 4096)); > + gem_write(i915, handle, offset, &bbe, sizeof(bbe)); > + > + return handle; > +} > + > +static uint32_t batch_create(int i915) > +{ > + return __batch_create(i915, 0); > +} Looks familiar. :) > + > +static void test_vm(int i915) > +{ > + struct drm_i915_gem_exec_object2 batch = { > + .handle = batch_create(i915), > + }; > + struct drm_i915_gem_execbuffer2 eb = { > + .buffers_ptr = to_user_pointer(&batch), > + .buffer_count = 1, > + }; > + struct drm_i915_gem_context_param arg = { > + .param = I915_CONTEXT_PARAM_VM, > + }; > + uint32_t parent, child; > + > + arg.value = -1ull; > + igt_require(__gem_context_set_param(i915, &arg) == -ENOENT); > + > + parent = gem_context_create(i915); > + child = gem_context_create(i915); > + > + eb.rsvd1 = parent; > + batch.offset = 48 << 20; > + gem_execbuf(i915, &eb); > + igt_assert_eq_u64(batch.offset, 48 << 20); > + > + eb.rsvd1 = child; > + batch.offset = 0; > + gem_execbuf(i915, &eb); > + igt_assert_eq_u64(batch.offset, 0); > + > + eb.rsvd1 = parent; > + gem_execbuf(i915, &eb); > + igt_assert_eq_u64(batch.offset, 48 << 20); Please drop a comment at the start of these execbuf operations to explain what and why. We don't need softpin to guarantee they will get pinned to where we want them to? > + > + arg.ctx_id = parent; > + gem_context_get_param(i915, &arg); > + > + arg.ctx_id = child; > + gem_context_set_param(i915, &arg); Another get param to assert child vm id is the same as the parent? Also, try self-assign? I mean set the same vm id as already have? > + > + eb.rsvd1 = child; > + gem_execbuf(i915, &eb); > + igt_assert_eq_u64(batch.offset, 48 << 20); Interesting, for me at least. Please put a comment here. > + > + gem_context_destroy(i915, child); > + gem_context_destroy(i915, parent); > + > + gem_sync(i915, batch.handle); > + gem_close(i915, batch.handle); > +} > + > igt_main > { > struct drm_i915_gem_context_param arg; > @@ -253,6 +309,9 @@ igt_main > gem_context_set_param(fd, &arg); > } > > + igt_subtest("vm") > + test_vm(fd); > + > arg.param = I915_CONTEXT_PARAM_PRIORITY; > > igt_subtest("set-priority-not-supported") { > Add to basic test list? Or call basic-vm? Honestly don't remember how we do it these days.. Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org Subject: Re: [igt-dev] [PATCH i-g-t 13/24] i915/gem_ctx_param: Test set/get (copy) VM Date: Tue, 26 Mar 2019 10:22:18 +0000 [thread overview] Message-ID: <d0f0ef4f-716f-ad65-3cc4-269e26cc1291@linux.intel.com> (raw) In-Reply-To: <20190322092155.1656-13-chris@chris-wilson.co.uk> On 22/03/2019 09:21, Chris Wilson wrote: > Exercise reusing the GTT of one ctx in another. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > tests/i915/gem_ctx_param.c | 83 ++++++++++++++++++++++++++++++++------ > 1 file changed, 71 insertions(+), 12 deletions(-) > > diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c > index b3f8637df..54ade8b4b 100644 > --- a/tests/i915/gem_ctx_param.c > +++ b/tests/i915/gem_ctx_param.c > @@ -36,17 +36,6 @@ IGT_TEST_DESCRIPTION("Basic test for context set/get param input validation."); > #define NEW_CTX BIT(0) > #define USER BIT(1) > > -static int reopen_driver(int fd) > -{ > - char path[256]; > - > - snprintf(path, sizeof(path), "/proc/self/fd/%d", fd); > - fd = open(path, O_RDWR); > - igt_assert_lte(0, fd); > - > - return fd; > -} > - > static void set_priority(int i915) > { > static const int64_t test_values[] = { > @@ -91,7 +80,7 @@ static void set_priority(int i915) > igt_permute_array(values, size, igt_exchange_int64); > > igt_fork(flags, NEW_CTX | USER) { > - int fd = reopen_driver(i915); > + int fd = gem_reopen_driver(i915); > struct drm_i915_gem_context_param arg = { > .param = I915_CONTEXT_PARAM_PRIORITY, > .ctx_id = flags & NEW_CTX ? gem_context_create(fd) : 0, > @@ -143,6 +132,73 @@ static void set_priority(int i915) > free(values); > } > > +static uint32_t __batch_create(int i915, uint32_t offset) > +{ > + const uint32_t bbe = MI_BATCH_BUFFER_END; > + uint32_t handle; > + > + handle = gem_create(i915, ALIGN(offset + 4, 4096)); > + gem_write(i915, handle, offset, &bbe, sizeof(bbe)); > + > + return handle; > +} > + > +static uint32_t batch_create(int i915) > +{ > + return __batch_create(i915, 0); > +} Looks familiar. :) > + > +static void test_vm(int i915) > +{ > + struct drm_i915_gem_exec_object2 batch = { > + .handle = batch_create(i915), > + }; > + struct drm_i915_gem_execbuffer2 eb = { > + .buffers_ptr = to_user_pointer(&batch), > + .buffer_count = 1, > + }; > + struct drm_i915_gem_context_param arg = { > + .param = I915_CONTEXT_PARAM_VM, > + }; > + uint32_t parent, child; > + > + arg.value = -1ull; > + igt_require(__gem_context_set_param(i915, &arg) == -ENOENT); > + > + parent = gem_context_create(i915); > + child = gem_context_create(i915); > + > + eb.rsvd1 = parent; > + batch.offset = 48 << 20; > + gem_execbuf(i915, &eb); > + igt_assert_eq_u64(batch.offset, 48 << 20); > + > + eb.rsvd1 = child; > + batch.offset = 0; > + gem_execbuf(i915, &eb); > + igt_assert_eq_u64(batch.offset, 0); > + > + eb.rsvd1 = parent; > + gem_execbuf(i915, &eb); > + igt_assert_eq_u64(batch.offset, 48 << 20); Please drop a comment at the start of these execbuf operations to explain what and why. We don't need softpin to guarantee they will get pinned to where we want them to? > + > + arg.ctx_id = parent; > + gem_context_get_param(i915, &arg); > + > + arg.ctx_id = child; > + gem_context_set_param(i915, &arg); Another get param to assert child vm id is the same as the parent? Also, try self-assign? I mean set the same vm id as already have? > + > + eb.rsvd1 = child; > + gem_execbuf(i915, &eb); > + igt_assert_eq_u64(batch.offset, 48 << 20); Interesting, for me at least. Please put a comment here. > + > + gem_context_destroy(i915, child); > + gem_context_destroy(i915, parent); > + > + gem_sync(i915, batch.handle); > + gem_close(i915, batch.handle); > +} > + > igt_main > { > struct drm_i915_gem_context_param arg; > @@ -253,6 +309,9 @@ igt_main > gem_context_set_param(fd, &arg); > } > > + igt_subtest("vm") > + test_vm(fd); > + > arg.param = I915_CONTEXT_PARAM_PRIORITY; > > igt_subtest("set-priority-not-supported") { > Add to basic test list? Or call basic-vm? Honestly don't remember how we do it these days.. Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-26 10:22 UTC|newest] Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-22 9:21 [PATCH i-g-t 01/24] i915/gem_exec_latency: Measure the latency of context switching Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 02/24] lib: Add GPU power measurement Chris Wilson 2019-03-22 9:21 ` [Intel-gfx] " Chris Wilson 2019-03-26 8:36 ` [igt-dev] " Tvrtko Ursulin 2019-03-26 8:36 ` Tvrtko Ursulin 2019-03-26 8:49 ` Chris Wilson 2019-03-26 8:49 ` Chris Wilson 2019-03-26 9:18 ` [PATCH i-g-t v2] " Chris Wilson 2019-03-26 9:18 ` [igt-dev] " Chris Wilson 2019-03-26 9:52 ` Tvrtko Ursulin 2019-03-26 9:52 ` Tvrtko Ursulin 2019-03-26 10:06 ` Chris Wilson 2019-03-26 10:06 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 03/24] i915/gem_exec_schedule: Measure semaphore power consumption Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 8:46 ` Tvrtko Ursulin 2019-03-26 8:46 ` [Intel-gfx] " Tvrtko Ursulin 2019-03-26 9:23 ` Chris Wilson 2019-03-26 9:23 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 04/24] i915/gem_exec_whisper: Measure total power consumed Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 8:47 ` Tvrtko Ursulin 2019-03-26 8:47 ` Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 05/24] i915/gem_exec_schedule: Verify that using HW semaphores doesn't block Chris Wilson 2019-03-22 9:21 ` [Intel-gfx] " Chris Wilson 2019-03-26 9:19 ` [igt-dev] " Tvrtko Ursulin 2019-03-26 9:19 ` Tvrtko Ursulin 2019-03-26 10:03 ` Chris Wilson 2019-03-26 10:03 ` [Intel-gfx] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 06/24] i915/gem_exec_nop: poll-sequential requires ordering between rings Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 9:38 ` Tvrtko Ursulin 2019-03-26 9:38 ` Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 07/24] i915/gem_sync: Make switch-default asymmetric Chris Wilson 2019-03-22 9:21 ` [Intel-gfx] " Chris Wilson 2019-03-26 9:57 ` [igt-dev] " Tvrtko Ursulin 2019-03-26 9:57 ` [Intel-gfx] " Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 08/24] i915/gem_ctx_param: Remove kneecapping Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 9:58 ` Tvrtko Ursulin 2019-03-26 9:58 ` Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 09/24] i915/gem_exec_big: Add a single shot test Chris Wilson 2019-03-22 9:21 ` [Intel-gfx] " Chris Wilson 2019-03-26 10:06 ` [igt-dev] " Tvrtko Ursulin 2019-03-26 10:06 ` Tvrtko Ursulin 2019-03-26 10:21 ` Chris Wilson 2019-03-26 10:21 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 10/24] kms_fence_pin_leak: Ask for the GPU before use Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 10:10 ` Tvrtko Ursulin 2019-03-26 10:10 ` Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 11/24] drm-uapi: Import i915_drm.h upto 53073249452d Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 12/24] lib/i915: Improve gem_context error messages Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 10:14 ` Tvrtko Ursulin 2019-03-26 10:14 ` Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 13/24] i915/gem_ctx_param: Test set/get (copy) VM Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 10:22 ` Tvrtko Ursulin [this message] 2019-03-26 10:22 ` Tvrtko Ursulin 2019-03-26 10:33 ` Tvrtko Ursulin 2019-03-26 10:33 ` Tvrtko Ursulin 2019-03-26 10:51 ` Chris Wilson 2019-03-26 10:51 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 14/24] i915/gem_ctx_create: Basic checks for constructor properties Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 10:46 ` Tvrtko Ursulin 2019-03-26 10:46 ` Tvrtko Ursulin 2019-03-26 11:06 ` Chris Wilson 2019-03-26 11:06 ` [Intel-gfx] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 15/24] i915: Add gem_vm_create Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 11:21 ` Tvrtko Ursulin 2019-03-26 11:21 ` Tvrtko Ursulin 2019-03-26 11:37 ` Chris Wilson 2019-03-26 11:37 ` Chris Wilson 2019-03-26 11:48 ` Tvrtko Ursulin 2019-03-26 11:48 ` Tvrtko Ursulin 2019-03-26 14:11 ` Chris Wilson 2019-03-26 14:11 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 16/24] drm-uapi: Import i915_drm.h upto 364df3d04d51 Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 17/24] i915: Add gem_ctx_clone Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 15:44 ` Tvrtko Ursulin 2019-03-26 15:44 ` Tvrtko Ursulin 2019-03-26 15:49 ` Chris Wilson 2019-03-26 15:49 ` Chris Wilson 2019-03-26 15:54 ` Chris Wilson 2019-03-26 15:54 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 18/24] i915: Exercise creating context with shared GTT Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 19/24] i915/gem_ctx_switch: Exercise queues Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 20/24] i915/gem_exec_whisper: Fork all-engine tests one-per-engine Chris Wilson 2019-03-22 9:21 ` [Intel-gfx] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 21/24] i915/gem_exec_whisper: debugfs/next_seqno is defunct Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 22/24] i915: Add gem_ctx_engines Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 16:40 ` Andi Shyti 2019-03-22 16:40 ` [igt-dev] " Andi Shyti 2019-03-22 16:48 ` Chris Wilson 2019-03-22 16:48 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 23/24] i915: Add gem_exec_balancer Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 24/24] i915/gem_exec_balancer: Exercise bonded pairs Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 10:22 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,01/24] i915/gem_exec_latency: Measure the latency of context switching Patchwork 2019-03-23 6:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2019-03-26 11:00 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,01/24] i915/gem_exec_latency: Measure the latency of context switching (rev2) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d0f0ef4f-716f-ad65-3cc4-269e26cc1291@linux.intel.com \ --to=tvrtko.ursulin@linux.intel.com \ --cc=chris@chris-wilson.co.uk \ --cc=igt-dev@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.