From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, ulf.hansson@linaro.org,
linus.walleij@linaro.org, catalin.marinas@arm.com,
will@kernel.org, shawnguo@kernel.org, arnd@arndb.de,
marcel.ziswiler@toradex.com, dmitry.baryshkov@linaro.org,
nfraprado@collabora.com, broonie@kernel.org, robimarko@gmail.com,
quic_gurus@quicinc.com, bhupesh.sharma@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/10] dt-bindings: pinctrl: qcom: add IPQ5332 pinctrl
Date: Wed, 25 Jan 2023 17:20:33 +0100 [thread overview]
Message-ID: <d6512673-a232-c8e5-45f7-e903fc1a01a7@linaro.org> (raw)
In-Reply-To: <0b28f4a3-c445-7473-501b-39cbcfdb9889@quicinc.com>
On 25/01/2023 16:49, Kathiravan Thirumoorthy wrote:
>>
>>> @@ -0,0 +1,134 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/pinctrl/qcom,ipq5332-pinctrl.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Qualcomm IPQ5332 TLMM pin controller
>>> +
>>> +maintainers:
>>> + - Bjorn Andersson <andersson@kernel.org>
>>> + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> +
>>> +description: |
>>> + Top Level Mode Multiplexer pin controller in Qualcomm IPQ5332 SoC.
>>> +
>>> +allOf:
>>> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
>>> +
>>> +properties:
>>> + compatible:
>>> + const: qcom,ipq5332-tlmm
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts: true
>> missing maxItems
>>
>> Rebase your patches on latest next and use the latest bindings and
>> drivers as starting point.
>
>
> Changes are based on v6.2-rc1. I see the maxItems changes in
> linux-next. Will update this in V2.
Your patches cannot be based on v6.2-rc1. They won't even apply. You
miss entire development of last month.
>
>
>>> + interrupt-controller: true
>>> + "#interrupt-cells": true
>>> + gpio-controller: true
>>> + "#gpio-cells": true
>>> + gpio-ranges: true
>>> + wakeup-parent: true
>>> +
>>> + gpio-reserved-ranges:
>>> + minItems: 1
>>> + maxItems: 27
>>> +
>>> + gpio-line-names:
>>> + maxItems: 53
>> You have 54 GPIOs.
>
>
> Sorry, GPIO ranges are from 0-52, will update it in all places in V2.
Ah, then the gpio pattern needs a fix.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, ulf.hansson@linaro.org,
linus.walleij@linaro.org, catalin.marinas@arm.com,
will@kernel.org, shawnguo@kernel.org, arnd@arndb.de,
marcel.ziswiler@toradex.com, dmitry.baryshkov@linaro.org,
nfraprado@collabora.com, broonie@kernel.org, robimarko@gmail.com,
quic_gurus@quicinc.com, bhupesh.sharma@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/10] dt-bindings: pinctrl: qcom: add IPQ5332 pinctrl
Date: Wed, 25 Jan 2023 17:20:33 +0100 [thread overview]
Message-ID: <d6512673-a232-c8e5-45f7-e903fc1a01a7@linaro.org> (raw)
In-Reply-To: <0b28f4a3-c445-7473-501b-39cbcfdb9889@quicinc.com>
On 25/01/2023 16:49, Kathiravan Thirumoorthy wrote:
>>
>>> @@ -0,0 +1,134 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/pinctrl/qcom,ipq5332-pinctrl.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Qualcomm IPQ5332 TLMM pin controller
>>> +
>>> +maintainers:
>>> + - Bjorn Andersson <andersson@kernel.org>
>>> + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> +
>>> +description: |
>>> + Top Level Mode Multiplexer pin controller in Qualcomm IPQ5332 SoC.
>>> +
>>> +allOf:
>>> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
>>> +
>>> +properties:
>>> + compatible:
>>> + const: qcom,ipq5332-tlmm
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts: true
>> missing maxItems
>>
>> Rebase your patches on latest next and use the latest bindings and
>> drivers as starting point.
>
>
> Changes are based on v6.2-rc1. I see the maxItems changes in
> linux-next. Will update this in V2.
Your patches cannot be based on v6.2-rc1. They won't even apply. You
miss entire development of last month.
>
>
>>> + interrupt-controller: true
>>> + "#interrupt-cells": true
>>> + gpio-controller: true
>>> + "#gpio-cells": true
>>> + gpio-ranges: true
>>> + wakeup-parent: true
>>> +
>>> + gpio-reserved-ranges:
>>> + minItems: 1
>>> + maxItems: 27
>>> +
>>> + gpio-line-names:
>>> + maxItems: 53
>> You have 54 GPIOs.
>
>
> Sorry, GPIO ranges are from 0-52, will update it in all places in V2.
Ah, then the gpio pattern needs a fix.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-25 16:21 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 10:45 [PATCH 00/10] Add minimal boot support for IPQ5332 Kathiravan Thirumoorthy
2023-01-25 10:45 ` Kathiravan Thirumoorthy
2023-01-25 10:45 ` [PATCH 01/10] dt-bindings: pinctrl: qcom: add IPQ5332 pinctrl Kathiravan Thirumoorthy
2023-01-25 10:45 ` Kathiravan Thirumoorthy
2023-01-25 11:10 ` Krzysztof Kozlowski
2023-01-25 11:10 ` Krzysztof Kozlowski
2023-01-25 15:49 ` Kathiravan Thirumoorthy
2023-01-25 15:49 ` Kathiravan Thirumoorthy
2023-01-25 16:20 ` Krzysztof Kozlowski [this message]
2023-01-25 16:20 ` Krzysztof Kozlowski
2023-01-25 16:38 ` Kathiravan Thirumoorthy
2023-01-25 16:38 ` Kathiravan Thirumoorthy
2023-01-25 10:45 ` [PATCH 02/10] pinctrl: qcom: Introduce IPQ5332 TLMM driver Kathiravan Thirumoorthy
2023-01-25 10:45 ` Kathiravan Thirumoorthy
2023-01-25 10:45 ` [PATCH 03/10] clk: qcom: Add STROMER PLUS PLL type for IPQ5332 Kathiravan Thirumoorthy
2023-01-25 10:45 ` Kathiravan Thirumoorthy
2023-01-25 20:35 ` Stephen Boyd
2023-01-25 20:35 ` Stephen Boyd
2023-01-25 10:45 ` [PATCH 04/10] dt-bindings: clock: Add Qualcomm IPQ5332 GCC Kathiravan Thirumoorthy
2023-01-25 10:45 ` Kathiravan Thirumoorthy
2023-01-25 11:13 ` Krzysztof Kozlowski
2023-01-25 11:13 ` Krzysztof Kozlowski
2023-01-25 15:50 ` Kathiravan Thirumoorthy
2023-01-25 15:50 ` Kathiravan Thirumoorthy
2023-01-25 10:45 ` [PATCH 05/10] clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC Kathiravan Thirumoorthy
2023-01-25 11:14 ` Krzysztof Kozlowski
2023-01-25 11:14 ` Krzysztof Kozlowski
2023-01-25 15:53 ` Kathiravan Thirumoorthy
2023-01-25 15:53 ` Kathiravan Thirumoorthy
2023-01-25 20:54 ` Stephen Boyd
2023-01-25 20:54 ` Stephen Boyd
2023-01-26 16:45 ` Kathiravan Thirumoorthy
2023-01-26 16:45 ` Kathiravan Thirumoorthy
2023-01-25 10:45 ` [PATCH 06/10] dt-bindings: qcom: add ipq5332 boards Kathiravan Thirumoorthy
2023-01-25 10:45 ` Kathiravan Thirumoorthy
2023-01-25 11:15 ` Krzysztof Kozlowski
2023-01-25 11:15 ` Krzysztof Kozlowski
2023-01-25 15:55 ` Kathiravan Thirumoorthy
2023-01-25 15:55 ` Kathiravan Thirumoorthy
2023-01-25 10:45 ` [PATCH 07/10] dt-bindings: firmware: document IPQ5332 SCM Kathiravan Thirumoorthy
2023-01-25 10:45 ` Kathiravan Thirumoorthy
2023-01-25 11:16 ` Krzysztof Kozlowski
2023-01-25 11:16 ` Krzysztof Kozlowski
2023-01-25 15:55 ` Kathiravan Thirumoorthy
2023-01-25 15:55 ` Kathiravan Thirumoorthy
2023-01-25 10:45 ` [PATCH 08/10] dt-bindings: mmc: sdhci-msm: add IPQ5332 compatible Kathiravan Thirumoorthy
2023-01-25 10:45 ` Kathiravan Thirumoorthy
2023-01-25 11:17 ` Krzysztof Kozlowski
2023-01-25 11:17 ` Krzysztof Kozlowski
2023-01-27 10:56 ` Ulf Hansson
2023-01-27 10:56 ` Ulf Hansson
2023-01-25 10:45 ` [PATCH 09/10] arm64: dts: qcom: add IPQ5332 SoC and MI01.2 board support Kathiravan Thirumoorthy
2023-01-25 10:45 ` Kathiravan Thirumoorthy
2023-01-25 11:22 ` Krzysztof Kozlowski
2023-01-25 11:22 ` Krzysztof Kozlowski
2023-01-25 16:05 ` Kathiravan Thirumoorthy
2023-01-25 16:05 ` Kathiravan Thirumoorthy
2023-01-25 21:59 ` Konrad Dybcio
2023-01-25 21:59 ` Konrad Dybcio
2023-01-26 16:50 ` Kathiravan Thirumoorthy
2023-01-26 16:50 ` Kathiravan Thirumoorthy
2023-01-30 11:56 ` Kathiravan Thirumoorthy
2023-01-30 11:56 ` Kathiravan Thirumoorthy
2023-01-31 19:24 ` Krzysztof Kozlowski
2023-01-31 19:24 ` Krzysztof Kozlowski
2023-01-25 10:45 ` [PATCH 10/10] arm64: defconfig: Enable IPQ5332 SoC base configs Kathiravan Thirumoorthy
2023-01-25 10:45 ` Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6512673-a232-c8e5-45f7-e903fc1a01a7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bhupesh.sharma@linaro.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=quic_gurus@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.