* [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static
@ 2020-08-18 11:22 Wei Yongjun
2020-08-18 19:32 ` Hyun Kwon
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Wei Yongjun @ 2020-08-18 11:22 UTC (permalink / raw)
To: Hulk Robot, Hyun Kwon, Laurent Pinchart, Vinod Koul, Michal Simek
Cc: Wei Yongjun, dmaengine, linux-arm-kernel
The sparse tool complains as follows:
drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning:
symbol 'dpdma_debugfs_reqs' was not declared. Should it be static?
This variable is not used outside of xilinx_dpdma.c, so this commit
marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
index 7db70d226e89..81ed1e482878 100644
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -346,7 +346,7 @@ static int xilinx_dpdma_debugfs_desc_done_irq_write(char *args)
}
/* Match xilinx_dpdma_testcases vs dpdma_debugfs_reqs[] entry */
-struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = {
+static struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = {
{
.name = "DESCRIPTOR_DONE_INTR",
.tc = DPDMA_TC_INTR_DONE,
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static
2020-08-18 11:22 [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static Wei Yongjun
@ 2020-08-18 19:32 ` Hyun Kwon
2020-08-18 23:41 ` Laurent Pinchart
2020-08-19 4:24 ` Vinod Koul
2 siblings, 0 replies; 5+ messages in thread
From: Hyun Kwon @ 2020-08-18 19:32 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hulk Robot, Laurent Pinchart, Vinod Koul, Michal Simek,
dmaengine, linux-arm-kernel
Hi Wei,
Thanks for the patch.
On Tue, Aug 18, 2020 at 04:22:17AM -0700, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning:
> symbol 'dpdma_debugfs_reqs' was not declared. Should it be static?
>
> This variable is not used outside of xilinx_dpdma.c, so this commit
> marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Hyun Kwon <hyun.kwon@xilinx.com>
Thanks,
-hyun
> ---
> drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 7db70d226e89..81ed1e482878 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -346,7 +346,7 @@ static int xilinx_dpdma_debugfs_desc_done_irq_write(char *args)
> }
>
> /* Match xilinx_dpdma_testcases vs dpdma_debugfs_reqs[] entry */
> -struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = {
> +static struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = {
> {
> .name = "DESCRIPTOR_DONE_INTR",
> .tc = DPDMA_TC_INTR_DONE,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static
2020-08-18 11:22 [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static Wei Yongjun
2020-08-18 19:32 ` Hyun Kwon
@ 2020-08-18 23:41 ` Laurent Pinchart
2020-08-19 4:26 ` Vinod Koul
2020-08-19 4:24 ` Vinod Koul
2 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2020-08-18 23:41 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hulk Robot, Hyun Kwon, Vinod Koul, Michal Simek, dmaengine,
linux-arm-kernel
Hi Wei,
Thank you for the patch.
On Tue, Aug 18, 2020 at 07:22:17PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning:
> symbol 'dpdma_debugfs_reqs' was not declared. Should it be static?
>
> This variable is not used outside of xilinx_dpdma.c, so this commit
> marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Looks good to me.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Vinod, could you pick this up as a v5.9 fix ?
> ---
> drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 7db70d226e89..81ed1e482878 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -346,7 +346,7 @@ static int xilinx_dpdma_debugfs_desc_done_irq_write(char *args)
> }
>
> /* Match xilinx_dpdma_testcases vs dpdma_debugfs_reqs[] entry */
> -struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = {
> +static struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = {
> {
> .name = "DESCRIPTOR_DONE_INTR",
> .tc = DPDMA_TC_INTR_DONE,
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static
2020-08-18 11:22 [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static Wei Yongjun
2020-08-18 19:32 ` Hyun Kwon
2020-08-18 23:41 ` Laurent Pinchart
@ 2020-08-19 4:24 ` Vinod Koul
2 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2020-08-19 4:24 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hulk Robot, Hyun Kwon, Laurent Pinchart, Michal Simek, dmaengine,
linux-arm-kernel
On 18-08-20, 19:22, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning:
> symbol 'dpdma_debugfs_reqs' was not declared. Should it be static?
>
> This variable is not used outside of xilinx_dpdma.c, so this commit
> marks it static.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static
2020-08-18 23:41 ` Laurent Pinchart
@ 2020-08-19 4:26 ` Vinod Koul
0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2020-08-19 4:26 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Wei Yongjun, Hulk Robot, Hyun Kwon, Michal Simek, dmaengine,
linux-arm-kernel
On 19-08-20, 02:41, Laurent Pinchart wrote:
> Hi Wei,
>
> Thank you for the patch.
>
> On Tue, Aug 18, 2020 at 07:22:17PM +0800, Wei Yongjun wrote:
> > The sparse tool complains as follows:
> >
> > drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning:
> > symbol 'dpdma_debugfs_reqs' was not declared. Should it be static?
> >
> > This variable is not used outside of xilinx_dpdma.c, so this commit
> > marks it static.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Looks good to me.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Vinod, could you pick this up as a v5.9 fix ?
This is not 5.9 fix. The debugfs patch will go into next for 5.10 so
this is applied to next as well
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-19 4:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18 11:22 [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static Wei Yongjun
2020-08-18 19:32 ` Hyun Kwon
2020-08-18 23:41 ` Laurent Pinchart
2020-08-19 4:26 ` Vinod Koul
2020-08-19 4:24 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).