* [PATCH] ethdev: Fix issue in Doxygen for TM API
@ 2018-03-21 15:45 Ben Shelton
2018-05-01 15:12 ` Dumitrescu, Cristian
0 siblings, 1 reply; 2+ messages in thread
From: Ben Shelton @ 2018-03-21 15:45 UTC (permalink / raw)
To: dev, Cristian Dumitrescu; +Cc: Ben Shelton
The rte_tm_node_wfq_weight_mode_update() API function operates on
non-leaf nodes, not leaf nodes.
Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
---
lib/librte_ether/rte_tm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_tm.h b/lib/librte_ether/rte_tm.h
index 2b25a87..f735f84 100644
--- a/lib/librte_ether/rte_tm.h
+++ b/lib/librte_ether/rte_tm.h
@@ -1643,7 +1643,7 @@ rte_tm_node_stats_update(uint16_t port_id,
* @param[in] port_id
* The port identifier of the Ethernet device.
* @param[in] node_id
- * Node ID. Needs to be valid leaf node ID.
+ * Node ID. Needs to be valid non-leaf node ID.
* @param[in] wfq_weight_mode
* WFQ weight mode for each SP priority. When NULL, it indicates that WFQ is
* to be used for all priorities. When non-NULL, it points to a pre-allocated
--
2.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ethdev: Fix issue in Doxygen for TM API
2018-03-21 15:45 [PATCH] ethdev: Fix issue in Doxygen for TM API Ben Shelton
@ 2018-05-01 15:12 ` Dumitrescu, Cristian
0 siblings, 0 replies; 2+ messages in thread
From: Dumitrescu, Cristian @ 2018-05-01 15:12 UTC (permalink / raw)
To: Shelton, Benjamin H, dev
> -----Original Message-----
> From: Shelton, Benjamin H
> Sent: Wednesday, March 21, 2018 3:46 PM
> To: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: Shelton, Benjamin H <benjamin.h.shelton@intel.com>
> Subject: [PATCH] ethdev: Fix issue in Doxygen for TM API
>
> The rte_tm_node_wfq_weight_mode_update() API function operates on
> non-leaf nodes, not leaf nodes.
>
> Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
> ---
> lib/librte_ether/rte_tm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_ether/rte_tm.h b/lib/librte_ether/rte_tm.h
> index 2b25a87..f735f84 100644
> --- a/lib/librte_ether/rte_tm.h
> +++ b/lib/librte_ether/rte_tm.h
> @@ -1643,7 +1643,7 @@ rte_tm_node_stats_update(uint16_t port_id,
> * @param[in] port_id
> * The port identifier of the Ethernet device.
> * @param[in] node_id
> - * Node ID. Needs to be valid leaf node ID.
> + * Node ID. Needs to be valid non-leaf node ID.
> * @param[in] wfq_weight_mode
> * WFQ weight mode for each SP priority. When NULL, it indicates that
> WFQ is
> * to be used for all priorities. When non-NULL, it points to a pre-allocated
> --
> 2.6.4
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied to next-qos tree, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-01 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-21 15:45 [PATCH] ethdev: Fix issue in Doxygen for TM API Ben Shelton
2018-05-01 15:12 ` Dumitrescu, Cristian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).