DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] net/bonding: do not inherit slave device configuration
@ 2019-11-19  9:03 Andrew Rybchenko
  2019-11-19 12:18 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Rybchenko @ 2019-11-19  9:03 UTC (permalink / raw)
  To: Chas Williams; +Cc: dev, stable

Bonding device should control bonded devices configuration.

Also avoid usage of slave's data->dev_conf.

Fixes: 2efb58cbab6e ("bond: new link bonding library")
Cc: stable@dpdk.org

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 707a0f3cdd..4f0e83205d 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1679,6 +1679,7 @@ int
 slave_configure(struct rte_eth_dev *bonded_eth_dev,
 		struct rte_eth_dev *slave_eth_dev)
 {
+	struct rte_eth_conf dev_conf;
 	struct bond_rx_queue *bd_rx_q;
 	struct bond_tx_queue *bd_tx_q;
 	uint16_t nb_rx_queues;
@@ -1693,34 +1694,34 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
 	/* Stop slave */
 	rte_eth_dev_stop(slave_eth_dev->data->port_id);
 
+	memset(&dev_conf, 0, sizeof(dev_conf));
+
 	/* Enable interrupts on slave device if supported */
 	if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
-		slave_eth_dev->data->dev_conf.intr_conf.lsc = 1;
+		dev_conf.intr_conf.lsc = 1;
 
 	/* If RSS is enabled for bonding, try to enable it for slaves  */
 	if (bonded_eth_dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
 		if (internals->rss_key_len != 0) {
-			slave_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len =
+			dev_conf.rx_adv_conf.rss_conf.rss_key_len =
 					internals->rss_key_len;
-			slave_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key =
+			dev_conf.rx_adv_conf.rss_conf.rss_key =
 					internals->rss_key;
 		} else {
-			slave_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
+			dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
 		}
 
-		slave_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf =
+		dev_conf.rx_adv_conf.rss_conf.rss_hf =
 				bonded_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf;
-		slave_eth_dev->data->dev_conf.rxmode.mq_mode =
+		dev_conf.rxmode.mq_mode =
 				bonded_eth_dev->data->dev_conf.rxmode.mq_mode;
 	}
 
 	if (bonded_eth_dev->data->dev_conf.rxmode.offloads &
 			DEV_RX_OFFLOAD_VLAN_FILTER)
-		slave_eth_dev->data->dev_conf.rxmode.offloads |=
-				DEV_RX_OFFLOAD_VLAN_FILTER;
+		dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;
 	else
-		slave_eth_dev->data->dev_conf.rxmode.offloads &=
-				~DEV_RX_OFFLOAD_VLAN_FILTER;
+		dev_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_VLAN_FILTER;
 
 	nb_rx_queues = bonded_eth_dev->data->nb_rx_queues;
 	nb_tx_queues = bonded_eth_dev->data->nb_tx_queues;
@@ -1742,8 +1743,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
 
 	/* Configure device */
 	errval = rte_eth_dev_configure(slave_eth_dev->data->port_id,
-			nb_rx_queues, nb_tx_queues,
-			&(slave_eth_dev->data->dev_conf));
+			nb_rx_queues, nb_tx_queues, &dev_conf);
 	if (errval != 0) {
 		RTE_BOND_LOG(ERR, "Cannot configure slave device: port %u, err (%d)",
 				slave_eth_dev->data->port_id, errval);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: do not inherit slave device configuration
  2019-11-19  9:03 [dpdk-dev] [PATCH] net/bonding: do not inherit slave device configuration Andrew Rybchenko
@ 2019-11-19 12:18 ` " Ferruh Yigit
  2019-11-19 12:40   ` Andrew Rybchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2019-11-19 12:18 UTC (permalink / raw)
  To: Andrew Rybchenko, Chas Williams; +Cc: dev, stable, Declan Doherty

On 11/19/2019 9:03 AM, Andrew Rybchenko wrote:
> Bonding device should control bonded devices configuration.
> 
> Also avoid usage of slave's data->dev_conf.
> 
> Fixes: 2efb58cbab6e ("bond: new link bonding library")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  drivers/net/bonding/rte_eth_bond_pmd.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 707a0f3cdd..4f0e83205d 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -1679,6 +1679,7 @@ int
>  slave_configure(struct rte_eth_dev *bonded_eth_dev,
>  		struct rte_eth_dev *slave_eth_dev)
>  {
> +	struct rte_eth_conf dev_conf;
>  	struct bond_rx_queue *bd_rx_q;
>  	struct bond_tx_queue *bd_tx_q;
>  	uint16_t nb_rx_queues;
> @@ -1693,34 +1694,34 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
>  	/* Stop slave */
>  	rte_eth_dev_stop(slave_eth_dev->data->port_id);
>  
> +	memset(&dev_conf, 0, sizeof(dev_conf));
> +
>  	/* Enable interrupts on slave device if supported */
>  	if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
> -		slave_eth_dev->data->dev_conf.intr_conf.lsc = 1;
> +		dev_conf.intr_conf.lsc = 1;

I assume the original intention is making incremental changes to the existing
slave configuration, if so we should copy the 'slave_eth_dev->data->dev_conf' to
'dev_conf' before start updating it.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: do not inherit slave device configuration
  2019-11-19 12:18 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-11-19 12:40   ` Andrew Rybchenko
  2019-12-03 10:17     ` Ferruh Yigit
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Rybchenko @ 2019-11-19 12:40 UTC (permalink / raw)
  To: Ferruh Yigit, Chas Williams; +Cc: dev, stable, Declan Doherty

On 11/19/19 3:18 PM, Ferruh Yigit wrote:
> On 11/19/2019 9:03 AM, Andrew Rybchenko wrote:
>> Bonding device should control bonded devices configuration.
>>
>> Also avoid usage of slave's data->dev_conf.
>>
>> Fixes: 2efb58cbab6e ("bond: new link bonding library")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>>  drivers/net/bonding/rte_eth_bond_pmd.c | 24 ++++++++++++------------
>>  1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
>> index 707a0f3cdd..4f0e83205d 100644
>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>> @@ -1679,6 +1679,7 @@ int
>>  slave_configure(struct rte_eth_dev *bonded_eth_dev,
>>  		struct rte_eth_dev *slave_eth_dev)
>>  {
>> +	struct rte_eth_conf dev_conf;
>>  	struct bond_rx_queue *bd_rx_q;
>>  	struct bond_tx_queue *bd_tx_q;
>>  	uint16_t nb_rx_queues;
>> @@ -1693,34 +1694,34 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
>>  	/* Stop slave */
>>  	rte_eth_dev_stop(slave_eth_dev->data->port_id);
>>  
>> +	memset(&dev_conf, 0, sizeof(dev_conf));
>> +
>>  	/* Enable interrupts on slave device if supported */
>>  	if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
>> -		slave_eth_dev->data->dev_conf.intr_conf.lsc = 1;
>> +		dev_conf.intr_conf.lsc = 1;
> I assume the original intention is making incremental changes to the existing
> slave configuration, if so we should copy the 'slave_eth_dev->data->dev_conf' to
> 'dev_conf' before start updating it.

The problem is that I don't understand how incremental changes
happen. It simply looks wrong or I don't understand something.
It looks like it is the only place in bonding where slave configuration
is done.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: do not inherit slave device configuration
  2019-11-19 12:40   ` Andrew Rybchenko
@ 2019-12-03 10:17     ` Ferruh Yigit
  0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2019-12-03 10:17 UTC (permalink / raw)
  To: Chas Williams, Declan Doherty; +Cc: Andrew Rybchenko, dev, stable

On 11/19/2019 12:40 PM, Andrew Rybchenko wrote:
> On 11/19/19 3:18 PM, Ferruh Yigit wrote:
>> On 11/19/2019 9:03 AM, Andrew Rybchenko wrote:
>>> Bonding device should control bonded devices configuration.
>>>
>>> Also avoid usage of slave's data->dev_conf.
>>>
>>> Fixes: 2efb58cbab6e ("bond: new link bonding library")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>>> ---
>>>  drivers/net/bonding/rte_eth_bond_pmd.c | 24 ++++++++++++------------
>>>  1 file changed, 12 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
>>> index 707a0f3cdd..4f0e83205d 100644
>>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>>> @@ -1679,6 +1679,7 @@ int
>>>  slave_configure(struct rte_eth_dev *bonded_eth_dev,
>>>  		struct rte_eth_dev *slave_eth_dev)
>>>  {
>>> +	struct rte_eth_conf dev_conf;
>>>  	struct bond_rx_queue *bd_rx_q;
>>>  	struct bond_tx_queue *bd_tx_q;
>>>  	uint16_t nb_rx_queues;
>>> @@ -1693,34 +1694,34 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
>>>  	/* Stop slave */
>>>  	rte_eth_dev_stop(slave_eth_dev->data->port_id);
>>>  
>>> +	memset(&dev_conf, 0, sizeof(dev_conf));
>>> +
>>>  	/* Enable interrupts on slave device if supported */
>>>  	if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
>>> -		slave_eth_dev->data->dev_conf.intr_conf.lsc = 1;
>>> +		dev_conf.intr_conf.lsc = 1;
>> I assume the original intention is making incremental changes to the existing
>> slave configuration, if so we should copy the 'slave_eth_dev->data->dev_conf' to
>> 'dev_conf' before start updating it.
> 
> The problem is that I don't understand how incremental changes
> happen. It simply looks wrong or I don't understand something.
> It looks like it is the only place in bonding where slave configuration
> is done.
> 
Hi Chas, Declan,

Can you please check the patch, and if possible comment on the initial intention
of the code?

Thanks,
ferruh

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19  9:03 [dpdk-dev] [PATCH] net/bonding: do not inherit slave device configuration Andrew Rybchenko
2019-11-19 12:18 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-11-19 12:40   ` Andrew Rybchenko
2019-12-03 10:17     ` Ferruh Yigit

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git