From: Ferruh Yigit <ferruh.yigit@intel.com> To: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>, dev@dpdk.org Cc: linuxarm@huawei.com, xavier_huwei@163.com, liudongdong3@huawei.com, forest.zhouchang@huawei.com Subject: Re: [dpdk-dev] [PATCH 03/22] net/hns3: register hns3 PMD driver Date: Fri, 30 Aug 2019 16:01:49 +0100 Message-ID: <763b0d93-3e5a-d12d-663a-65ba94189f0e@intel.com> (raw) In-Reply-To: <1566568031-45991-4-git-send-email-xavier.huwei@huawei.com> On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote: > This patch registers hns3 PMD driver and adds the definition for log > interfaces. > > Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> > Signed-off-by: Chunsong Feng <fengchunsong@huawei.com> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com> > Signed-off-by: Hao Chen <chenhao164@huawei.com> > Signed-off-by: Huisong Li <lihuisong@huawei.com> <...> > diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c > new file mode 100644 > index 0000000..0587a9c > --- /dev/null > +++ b/drivers/net/hns3/hns3_ethdev.c > @@ -0,0 +1,141 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018-2019 Hisilicon Limited. > + */ > + > +#include <errno.h> > +#include <stdarg.h> > +#include <stdbool.h> > +#include <stdio.h> > +#include <stdint.h> > +#include <string.h> > +#include <sys/queue.h> > +#include <inttypes.h> > +#include <unistd.h> > +#include <arpa/inet.h> > +#include <rte_alarm.h> > +#include <rte_atomic.h> > +#include <rte_bus_pci.h> > +#include <rte_byteorder.h> > +#include <rte_common.h> > +#include <rte_cycles.h> > +#include <rte_debug.h> > +#include <rte_dev.h> > +#include <rte_eal.h> > +#include <rte_ether.h> > +#include <rte_ethdev_driver.h> > +#include <rte_ethdev_pci.h> > +#include <rte_interrupts.h> > +#include <rte_io.h> > +#include <rte_log.h> > +#include <rte_pci.h> Are all these headers really used at this stage? Can you please clean them and add later patches when they are required? <...> > +static int > +hns3_dev_init(struct rte_eth_dev *eth_dev) > +{ > + struct rte_device *dev = eth_dev->device; > + struct rte_pci_device *pci_dev = RTE_DEV_TO_PCI(dev); > + struct hns3_adapter *hns = eth_dev->data->dev_private; > + struct hns3_hw *hw = &hns->hw; > + uint16_t device_id = pci_dev->id.device_id; > + int ret; > + > + PMD_INIT_FUNC_TRACE(); > + > + if (rte_eal_process_type() != RTE_PROC_PRIMARY) > + return 0; > + > + eth_dev->dev_ops = &hns3_eth_dev_ops; > + rte_eth_copy_pci_info(eth_dev, pci_dev); I think no need to call 'rte_eth_copy_pci_info()', it is called by 'rte_eth_dev_pci_generic_probe()' before 'hns3_dev_init()' called. > + > + hns->is_vf = false; There is a separate VF driver, is this field still needed? > + hw->data = eth_dev->data; > + hw->adapter_state = HNS3_NIC_INITIALIZED; > + > + return 0; Init should set 'RTE_ETH_DEV_CLOSE_REMOVE' flag, and '.dev_close' should free the driver allocated resources, which there is not up until this patch: +eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
next prev parent reply index Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-23 13:46 [dpdk-dev] [PATCH 00/22] add hns3 ethernet " Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 01/22] net/hns3: add hardware registers definition Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 02/22] net/hns3: add some definitions for data structure and macro Wei Hu (Xavier) 2019-08-30 8:25 ` Gavin Hu (Arm Technology China) 2019-09-05 6:01 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 03/22] net/hns3: register hns3 PMD driver Wei Hu (Xavier) 2019-08-30 15:01 ` Ferruh Yigit [this message] 2019-09-06 6:20 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 04/22] net/hns3: add support for cmd of " Wei Hu (Xavier) 2019-08-30 15:02 ` Ferruh Yigit 2019-09-06 6:49 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 05/22] net/hns3: add the initialization " Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 06/22] net/hns3: add support for MAC address related operations Wei Hu (Xavier) 2019-08-30 15:03 ` Ferruh Yigit 2019-09-05 5:40 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 07/22] net/hns3: add support for some misc operations Wei Hu (Xavier) 2019-08-30 15:04 ` Ferruh Yigit 2019-08-23 13:46 ` [dpdk-dev] [PATCH 08/22] net/hns3: add support for link update operation Wei Hu (Xavier) 2019-08-30 15:04 ` Ferruh Yigit 2019-09-06 6:56 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 09/22] net/hns3: add support for flow directory of hns3 PMD driver Wei Hu (Xavier) 2019-08-30 15:06 ` Ferruh Yigit 2019-09-06 8:23 ` Wei Hu (Xavier) 2019-09-06 11:08 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 10/22] net/hns3: add support for RSS " Wei Hu (Xavier) 2019-08-30 15:07 ` Ferruh Yigit 2019-08-31 9:16 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 11/22] net/hns3: add support for flow control " Wei Hu (Xavier) 2019-08-30 15:07 ` Ferruh Yigit 2019-08-31 8:04 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 12/22] net/hns3: add support for VLAN " Wei Hu (Xavier) 2019-08-30 15:08 ` Ferruh Yigit 2019-08-31 9:04 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 13/22] net/hns3: add support for mailbox " Wei Hu (Xavier) 2019-08-30 15:08 ` Ferruh Yigit 2019-09-06 11:25 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 14/22] net/hns3: add support for hns3 VF " Wei Hu (Xavier) 2019-08-30 15:11 ` Ferruh Yigit 2019-08-31 9:03 ` Wei Hu (Xavier) 2019-09-06 11:27 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 15/22] net/hns3: add package and queue related operation Wei Hu (Xavier) 2019-08-23 15:42 ` Aaron Conole 2019-08-30 15:13 ` Ferruh Yigit 2019-09-11 11:40 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 16/22] net/hns3: add start stop configure promiscuous ops Wei Hu (Xavier) 2019-08-30 15:14 ` Ferruh Yigit 2019-09-06 11:51 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 17/22] net/hns3: add dump register ops for hns3 PMD driver Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 18/22] net/hns3: add abnormal interrupt process " Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 19/22] net/hns3: add stats related ops " Wei Hu (Xavier) 2019-08-30 15:20 ` Ferruh Yigit 2019-08-31 8:49 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 20/22] net/hns3: add reset related process " Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 21/22] net/hns3: add multiple process support " Wei Hu (Xavier) 2019-08-30 15:14 ` Ferruh Yigit 2019-09-02 13:41 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files Wei Hu (Xavier) 2019-08-23 14:08 ` Jerin Jacob Kollanukkaran 2019-08-30 3:22 ` Wei Hu (Xavier) 2019-08-31 2:10 ` Wei Hu (Xavier) 2019-08-30 14:57 ` Ferruh Yigit 2019-08-30 6:16 ` Stephen Hemminger 2019-08-31 8:46 ` Wei Hu (Xavier) 2019-08-30 6:17 ` Stephen Hemminger 2019-08-31 8:44 ` Wei Hu (Xavier) 2019-09-03 15:27 ` Ye Xiaolong 2019-09-11 11:36 ` Wei Hu (Xavier) 2019-08-30 14:58 ` Ferruh Yigit 2019-09-10 11:43 ` Wei Hu (Xavier) 2019-08-30 15:00 ` Ferruh Yigit 2019-08-31 8:07 ` Wei Hu (Xavier) 2019-08-30 15:12 ` Ferruh Yigit 2019-08-31 8:07 ` Wei Hu (Xavier) 2019-08-30 15:23 ` [dpdk-dev] [PATCH 00/22] add hns3 ethernet PMD driver Ferruh Yigit 2019-08-31 8:06 ` Wei Hu (Xavier)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=763b0d93-3e5a-d12d-663a-65ba94189f0e@intel.com \ --to=ferruh.yigit@intel.com \ --cc=dev@dpdk.org \ --cc=forest.zhouchang@huawei.com \ --cc=linuxarm@huawei.com \ --cc=liudongdong3@huawei.com \ --cc=xavier.huwei@huawei.com \ --cc=xavier_huwei@163.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git