From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com> To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org> Cc: <linuxarm@huawei.com>, <xavier_huwei@163.com>, <liudongdong3@huawei.com>, <forest.zhouchang@huawei.com> Subject: Re: [dpdk-dev] [PATCH 11/22] net/hns3: add support for flow control of hns3 PMD driver Date: Sat, 31 Aug 2019 16:04:15 +0800 Message-ID: <218b115d-0949-adf4-aad3-47d2fa88997b@huawei.com> (raw) In-Reply-To: <7497c1f6-4f50-16a0-6114-227fd7dca55d@intel.com> On 2019/8/30 23:07, Ferruh Yigit wrote: > On 8/23/2019 2:47 PM, Wei Hu (Xavier) wrote: >> This patch adds support for MAC PAUSE flow control and priority flow >> control of hns3 PMD driver. All user priorities(up) must be mapped to >> tc0 when MAC PAUSE flow control is enabled. Ups can be mapped to other >> tcs driver permit when PFC is enabled. Flow control function by default >> is turned off to ensure that app startup state is the same each time. > As far as I can see the patch both enable DCB and flow control, can you please > either split the patch or update the commit log to cover both features? Hi, Ferruh Yigit Thanks for your comments. We will modify the commit log in patch V2 as follows: This patch adds support for MAC PAUSE flow control and priority flow control(PFC). MAC PAUSE flow control features: All user priorities(up) are mapped to tc0. It supports settings of flow mode and pause time. DCB features: Up can be mapped to other tc driver permits according to business requirement. We can config DCB information and enable PFC by rte_eth_dev_configure interface. Besides, enabling flow control of a priority is supported by rte_eth_dev_priority_flow_ctrl_set interface. we can also set flow mode and pause time by rte_eth_dev_priority_flow_ctrl_set. we do not support manual setting of ETS, but driver equally distributes bandwidth for each tc according to number of used tc. In addition, flow control function by default is turned off to ensure that app startup state is the same each time. >> Signed-off-by: Huisong Li <lihuisong@huawei.com> >> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> >> Signed-off-by: Chunsong Feng <fengchunsong@huawei.com> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >> Signed-off-by: Hao Chen <chenhao164@huawei.com> > <...> > >> static const struct eth_dev_ops hns3_eth_dev_ops = { >> .dev_close = hns3_dev_close, >> .mtu_set = hns3_dev_mtu_set, >> .dev_infos_get = hns3_dev_infos_get, >> .fw_version_get = hns3_fw_version_get, >> + .flow_ctrl_get = hns3_flow_ctrl_get, >> + .flow_ctrl_set = hns3_flow_ctrl_set, >> + .priority_flow_ctrl_set = hns3_priority_flow_ctrl_set, > Can you please update .ini file in this patch and mark following features as > supported: > Flow control OK, We will fix it in patch V2. >> .mac_addr_add = hns3_add_mac_addr, >> .mac_addr_remove = hns3_remove_mac_addr, >> .mac_addr_set = hns3_set_default_mac_addr, >> @@ -2753,6 +2949,7 @@ static const struct eth_dev_ops hns3_eth_dev_ops = { >> .reta_update = hns3_dev_rss_reta_update, >> .reta_query = hns3_dev_rss_reta_query, >> .filter_ctrl = hns3_dev_filter_ctrl, >> + .get_dcb_info = hns3_get_dcb_info, > Can you please update .ini file in this patch and mark following features as > supported: > DCB > OK, We will fix it in patch V2. Regards Xavier
next prev parent reply index Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-23 13:46 [dpdk-dev] [PATCH 00/22] add hns3 ethernet " Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 01/22] net/hns3: add hardware registers definition Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 02/22] net/hns3: add some definitions for data structure and macro Wei Hu (Xavier) 2019-08-30 8:25 ` Gavin Hu (Arm Technology China) 2019-09-05 6:01 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 03/22] net/hns3: register hns3 PMD driver Wei Hu (Xavier) 2019-08-30 15:01 ` Ferruh Yigit 2019-09-06 6:20 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 04/22] net/hns3: add support for cmd of " Wei Hu (Xavier) 2019-08-30 15:02 ` Ferruh Yigit 2019-09-06 6:49 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 05/22] net/hns3: add the initialization " Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 06/22] net/hns3: add support for MAC address related operations Wei Hu (Xavier) 2019-08-30 15:03 ` Ferruh Yigit 2019-09-05 5:40 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 07/22] net/hns3: add support for some misc operations Wei Hu (Xavier) 2019-08-30 15:04 ` Ferruh Yigit 2019-08-23 13:46 ` [dpdk-dev] [PATCH 08/22] net/hns3: add support for link update operation Wei Hu (Xavier) 2019-08-30 15:04 ` Ferruh Yigit 2019-09-06 6:56 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 09/22] net/hns3: add support for flow directory of hns3 PMD driver Wei Hu (Xavier) 2019-08-30 15:06 ` Ferruh Yigit 2019-09-06 8:23 ` Wei Hu (Xavier) 2019-09-06 11:08 ` Wei Hu (Xavier) 2019-08-23 13:46 ` [dpdk-dev] [PATCH 10/22] net/hns3: add support for RSS " Wei Hu (Xavier) 2019-08-30 15:07 ` Ferruh Yigit 2019-08-31 9:16 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 11/22] net/hns3: add support for flow control " Wei Hu (Xavier) 2019-08-30 15:07 ` Ferruh Yigit 2019-08-31 8:04 ` Wei Hu (Xavier) [this message] 2019-08-23 13:47 ` [dpdk-dev] [PATCH 12/22] net/hns3: add support for VLAN " Wei Hu (Xavier) 2019-08-30 15:08 ` Ferruh Yigit 2019-08-31 9:04 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 13/22] net/hns3: add support for mailbox " Wei Hu (Xavier) 2019-08-30 15:08 ` Ferruh Yigit 2019-09-06 11:25 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 14/22] net/hns3: add support for hns3 VF " Wei Hu (Xavier) 2019-08-30 15:11 ` Ferruh Yigit 2019-08-31 9:03 ` Wei Hu (Xavier) 2019-09-06 11:27 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 15/22] net/hns3: add package and queue related operation Wei Hu (Xavier) 2019-08-23 15:42 ` Aaron Conole 2019-08-30 15:13 ` Ferruh Yigit 2019-09-11 11:40 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 16/22] net/hns3: add start stop configure promiscuous ops Wei Hu (Xavier) 2019-08-30 15:14 ` Ferruh Yigit 2019-09-06 11:51 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 17/22] net/hns3: add dump register ops for hns3 PMD driver Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 18/22] net/hns3: add abnormal interrupt process " Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 19/22] net/hns3: add stats related ops " Wei Hu (Xavier) 2019-08-30 15:20 ` Ferruh Yigit 2019-08-31 8:49 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 20/22] net/hns3: add reset related process " Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 21/22] net/hns3: add multiple process support " Wei Hu (Xavier) 2019-08-30 15:14 ` Ferruh Yigit 2019-09-02 13:41 ` Wei Hu (Xavier) 2019-08-23 13:47 ` [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files Wei Hu (Xavier) 2019-08-23 14:08 ` Jerin Jacob Kollanukkaran 2019-08-30 3:22 ` Wei Hu (Xavier) 2019-08-31 2:10 ` Wei Hu (Xavier) 2019-08-30 14:57 ` Ferruh Yigit 2019-08-30 6:16 ` Stephen Hemminger 2019-08-31 8:46 ` Wei Hu (Xavier) 2019-08-30 6:17 ` Stephen Hemminger 2019-08-31 8:44 ` Wei Hu (Xavier) 2019-09-03 15:27 ` Ye Xiaolong 2019-09-11 11:36 ` Wei Hu (Xavier) 2019-08-30 14:58 ` Ferruh Yigit 2019-09-10 11:43 ` Wei Hu (Xavier) 2019-08-30 15:00 ` Ferruh Yigit 2019-08-31 8:07 ` Wei Hu (Xavier) 2019-08-30 15:12 ` Ferruh Yigit 2019-08-31 8:07 ` Wei Hu (Xavier) 2019-08-30 15:23 ` [dpdk-dev] [PATCH 00/22] add hns3 ethernet PMD driver Ferruh Yigit 2019-08-31 8:06 ` Wei Hu (Xavier)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=218b115d-0949-adf4-aad3-47d2fa88997b@huawei.com \ --to=xavier.huwei@huawei.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=forest.zhouchang@huawei.com \ --cc=linuxarm@huawei.com \ --cc=liudongdong3@huawei.com \ --cc=xavier_huwei@163.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git