From: Dekel Peled <dekelp@mellanox.com> To: john.mcnamara@intel.com, marko.kovacevic@intel.com, nhorman@tuxdriver.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, anatoly.burakov@intel.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, matan@mellanox.com, shahafs@mellanox.com, viacheslavo@mellanox.com, rmody@marvell.com, shshaikh@marvell.com, maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com, yongwang@vmware.com, thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com, jingjing.wu@intel.com, bernard.iremonger@intel.com Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH v3 2/3] net/mlx5: use API to set max LRO packet size Date: Wed, 6 Nov 2019 16:28:17 +0200 Message-ID: <bd4231db7829e2113493bb130b4f15b27efb9d25.1573050134.git.dekelp@mellanox.com> (raw) In-Reply-To: <cover.1573050133.git.dekelp@mellanox.com> This patch implements use of the API for LRO aggregated packet max size. Rx queue create is updated to use the relevant configuration. Documentation is updated accordingly. Signed-off-by: Dekel Peled <dekelp@mellanox.com> --- doc/guides/nics/mlx5.rst | 2 ++ drivers/net/mlx5/mlx5_rxq.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 4f1093f..3b10daf 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -207,6 +207,8 @@ Limitations - KEEP_CRC offload cannot be supported with LRO. - The first mbuf length, without head-room, must be big enough to include the TCP header (122B). + - Rx queue with LRO offload enabled, receiving a non-LRO packet, can forward + it with size limited to max LRO size, not to max RX packet length. Statistics ---------- diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 9423e7b..c725e14 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -1772,7 +1772,9 @@ struct mlx5_rxq_ctrl * dev->data->dev_conf.rxmode.offloads; unsigned int lro_on_queue = !!(offloads & DEV_RX_OFFLOAD_TCP_LRO); const int mprq_en = mlx5_check_mprq_support(dev) > 0; - unsigned int max_rx_pkt_len = dev->data->dev_conf.rxmode.max_rx_pkt_len; + unsigned int max_rx_pkt_len = lro_on_queue ? + dev->data->dev_conf.rxmode.max_lro_pkt_size : + dev->data->dev_conf.rxmode.max_rx_pkt_len; unsigned int non_scatter_min_mbuf_size = max_rx_pkt_len + RTE_PKTMBUF_HEADROOM; unsigned int max_lro_size = 0; -- 1.8.3.1
next prev parent reply index Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-05 8:40 [dpdk-dev] [PATCH 0/3] support " Dekel Peled 2019-11-05 8:40 ` [dpdk-dev] [PATCH 1/3] ethdev: " Dekel Peled 2019-11-05 12:39 ` Andrew Rybchenko 2019-11-05 13:09 ` Thomas Monjalon 2019-11-05 14:18 ` Dekel Peled 2019-11-05 14:27 ` Andrew Rybchenko 2019-11-05 14:51 ` Dekel Peled 2019-11-05 8:40 ` [dpdk-dev] [PATCH 2/3] net/mlx5: use " Dekel Peled 2019-11-05 8:40 ` [dpdk-dev] [PATCH 3/3] app/testpmd: " Dekel Peled 2019-11-05 9:35 ` [dpdk-dev] [PATCH 0/3] support " Matan Azrad 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 " Dekel Peled 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 1/3] ethdev: " Dekel Peled 2019-11-06 12:26 ` Thomas Monjalon 2019-11-06 12:39 ` Dekel Peled 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 2/3] net/mlx5: use " Dekel Peled 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: " Dekel Peled 2019-11-06 12:35 ` Iremonger, Bernard 2019-11-06 13:14 ` Dekel Peled 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 0/3] support " Dekel Peled 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 1/3] ethdev: " Dekel Peled 2019-11-07 11:57 ` [dpdk-dev] [EXT] " Shahed Shaikh 2019-11-07 12:18 ` Dekel Peled 2019-11-06 14:28 ` Dekel Peled [this message] 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: use " Dekel Peled 2019-11-06 16:41 ` [dpdk-dev] [PATCH v3 0/3] support " Iremonger, Bernard 2019-11-07 6:10 ` Dekel Peled 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 " Dekel Peled 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 1/3] ethdev: " Dekel Peled 2019-11-07 20:15 ` Ferruh Yigit 2019-11-08 6:54 ` Matan Azrad 2019-11-08 9:19 ` Ferruh Yigit 2019-11-08 10:10 ` Matan Azrad 2019-11-08 11:37 ` Ferruh Yigit 2019-11-08 11:56 ` Matan Azrad 2019-11-08 12:51 ` Ferruh Yigit 2019-11-08 16:11 ` Dekel Peled 2019-11-08 16:53 ` Ferruh Yigit 2019-11-09 18:20 ` Matan Azrad 2019-11-10 23:40 ` Ananyev, Konstantin 2019-11-11 8:01 ` Matan Azrad 2019-11-12 18:31 ` Ananyev, Konstantin 2019-11-11 11:15 ` Ferruh Yigit 2019-11-11 11:33 ` Matan Azrad 2019-11-11 12:21 ` Ferruh Yigit 2019-11-11 13:32 ` Matan Azrad 2019-11-08 13:11 ` Ananyev, Konstantin 2019-11-08 14:10 ` Dekel Peled 2019-11-08 14:52 ` Ananyev, Konstantin 2019-11-08 16:08 ` Dekel Peled 2019-11-08 16:28 ` Ananyev, Konstantin 2019-11-09 18:26 ` Matan Azrad 2019-11-10 22:51 ` Ananyev, Konstantin 2019-11-11 6:53 ` Matan Azrad 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 2/3] net/mlx5: use " Dekel Peled 2019-11-08 9:12 ` Slava Ovsiienko 2019-11-08 9:23 ` Ferruh Yigit 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: " Dekel Peled 2019-11-07 14:20 ` Iremonger, Bernard 2019-11-07 20:25 ` Ferruh Yigit 2019-11-08 6:56 ` Matan Azrad 2019-11-08 13:58 ` Dekel Peled 2019-11-08 6:28 ` [dpdk-dev] [PATCH v4 0/3] support " Matan Azrad 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 " Dekel Peled 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 1/3] ethdev: " Dekel Peled 2019-11-10 23:07 ` Ananyev, Konstantin 2019-11-11 7:40 ` Dekel Peled 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 2/3] net/mlx5: use " Dekel Peled 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: " Dekel Peled 2019-11-10 23:11 ` Ananyev, Konstantin 2019-11-11 7:40 ` Dekel Peled 2019-11-08 23:07 ` [dpdk-dev] [PATCH v6] ethdev: add " Thomas Monjalon 2019-11-10 22:47 ` Ananyev, Konstantin 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 0/3] support API to set " Dekel Peled 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 1/3] ethdev: " Dekel Peled 2019-11-12 0:46 ` Ferruh Yigit 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 2/3] net/mlx5: use " Dekel Peled 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: " Dekel Peled 2019-11-12 0:46 ` Ferruh Yigit 2019-11-12 0:47 ` [dpdk-dev] [PATCH v7 0/3] support " Ferruh Yigit
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bd4231db7829e2113493bb130b4f15b27efb9d25.1573050134.git.dekelp@mellanox.com \ --to=dekelp@mellanox.com \ --cc=ajit.khaparde@broadcom.com \ --cc=anatoly.burakov@intel.com \ --cc=arybchenko@solarflare.com \ --cc=bernard.iremonger@intel.com \ --cc=cloud.wangxiaoyun@huawei.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jingjing.wu@intel.com \ --cc=john.mcnamara@intel.com \ --cc=konstantin.ananyev@intel.com \ --cc=marko.kovacevic@intel.com \ --cc=matan@mellanox.com \ --cc=maxime.coquelin@redhat.com \ --cc=nhorman@tuxdriver.com \ --cc=rmody@marvell.com \ --cc=shahafs@mellanox.com \ --cc=shshaikh@marvell.com \ --cc=somnath.kotur@broadcom.com \ --cc=thomas@monjalon.net \ --cc=tiwei.bie@intel.com \ --cc=viacheslavo@mellanox.com \ --cc=wenzhuo.lu@intel.com \ --cc=xuanziyang2@huawei.com \ --cc=yongwang@vmware.com \ --cc=zhihong.wang@intel.com \ --cc=zhouguoyang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git