DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>, hemant.agrawal@nxp.com
Cc: dev@dpdk.org, thomas@monjalon.net, nipun.gupta@nxp.com,
	akhil.goyal@nxp.com
Subject: Re: [dpdk-dev] [PATCH v4 1/7] bus/fslmc: change to dynamic logging
Date: Tue, 3 Dec 2019 15:35:14 +0000
Message-ID: <e4a4179d-c691-cff4-5f19-675b37b44595@intel.com> (raw)
In-Reply-To: <20180402140601.21078-2-shreyansh.jain@nxp.com>

On 4/2/2018 3:05 PM, Shreyansh Jain wrote:
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

<...>

> diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
> index 5ee0beb85..4d29b53b1 100644
> --- a/drivers/bus/fslmc/fslmc_bus.c
> +++ b/drivers/bus/fslmc/fslmc_bus.c
> @@ -18,9 +18,9 @@
>  
>  #include <rte_fslmc.h>
>  #include <fslmc_vfio.h>
> +#include "fslmc_logs.h"
>  
> -#define FSLMC_BUS_LOG(level, fmt, args...) \
> -	RTE_LOG(level, EAL, fmt "\n", ##args)
> +int dpaa2_logtype_bus;
>  
>  #define VFIO_IOMMU_GROUP_PATH "/sys/kernel/iommu_groups"
>  
> @@ -93,6 +93,25 @@ insert_in_device_list(struct rte_dpaa2_device *newdev)
>  		TAILQ_INSERT_TAIL(&rte_fslmc_bus.device_list, newdev, next);
>  }
>  
> +static void
> +dump_device_list(void)
> +{
> +	struct rte_dpaa2_device *dev;
> +	uint32_t global_log_level;
> +	int local_log_level;
> +
> +	/* Only if the log level has been set to Debugging, print list */
> +	global_log_level = rte_log_get_global_level();
> +	local_log_level = rte_log_get_level(dpaa2_logtype_bus);
> +	if (global_log_level == RTE_LOG_DEBUG ||
> +	    global_log_level == RTE_LOG_DEBUG) {
> +		DPAA2_BUS_DEBUG("List of devices scanned on bus:");
> +		TAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {
> +			DPAA2_BUS_DEBUG("%s", dev->device.name);
> +		}
> +	}
> +}

Hi Hemant, Shreyansh,

This is old code but I saw it while checking something else, is
'global_log_level' & 'global_log_level' checks required?
Won't 'DPAA2_BUS_DEBUG' macro do it already?

Thanks,
ferruh




  reply index

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12  9:25 [PATCH 0/7] Change DPAA2 " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-12 11:04   ` Ferruh Yigit
2018-03-12 12:01     ` Shreyansh Jain
2018-03-12  9:25 ` [PATCH 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-12  9:25 ` [PATCH 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-12  9:25 ` [PATCH 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-03-12 12:10 ` [PATCH 0/7] Change DPAA2 " Hemant Agrawal
2018-03-12 12:37 ` Shreyansh Jain
2018-03-13  5:44 ` [RESEND v2 " Shreyansh Jain
2018-03-13  5:44   ` [RESEND v2 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-21  6:24     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-21  6:27     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-21  6:31     ` Hemant Agrawal
2018-03-23  7:19       ` Shreyansh Jain
2018-03-13  5:44   ` [RESEND v2 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-14  4:01     ` Nipun Gupta
2018-03-13  5:44   ` [RESEND v2 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-21  6:13     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-21  6:12     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-03-21  6:18     ` Hemant Agrawal
2018-03-23 12:04   ` [PATCH v3 0/7] Change DPAA2 " Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-26  8:48       ` Hemant Agrawal
2018-03-23 12:04     ` [PATCH v3 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-26  8:48       ` Hemant Agrawal
2018-03-29 15:26       ` Thomas Monjalon
2018-03-29 18:01         ` Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-04-02 14:05     ` [PATCH v4 0/7] Change DPAA2 " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 1/7] bus/fslmc: change " Shreyansh Jain
2019-12-03 15:35         ` Ferruh Yigit [this message]
2018-04-02 14:05       ` [PATCH v4 2/7] mempool/dpaa2: " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 3/7] net/dpaa2: change into " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 4/7] event/dpaa2: change to " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-04-02 14:06       ` [PATCH v4 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-04-02 14:06       ` [PATCH v4 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-04-02 22:03       ` [PATCH v4 0/7] Change DPAA2 " Thomas Monjalon

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4a4179d-c691-cff4-5f19-675b37b44595@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=nipun.gupta@nxp.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git