DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: dev@dpdk.org, hemant.agrawal@nxp.com, akhil.goyal@nxp.com,
	nipun.gupta@nxp.com
Subject: Re: [PATCH 3/7] net/dpaa2: change into dynamic logging
Date: Mon, 12 Mar 2018 11:04:42 +0000
Message-ID: <f5fe140a-c3a8-c299-73c8-dabe1e9c6fb8@intel.com> (raw)
In-Reply-To: <20180312092547.18472-4-shreyansh.jain@nxp.com>

On 3/12/2018 9:25 AM, Shreyansh Jain wrote:
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

<...>

> @@ -188,11 +188,6 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
>  # Compile burst-oriented NXP DPAA2 PMD driver
>  #
>  CONFIG_RTE_LIBRTE_DPAA2_PMD=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=n

Just to double check, are you sure to remove data path logging config options
too (RX, TX, TX_FREE)?

<...>

> @@ -557,6 +536,27 @@ for details.
>        Done
>        testpmd>
>  
> +Enabling logs
> +-------------
> +
> +For enabling logging for DPAA2 PMD, following log-level prefix can be used:
> +
> + .. code-block:: console
> +
> +    <dpdk app> <EAL args> --log-level=bus.fslmc,<level> -- ...
> +
> +Using ``bus.fslmc`` as log matching criteria, all FSLMC bus logs can be enabled
> +which are lower than logging ``level``.
> +
> + Or
> +
> + .. code-block:: console
> +
> +    <dpdk app> <EAL args> --log-level=pmd.dpaa2,<level> -- ...

Reminder, this will be also effected from naming change (pmd.net.dpaa2)

<...>

> @@ -2045,3 +2046,12 @@ static struct rte_dpaa2_driver rte_dpaa2_pmd = {
>  };
>  
>  RTE_PMD_REGISTER_DPAA2(net_dpaa2, rte_dpaa2_pmd);
> +
> +RTE_INIT(dpaa2_pmd_init_log);
> +static void
> +dpaa2_pmd_init_log(void)
> +{
> +	dpaa2_logtype_pmd = rte_log_register("pmd.dpaa2");

After commit [1] naming changed to "pmd.net.dpaa2"

[1]
Commit: 7db274b9ada2 ("doc: describe dynamic logging format")

<...>

> +/* DP Logs, toggled out at compile time if level lower than current level */
> +#define DPAA2_PMD_DP_LOG(level, fmt, args...) \
> +	RTE_LOG_DP(level, PMD, fmt, ## args)
> +
> +#define DPAA2_PMD_DP_DEBUG(fmt, args...) \
> +	DPAA2_PMD_DP_LOG(DEBUG, fmt, ## args)
> +#define DPAA2_PMD_DP_INFO(fmt, args...) \
> +	DPAA2_PMD_DP_LOG(INFO, fmt, ## args)
> +#define DPAA2_PMD_DP_WARN(fmt, args...) \
> +	DPAA2_PMD_DP_LOG(WARNING, fmt, ## args)

Just a reminder about using RTE_LOG_DP without config wrapper to disable them,
not all code will be removed in compilation time, only ones with log_level >
RTE_LOG_DP_LEVEL, so with default config DPAA2_PMD_DP_WARN() ones will not be
removed.
This can be OK or not based on your usage but this may effect your datapath.

<...>

  reply index

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12  9:25 [PATCH 0/7] Change DPAA2 to " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-12 11:04   ` Ferruh Yigit [this message]
2018-03-12 12:01     ` Shreyansh Jain
2018-03-12  9:25 ` [PATCH 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-12  9:25 ` [PATCH 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-12  9:25 ` [PATCH 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-12  9:25 ` [PATCH 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-03-12 12:10 ` [PATCH 0/7] Change DPAA2 " Hemant Agrawal
2018-03-12 12:37 ` Shreyansh Jain
2018-03-13  5:44 ` [RESEND v2 " Shreyansh Jain
2018-03-13  5:44   ` [RESEND v2 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-21  6:24     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-21  6:27     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-21  6:31     ` Hemant Agrawal
2018-03-23  7:19       ` Shreyansh Jain
2018-03-13  5:44   ` [RESEND v2 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-14  4:01     ` Nipun Gupta
2018-03-13  5:44   ` [RESEND v2 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-21  6:13     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-21  6:12     ` Hemant Agrawal
2018-03-13  5:44   ` [RESEND v2 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-03-21  6:18     ` Hemant Agrawal
2018-03-23 12:04   ` [PATCH v3 0/7] Change DPAA2 " Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-26  8:48       ` Hemant Agrawal
2018-03-23 12:04     ` [PATCH v3 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-26  8:48       ` Hemant Agrawal
2018-03-29 15:26       ` Thomas Monjalon
2018-03-29 18:01         ` Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-23 12:04     ` [PATCH v3 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-04-02 14:05     ` [PATCH v4 0/7] Change DPAA2 " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 1/7] bus/fslmc: change " Shreyansh Jain
2019-12-03 15:35         ` [dpdk-dev] " Ferruh Yigit
2018-04-02 14:05       ` [PATCH v4 2/7] mempool/dpaa2: " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 3/7] net/dpaa2: change into " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 4/7] event/dpaa2: change to " Shreyansh Jain
2018-04-02 14:05       ` [PATCH v4 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-04-02 14:06       ` [PATCH v4 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-04-02 14:06       ` [PATCH v4 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-04-02 22:03       ` [PATCH v4 0/7] Change DPAA2 " Thomas Monjalon

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5fe140a-c3a8-c299-73c8-dabe1e9c6fb8@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=nipun.gupta@nxp.com \
    --cc=shreyansh.jain@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git