Re: [PATCH 3/7] net/dpaa2: change into dynamic logging

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 3/12/2018 9:25 AM, Shreyansh Jain wrote:
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

<...>

> @@ -188,11 +188,6 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
>  # Compile burst-oriented NXP DPAA2 PMD driver
>  #
>  CONFIG_RTE_LIBRTE_DPAA2_PMD=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=n

Just to double check, are you sure to remove data path logging config options
too (RX, TX, TX_FREE)?

<...>

> @@ -557,6 +536,27 @@ for details.
>        Done
>        testpmd>
>  
> +Enabling logs
> +-------------
> +
> +For enabling logging for DPAA2 PMD, following log-level prefix can be used:
> +
> + .. code-block:: console
> +
> +    <dpdk app> <EAL args> --log-level=bus.fslmc,<level> -- ...
> +
> +Using ``bus.fslmc`` as log matching criteria, all FSLMC bus logs can be enabled
> +which are lower than logging ``level``.
> +
> + Or
> +
> + .. code-block:: console
> +
> +    <dpdk app> <EAL args> --log-level=pmd.dpaa2,<level> -- ...

Reminder, this will be also effected from naming change (pmd.net.dpaa2)

<...>

> @@ -2045,3 +2046,12 @@ static struct rte_dpaa2_driver rte_dpaa2_pmd = {
>  };
>  
>  RTE_PMD_REGISTER_DPAA2(net_dpaa2, rte_dpaa2_pmd);
> +
> +RTE_INIT(dpaa2_pmd_init_log);
> +static void
> +dpaa2_pmd_init_log(void)
> +{
> +	dpaa2_logtype_pmd = rte_log_register("pmd.dpaa2");

After commit [1] naming changed to "pmd.net.dpaa2"

[1]
Commit: 7db274b9ada2 ("doc: describe dynamic logging format")

<...>

> +/* DP Logs, toggled out at compile time if level lower than current level */
> +#define DPAA2_PMD_DP_LOG(level, fmt, args...) \
> +	RTE_LOG_DP(level, PMD, fmt, ## args)
> +
> +#define DPAA2_PMD_DP_DEBUG(fmt, args...) \
> +	DPAA2_PMD_DP_LOG(DEBUG, fmt, ## args)
> +#define DPAA2_PMD_DP_INFO(fmt, args...) \
> +	DPAA2_PMD_DP_LOG(INFO, fmt, ## args)
> +#define DPAA2_PMD_DP_WARN(fmt, args...) \
> +	DPAA2_PMD_DP_LOG(WARNING, fmt, ## args)

Just a reminder about using RTE_LOG_DP without config wrapper to disable them,
not all code will be removed in compilation time, only ones with log_level >
RTE_LOG_DP_LEVEL, so with default config DPAA2_PMD_DP_WARN() ones will not be
removed.
This can be OK or not based on your usage but this may effect your datapath.

<...>