* [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues @ 2020-02-26 22:05 Melissa Wen 2020-02-26 22:07 ` [PATCH 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function Melissa Wen ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Melissa Wen @ 2020-02-26 22:05 UTC (permalink / raw) To: Harry Wentland, Leo Li, Alex Deucher, Christian Konig, David Zhou, David Airlie, Daniel Vetter, Rodrigo Siqueira Cc: dri-devel, amd-gfx, linux-kernel This patchset solves some coding style issues on dc_link for readability and cleaning up warnings. Change suggested by checkpatch.pl. Melissa Wen (2): drm/amd/display: dc_link: code clean up on enable_link_dp function drm/amd/display: dc_link: code clean up on detect_dp function drivers/gpu/drm/amd/display/dc/core/dc_link.c | 67 +++++++++---------- 1 file changed, 32 insertions(+), 35 deletions(-) -- 2.25.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function 2020-02-26 22:05 [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Melissa Wen @ 2020-02-26 22:07 ` Melissa Wen 2020-02-27 15:04 ` Rodrigo Siqueira 2020-02-26 22:08 ` [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp function Melissa Wen 2020-02-27 15:05 ` [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Rodrigo Siqueira 2 siblings, 1 reply; 8+ messages in thread From: Melissa Wen @ 2020-02-26 22:07 UTC (permalink / raw) To: Harry Wentland, Leo Li, Alex Deucher, Christian Konig, David Zhou, David Airlie, Daniel Vetter, Rodrigo Siqueira Cc: dri-devel, amd-gfx, linux-kernel Coding style clean up on enable_link_dp function as suggested by checkpatch.pl: CHECK: Lines should not end with a '(' WARNING: line over 80 characters WARNING: suspect code indent for conditional statements (8, 24) CHECK: braces {} should be used on all arms of this statement ERROR: else should follow close brace '}' CHECK: Comparison to NULL could be written "link->preferred_training_settings.fec_enable" Signed-off-by: Melissa Wen <melissa.srw@gmail.com> --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c index a09119c10d7c..0f28b5694144 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c @@ -1480,9 +1480,8 @@ static void enable_stream_features(struct pipe_ctx *pipe_ctx) } } -static enum dc_status enable_link_dp( - struct dc_state *state, - struct pipe_ctx *pipe_ctx) +static enum dc_status enable_link_dp(struct dc_state *state, + struct pipe_ctx *pipe_ctx) { struct dc_stream_state *stream = pipe_ctx->stream; enum dc_status status; @@ -1512,27 +1511,28 @@ static enum dc_status enable_link_dp( pipe_ctx->stream_res.pix_clk_params.requested_sym_clk = link_settings.link_rate * LINK_RATE_REF_FREQ_IN_KHZ; - if (state->clk_mgr && !apply_seamless_boot_optimization) - state->clk_mgr->funcs->update_clocks(state->clk_mgr, state, false); + if (state->clk_mgr && !apply_seamless_boot_optimization) { + state->clk_mgr->funcs->update_clocks(state->clk_mgr, + state, false); + } skip_video_pattern = true; if (link_settings.link_rate == LINK_RATE_LOW) - skip_video_pattern = false; - - if (perform_link_training_with_retries( - &link_settings, - skip_video_pattern, - LINK_TRAINING_ATTEMPTS, - pipe_ctx, - pipe_ctx->stream->signal)) { + skip_video_pattern = false; + + if (perform_link_training_with_retries(&link_settings, + skip_video_pattern, + LINK_TRAINING_ATTEMPTS, + pipe_ctx, + pipe_ctx->stream->signal)) { link->cur_link_settings = link_settings; status = DC_OK; - } - else + } else { status = DC_FAIL_DP_LINK_TRAINING; + } - if (link->preferred_training_settings.fec_enable != NULL) + if (link->preferred_training_settings.fec_enable) fec_enable = *link->preferred_training_settings.fec_enable; else fec_enable = true; -- 2.25.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function 2020-02-26 22:07 ` [PATCH 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function Melissa Wen @ 2020-02-27 15:04 ` Rodrigo Siqueira 0 siblings, 0 replies; 8+ messages in thread From: Rodrigo Siqueira @ 2020-02-27 15:04 UTC (permalink / raw) To: Melissa Wen Cc: Rodrigo Siqueira, Leo Li, linux-kernel, dri-devel, David Airlie, amd-gfx, Alex Deucher, Christian Konig [-- Attachment #1.1: Type: text/plain, Size: 3598 bytes --] Hi, First of all, thank you for your patch. I just have one tiny comment inline. On 02/26, Melissa Wen wrote: > Coding style clean up on enable_link_dp function as suggested by > checkpatch.pl: > > CHECK: Lines should not end with a '(' > WARNING: line over 80 characters > WARNING: suspect code indent for conditional statements (8, 24) > CHECK: braces {} should be used on all arms of this statement > ERROR: else should follow close brace '}' > CHECK: Comparison to NULL could be written > "link->preferred_training_settings.fec_enable" > > Signed-off-by: Melissa Wen <melissa.srw@gmail.com> > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 32 +++++++++---------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > index a09119c10d7c..0f28b5694144 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > @@ -1480,9 +1480,8 @@ static void enable_stream_features(struct pipe_ctx *pipe_ctx) > } > } > > -static enum dc_status enable_link_dp( > - struct dc_state *state, > - struct pipe_ctx *pipe_ctx) > +static enum dc_status enable_link_dp(struct dc_state *state, > + struct pipe_ctx *pipe_ctx) > { > struct dc_stream_state *stream = pipe_ctx->stream; > enum dc_status status; > @@ -1512,27 +1511,28 @@ static enum dc_status enable_link_dp( > > pipe_ctx->stream_res.pix_clk_params.requested_sym_clk = > link_settings.link_rate * LINK_RATE_REF_FREQ_IN_KHZ; > - if (state->clk_mgr && !apply_seamless_boot_optimization) > - state->clk_mgr->funcs->update_clocks(state->clk_mgr, state, false); > + if (state->clk_mgr && !apply_seamless_boot_optimization) { > + state->clk_mgr->funcs->update_clocks(state->clk_mgr, > + state, false); > + } This `if` condition only has one action, which means that you don't need to add `{}` in the above statement. See: https://www.kernel.org/doc/html/v4.10/process/coding-style.html#placing-braces-and-spaces Thanks > > skip_video_pattern = true; > > if (link_settings.link_rate == LINK_RATE_LOW) > - skip_video_pattern = false; > - > - if (perform_link_training_with_retries( > - &link_settings, > - skip_video_pattern, > - LINK_TRAINING_ATTEMPTS, > - pipe_ctx, > - pipe_ctx->stream->signal)) { > + skip_video_pattern = false; > + > + if (perform_link_training_with_retries(&link_settings, > + skip_video_pattern, > + LINK_TRAINING_ATTEMPTS, > + pipe_ctx, > + pipe_ctx->stream->signal)) { > link->cur_link_settings = link_settings; > status = DC_OK; > - } > - else > + } else { > status = DC_FAIL_DP_LINK_TRAINING; > + } > > - if (link->preferred_training_settings.fec_enable != NULL) > + if (link->preferred_training_settings.fec_enable) > fec_enable = *link->preferred_training_settings.fec_enable; > else > fec_enable = true; > -- > 2.25.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7CRodrigo.Siqueira%40amd.com%7Ccbf2adb12548404e917208d7bb0842d2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637183516476617662&sdata=%2FyyxWqZVGvbVAnr1OWCKi0y5Sdl5j5Le6C3dmYoaNy4%3D&reserved=0 -- Rodrigo Siqueira https://siqueira.tech [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp function 2020-02-26 22:05 [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Melissa Wen 2020-02-26 22:07 ` [PATCH 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function Melissa Wen @ 2020-02-26 22:08 ` Melissa Wen 2020-02-27 18:39 ` Liu, Zhan 2020-02-27 15:05 ` [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Rodrigo Siqueira 2 siblings, 1 reply; 8+ messages in thread From: Melissa Wen @ 2020-02-26 22:08 UTC (permalink / raw) To: Harry Wentland, Leo Li, Alex Deucher, Christian Konig, David Zhou, David Airlie, Daniel Vetter, Rodrigo Siqueira Cc: dri-devel, amd-gfx, linux-kernel Removes codestyle issues on detect_dp function as suggested by checkpatch.pl. CHECK: Lines should not end with a '(' WARNING: Missing a blank line after declarations WARNING: line over 80 characters CHECK: Alignment should match open parenthesis Signed-off-by: Melissa Wen <melissa.srw@gmail.com> --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 35 +++++++++---------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c index 0f28b5694144..adb717f02c9c 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c @@ -585,14 +585,14 @@ static void read_current_link_settings_on_detect(struct dc_link *link) LINK_SPREAD_05_DOWNSPREAD_30KHZ : LINK_SPREAD_DISABLED; } -static bool detect_dp( - struct dc_link *link, - struct display_sink_capability *sink_caps, - bool *converter_disable_audio, - struct audio_support *audio_support, - enum dc_detect_reason reason) +static bool detect_dp(struct dc_link *link, + struct display_sink_capability *sink_caps, + bool *converter_disable_audio, + struct audio_support *audio_support, + enum dc_detect_reason reason) { bool boot = false; + sink_caps->signal = link_detect_sink(link, reason); sink_caps->transaction_type = get_ddc_transaction_type(sink_caps->signal); @@ -606,9 +606,8 @@ static bool detect_dp( sink_caps->signal = SIGNAL_TYPE_DISPLAY_PORT_MST; link->type = dc_connection_mst_branch; - dal_ddc_service_set_transaction_type( - link->ddc, - sink_caps->transaction_type); + dal_ddc_service_set_transaction_type(link->ddc, + sink_caps->transaction_type); /* * This call will initiate MST topology discovery. Which @@ -637,13 +636,10 @@ static bool detect_dp( if (reason == DETECT_REASON_BOOT) boot = true; - dm_helpers_dp_update_branch_info( - link->ctx, - link); + dm_helpers_dp_update_branch_info(link->ctx, link); - if (!dm_helpers_dp_mst_start_top_mgr( - link->ctx, - link, boot)) { + if (!dm_helpers_dp_mst_start_top_mgr(link->ctx, + link, boot)) { /* MST not supported */ link->type = dc_connection_single; sink_caps->signal = SIGNAL_TYPE_DISPLAY_PORT; @@ -651,7 +647,7 @@ static bool detect_dp( } if (link->type != dc_connection_mst_branch && - is_dp_active_dongle(link)) { + is_dp_active_dongle(link)) { /* DP active dongles */ link->type = dc_connection_active_dongle; if (!link->dpcd_caps.sink_count.bits.SINK_COUNT) { @@ -662,14 +658,15 @@ static bool detect_dp( return true; } - if (link->dpcd_caps.dongle_type != DISPLAY_DONGLE_DP_HDMI_CONVERTER) + if (link->dpcd_caps.dongle_type != + DISPLAY_DONGLE_DP_HDMI_CONVERTER) *converter_disable_audio = true; } } else { /* DP passive dongles */ sink_caps->signal = dp_passive_dongle_detection(link->ddc, - sink_caps, - audio_support); + sink_caps, + audio_support); } return true; -- 2.25.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp function 2020-02-26 22:08 ` [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp function Melissa Wen @ 2020-02-27 18:39 ` Liu, Zhan 2020-02-27 18:48 ` Liu, Zhan 0 siblings, 1 reply; 8+ messages in thread From: Liu, Zhan @ 2020-02-27 18:39 UTC (permalink / raw) To: Melissa Wen, Wentland, Harry, Li, Sun peng (Leo), Deucher, Alexander, Koenig, Christian, Zhou, David(ChunMing), David Airlie, Daniel Vetter, Rodrigo Siqueira Cc: amd-gfx, dri-devel, linux-kernel > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of > Melissa Wen > Sent: 2020/February/26, Wednesday 5:08 PM > To: Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) > <Sunpeng.Li@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; Koenig, Christian > <Christian.Koenig@amd.com>; Zhou, David(ChunMing) > <David1.Zhou@amd.com>; David Airlie <airlied@linux.ie>; Daniel Vetter > <daniel@ffwll.ch>; Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> > Cc: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; linux- > kernel@vger.kernel.org > Subject: [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp > function > > Removes codestyle issues on detect_dp function as suggested by > checkpatch.pl. > > CHECK: Lines should not end with a '(' > WARNING: Missing a blank line after declarations > WARNING: line over 80 characters > CHECK: Alignment should match open parenthesis > > Signed-off-by: Melissa Wen <melissa.srw@gmail.com> Thank you Melissa for your contribution! Will apply it. This patch is: Reviewed-by: Zhan Liu <zhan.liu@amd.com> > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 35 +++++++++---------- > 1 file changed, 16 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > index 0f28b5694144..adb717f02c9c 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > @@ -585,14 +585,14 @@ static void > read_current_link_settings_on_detect(struct dc_link *link) > LINK_SPREAD_05_DOWNSPREAD_30KHZ : > LINK_SPREAD_DISABLED; } > > -static bool detect_dp( > - struct dc_link *link, > - struct display_sink_capability *sink_caps, > - bool *converter_disable_audio, > - struct audio_support *audio_support, > - enum dc_detect_reason reason) > +static bool detect_dp(struct dc_link *link, > + struct display_sink_capability *sink_caps, > + bool *converter_disable_audio, > + struct audio_support *audio_support, > + enum dc_detect_reason reason) > { > bool boot = false; > + > sink_caps->signal = link_detect_sink(link, reason); > sink_caps->transaction_type = > get_ddc_transaction_type(sink_caps->signal); > @@ -606,9 +606,8 @@ static bool detect_dp( > sink_caps->signal = > SIGNAL_TYPE_DISPLAY_PORT_MST; > link->type = dc_connection_mst_branch; > > - dal_ddc_service_set_transaction_type( > - link->ddc, > - sink_caps- > >transaction_type); > + dal_ddc_service_set_transaction_type(link->ddc, > + sink_caps- > >transaction_type); > > /* > * This call will initiate MST topology discovery. > Which @@ -637,13 +636,10 @@ static bool detect_dp( > if (reason == DETECT_REASON_BOOT) > boot = true; > > - dm_helpers_dp_update_branch_info( > - link->ctx, > - link); > + dm_helpers_dp_update_branch_info(link->ctx, link); > > - if (!dm_helpers_dp_mst_start_top_mgr( > - link->ctx, > - link, boot)) { > + if (!dm_helpers_dp_mst_start_top_mgr(link->ctx, > + link, boot)) { > /* MST not supported */ > link->type = dc_connection_single; > sink_caps->signal = > SIGNAL_TYPE_DISPLAY_PORT; @@ -651,7 +647,7 @@ static bool detect_dp( > } > > if (link->type != dc_connection_mst_branch && > - is_dp_active_dongle(link)) { > + is_dp_active_dongle(link)) { > /* DP active dongles */ > link->type = dc_connection_active_dongle; > if (!link->dpcd_caps.sink_count.bits.SINK_COUNT) > { @@ -662,14 +658,15 @@ static bool detect_dp( > return true; > } > > - if (link->dpcd_caps.dongle_type != > DISPLAY_DONGLE_DP_HDMI_CONVERTER) > + if (link->dpcd_caps.dongle_type != > + DISPLAY_DONGLE_DP_HDMI_CONVERTER) > *converter_disable_audio = true; > } > } else { > /* DP passive dongles */ > sink_caps->signal = dp_passive_dongle_detection(link->ddc, > - sink_caps, > - audio_support); > + sink_caps, > + > audio_support); > } > > return true; > -- > 2.25.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp function 2020-02-27 18:39 ` Liu, Zhan @ 2020-02-27 18:48 ` Liu, Zhan 0 siblings, 0 replies; 8+ messages in thread From: Liu, Zhan @ 2020-02-27 18:48 UTC (permalink / raw) To: Liu, Zhan, Melissa Wen, Wentland, Harry, Li, Sun peng (Leo), Deucher, Alexander, Koenig, Christian, Zhou, David(ChunMing), David Airlie, Daniel Vetter, Rodrigo Siqueira Cc: dri-devel, amd-gfx, linux-kernel > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Liu, > Zhan > Sent: 2020/February/27, Thursday 1:40 PM > To: Melissa Wen <melissa.srw@gmail.com>; Wentland, Harry > <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; > Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian > <Christian.Koenig@amd.com>; Zhou, David(ChunMing) > <David1.Zhou@amd.com>; David Airlie <airlied@linux.ie>; Daniel Vetter > <daniel@ffwll.ch>; Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> > Cc: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > kernel@vger.kernel.org > Subject: RE: [PATCH 2/2] drm/amd/display: dc_link: code clean up on > detect_dp function > > > > -----Original Message----- > > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of > > Melissa Wen > > Sent: 2020/February/26, Wednesday 5:08 PM > > To: Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) > > <Sunpeng.Li@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; > > Koenig, Christian <Christian.Koenig@amd.com>; Zhou, David(ChunMing) > > <David1.Zhou@amd.com>; David Airlie <airlied@linux.ie>; Daniel Vetter > > <daniel@ffwll.ch>; Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> > > Cc: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; > > linux- kernel@vger.kernel.org > > Subject: [PATCH 2/2] drm/amd/display: dc_link: code clean up on > > detect_dp function > > > > Removes codestyle issues on detect_dp function as suggested by > > checkpatch.pl. > > > > CHECK: Lines should not end with a '(' > > WARNING: Missing a blank line after declarations > > WARNING: line over 80 characters > > CHECK: Alignment should match open parenthesis > > > > Signed-off-by: Melissa Wen <melissa.srw@gmail.com> > > Thank you Melissa for your contribution! Will apply it. > > This patch is: > Reviewed-by: Zhan Liu <zhan.liu@amd.com> Sorry I didn't see Rodrigo already replied your email. Please send us a V2, then we will review your V2 patch. And again, thank you so much for your contribution! Zhan > > > --- > > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 35 > > +++++++++---------- > > 1 file changed, 16 insertions(+), 19 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > > b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > > index 0f28b5694144..adb717f02c9c 100644 > > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > > @@ -585,14 +585,14 @@ static void > > read_current_link_settings_on_detect(struct dc_link *link) > > LINK_SPREAD_05_DOWNSPREAD_30KHZ : > > LINK_SPREAD_DISABLED; } > > > > -static bool detect_dp( > > - struct dc_link *link, > > - struct display_sink_capability *sink_caps, > > - bool *converter_disable_audio, > > - struct audio_support *audio_support, > > - enum dc_detect_reason reason) > > +static bool detect_dp(struct dc_link *link, > > + struct display_sink_capability *sink_caps, > > + bool *converter_disable_audio, > > + struct audio_support *audio_support, > > + enum dc_detect_reason reason) > > { > > bool boot = false; > > + > > sink_caps->signal = link_detect_sink(link, reason); > > sink_caps->transaction_type = > > get_ddc_transaction_type(sink_caps->signal); > > @@ -606,9 +606,8 @@ static bool detect_dp( > > sink_caps->signal = > > SIGNAL_TYPE_DISPLAY_PORT_MST; > > link->type = dc_connection_mst_branch; > > > > - dal_ddc_service_set_transaction_type( > > - link->ddc, > > - sink_caps- > > >transaction_type); > > + dal_ddc_service_set_transaction_type(link->ddc, > > + sink_caps- > > >transaction_type); > > > > /* > > * This call will initiate MST topology discovery. > > Which @@ -637,13 +636,10 @@ static bool detect_dp( > > if (reason == DETECT_REASON_BOOT) > > boot = true; > > > > - dm_helpers_dp_update_branch_info( > > - link->ctx, > > - link); > > + dm_helpers_dp_update_branch_info(link->ctx, link); > > > > - if (!dm_helpers_dp_mst_start_top_mgr( > > - link->ctx, > > - link, boot)) { > > + if (!dm_helpers_dp_mst_start_top_mgr(link->ctx, > > + link, boot)) { > > /* MST not supported */ > > link->type = dc_connection_single; > > sink_caps->signal = > > SIGNAL_TYPE_DISPLAY_PORT; @@ -651,7 +647,7 @@ static bool > detect_dp( > > } > > > > if (link->type != dc_connection_mst_branch && > > - is_dp_active_dongle(link)) { > > + is_dp_active_dongle(link)) { > > /* DP active dongles */ > > link->type = dc_connection_active_dongle; > > if (!link->dpcd_caps.sink_count.bits.SINK_COUNT) > > { @@ -662,14 +658,15 @@ static bool detect_dp( > > return true; > > } > > > > - if (link->dpcd_caps.dongle_type != > > DISPLAY_DONGLE_DP_HDMI_CONVERTER) > > + if (link->dpcd_caps.dongle_type != > > + DISPLAY_DONGLE_DP_HDMI_CONVERTER) > > *converter_disable_audio = true; > > } > > } else { > > /* DP passive dongles */ > > sink_caps->signal = dp_passive_dongle_detection(link->ddc, > > - sink_caps, > > - audio_support); > > + sink_caps, > > + > > audio_support); > > } > > > > return true; > > -- > > 2.25.0 > > > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@lists.freedesktop.org > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues 2020-02-26 22:05 [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Melissa Wen 2020-02-26 22:07 ` [PATCH 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function Melissa Wen 2020-02-26 22:08 ` [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp function Melissa Wen @ 2020-02-27 15:05 ` Rodrigo Siqueira 2020-02-27 18:38 ` Melissa Wen 2 siblings, 1 reply; 8+ messages in thread From: Rodrigo Siqueira @ 2020-02-27 15:05 UTC (permalink / raw) To: Melissa Wen Cc: Rodrigo Siqueira, Leo Li, linux-kernel, dri-devel, David Airlie, amd-gfx, Alex Deucher, Christian Konig [-- Attachment #1.1: Type: text/plain, Size: 1361 bytes --] Hi Melissa, First of all, thank you very much for this patchset; in general, everything looks good to me. I noticed that your patchset does not apply because you made your changes based on `drm-misc-next`; when you send patches to amdgpu, use the following repository: git://people.freedesktop.org/~agd5f/linux Could you prepare a V2? Thanks! On 02/26, Melissa Wen wrote: > This patchset solves some coding style issues on dc_link for readability > and cleaning up warnings. Change suggested by checkpatch.pl. > > Melissa Wen (2): > drm/amd/display: dc_link: code clean up on enable_link_dp function > drm/amd/display: dc_link: code clean up on detect_dp function > > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 67 +++++++++---------- > 1 file changed, 32 insertions(+), 35 deletions(-) > > -- > 2.25.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7CRodrigo.Siqueira%40amd.com%7C7a3e02e3f43447ed4fab08d7bb080d9b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637183515885211986&sdata=bnipkrUtKdO1oOKxdt1th4iIG1%2BBgl2wMPVrdmn3P1U%3D&reserved=0 -- Rodrigo Siqueira https://siqueira.tech [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues 2020-02-27 15:05 ` [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Rodrigo Siqueira @ 2020-02-27 18:38 ` Melissa Wen 0 siblings, 0 replies; 8+ messages in thread From: Melissa Wen @ 2020-02-27 18:38 UTC (permalink / raw) To: Rodrigo Siqueira Cc: Rodrigo Siqueira, Leo Li, linux-kernel, dri-devel, David Airlie, amd-gfx, Alex Deucher, Christian Konig Hi Rodrigo, On 02/27, Rodrigo Siqueira wrote: > Hi Melissa, > > First of all, thank you very much for this patchset; in general, > everything looks good to me. > > I noticed that your patchset does not apply because you made your > changes based on `drm-misc-next`; when you send patches to amdgpu, use > the following repository: > > git://people.freedesktop.org/~agd5f/linux > > Could you prepare a V2? Yes. Thanks for reviewing my patches. Soon, I will send a V2 with the changes suggested by you. > > Thanks! > > On 02/26, Melissa Wen wrote: > > This patchset solves some coding style issues on dc_link for readability > > and cleaning up warnings. Change suggested by checkpatch.pl. > > > > Melissa Wen (2): > > drm/amd/display: dc_link: code clean up on enable_link_dp function > > drm/amd/display: dc_link: code clean up on detect_dp function > > > > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 67 +++++++++---------- > > 1 file changed, 32 insertions(+), 35 deletions(-) > > > > -- > > 2.25.0 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7CRodrigo.Siqueira%40amd.com%7C7a3e02e3f43447ed4fab08d7bb080d9b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637183515885211986&sdata=bnipkrUtKdO1oOKxdt1th4iIG1%2BBgl2wMPVrdmn3P1U%3D&reserved=0 > > -- > Rodrigo Siqueira > https://siqueira.tech Melissa Wen _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-02-27 18:48 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-26 22:05 [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Melissa Wen 2020-02-26 22:07 ` [PATCH 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function Melissa Wen 2020-02-27 15:04 ` Rodrigo Siqueira 2020-02-26 22:08 ` [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp function Melissa Wen 2020-02-27 18:39 ` Liu, Zhan 2020-02-27 18:48 ` Liu, Zhan 2020-02-27 15:05 ` [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Rodrigo Siqueira 2020-02-27 18:38 ` Melissa Wen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).