From: Sam Ravnborg via B4 Submission Endpoint <devnull+sam.ravnborg.org@kernel.org>
To: Nicolas Ferre <nicolas.ferre@microchip.com>,
Helge Deller <deller@gmx.de>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Antonino Daplas <adaplas@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Robin van der Gracht <robin@protonic.nl>,
Miguel Ojeda <ojeda@kernel.org>, Lee Jones <lee@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, Stephen Kitt <steve@sk2.org>,
Arnd Bergmann <arnd@arndb.de>,
Jani Nikula <jani.nikula@intel.com>,
Sam Ravnborg <sam@ravnborg.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/15] video: fbdev: mx3fb: Introduce backlight_get_brightness()
Date: Sat, 07 Jan 2023 19:26:21 +0100 [thread overview]
Message-ID: <20230107-sam-video-backlight-drop-fb_blank-v1-7-1bd9bafb351f@ravnborg.org> (raw)
In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org>
From: Sam Ravnborg <sam@ravnborg.org>
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Kate Stewart <kstewart@linuxfoundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Jani Nikula <jani.nikula@intel.com>
---
drivers/video/fbdev/mx3fb.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
index b945b68984b9..bc35f664cbff 100644
--- a/drivers/video/fbdev/mx3fb.c
+++ b/drivers/video/fbdev/mx3fb.c
@@ -283,12 +283,7 @@ static int mx3fb_bl_get_brightness(struct backlight_device *bl)
static int mx3fb_bl_update_status(struct backlight_device *bl)
{
struct mx3fb_data *fbd = bl_get_data(bl);
- int brightness = bl->props.brightness;
-
- if (bl->props.power != FB_BLANK_UNBLANK)
- brightness = 0;
- if (bl->props.fb_blank != FB_BLANK_UNBLANK)
- brightness = 0;
+ int brightness = backlight_get_brightness(bl);
fbd->backlight_level = (fbd->backlight_level & ~0xFF) | brightness;
@@ -325,7 +320,6 @@ static void mx3fb_init_backlight(struct mx3fb_data *fbd)
fbd->bl = bl;
bl->props.power = FB_BLANK_UNBLANK;
- bl->props.fb_blank = FB_BLANK_UNBLANK;
bl->props.brightness = mx3fb_bl_get_brightness(bl);
}
--
2.34.1
next prev parent reply other threads:[~2023-01-07 18:26 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 18:26 [PATCH 00/15] backlight: Drop use of deprecated fb_blank property Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling Sam Ravnborg via B4 Submission Endpoint
2023-01-07 20:36 ` Stephen Kitt
2023-01-07 20:53 ` Sam Ravnborg
2023-01-08 7:45 ` Stephen Kitt
2023-01-08 7:47 ` Stephen Kitt
2023-01-08 20:24 ` Sam Ravnborg
2023-01-09 19:53 ` Stephen Kitt
2023-01-09 20:03 ` Stephen Kitt
2023-01-08 17:26 ` Helge Deller
2023-01-08 20:26 ` Sam Ravnborg
2023-01-09 20:18 ` Stephen Kitt
2023-01-09 20:34 ` Helge Deller
2023-01-09 9:14 ` Jani Nikula
2023-01-07 18:26 ` [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness() Sam Ravnborg via B4 Submission Endpoint
2023-01-09 17:44 ` Christophe Leroy
2023-01-09 18:21 ` Sam Ravnborg
2023-01-07 18:26 ` [PATCH 03/15] video: fbdev: nvidia: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 04/15] video: fbdev: radeon: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 05/15] video: fbdev: riva: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 06/15] video: fbdev: aty128fb: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint [this message]
2023-01-07 18:26 ` [PATCH 08/15] video: fbdev: omap2: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank() Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:28 ` Stephen Kitt
2023-01-08 20:29 ` Sam Ravnborg
2023-01-09 7:04 ` Stephen Kitt
2023-01-09 11:16 ` Daniel Thompson
2023-01-09 11:13 ` Andy Shevchenko
2023-01-07 18:26 ` [PATCH 10/15] staging: fbtft: core: " Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:29 ` Stephen Kitt
2023-01-09 11:15 ` Andy Shevchenko
2023-01-07 18:26 ` [PATCH 11/15] powerpc: via-pmu-backlight: Introduce backlight_get_brightness() Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:36 ` Stephen Kitt
2023-01-07 18:26 ` [PATCH 12/15] auxdisplay: ht16k33: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 21:02 ` Miguel Ojeda
2023-01-08 9:29 ` Sam Ravnborg
2023-01-09 10:12 ` Robin van der Gracht
2023-03-19 13:44 ` Stephen Kitt
2023-03-19 18:44 ` Sam Ravnborg
2023-01-07 18:26 ` [PATCH 13/15] backlight: omap1: Use backlight helpers Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:32 ` Stephen Kitt
2023-01-09 11:02 ` Daniel Thompson
2023-01-07 18:26 ` [PATCH 14/15] backlight: tosa: Use backlight helper Sam Ravnborg via B4 Submission Endpoint
2023-01-09 11:04 ` Daniel Thompson
2023-01-07 18:26 ` [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:32 ` Stephen Kitt
2023-01-09 11:06 ` Daniel Thompson
2023-01-09 16:27 ` Sam Ravnborg
2023-01-10 10:09 ` Lee Jones
2023-01-26 14:27 ` Lee Jones
2023-01-26 16:11 ` Sam Ravnborg
2023-01-26 16:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230107-sam-video-backlight-drop-fb_blank-v1-7-1bd9bafb351f@ravnborg.org \
--to=devnull+sam.ravnborg.org@kernel.org \
--cc=adaplas@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=claudiu.beznea@microchip.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@intel.com \
--cc=jingoohan1@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicolas.ferre@microchip.com \
--cc=ojeda@kernel.org \
--cc=paulus@samba.org \
--cc=robin@protonic.nl \
--cc=sam@ravnborg.org \
--cc=steve@sk2.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).